)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"fe903f9f3fcc268ffbdfd3958d99b69140ae0d92","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Mark Beierl \u003cmbeierl@vmware.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-07-03 16:20:05 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve iDrac Documentation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds additional details on how to use the iDrac driver with"},{"line_number":10,"context_line":"Ironic."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_2d2cea00","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":13},"updated":"2019-07-10 21:06:21.000000000","message":"iDRAC","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"fe903f9f3fcc268ffbdfd3958d99b69140ae0d92","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve iDrac Documentation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds additional details on how to use the iDrac driver with"},{"line_number":10,"context_line":"Ironic."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I598181a8227179b8c587b31905e38aa7595eef87"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_ad3f7a23","line":9,"range":{"start_line":9,"start_character":42,"end_line":9,"end_character":47},"updated":"2019-07-10 21:06:21.000000000","message":"iDRAC","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"918cacc5e222d093b78261153fb2b61db21d59af","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Ironic."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I598181a8227179b8c587b31905e38aa7595eef87"},{"line_number":13,"context_line":"Signed-off-by: Mark Beierl \u003cmbeierl@vmware.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3fa7e38b_8980fdc0","line":13,"updated":"2019-10-15 21:32:53.000000000","message":"Great job finishing up this patch Pranjali!  Be sure to list yourself as a co-author by adding the following line here:\nCo-Authored-By: Pranjali Srivastava \u003csrivastavapranjali@ymail.com\u003e","commit_id":"32995ec033146e0324d1a90b91e8a810fdb27df9"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"37588b1b37f249de5361d0dc5954389d48d96f66","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Ironic."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I598181a8227179b8c587b31905e38aa7595eef87"},{"line_number":13,"context_line":"Signed-off-by: Mark Beierl \u003cmbeierl@vmware.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3fa7e38b_1a4d29c3","line":13,"in_reply_to":"3fa7e38b_8980fdc0","updated":"2019-10-16 03:30:23.000000000","message":"Done","commit_id":"32995ec033146e0324d1a90b91e8a810fdb27df9"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Ironic."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I598181a8227179b8c587b31905e38aa7595eef87"},{"line_number":13,"context_line":"Signed-off-by: Mark Beierl \u003cmbeierl@vmware.com\u003e"},{"line_number":14,"context_line":"Co-Authored-By: Pranjali Srivastava \u003csrivastavapranjali@ymail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3fa7e38b_b4e941b8","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":47},"updated":"2019-10-21 23:03:47.000000000","message":"nit: Signed-off-by is not required. This is discussed in https://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references\n\n\"Note: Although it is common practice across many open source projects using Git to include a \"Signed-off-by\" tag (generated by \u0027git commit -s\u0027), this is not required for OpenStack. Prior to gaining the ability to submit code to Gerrit, OpenStack requires that all contributors sign the CLA, which serves an equivalent purpose.\"","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Ironic."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I598181a8227179b8c587b31905e38aa7595eef87"},{"line_number":13,"context_line":"Signed-off-by: Mark Beierl \u003cmbeierl@vmware.com\u003e"},{"line_number":14,"context_line":"Co-Authored-By: Pranjali Srivastava \u003csrivastavapranjali@ymail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3fa7e38b_12db624f","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":47},"in_reply_to":"3fa7e38b_b4e941b8","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"}],"doc/source/admin/drivers/idrac.rst":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"919970e4e40daee416178ffcbbaf6170fdd709fe","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Overview"},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":"The integrated Dell Remote Access Controller (iDRAC_), is an out-of-band"},{"line_number":8,"context_line":"management platform on Dell servers, and is supported directly by the"},{"line_number":9,"context_line":"``idrac`` hardware type.  This driver uses the Dell Web Services for"},{"line_number":10,"context_line":"Management (WSMAN) APIs to perform all of its functions."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_3cb55eef","line":7,"range":{"start_line":7,"start_character":53,"end_line":7,"end_character":54},"updated":"2019-07-04 09:48:59.000000000","message":"nit: remove comma \u0027,\u0027","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"fe903f9f3fcc268ffbdfd3958d99b69140ae0d92","unresolved":false,"context_lines":[{"line_number":9,"context_line":"``idrac`` hardware type.  This driver uses the Dell Web Services for"},{"line_number":10,"context_line":"Management (WSMAN) APIs to perform all of its functions."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"iDRAC_ hardware is also supported by the standard ``ipmi`` hardware type,"},{"line_number":13,"context_line":"though with a smaller feature set."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Key features of the Dell iDRAC:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_4d1846d2","line":12,"range":{"start_line":12,"start_character":50,"end_line":12,"end_character":72},"updated":"2019-07-10 21:06:21.000000000","message":"suggest also adding redfish type.","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"919970e4e40daee416178ffcbbaf6170fdd709fe","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"iDRAC_ hardware is also supported by the standard ``ipmi`` hardware type,"},{"line_number":13,"context_line":"though with a smaller feature set."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Key features of the Dell iDRAC:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"* Inventory and Monitoring"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_1ccd025d","line":14,"updated":"2019-07-04 09:48:59.000000000","message":"should we also mention redfish here ?","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"919970e4e40daee416178ffcbbaf6170fdd709fe","unresolved":false,"context_lines":[{"line_number":27,"context_line":"Ironic Features"},{"line_number":28,"context_line":"---------------"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"The hardware type ``idrac`` supports following Ironic interfaces:"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"* `Inspect Interface`_: Hardware Inspection"},{"line_number":33,"context_line":"* `Management Interface`_:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_7c13d6b9","line":30,"updated":"2019-07-04 09:48:59.000000000","message":"nit: add \u0027the\u0027","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"919970e4e40daee416178ffcbbaf6170fdd709fe","unresolved":false,"context_lines":[{"line_number":30,"context_line":"The hardware type ``idrac`` supports following Ironic interfaces:"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"* `Inspect Interface`_: Hardware Inspection"},{"line_number":33,"context_line":"* `Management Interface`_:"},{"line_number":34,"context_line":"* `Power Interface`_: Power management"},{"line_number":35,"context_line":"* `RAID Interface`_: RAID controller and disk management"},{"line_number":36,"context_line":"* `Vendor Interface`_: BIOS management"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_bc470ebd","line":33,"updated":"2019-07-04 09:48:59.000000000","message":"looks like it\u0027s missing something :)","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"919970e4e40daee416178ffcbbaf6170fdd709fe","unresolved":false,"context_lines":[{"line_number":42,"context_line":"The ``idrac`` hardware type requires the ``python-dracclient`` library to be"},{"line_number":43,"context_line":"installed, for example::"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    sudo pip install \u0027python-dracclient\u003e\u003d1.3.0\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"To enable the ``idrac`` hardware type, add the following to your"},{"line_number":48,"context_line":"``/etc/ironic/ironic.conf``:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_fcca664d","line":45,"updated":"2019-07-04 09:48:59.000000000","message":"according to driver-requirements the version of python-dracclient is costrained between 3.0.0 and 4.0.0\nshouldn\u0027t we specify the same here ?","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"fe903f9f3fcc268ffbdfd3958d99b69140ae0d92","unresolved":false,"context_lines":[{"line_number":42,"context_line":"The ``idrac`` hardware type requires the ``python-dracclient`` library to be"},{"line_number":43,"context_line":"installed, for example::"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    sudo pip install \u0027python-dracclient\u003e\u003d1.3.0\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"To enable the ``idrac`` hardware type, add the following to your"},{"line_number":48,"context_line":"``/etc/ironic/ironic.conf``:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_8d72be10","line":45,"in_reply_to":"7faddb67_fcca664d","updated":"2019-07-10 21:06:21.000000000","message":"It should the one specific to Ironic release.","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"fe903f9f3fcc268ffbdfd3958d99b69140ae0d92","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    openstack baremetal node create --driver idrac \\"},{"line_number":80,"context_line":"        --driver-info drac_address\u003dhttp://drac.host \\"},{"line_number":81,"context_line":"        --driver-info drac_username\u003duser \\"},{"line_number":82,"context_line":"        --driver-info drac_password\u003dpa$$w0rd"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Inspect Interface"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_0d600e32","line":82,"range":{"start_line":81,"start_character":0,"end_line":82,"end_character":44},"updated":"2019-07-10 21:06:21.000000000","message":"need to comment to populate user and password and values present here are just an example.","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"fe903f9f3fcc268ffbdfd3958d99b69140ae0d92","unresolved":false,"context_lines":[{"line_number":85,"context_line":"Inspect Interface"},{"line_number":86,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"The Dell iDrac out-of-band inspection process catalogs all the same"},{"line_number":89,"context_line":"attributes of the server as the IPMI driver.  Unlike IMPI, it does this"},{"line_number":90,"context_line":"without requiring the system to be rebooted, or even in a power on"},{"line_number":91,"context_line":"state.  Inspection is performed using the Dell WSMAN API directly without"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_cd519664","line":88,"range":{"start_line":88,"start_character":9,"end_line":88,"end_character":14},"updated":"2019-07-10 21:06:21.000000000","message":"iDRAC","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2802e9cc503a61e5c083ccb901cfb8ad5d7961a4","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"The Dell iDrac out-of-band inspection process catalogs all the same"},{"line_number":89,"context_line":"attributes of the server as the IPMI driver.  Unlike IMPI, it does this"},{"line_number":90,"context_line":"without requiring the system to be rebooted, or even in a power on"},{"line_number":91,"context_line":"state.  Inspection is performed using the Dell WSMAN API directly without"},{"line_number":92,"context_line":"affecting the operation of the system being inspected."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"The inspection discovers the following properties:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_f4018407","line":91,"range":{"start_line":90,"start_character":48,"end_line":91,"end_character":5},"updated":"2019-07-15 18:24:43.000000000","message":"or even being in a powered on state.","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2802e9cc503a61e5c083ccb901cfb8ad5d7961a4","unresolved":false,"context_lines":[{"line_number":97,"context_line":"* ``cpus``: number of cpus"},{"line_number":98,"context_line":"* ``local_gb``: disk size"},{"line_number":99,"context_line":"* ``memory_mb``: memory size"},{"line_number":100,"context_line":"* ``model``: the Dell server model (eg: \"PowerEdge R640\")"},{"line_number":101,"context_line":"* ``provisioning_mac``: MAC address configured to PXE boot for provisioning."},{"line_number":102,"context_line":"* ``service_tag``: Dell service tag for the server (eg: \"FL0AQD2\")"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_4f5481fe","line":100,"updated":"2019-07-15 18:24:43.000000000","message":"model, provisioning_mac and service_tag should be removed since these are discovered by JetStream, outside of Ironic.","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"919970e4e40daee416178ffcbbaf6170fdd709fe","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Extra capabilities:"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"* ``boot_mode``: eufi or bios boot mode."},{"line_number":107,"context_line":"* ``boot_option``: ?"},{"line_number":108,"context_line":"* ``cpu_aes``: true if the CPU supports AES encryption."},{"line_number":109,"context_line":"* ``cpu_hugepages``: true, if the CPU supports huge pages."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_9ccb321d","line":106,"range":{"start_line":106,"start_character":17,"end_line":106,"end_character":21},"updated":"2019-07-04 09:48:59.000000000","message":"eufi sounds very French :D\nuefi should be the correct one","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"919970e4e40daee416178ffcbbaf6170fdd709fe","unresolved":false,"context_lines":[{"line_number":104,"context_line":"Extra capabilities:"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"* ``boot_mode``: eufi or bios boot mode."},{"line_number":107,"context_line":"* ``boot_option``: ?"},{"line_number":108,"context_line":"* ``cpu_aes``: true if the CPU supports AES encryption."},{"line_number":109,"context_line":"* ``cpu_hugepages``: true, if the CPU supports huge pages."},{"line_number":110,"context_line":"* ``cpu_hugepages_1g``: true if the CPU supports 1g huge pages."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_3c9ebe07","line":107,"updated":"2019-07-04 09:48:59.000000000","message":"in general this is the type of boot in terms of how to boot the server, so for example netboot or local, although I\u0027m not sure this is discovered by inspection","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2802e9cc503a61e5c083ccb901cfb8ad5d7961a4","unresolved":false,"context_lines":[{"line_number":104,"context_line":"Extra capabilities:"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"* ``boot_mode``: eufi or bios boot mode."},{"line_number":107,"context_line":"* ``boot_option``: ?"},{"line_number":108,"context_line":"* ``cpu_aes``: true if the CPU supports AES encryption."},{"line_number":109,"context_line":"* ``cpu_hugepages``: true, if the CPU supports huge pages."},{"line_number":110,"context_line":"* ``cpu_hugepages_1g``: true if the CPU supports 1g huge pages."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_cf47114c","line":107,"in_reply_to":"7faddb67_3c9ebe07","updated":"2019-07-15 18:24:43.000000000","message":"OOB introspection does not discover boot_option, cpu_aes, cpe_hugepages, cpu_hugepages_1g, cpu_txt, cpu_vt.","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"919970e4e40daee416178ffcbbaf6170fdd709fe","unresolved":false,"context_lines":[{"line_number":108,"context_line":"* ``cpu_aes``: true if the CPU supports AES encryption."},{"line_number":109,"context_line":"* ``cpu_hugepages``: true, if the CPU supports huge pages."},{"line_number":110,"context_line":"* ``cpu_hugepages_1g``: true if the CPU supports 1g huge pages."},{"line_number":111,"context_line":"* ``cpu_txt``: true if the CPU supports ?"},{"line_number":112,"context_line":"* ``cpu_vt``: true, if the CPU supports cpu virtualization."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"It also creates baremetal ports for each NIC card detected in the system."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_3c6c7e07","line":111,"updated":"2019-07-04 09:48:59.000000000","message":"In the code it\u0027s directly associated to SMX, safer mode extensions instructions set, but this means TXT trusted execution technology (TPM and friends).\nI guess the association is done based on the fact that SMX is the programming interface for the TXT Intel platform and it\u0027s reported as \u0027smx\u0027 by the kernel in /proc/cpuinfo\nYou could probably say that the cpu supports TPM in this case","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"fe903f9f3fcc268ffbdfd3958d99b69140ae0d92","unresolved":false,"context_lines":[{"line_number":111,"context_line":"* ``cpu_txt``: true if the CPU supports ?"},{"line_number":112,"context_line":"* ``cpu_vt``: true, if the CPU supports cpu virtualization."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"It also creates baremetal ports for each NIC card detected in the system."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Management Interface"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_0dd56eb9","line":114,"range":{"start_line":114,"start_character":41,"end_line":114,"end_character":50},"updated":"2019-07-10 21:06:21.000000000","message":"is it for each port on each NIC card?","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2802e9cc503a61e5c083ccb901cfb8ad5d7961a4","unresolved":false,"context_lines":[{"line_number":111,"context_line":"* ``cpu_txt``: true if the CPU supports ?"},{"line_number":112,"context_line":"* ``cpu_vt``: true, if the CPU supports cpu virtualization."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"It also creates baremetal ports for each NIC card detected in the system."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Management Interface"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_ef5d2d15","line":114,"range":{"start_line":114,"start_character":41,"end_line":114,"end_character":50},"in_reply_to":"7faddb67_0dd56eb9","updated":"2019-07-15 18:24:43.000000000","message":"probably should say NIC port instead of NIC card.  It also tags any port with pxe_enabled\u003dtrue if that port is set to PXE boot.","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2802e9cc503a61e5c083ccb901cfb8ad5d7961a4","unresolved":false,"context_lines":[{"line_number":120,"context_line":"The following management functions are supported:"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"* `Set boot device`_"},{"line_number":123,"context_line":"* `Show boot device`_"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":".. NOTE:"},{"line_number":126,"context_line":"  Inject NMI is not supported."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_84525b3a","line":123,"updated":"2019-07-15 18:24:43.000000000","message":"Maybe change the above to `Get boot device`?\nAdd get_supported_boot_devices.","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2802e9cc503a61e5c083ccb901cfb8ad5d7961a4","unresolved":false,"context_lines":[{"line_number":123,"context_line":"* `Show boot device`_"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":".. NOTE:"},{"line_number":126,"context_line":"  Inject NMI is not supported."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Set Boot Device"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_64bf1f61","line":126,"updated":"2019-07-15 18:24:43.000000000","message":"Other not supported functions: get_sensors_data, get_boot_mode, set_boot_mode, get_supported_boot_modes","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2802e9cc503a61e5c083ccb901cfb8ad5d7961a4","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"* `Power off`_"},{"line_number":152,"context_line":"* `Power on`_"},{"line_number":153,"context_line":"* `Reboot`_"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Power Off"},{"line_number":156,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_0423cbbe","line":153,"updated":"2019-07-15 18:24:43.000000000","message":"Add get_power_state","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"fe903f9f3fcc268ffbdfd3958d99b69140ae0d92","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"See :doc:`/admin/raid` for more information on Ironic RAID support."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"The following propeties are supported by the iDrac RAID driver:"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"Mandatory properties"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_cdff5632","line":182,"range":{"start_line":182,"start_character":45,"end_line":182,"end_character":50},"updated":"2019-07-10 21:06:21.000000000","message":"iDRAC","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"919970e4e40daee416178ffcbbaf6170fdd709fe","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"See :doc:`/admin/raid` for more information on Ironic RAID support."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"The following propeties are supported by the iDrac RAID driver:"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"Mandatory properties"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_77752f98","line":182,"range":{"start_line":182,"start_character":14,"end_line":182,"end_character":23},"updated":"2019-07-04 09:48:59.000000000","message":"s/propeties/properties","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"919970e4e40daee416178ffcbbaf6170fdd709fe","unresolved":false,"context_lines":[{"line_number":185,"context_line":"Mandatory properties"},{"line_number":186,"context_line":"--------------------"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"* ``size_gb``: Size in GiB (Integer) for the logical disk. Use \u0027MAX\u0027 as size_gb if this logical disk is supposed to use the rest of the space available."},{"line_number":189,"context_line":"* ``raid_level``: RAID level for the logical disk. Valid values are"},{"line_number":190,"context_line":"  \u00270\u0027, \u00271\u0027, \u00275\u0027, \u00276\u0027, \u00271+0\u0027, \u00275+0\u0027 and \u00276+0\u0027."},{"line_number":191,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_b7496761","line":188,"updated":"2019-07-04 09:48:59.000000000","message":"please keep the line under 80 columns, thanks\nsame for\nL199\nL200\nL254","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"fe903f9f3fcc268ffbdfd3958d99b69140ae0d92","unresolved":false,"context_lines":[{"line_number":196,"context_line":"Optional properties"},{"line_number":197,"context_line":"-------------------"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"* ``is_root_volume``: Optional. Specifies whether this disk is a root volume. By default, this is False."},{"line_number":200,"context_line":"* ``volume_name``: Optional. Name of the volume to be created. If this is not specified, it will be auto-generated."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Backing physical disk hints"},{"line_number":203,"context_line":"---------------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_0da32e51","line":200,"range":{"start_line":199,"start_character":0,"end_line":200,"end_character":115},"updated":"2019-07-10 21:06:21.000000000","message":"keep within 80 characters length of the line","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"919970e4e40daee416178ffcbbaf6170fdd709fe","unresolved":false,"context_lines":[{"line_number":199,"context_line":"* ``is_root_volume``: Optional. Specifies whether this disk is a root volume. By default, this is False."},{"line_number":200,"context_line":"* ``volume_name``: Optional. Name of the volume to be created. If this is not specified, it will be auto-generated."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Backing physical disk hints"},{"line_number":203,"context_line":"---------------------------"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":".. NOTE::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_f7db5f7a","line":202,"updated":"2019-07-04 09:48:59.000000000","message":"not sure what you mean here","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":28370,"name":"Mark Beierl","email":"mark.beierl@canonical.com","username":"mbeierl"},"change_message_id":"2b9478c520b71384af3f0000d03458d5532d83cd","unresolved":false,"context_lines":[{"line_number":199,"context_line":"* ``is_root_volume``: Optional. Specifies whether this disk is a root volume. By default, this is False."},{"line_number":200,"context_line":"* ``volume_name``: Optional. Name of the volume to be created. If this is not specified, it will be auto-generated."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Backing physical disk hints"},{"line_number":203,"context_line":"---------------------------"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":".. NOTE::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_b40b0cd4","line":202,"in_reply_to":"7faddb67_f7db5f7a","updated":"2019-07-17 12:19:40.000000000","message":"Backing physical disk hints are documented in the raid.rst guide in Ironic.  I\u0027ll see if I can add a reference link here.","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2802e9cc503a61e5c083ccb901cfb8ad5d7961a4","unresolved":false,"context_lines":[{"line_number":203,"context_line":"---------------------------"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":".. NOTE::"},{"line_number":206,"context_line":"  These properties are currently not supported by the iDrac RAID driver."},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"* ``disk_type``"},{"line_number":209,"context_line":"* ``interface_type``"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_171f7f5b","line":206,"range":{"start_line":206,"start_character":54,"end_line":206,"end_character":59},"updated":"2019-07-15 18:24:43.000000000","message":"iDRAC","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2802e9cc503a61e5c083ccb901cfb8ad5d7961a4","unresolved":false,"context_lines":[{"line_number":205,"context_line":".. NOTE::"},{"line_number":206,"context_line":"  These properties are currently not supported by the iDrac RAID driver."},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"* ``disk_type``"},{"line_number":209,"context_line":"* ``interface_type``"},{"line_number":210,"context_line":"* ``share_physical_disks``"},{"line_number":211,"context_line":"* ``number_of_physical_disks``"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_f7ac23ee","line":208,"updated":"2019-07-15 18:24:43.000000000","message":"It looks to me like disk_type is supported:\nhttps://github.com/openstack/ironic/blob/master/ironic/drivers/modules/drac/raid.py#L648","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":28370,"name":"Mark Beierl","email":"mark.beierl@canonical.com","username":"mbeierl"},"change_message_id":"2b9478c520b71384af3f0000d03458d5532d83cd","unresolved":false,"context_lines":[{"line_number":205,"context_line":".. NOTE::"},{"line_number":206,"context_line":"  These properties are currently not supported by the iDrac RAID driver."},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"* ``disk_type``"},{"line_number":209,"context_line":"* ``interface_type``"},{"line_number":210,"context_line":"* ``share_physical_disks``"},{"line_number":211,"context_line":"* ``number_of_physical_disks``"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_68bef4b4","line":208,"in_reply_to":"7faddb67_f7ac23ee","updated":"2019-07-17 12:19:40.000000000","message":"Unfortunately, I no longer have a test environment for this.  When I was writing this (March?) it did not work.  Can someone from Dell verify if these hints are effective?","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2802e9cc503a61e5c083ccb901cfb8ad5d7961a4","unresolved":false,"context_lines":[{"line_number":206,"context_line":"  These properties are currently not supported by the iDrac RAID driver."},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"* ``disk_type``"},{"line_number":209,"context_line":"* ``interface_type``"},{"line_number":210,"context_line":"* ``share_physical_disks``"},{"line_number":211,"context_line":"* ``number_of_physical_disks``"},{"line_number":212,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_97b5af34","line":209,"updated":"2019-07-15 18:24:43.000000000","message":"It looks to me like interface_type is supported:\nhttps://github.com/openstack/ironic/blob/master/ironic/drivers/modules/drac/raid.py#L652","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2802e9cc503a61e5c083ccb901cfb8ad5d7961a4","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"* ``disk_type``"},{"line_number":209,"context_line":"* ``interface_type``"},{"line_number":210,"context_line":"* ``share_physical_disks``"},{"line_number":211,"context_line":"* ``number_of_physical_disks``"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"Backing physical disks"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_778a736a","line":210,"updated":"2019-07-15 18:24:43.000000000","message":"It looks to me like share_physical_disks is supported:\nhttps://github.com/openstack/ironic/blob/master/ironic/drivers/modules/drac/raid.py#L665","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2802e9cc503a61e5c083ccb901cfb8ad5d7961a4","unresolved":false,"context_lines":[{"line_number":208,"context_line":"* ``disk_type``"},{"line_number":209,"context_line":"* ``interface_type``"},{"line_number":210,"context_line":"* ``share_physical_disks``"},{"line_number":211,"context_line":"* ``number_of_physical_disks``"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"Backing physical disks"},{"line_number":214,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_77efd31d","line":211,"updated":"2019-07-15 18:24:43.000000000","message":"It looks to me like number_of_physical_disks is supported:\nhttps://github.com/openstack/ironic/blob/master/ironic/drivers/modules/drac/raid.py#L679","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2802e9cc503a61e5c083ccb901cfb8ad5d7961a4","unresolved":false,"context_lines":[{"line_number":214,"context_line":"----------------------"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"These are Dell RAID controller specific values and must match the"},{"line_number":217,"context_line":"names as provided by the iDrac."},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"* ``controller``: Manditory. The name of the controller to use."},{"line_number":220,"context_line":"* ``physical_disks``: Manditory. The names of the physical disks to use."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_d7dd6770","line":217,"range":{"start_line":217,"start_character":25,"end_line":217,"end_character":30},"updated":"2019-07-15 18:24:43.000000000","message":"iDRAC","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"919970e4e40daee416178ffcbbaf6170fdd709fe","unresolved":false,"context_lines":[{"line_number":216,"context_line":"These are Dell RAID controller specific values and must match the"},{"line_number":217,"context_line":"names as provided by the iDrac."},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"* ``controller``: Manditory. The name of the controller to use."},{"line_number":220,"context_line":"* ``physical_disks``: Manditory. The names of the physical disks to use."},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Examples"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_9788eb71","line":219,"range":{"start_line":219,"start_character":18,"end_line":219,"end_character":27},"updated":"2019-07-04 09:48:59.000000000","message":"Mandatory","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"919970e4e40daee416178ffcbbaf6170fdd709fe","unresolved":false,"context_lines":[{"line_number":217,"context_line":"names as provided by the iDrac."},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"* ``controller``: Manditory. The name of the controller to use."},{"line_number":220,"context_line":"* ``physical_disks``: Manditory. The names of the physical disks to use."},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Examples"},{"line_number":223,"context_line":"--------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_57827351","line":220,"range":{"start_line":220,"start_character":22,"end_line":220,"end_character":31},"updated":"2019-07-04 09:48:59.000000000","message":"Mandatory","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"919970e4e40daee416178ffcbbaf6170fdd709fe","unresolved":false,"context_lines":[{"line_number":251,"context_line":"    \u0027[{\"interface\": \"raid\", \"step\": \"delete_configuration\"}]\u0027 ${node_uuid}"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"The follwing command shows an example of how to set the target RAID configuration:"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":".. code-block:: bash"},{"line_number":257,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_97d6ab4f","line":254,"range":{"start_line":254,"start_character":4,"end_line":254,"end_character":12},"updated":"2019-07-04 09:48:59.000000000","message":"following","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"919970e4e40daee416178ffcbbaf6170fdd709fe","unresolved":false,"context_lines":[{"line_number":273,"context_line":"    \u0027[{\"interface\": \"raid\", \"step\": \"create_configuration\"}]\u0027 ${node_uuid}"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"In the case where the physical disk names, or controller names are not"},{"line_number":277,"context_line":"known, the following python code example shows how the python-dracclient"},{"line_number":278,"context_line":"can be used to fetch the information directly from the Dell server:"},{"line_number":279,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_17c2bb86","line":276,"range":{"start_line":276,"start_character":41,"end_line":276,"end_character":42},"updated":"2019-07-04 09:48:59.000000000","message":"remove comma \u0027,\u0027","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"919970e4e40daee416178ffcbbaf6170fdd709fe","unresolved":false,"context_lines":[{"line_number":293,"context_line":"  print (physical_disks)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"Vendor  Interface"},{"line_number":297,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"Dell iDrac BIOS management is available through the Ironic vendor"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_b753a7e2","line":296,"range":{"start_line":296,"start_character":6,"end_line":296,"end_character":8},"updated":"2019-07-04 09:48:59.000000000","message":"nit: remove one blank space","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"fe903f9f3fcc268ffbdfd3958d99b69140ae0d92","unresolved":false,"context_lines":[{"line_number":296,"context_line":"Vendor  Interface"},{"line_number":297,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"Dell iDrac BIOS management is available through the Ironic vendor"},{"line_number":300,"context_line":"passthrough interface.  The"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_0dbc8e67","line":299,"range":{"start_line":299,"start_character":5,"end_line":299,"end_character":10},"updated":"2019-07-10 21:06:21.000000000","message":"iDRAC","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"919970e4e40daee416178ffcbbaf6170fdd709fe","unresolved":false,"context_lines":[{"line_number":297,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"Dell iDrac BIOS management is available through the Ironic vendor"},{"line_number":300,"context_line":"passthrough interface.  The"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":303,"context_line":"Method Name           HTTP Method    Descrption"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_775f6fe5","line":300,"range":{"start_line":300,"start_character":22,"end_line":300,"end_character":27},"updated":"2019-07-04 09:48:59.000000000","message":"not needed ?","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"919970e4e40daee416178ffcbbaf6170fdd709fe","unresolved":false,"context_lines":[{"line_number":300,"context_line":"passthrough interface.  The"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":303,"context_line":"Method Name           HTTP Method    Descrption"},{"line_number":304,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":305,"context_line":"abandon_bios_config   DELETE         Abandon a BIOS configuration job"},{"line_number":306,"context_line":"commit_bios_config    POST           Commit a BIOS configuration job"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_3759f7fd","line":303,"range":{"start_line":303,"start_character":37,"end_line":303,"end_character":47},"updated":"2019-07-04 09:48:59.000000000","message":"Description","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2802e9cc503a61e5c083ccb901cfb8ad5d7961a4","unresolved":false,"context_lines":[{"line_number":325,"context_line":"                                     a node. Required argument: a"},{"line_number":326,"context_line":"                                     dictionary of {``AttributeName``:"},{"line_number":327,"context_line":"                                     ``NewValue``}. Returns a dictionary"},{"line_number":328,"context_line":"                                     containing the \u0027commit_required\u0027"},{"line_number":329,"context_line":"                                     key with a Boolean value indicating"},{"line_number":330,"context_line":"                                     whether commit_bios_config needs to"},{"line_number":331,"context_line":"                                     be called to make the changes."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_375cfbeb","line":328,"range":{"start_line":328,"start_character":53,"end_line":328,"end_character":68},"updated":"2019-07-15 18:24:43.000000000","message":"commit_required was deprecated in the past and was recently removed.  The dictionary now contains \u0027is_commit_required\u0027 and \u0027is_reboot_required\u0027.","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"919970e4e40daee416178ffcbbaf6170fdd709fe","unresolved":false,"context_lines":[{"line_number":375,"context_line":"  openstack baremetal node passthru call ${node_uuid} set_bios_config --arg \"name\u003dvalue\""},{"line_number":376,"context_line":""},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"Walkthough of perfoming a BIOS configuration change:"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"The following section demonstrates how to change BIOS configuration settings,"},{"line_number":381,"context_line":"detect that a commit and reboot are required, and act on them accordingly.  The"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_9709cbde","line":378,"range":{"start_line":378,"start_character":0,"end_line":378,"end_character":10},"updated":"2019-07-04 09:48:59.000000000","message":"Walkthrough","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2802e9cc503a61e5c083ccb901cfb8ad5d7961a4","unresolved":false,"context_lines":[{"line_number":396,"context_line":""},{"line_number":397,"context_line":"  {"},{"line_number":398,"context_line":"    \"is_reboot_required\": true,"},{"line_number":399,"context_line":"    \"commit_required\": true,"},{"line_number":400,"context_line":"    \"is_commit_required\": true"},{"line_number":401,"context_line":"  }"},{"line_number":402,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_17a8df89","line":399,"updated":"2019-07-15 18:24:43.000000000","message":"The above line should be removed since commit_required was deprecated and has been removed this release.","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"change_message_id":"e564a5fc1a61eab088fb58af6444438720fcd01f","unresolved":false,"context_lines":[{"line_number":405,"context_line":"~~~~~~~~~~~~~~~~~~~"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"Next step is to commit the pending change to the BIOS.  Note that in this"},{"line_number":408,"context_line":"example, the ``reboot`` argument is set to true.  The response indicates"},{"line_number":409,"context_line":"that a reboot is no longer required as it has been scheduled automatically"},{"line_number":410,"context_line":"by the commit_bios_config call.  If the reboot argument is not supplied,"},{"line_number":411,"context_line":"the job is still created, however it remains in the ``scheduled`` state"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_c1b05346","line":408,"range":{"start_line":408,"start_character":48,"end_line":408,"end_character":50},"updated":"2019-07-14 08:36:37.000000000","message":"nit：remove one blank space","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"919970e4e40daee416178ffcbbaf6170fdd709fe","unresolved":false,"context_lines":[{"line_number":409,"context_line":"that a reboot is no longer required as it has been scheduled automatically"},{"line_number":410,"context_line":"by the commit_bios_config call.  If the reboot argument is not supplied,"},{"line_number":411,"context_line":"the job is still created, however it remains in the ``scheduled`` state"},{"line_number":412,"context_line":"until a reboot is performed.  The reboot can be initiated through the"},{"line_number":413,"context_line":"ironic reboot api."},{"line_number":414,"context_line":""},{"line_number":415,"context_line":".. code-block:: bash"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_b71ac714","line":412,"range":{"start_line":412,"start_character":28,"end_line":412,"end_character":30},"updated":"2019-07-04 09:48:59.000000000","message":"nit: remove one blank space","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"919970e4e40daee416178ffcbbaf6170fdd709fe","unresolved":false,"context_lines":[{"line_number":425,"context_line":"      \"reboot_required\": false"},{"line_number":426,"context_line":"  }"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"The state of any executing jobs can be queried:"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":".. code-block:: bash"},{"line_number":431,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_f7e59f0b","line":428,"range":{"start_line":428,"start_character":27,"end_line":428,"end_character":31},"updated":"2019-07-04 09:48:59.000000000","message":"job","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2802e9cc503a61e5c083ccb901cfb8ad5d7961a4","unresolved":false,"context_lines":[{"line_number":425,"context_line":"      \"reboot_required\": false"},{"line_number":426,"context_line":"  }"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"The state of any executing jobs can be queried:"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":".. code-block:: bash"},{"line_number":431,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_7790334b","line":428,"range":{"start_line":428,"start_character":27,"end_line":428,"end_character":31},"in_reply_to":"7faddb67_f7e59f0b","updated":"2019-07-15 18:24:43.000000000","message":"I think jobs is correct here because multiple jobs could be returned.","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2802e9cc503a61e5c083ccb901cfb8ad5d7961a4","unresolved":false,"context_lines":[{"line_number":444,"context_line":"        \"id\": \"JID_499377293428\"}]}"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"Adandon BIOS Changes"},{"line_number":448,"context_line":"~~~~~~~~~~~~~~~~~~~~"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"Instead of committing, the pending change can also be rolled back"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_f77bc324","line":447,"range":{"start_line":447,"start_character":0,"end_line":447,"end_character":7},"updated":"2019-07-15 18:24:43.000000000","message":"Abandon","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2802e9cc503a61e5c083ccb901cfb8ad5d7961a4","unresolved":false,"context_lines":[{"line_number":460,"context_line":"Change Boot Mode"},{"line_number":461,"context_line":"----------------"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"The boot mode of the iDrac can be changed to:"},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"* BIOS - Also called legacy or traditional boot mode.  The BIOS initializes the"},{"line_number":466,"context_line":"  system’s processors, memory, bus controllers, and I/O devices. After"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_57909743","line":463,"range":{"start_line":463,"start_character":21,"end_line":463,"end_character":26},"updated":"2019-07-15 18:24:43.000000000","message":"iDRAC","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2802e9cc503a61e5c083ccb901cfb8ad5d7961a4","unresolved":false,"context_lines":[{"line_number":478,"context_line":"  data structures the BIOS uses to interact with I/O device firmware and"},{"line_number":479,"context_line":"  operating system software. The primary intent of UEFI is to eliminate"},{"line_number":480,"context_line":"  shortcomings in the traditional BIOS environment, enabling system firmware to"},{"line_number":481,"context_line":"  continue scaling with industry trends"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"The UEFI boot mode offers:"},{"line_number":484,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_d7a3279d","line":481,"updated":"2019-07-15 18:24:43.000000000","message":"Need a period at the end of the sentence above.","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2802e9cc503a61e5c083ccb901cfb8ad5d7961a4","unresolved":false,"context_lines":[{"line_number":482,"context_line":""},{"line_number":483,"context_line":"The UEFI boot mode offers:"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"* Improved Partitioning scheme for boot media"},{"line_number":486,"context_line":"* Support for media larger than 2 TB"},{"line_number":487,"context_line":"* Redundant partition tables"},{"line_number":488,"context_line":"* Flexible handoff from BIOS to OS"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_97a92f7d","line":485,"range":{"start_line":485,"start_character":11,"end_line":485,"end_character":23},"updated":"2019-07-15 18:24:43.000000000","message":"lower case p?","commit_id":"1c19da723c452a55b440e0a6d79986e549b47416"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"23667c6079767f2744df02d96b0474b484972759","unresolved":false,"context_lines":[{"line_number":105,"context_line":"Extra capabilities:"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"* ``boot_mode``: UEFI or BIOS boot mode."},{"line_number":108,"context_line":"* ``boot_option``: ?"},{"line_number":109,"context_line":"* ``cpu_aes``: true if the CPU supports AES encryption."},{"line_number":110,"context_line":"* ``cpu_hugepages``: true, if the CPU supports huge pages."},{"line_number":111,"context_line":"* ``cpu_hugepages_1g``: true if the CPU supports 1g huge pages."}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_d07ce621","line":108,"updated":"2019-07-26 08:44:58.000000000","message":"I don\u0027t think this is set by inspection","commit_id":"0340c93dbd10729e5d11448fa7b76d2d2a3b0cbe"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d3be5c11a68ef29c1ed38a4277589ad876104b85","unresolved":false,"context_lines":[{"line_number":105,"context_line":"Extra capabilities:"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"* ``boot_mode``: UEFI or BIOS boot mode."},{"line_number":108,"context_line":"* ``boot_option``: ?"},{"line_number":109,"context_line":"* ``cpu_aes``: true if the CPU supports AES encryption."},{"line_number":110,"context_line":"* ``cpu_hugepages``: true, if the CPU supports huge pages."},{"line_number":111,"context_line":"* ``cpu_hugepages_1g``: true if the CPU supports 1g huge pages."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_462db5a6","line":108,"in_reply_to":"7faddb67_d07ce621","updated":"2019-10-04 15:57:18.000000000","message":"Done","commit_id":"0340c93dbd10729e5d11448fa7b76d2d2a3b0cbe"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"23667c6079767f2744df02d96b0474b484972759","unresolved":false,"context_lines":[{"line_number":113,"context_line":"* ``cpu_vt``: true, if the CPU supports CPU virtualization."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"It also creates baremetal ports for each NIC card detected in the system."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Management Interface"},{"line_number":119,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_f077a23a","line":116,"updated":"2019-07-26 08:44:58.000000000","message":"Maybe show an example?","commit_id":"0340c93dbd10729e5d11448fa7b76d2d2a3b0cbe"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d3be5c11a68ef29c1ed38a4277589ad876104b85","unresolved":false,"context_lines":[{"line_number":113,"context_line":"* ``cpu_vt``: true, if the CPU supports CPU virtualization."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"It also creates baremetal ports for each NIC card detected in the system."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Management Interface"},{"line_number":119,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_261e7970","line":116,"in_reply_to":"7faddb67_f077a23a","updated":"2019-10-04 15:57:18.000000000","message":"Done","commit_id":"0340c93dbd10729e5d11448fa7b76d2d2a3b0cbe"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"23667c6079767f2744df02d96b0474b484972759","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Management Interface"},{"line_number":119,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"The following management functions are supported:"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_90766e3e","line":119,"updated":"2019-07-26 08:44:58.000000000","message":"There seems to be nothing Dell-specific here, I\u0027d remove this section.","commit_id":"0340c93dbd10729e5d11448fa7b76d2d2a3b0cbe"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d3be5c11a68ef29c1ed38a4277589ad876104b85","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Management Interface"},{"line_number":119,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"The following management functions are supported:"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_860c0d43","line":119,"in_reply_to":"7faddb67_90766e3e","updated":"2019-10-04 15:57:18.000000000","message":"Done","commit_id":"0340c93dbd10729e5d11448fa7b76d2d2a3b0cbe"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"23667c6079767f2744df02d96b0474b484972759","unresolved":false,"context_lines":[{"line_number":141,"context_line":"UEFI Secure Boot Support"},{"line_number":142,"context_line":"------------------------"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"See section on vendor passthrough"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Power Interface"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_b0712a47","line":144,"updated":"2019-07-26 08:44:58.000000000","message":"missing dot in the end. also better use a link.","commit_id":"0340c93dbd10729e5d11448fa7b76d2d2a3b0cbe"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d3be5c11a68ef29c1ed38a4277589ad876104b85","unresolved":false,"context_lines":[{"line_number":141,"context_line":"UEFI Secure Boot Support"},{"line_number":142,"context_line":"------------------------"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"See section on vendor passthrough"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Power Interface"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_6cce93b5","line":144,"in_reply_to":"7faddb67_b0712a47","updated":"2019-10-04 15:57:18.000000000","message":"Removed this section \"Management Interface\".","commit_id":"0340c93dbd10729e5d11448fa7b76d2d2a3b0cbe"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"23667c6079767f2744df02d96b0474b484972759","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Power Interface"},{"line_number":148,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"The following power methods are supported:"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_508eb627","line":148,"updated":"2019-07-26 08:44:58.000000000","message":"The power interface is pretty standard, I suggest not documenting it.","commit_id":"0340c93dbd10729e5d11448fa7b76d2d2a3b0cbe"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d3be5c11a68ef29c1ed38a4277589ad876104b85","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Power Interface"},{"line_number":148,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"The following power methods are supported:"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_ecb92315","line":148,"in_reply_to":"7faddb67_508eb627","updated":"2019-10-04 15:57:18.000000000","message":"Done","commit_id":"0340c93dbd10729e5d11448fa7b76d2d2a3b0cbe"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"23667c6079767f2744df02d96b0474b484972759","unresolved":false,"context_lines":[{"line_number":282,"context_line":""},{"line_number":283,"context_line":"In the case where the physical disk names or controller names are not"},{"line_number":284,"context_line":"known, the following python code example shows how the python-dracclient"},{"line_number":285,"context_line":"can be used to fetch the information directly from the Dell server:"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":".. code-block:: python"},{"line_number":288,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_70917246","line":285,"updated":"2019-07-26 08:44:58.000000000","message":"Side note: create a vendor passthru to fetch this information?","commit_id":"0340c93dbd10729e5d11448fa7b76d2d2a3b0cbe"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"11b018b3ca94851f2c7ebdb95ce106ed28eb9a0c","unresolved":false,"context_lines":[{"line_number":282,"context_line":""},{"line_number":283,"context_line":"In the case where the physical disk names or controller names are not"},{"line_number":284,"context_line":"known, the following python code example shows how the python-dracclient"},{"line_number":285,"context_line":"can be used to fetch the information directly from the Dell server:"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":".. code-block:: python"},{"line_number":288,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_3602a00b","line":285,"in_reply_to":"7faddb67_70917246","updated":"2019-09-26 18:07:56.000000000","message":"Sounds like a good idea!  I created a story to track this and added it to our internal roadmap:\nhttps://storyboard.openstack.org/#!/story/2006624","commit_id":"0340c93dbd10729e5d11448fa7b76d2d2a3b0cbe"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"23667c6079767f2744df02d96b0474b484972759","unresolved":false,"context_lines":[{"line_number":328,"context_line":"                                     is a list of dictionaries. Each"},{"line_number":329,"context_line":"                                     dictionary represents an unfinished"},{"line_number":330,"context_line":"                                     config Job object."},{"line_number":331,"context_line":"set_bios_config       POST           Change the BIOS configuration on"},{"line_number":332,"context_line":"                                     a node. Required argument: a"},{"line_number":333,"context_line":"                                     dictionary of {``AttributeName``:"},{"line_number":334,"context_line":"                                     ``NewValue``}. Returns a dictionary"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_10983e68","line":331,"updated":"2019-07-26 08:44:58.000000000","message":"Let\u0027s emphasize that this is the old way to get/set BIOS information","commit_id":"0340c93dbd10729e5d11448fa7b76d2d2a3b0cbe"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d3be5c11a68ef29c1ed38a4277589ad876104b85","unresolved":false,"context_lines":[{"line_number":328,"context_line":"                                     is a list of dictionaries. Each"},{"line_number":329,"context_line":"                                     dictionary represents an unfinished"},{"line_number":330,"context_line":"                                     config Job object."},{"line_number":331,"context_line":"set_bios_config       POST           Change the BIOS configuration on"},{"line_number":332,"context_line":"                                     a node. Required argument: a"},{"line_number":333,"context_line":"                                     dictionary of {``AttributeName``:"},{"line_number":334,"context_line":"                                     ``NewValue``}. Returns a dictionary"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_ac07abc9","line":331,"in_reply_to":"7faddb67_10983e68","updated":"2019-10-04 15:57:18.000000000","message":"Done.","commit_id":"0340c93dbd10729e5d11448fa7b76d2d2a3b0cbe"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"23667c6079767f2744df02d96b0474b484972759","unresolved":false,"context_lines":[{"line_number":381,"context_line":""},{"line_number":382,"context_line":"  openstack baremetal node passthru call ${node_uuid} set_bios_config --arg \"name\u003dvalue\""},{"line_number":383,"context_line":""},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"Walkthrough of perfoming a BIOS configuration change:"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"The following section demonstrates how to change BIOS configuration settings,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_309bfa66","line":384,"updated":"2019-07-26 08:44:58.000000000","message":"ditto","commit_id":"0340c93dbd10729e5d11448fa7b76d2d2a3b0cbe"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d3be5c11a68ef29c1ed38a4277589ad876104b85","unresolved":false,"context_lines":[{"line_number":381,"context_line":""},{"line_number":382,"context_line":"  openstack baremetal node passthru call ${node_uuid} set_bios_config --arg \"name\u003dvalue\""},{"line_number":383,"context_line":""},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"Walkthrough of perfoming a BIOS configuration change:"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"The following section demonstrates how to change BIOS configuration settings,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_0c211f4e","line":384,"in_reply_to":"7faddb67_309bfa66","updated":"2019-10-04 15:57:18.000000000","message":"Done","commit_id":"0340c93dbd10729e5d11448fa7b76d2d2a3b0cbe"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"1018e94fdd11df68b32ced4dcd98399b4d18d4b7","unresolved":false,"context_lines":[{"line_number":87,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"The Dell iDRAC out-of-band inspection process catalogs all the same"},{"line_number":90,"context_line":"attributes of the server as the IPMI driver.  Unlike IMPI, it does this"},{"line_number":91,"context_line":"without requiring the system to be rebooted, or even in a power on"},{"line_number":92,"context_line":"state.  Inspection is performed using the Dell WSMAN API directly without"},{"line_number":93,"context_line":"affecting the operation of the system being inspected."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_e0c84275","line":90,"range":{"start_line":90,"start_character":53,"end_line":90,"end_character":57},"updated":"2019-10-04 19:49:17.000000000","message":"misspelling: IPMI","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"1714c2275980b3ad0f22a8c0feef6b768231fc82","unresolved":false,"context_lines":[{"line_number":87,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"The Dell iDRAC out-of-band inspection process catalogs all the same"},{"line_number":90,"context_line":"attributes of the server as the IPMI driver.  Unlike IMPI, it does this"},{"line_number":91,"context_line":"without requiring the system to be rebooted, or even in a power on"},{"line_number":92,"context_line":"state.  Inspection is performed using the Dell WSMAN API directly without"},{"line_number":93,"context_line":"affecting the operation of the system being inspected."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_21dc1245","line":90,"range":{"start_line":90,"start_character":53,"end_line":90,"end_character":57},"in_reply_to":"3fa7e38b_e0c84275","updated":"2019-10-07 10:44:18.000000000","message":"done.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"1018e94fdd11df68b32ced4dcd98399b4d18d4b7","unresolved":false,"context_lines":[{"line_number":98,"context_line":"* ``cpus``: number of cpus"},{"line_number":99,"context_line":"* ``local_gb``: disk size"},{"line_number":100,"context_line":"* ``memory_mb``: memory size"},{"line_number":101,"context_line":"* ``model``: the Dell server model (eg: \"PowerEdge R640\")"},{"line_number":102,"context_line":"* ``provisioning_mac``: MAC address configured to PXE boot for provisioning."},{"line_number":103,"context_line":"* ``service_tag``: Dell service tag for the server (eg: \"FL0AQD2\")"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_a0b7aad8","line":101,"updated":"2019-10-04 19:49:17.000000000","message":"Need to remove \u0027model\u0027 since this is discovered by JetPack, not Ironic inspection.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"1714c2275980b3ad0f22a8c0feef6b768231fc82","unresolved":false,"context_lines":[{"line_number":98,"context_line":"* ``cpus``: number of cpus"},{"line_number":99,"context_line":"* ``local_gb``: disk size"},{"line_number":100,"context_line":"* ``memory_mb``: memory size"},{"line_number":101,"context_line":"* ``model``: the Dell server model (eg: \"PowerEdge R640\")"},{"line_number":102,"context_line":"* ``provisioning_mac``: MAC address configured to PXE boot for provisioning."},{"line_number":103,"context_line":"* ``service_tag``: Dell service tag for the server (eg: \"FL0AQD2\")"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_41dfce39","line":101,"in_reply_to":"3fa7e38b_a0b7aad8","updated":"2019-10-07 10:44:18.000000000","message":"done.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"1018e94fdd11df68b32ced4dcd98399b4d18d4b7","unresolved":false,"context_lines":[{"line_number":99,"context_line":"* ``local_gb``: disk size"},{"line_number":100,"context_line":"* ``memory_mb``: memory size"},{"line_number":101,"context_line":"* ``model``: the Dell server model (eg: \"PowerEdge R640\")"},{"line_number":102,"context_line":"* ``provisioning_mac``: MAC address configured to PXE boot for provisioning."},{"line_number":103,"context_line":"* ``service_tag``: Dell service tag for the server (eg: \"FL0AQD2\")"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Extra capabilities:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_80b4eed2","line":102,"updated":"2019-10-04 19:49:17.000000000","message":"The same is true with provisioning_mac.  It should be removed too.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"1714c2275980b3ad0f22a8c0feef6b768231fc82","unresolved":false,"context_lines":[{"line_number":99,"context_line":"* ``local_gb``: disk size"},{"line_number":100,"context_line":"* ``memory_mb``: memory size"},{"line_number":101,"context_line":"* ``model``: the Dell server model (eg: \"PowerEdge R640\")"},{"line_number":102,"context_line":"* ``provisioning_mac``: MAC address configured to PXE boot for provisioning."},{"line_number":103,"context_line":"* ``service_tag``: Dell service tag for the server (eg: \"FL0AQD2\")"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Extra capabilities:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_e1e59a0b","line":102,"in_reply_to":"3fa7e38b_80b4eed2","updated":"2019-10-07 10:44:18.000000000","message":"done.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"1018e94fdd11df68b32ced4dcd98399b4d18d4b7","unresolved":false,"context_lines":[{"line_number":100,"context_line":"* ``memory_mb``: memory size"},{"line_number":101,"context_line":"* ``model``: the Dell server model (eg: \"PowerEdge R640\")"},{"line_number":102,"context_line":"* ``provisioning_mac``: MAC address configured to PXE boot for provisioning."},{"line_number":103,"context_line":"* ``service_tag``: Dell service tag for the server (eg: \"FL0AQD2\")"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Extra capabilities:"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_40c6f64b","line":103,"updated":"2019-10-04 19:49:17.000000000","message":"The same is true with service_tag.  It should be removed too.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"1714c2275980b3ad0f22a8c0feef6b768231fc82","unresolved":false,"context_lines":[{"line_number":100,"context_line":"* ``memory_mb``: memory size"},{"line_number":101,"context_line":"* ``model``: the Dell server model (eg: \"PowerEdge R640\")"},{"line_number":102,"context_line":"* ``provisioning_mac``: MAC address configured to PXE boot for provisioning."},{"line_number":103,"context_line":"* ``service_tag``: Dell service tag for the server (eg: \"FL0AQD2\")"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Extra capabilities:"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_01e1d6fc","line":103,"in_reply_to":"3fa7e38b_40c6f64b","updated":"2019-10-07 10:44:18.000000000","message":"done.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"1018e94fdd11df68b32ced4dcd98399b4d18d4b7","unresolved":false,"context_lines":[{"line_number":105,"context_line":"Extra capabilities:"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"* ``boot_mode``: UEFI or BIOS boot mode."},{"line_number":108,"context_line":"* ``cpu_aes``: true if the CPU supports AES encryption."},{"line_number":109,"context_line":"* ``cpu_hugepages``: true, if the CPU supports huge pages."},{"line_number":110,"context_line":"* ``cpu_hugepages_1g``: true if the CPU supports 1g huge pages."},{"line_number":111,"context_line":"* ``cpu_txt``: true if the CPU supports a trusted platform module"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_80e94eb8","line":108,"updated":"2019-10-04 19:49:17.000000000","message":"Need to remove cpu_aes since OOB inspection does not discover it.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"1714c2275980b3ad0f22a8c0feef6b768231fc82","unresolved":false,"context_lines":[{"line_number":105,"context_line":"Extra capabilities:"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"* ``boot_mode``: UEFI or BIOS boot mode."},{"line_number":108,"context_line":"* ``cpu_aes``: true if the CPU supports AES encryption."},{"line_number":109,"context_line":"* ``cpu_hugepages``: true, if the CPU supports huge pages."},{"line_number":110,"context_line":"* ``cpu_hugepages_1g``: true if the CPU supports 1g huge pages."},{"line_number":111,"context_line":"* ``cpu_txt``: true if the CPU supports a trusted platform module"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_a1efa2e7","line":108,"in_reply_to":"3fa7e38b_80e94eb8","updated":"2019-10-07 10:44:18.000000000","message":"done.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"1018e94fdd11df68b32ced4dcd98399b4d18d4b7","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"* ``boot_mode``: UEFI or BIOS boot mode."},{"line_number":108,"context_line":"* ``cpu_aes``: true if the CPU supports AES encryption."},{"line_number":109,"context_line":"* ``cpu_hugepages``: true, if the CPU supports huge pages."},{"line_number":110,"context_line":"* ``cpu_hugepages_1g``: true if the CPU supports 1g huge pages."},{"line_number":111,"context_line":"* ``cpu_txt``: true if the CPU supports a trusted platform module"},{"line_number":112,"context_line":"* ``cpu_vt``: true, if the CPU supports CPU virtualization."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_e0d92222","line":109,"updated":"2019-10-04 19:49:17.000000000","message":"Same with cpu_hugepages.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"1714c2275980b3ad0f22a8c0feef6b768231fc82","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"* ``boot_mode``: UEFI or BIOS boot mode."},{"line_number":108,"context_line":"* ``cpu_aes``: true if the CPU supports AES encryption."},{"line_number":109,"context_line":"* ``cpu_hugepages``: true, if the CPU supports huge pages."},{"line_number":110,"context_line":"* ``cpu_hugepages_1g``: true if the CPU supports 1g huge pages."},{"line_number":111,"context_line":"* ``cpu_txt``: true if the CPU supports a trusted platform module"},{"line_number":112,"context_line":"* ``cpu_vt``: true, if the CPU supports CPU virtualization."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_c1eaded6","line":109,"in_reply_to":"3fa7e38b_e0d92222","updated":"2019-10-07 10:44:18.000000000","message":"done.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"1018e94fdd11df68b32ced4dcd98399b4d18d4b7","unresolved":false,"context_lines":[{"line_number":107,"context_line":"* ``boot_mode``: UEFI or BIOS boot mode."},{"line_number":108,"context_line":"* ``cpu_aes``: true if the CPU supports AES encryption."},{"line_number":109,"context_line":"* ``cpu_hugepages``: true, if the CPU supports huge pages."},{"line_number":110,"context_line":"* ``cpu_hugepages_1g``: true if the CPU supports 1g huge pages."},{"line_number":111,"context_line":"* ``cpu_txt``: true if the CPU supports a trusted platform module"},{"line_number":112,"context_line":"* ``cpu_vt``: true, if the CPU supports CPU virtualization."},{"line_number":113,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_00d55ee5","line":110,"updated":"2019-10-04 19:49:17.000000000","message":"Same with cpu_hugepages_1g.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"1714c2275980b3ad0f22a8c0feef6b768231fc82","unresolved":false,"context_lines":[{"line_number":107,"context_line":"* ``boot_mode``: UEFI or BIOS boot mode."},{"line_number":108,"context_line":"* ``cpu_aes``: true if the CPU supports AES encryption."},{"line_number":109,"context_line":"* ``cpu_hugepages``: true, if the CPU supports huge pages."},{"line_number":110,"context_line":"* ``cpu_hugepages_1g``: true if the CPU supports 1g huge pages."},{"line_number":111,"context_line":"* ``cpu_txt``: true if the CPU supports a trusted platform module"},{"line_number":112,"context_line":"* ``cpu_vt``: true, if the CPU supports CPU virtualization."},{"line_number":113,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_61bbeae4","line":110,"in_reply_to":"3fa7e38b_00d55ee5","updated":"2019-10-07 10:44:18.000000000","message":"done.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"1018e94fdd11df68b32ced4dcd98399b4d18d4b7","unresolved":false,"context_lines":[{"line_number":108,"context_line":"* ``cpu_aes``: true if the CPU supports AES encryption."},{"line_number":109,"context_line":"* ``cpu_hugepages``: true, if the CPU supports huge pages."},{"line_number":110,"context_line":"* ``cpu_hugepages_1g``: true if the CPU supports 1g huge pages."},{"line_number":111,"context_line":"* ``cpu_txt``: true if the CPU supports a trusted platform module"},{"line_number":112,"context_line":"* ``cpu_vt``: true, if the CPU supports CPU virtualization."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"It also creates baremetal ports for each NIC card detected in the system."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_a0056a7c","line":111,"updated":"2019-10-04 19:49:17.000000000","message":"Same with cpu_txt.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"1714c2275980b3ad0f22a8c0feef6b768231fc82","unresolved":false,"context_lines":[{"line_number":108,"context_line":"* ``cpu_aes``: true if the CPU supports AES encryption."},{"line_number":109,"context_line":"* ``cpu_hugepages``: true, if the CPU supports huge pages."},{"line_number":110,"context_line":"* ``cpu_hugepages_1g``: true if the CPU supports 1g huge pages."},{"line_number":111,"context_line":"* ``cpu_txt``: true if the CPU supports a trusted platform module"},{"line_number":112,"context_line":"* ``cpu_vt``: true, if the CPU supports CPU virtualization."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"It also creates baremetal ports for each NIC card detected in the system."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_81be26d2","line":111,"in_reply_to":"3fa7e38b_a0056a7c","updated":"2019-10-07 10:44:18.000000000","message":"done.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"1018e94fdd11df68b32ced4dcd98399b4d18d4b7","unresolved":false,"context_lines":[{"line_number":109,"context_line":"* ``cpu_hugepages``: true, if the CPU supports huge pages."},{"line_number":110,"context_line":"* ``cpu_hugepages_1g``: true if the CPU supports 1g huge pages."},{"line_number":111,"context_line":"* ``cpu_txt``: true if the CPU supports a trusted platform module"},{"line_number":112,"context_line":"* ``cpu_vt``: true, if the CPU supports CPU virtualization."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"It also creates baremetal ports for each NIC card detected in the system."},{"line_number":115,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_c008a692","line":112,"updated":"2019-10-04 19:49:17.000000000","message":"Same with cpu_vt.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"1714c2275980b3ad0f22a8c0feef6b768231fc82","unresolved":false,"context_lines":[{"line_number":109,"context_line":"* ``cpu_hugepages``: true, if the CPU supports huge pages."},{"line_number":110,"context_line":"* ``cpu_hugepages_1g``: true if the CPU supports 1g huge pages."},{"line_number":111,"context_line":"* ``cpu_txt``: true if the CPU supports a trusted platform module"},{"line_number":112,"context_line":"* ``cpu_vt``: true, if the CPU supports CPU virtualization."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"It also creates baremetal ports for each NIC card detected in the system."},{"line_number":115,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_21b5f2ee","line":112,"in_reply_to":"3fa7e38b_c008a692","updated":"2019-10-07 10:44:18.000000000","message":"done.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"1018e94fdd11df68b32ced4dcd98399b4d18d4b7","unresolved":false,"context_lines":[{"line_number":111,"context_line":"* ``cpu_txt``: true if the CPU supports a trusted platform module"},{"line_number":112,"context_line":"* ``cpu_vt``: true, if the CPU supports CPU virtualization."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"It also creates baremetal ports for each NIC card detected in the system."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Example"},{"line_number":117,"context_line":"--------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_40f4b687","line":114,"updated":"2019-10-04 19:49:17.000000000","message":"Can you change the above line to:\n\nIt also creates a baremetal port for each NIC port detected in the system and sets ``pxe_enabled`` to ``True`` on every baremetal port where PXE booting is enabled.  ``pxe_enabled`` is set appropriately on the baremetal ports regardless of the boot mode of the system.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"1714c2275980b3ad0f22a8c0feef6b768231fc82","unresolved":false,"context_lines":[{"line_number":111,"context_line":"* ``cpu_txt``: true if the CPU supports a trusted platform module"},{"line_number":112,"context_line":"* ``cpu_vt``: true, if the CPU supports CPU virtualization."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"It also creates baremetal ports for each NIC card detected in the system."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Example"},{"line_number":117,"context_line":"--------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_41b82ee4","line":114,"in_reply_to":"3fa7e38b_40f4b687","updated":"2019-10-07 10:44:18.000000000","message":"done.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"1018e94fdd11df68b32ced4dcd98399b4d18d4b7","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":".. code-block:: bash"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"  openstack baremetal port create --node ${node_uuid} ${mac_address}"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"RAID Interface"},{"line_number":127,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_609e9208","line":124,"updated":"2019-10-04 19:49:17.000000000","message":"I think this example is confusing because since the code is creating the ports, there is no reason for the user to create them.  How about just including a sample run of an \"openstack baremetal port show \u003csome_uuid\u003e\" command on a port where pxe_enabled is True?","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"1714c2275980b3ad0f22a8c0feef6b768231fc82","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":".. code-block:: bash"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"  openstack baremetal port create --node ${node_uuid} ${mac_address}"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"RAID Interface"},{"line_number":127,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_c7150ee7","line":124,"in_reply_to":"3fa7e38b_609e9208","updated":"2019-10-07 10:44:18.000000000","message":"done","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"1018e94fdd11df68b32ced4dcd98399b4d18d4b7","unresolved":false,"context_lines":[{"line_number":157,"context_line":"See :doc:`/admin/raid` for more information on backing disk hints."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":".. NOTE::"},{"line_number":160,"context_line":"  These properties are currently not supported by the iDRAC RAID driver."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"* ``disk_type``"},{"line_number":163,"context_line":"* ``interface_type``"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_9b9a1fc3","line":160,"updated":"2019-10-04 19:49:17.000000000","message":"It doesn\u0027t look to me like this is the case.  It appears that these properties are supported:\nhttps://github.com/openstack/ironic/blob/master/ironic/drivers/modules/drac/raid.py#L669\nCan you do a test and verify that each of these are supported, then update this doc?","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"1714c2275980b3ad0f22a8c0feef6b768231fc82","unresolved":false,"context_lines":[{"line_number":157,"context_line":"See :doc:`/admin/raid` for more information on backing disk hints."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":".. NOTE::"},{"line_number":160,"context_line":"  These properties are currently not supported by the iDRAC RAID driver."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"* ``disk_type``"},{"line_number":163,"context_line":"* ``interface_type``"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_41ecae8e","line":160,"in_reply_to":"3fa7e38b_9b9a1fc3","updated":"2019-10-07 10:44:18.000000000","message":"done.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"1018e94fdd11df68b32ced4dcd98399b4d18d4b7","unresolved":false,"context_lines":[{"line_number":171,"context_line":"names as provided by the iDRAC."},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"* ``controller``: Mandatory. The name of the controller to use."},{"line_number":174,"context_line":"* ``physical_disks``: Mandatory. The names of the physical disks to use."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Examples"},{"line_number":177,"context_line":"--------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_7bf5e3ec","line":174,"updated":"2019-10-04 19:49:17.000000000","message":"physical_disks is only required when a size_gb of MAX is also specified.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"1714c2275980b3ad0f22a8c0feef6b768231fc82","unresolved":false,"context_lines":[{"line_number":171,"context_line":"names as provided by the iDRAC."},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"* ``controller``: Mandatory. The name of the controller to use."},{"line_number":174,"context_line":"* ``physical_disks``: Mandatory. The names of the physical disks to use."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Examples"},{"line_number":177,"context_line":"--------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_c18c1ed9","line":174,"in_reply_to":"3fa7e38b_7bf5e3ec","updated":"2019-10-07 10:44:18.000000000","message":"done.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"1018e94fdd11df68b32ced4dcd98399b4d18d4b7","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                                     a node. Required argument: a"},{"line_number":278,"context_line":"                                     dictionary of {``AttributeName``:"},{"line_number":279,"context_line":"                                     ``NewValue``}. Returns a dictionary"},{"line_number":280,"context_line":"                                     containing ``is_commit_required``"},{"line_number":281,"context_line":"                                     key whether commit_bios_config needs to"},{"line_number":282,"context_line":"                                     be called to make the changes and"},{"line_number":283,"context_line":"\t\t\t\t     ``is_reboot_required`` value indicating"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_1b4aaf26","line":280,"updated":"2019-10-04 19:49:17.000000000","message":"Can you change the above to:\ncontaining the ``is_commit_required``","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"1714c2275980b3ad0f22a8c0feef6b768231fc82","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                                     a node. Required argument: a"},{"line_number":278,"context_line":"                                     dictionary of {``AttributeName``:"},{"line_number":279,"context_line":"                                     ``NewValue``}. Returns a dictionary"},{"line_number":280,"context_line":"                                     containing ``is_commit_required``"},{"line_number":281,"context_line":"                                     key whether commit_bios_config needs to"},{"line_number":282,"context_line":"                                     be called to make the changes and"},{"line_number":283,"context_line":"\t\t\t\t     ``is_reboot_required`` value indicating"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_e1cefa81","line":280,"in_reply_to":"3fa7e38b_1b4aaf26","updated":"2019-10-07 10:44:18.000000000","message":"done.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"1018e94fdd11df68b32ced4dcd98399b4d18d4b7","unresolved":false,"context_lines":[{"line_number":278,"context_line":"                                     dictionary of {``AttributeName``:"},{"line_number":279,"context_line":"                                     ``NewValue``}. Returns a dictionary"},{"line_number":280,"context_line":"                                     containing ``is_commit_required``"},{"line_number":281,"context_line":"                                     key whether commit_bios_config needs to"},{"line_number":282,"context_line":"                                     be called to make the changes and"},{"line_number":283,"context_line":"\t\t\t\t     ``is_reboot_required`` value indicating"},{"line_number":284,"context_line":"\t\t\t\t     whether the server must be rebooted"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_9b5f7fe4","line":281,"updated":"2019-10-04 19:49:17.000000000","message":"Can you change the above to:\nkey indicating whether ...","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"1714c2275980b3ad0f22a8c0feef6b768231fc82","unresolved":false,"context_lines":[{"line_number":278,"context_line":"                                     dictionary of {``AttributeName``:"},{"line_number":279,"context_line":"                                     ``NewValue``}. Returns a dictionary"},{"line_number":280,"context_line":"                                     containing ``is_commit_required``"},{"line_number":281,"context_line":"                                     key whether commit_bios_config needs to"},{"line_number":282,"context_line":"                                     be called to make the changes and"},{"line_number":283,"context_line":"\t\t\t\t     ``is_reboot_required`` value indicating"},{"line_number":284,"context_line":"\t\t\t\t     whether the server must be rebooted"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_a1c80274","line":281,"in_reply_to":"3fa7e38b_9b5f7fe4","updated":"2019-10-07 10:44:18.000000000","message":"done.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"1018e94fdd11df68b32ced4dcd98399b4d18d4b7","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                                     containing ``is_commit_required``"},{"line_number":281,"context_line":"                                     key whether commit_bios_config needs to"},{"line_number":282,"context_line":"                                     be called to make the changes and"},{"line_number":283,"context_line":"\t\t\t\t     ``is_reboot_required`` value indicating"},{"line_number":284,"context_line":"\t\t\t\t     whether the server must be rebooted"},{"line_number":285,"context_line":"\t\t\t\t     for set_bios_config to be applied."},{"line_number":286,"context_line":"\t\t\t\t     Possible values are true and false."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_9b045fc8","line":283,"updated":"2019-10-04 19:49:17.000000000","message":"Can you change the above line to:\nthe ``is_reboot_required`` ...","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"1714c2275980b3ad0f22a8c0feef6b768231fc82","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                                     containing ``is_commit_required``"},{"line_number":281,"context_line":"                                     key whether commit_bios_config needs to"},{"line_number":282,"context_line":"                                     be called to make the changes and"},{"line_number":283,"context_line":"\t\t\t\t     ``is_reboot_required`` value indicating"},{"line_number":284,"context_line":"\t\t\t\t     whether the server must be rebooted"},{"line_number":285,"context_line":"\t\t\t\t     for set_bios_config to be applied."},{"line_number":286,"context_line":"\t\t\t\t     Possible values are true and false."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_c1c3be56","line":283,"in_reply_to":"3fa7e38b_9b045fc8","updated":"2019-10-07 10:44:18.000000000","message":"done.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"1018e94fdd11df68b32ced4dcd98399b4d18d4b7","unresolved":false,"context_lines":[{"line_number":282,"context_line":"                                     be called to make the changes and"},{"line_number":283,"context_line":"\t\t\t\t     ``is_reboot_required`` value indicating"},{"line_number":284,"context_line":"\t\t\t\t     whether the server must be rebooted"},{"line_number":285,"context_line":"\t\t\t\t     for set_bios_config to be applied."},{"line_number":286,"context_line":"\t\t\t\t     Possible values are true and false."},{"line_number":287,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":288,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_1bf86fc2","line":285,"updated":"2019-10-04 19:49:17.000000000","message":"Can you change the above line to:\nfor the BIOS settings to be applied.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"1714c2275980b3ad0f22a8c0feef6b768231fc82","unresolved":false,"context_lines":[{"line_number":282,"context_line":"                                     be called to make the changes and"},{"line_number":283,"context_line":"\t\t\t\t     ``is_reboot_required`` value indicating"},{"line_number":284,"context_line":"\t\t\t\t     whether the server must be rebooted"},{"line_number":285,"context_line":"\t\t\t\t     for set_bios_config to be applied."},{"line_number":286,"context_line":"\t\t\t\t     Possible values are true and false."},{"line_number":287,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":288,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_61a0caa6","line":285,"in_reply_to":"3fa7e38b_1bf86fc2","updated":"2019-10-07 10:44:18.000000000","message":"done.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"1018e94fdd11df68b32ced4dcd98399b4d18d4b7","unresolved":false,"context_lines":[{"line_number":358,"context_line":"Commit BIOS Changes"},{"line_number":359,"context_line":"~~~~~~~~~~~~~~~~~~~"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"Next step is to commit the pending change to the BIOS.  Note that in this"},{"line_number":362,"context_line":"example, the ``reboot`` argument is set to true. The response indicates"},{"line_number":363,"context_line":"that a reboot is no longer required as it has been scheduled automatically"},{"line_number":364,"context_line":"by the commit_bios_config call. If the reboot argument is not supplied,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_3bc68b4b","line":361,"updated":"2019-10-04 19:49:17.000000000","message":"Can you change the above to:\nThe next step ...","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"1714c2275980b3ad0f22a8c0feef6b768231fc82","unresolved":false,"context_lines":[{"line_number":358,"context_line":"Commit BIOS Changes"},{"line_number":359,"context_line":"~~~~~~~~~~~~~~~~~~~"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"Next step is to commit the pending change to the BIOS.  Note that in this"},{"line_number":362,"context_line":"example, the ``reboot`` argument is set to true. The response indicates"},{"line_number":363,"context_line":"that a reboot is no longer required as it has been scheduled automatically"},{"line_number":364,"context_line":"by the commit_bios_config call. If the reboot argument is not supplied,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_81a386b1","line":361,"in_reply_to":"3fa7e38b_3bc68b4b","updated":"2019-10-07 10:44:18.000000000","message":"done.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"1018e94fdd11df68b32ced4dcd98399b4d18d4b7","unresolved":false,"context_lines":[{"line_number":364,"context_line":"by the commit_bios_config call. If the reboot argument is not supplied,"},{"line_number":365,"context_line":"the job is still created, however it remains in the ``scheduled`` state"},{"line_number":366,"context_line":"until a reboot is performed. The reboot can be initiated through the"},{"line_number":367,"context_line":"ironic reboot api."},{"line_number":368,"context_line":""},{"line_number":369,"context_line":".. code-block:: bash"},{"line_number":370,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_9bb77fd9","line":367,"updated":"2019-10-04 19:49:17.000000000","message":"Can you change the above line to:\nIronic power API","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"1714c2275980b3ad0f22a8c0feef6b768231fc82","unresolved":false,"context_lines":[{"line_number":364,"context_line":"by the commit_bios_config call. If the reboot argument is not supplied,"},{"line_number":365,"context_line":"the job is still created, however it remains in the ``scheduled`` state"},{"line_number":366,"context_line":"until a reboot is performed. The reboot can be initiated through the"},{"line_number":367,"context_line":"ironic reboot api."},{"line_number":368,"context_line":""},{"line_number":369,"context_line":".. code-block:: bash"},{"line_number":370,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_81d5c61d","line":367,"in_reply_to":"3fa7e38b_9bb77fd9","updated":"2019-10-07 10:44:18.000000000","message":"done.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"1018e94fdd11df68b32ced4dcd98399b4d18d4b7","unresolved":false,"context_lines":[{"line_number":371,"context_line":"  openstack baremetal node passthru call ${node_uuid} commit_bios_config \\"},{"line_number":372,"context_line":"    --arg \"reboot\u003dtrue\""},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"This returns \u0027job_id\u0027 of created config job:"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":".. code-block:: bash "},{"line_number":377,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_bbdfdb0a","line":374,"updated":"2019-10-04 19:49:17.000000000","message":"Can you change the above line to:\nThis returns the \u0027job_id\u0027 of the created config job:","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"1714c2275980b3ad0f22a8c0feef6b768231fc82","unresolved":false,"context_lines":[{"line_number":371,"context_line":"  openstack baremetal node passthru call ${node_uuid} commit_bios_config \\"},{"line_number":372,"context_line":"    --arg \"reboot\u003dtrue\""},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"This returns \u0027job_id\u0027 of created config job:"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":".. code-block:: bash "},{"line_number":377,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_a11a4214","line":374,"in_reply_to":"3fa7e38b_bbdfdb0a","updated":"2019-10-07 10:44:18.000000000","message":"done.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"1018e94fdd11df68b32ced4dcd98399b4d18d4b7","unresolved":false,"context_lines":[{"line_number":373,"context_line":""},{"line_number":374,"context_line":"This returns \u0027job_id\u0027 of created config job:"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":".. code-block:: bash "},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"      \"job_id\": \"JID_499377293428\""},{"line_number":379,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_7bb403d2","line":376,"updated":"2019-10-04 19:49:17.000000000","message":"Can you remove the trailing space on the line above?","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"1714c2275980b3ad0f22a8c0feef6b768231fc82","unresolved":false,"context_lines":[{"line_number":373,"context_line":""},{"line_number":374,"context_line":"This returns \u0027job_id\u0027 of created config job:"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":".. code-block:: bash "},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"      \"job_id\": \"JID_499377293428\""},{"line_number":379,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_61d20a37","line":376,"in_reply_to":"3fa7e38b_7bb403d2","updated":"2019-10-07 10:44:18.000000000","message":"done.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"1018e94fdd11df68b32ced4dcd98399b4d18d4b7","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        \"id\": \"JID_499377293428\"}]}"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"Adandon BIOS Changes"},{"line_number":400,"context_line":"~~~~~~~~~~~~~~~~~~~~"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"Instead of committing, the pending change can also be rolled back"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_5bffc766","line":399,"updated":"2019-10-04 19:49:17.000000000","message":"Spelling: Abandon","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"1714c2275980b3ad0f22a8c0feef6b768231fc82","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        \"id\": \"JID_499377293428\"}]}"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"Adandon BIOS Changes"},{"line_number":400,"context_line":"~~~~~~~~~~~~~~~~~~~~"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"Instead of committing, the pending change can also be rolled back"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_011c7611","line":399,"in_reply_to":"3fa7e38b_5bffc766","updated":"2019-10-07 10:44:18.000000000","message":"done.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"1018e94fdd11df68b32ced4dcd98399b4d18d4b7","unresolved":false,"context_lines":[{"line_number":434,"context_line":""},{"line_number":435,"context_line":"The UEFI boot mode offers:"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"* Improved Partitioning scheme for boot media"},{"line_number":438,"context_line":"* Support for media larger than 2 TB"},{"line_number":439,"context_line":"* Redundant partition tables"},{"line_number":440,"context_line":"* Flexible handoff from BIOS to OS"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_7b37234f","line":437,"updated":"2019-10-04 19:49:17.000000000","message":"Can you change \"Partitioning\" to \"partitioning\" in the line above?","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"1714c2275980b3ad0f22a8c0feef6b768231fc82","unresolved":false,"context_lines":[{"line_number":434,"context_line":""},{"line_number":435,"context_line":"The UEFI boot mode offers:"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"* Improved Partitioning scheme for boot media"},{"line_number":438,"context_line":"* Support for media larger than 2 TB"},{"line_number":439,"context_line":"* Redundant partition tables"},{"line_number":440,"context_line":"* Flexible handoff from BIOS to OS"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_21aad284","line":437,"in_reply_to":"3fa7e38b_7b37234f","updated":"2019-10-07 10:44:18.000000000","message":"done.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"1018e94fdd11df68b32ced4dcd98399b4d18d4b7","unresolved":false,"context_lines":[{"line_number":446,"context_line":".. code-block:: bash"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"  openstack baremetal node passthru call ${node_uuid} set_bios_config \\"},{"line_number":449,"context_line":"    --arg \"BootMode\u003dUefi\""},{"line_number":450,"context_line":""},{"line_number":451,"context_line":".. code-block:: bash"},{"line_number":452,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_9b61bf3c","line":449,"updated":"2019-10-04 19:49:17.000000000","message":"Could you add the command to commit the changes and reboot here?","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"1714c2275980b3ad0f22a8c0feef6b768231fc82","unresolved":false,"context_lines":[{"line_number":446,"context_line":".. code-block:: bash"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"  openstack baremetal node passthru call ${node_uuid} set_bios_config \\"},{"line_number":449,"context_line":"    --arg \"BootMode\u003dUefi\""},{"line_number":450,"context_line":""},{"line_number":451,"context_line":".. code-block:: bash"},{"line_number":452,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_a14ec2be","line":449,"in_reply_to":"3fa7e38b_9b61bf3c","updated":"2019-10-07 10:44:18.000000000","message":"done.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"1018e94fdd11df68b32ced4dcd98399b4d18d4b7","unresolved":false,"context_lines":[{"line_number":451,"context_line":".. code-block:: bash"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"  openstack baremetal node passthru call ${node_uuid} set_bios_config \\"},{"line_number":454,"context_line":"    --arg \"BootMode\u003dBios\""},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"Known Issues"},{"line_number":457,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_7b5e4377","line":454,"updated":"2019-10-04 19:49:17.000000000","message":"Same here.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"1714c2275980b3ad0f22a8c0feef6b768231fc82","unresolved":false,"context_lines":[{"line_number":451,"context_line":".. code-block:: bash"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"  openstack baremetal node passthru call ${node_uuid} set_bios_config \\"},{"line_number":454,"context_line":"    --arg \"BootMode\u003dBios\""},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"Known Issues"},{"line_number":457,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_0150f65d","line":454,"in_reply_to":"3fa7e38b_7b5e4377","updated":"2019-10-07 10:44:18.000000000","message":"done.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"1018e94fdd11df68b32ced4dcd98399b4d18d4b7","unresolved":false,"context_lines":[{"line_number":465,"context_line":"``[conductor]sync_power_state_interval`` in ``/etc/ironic/ironic.conf``."},{"line_number":466,"context_line":""},{"line_number":467,"context_line":".. _Ironic_RAID: https://docs.openstack.org/ironic/latest/admin/raid.html"},{"line_number":468,"context_line":".. _iDRAC: www.dell.com/idracmanuals"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_1bb14f90","line":468,"updated":"2019-10-04 19:49:17.000000000","message":"Can you add https:// in front of the URL above?  It is currently being treated as a relative URL.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"1714c2275980b3ad0f22a8c0feef6b768231fc82","unresolved":false,"context_lines":[{"line_number":465,"context_line":"``[conductor]sync_power_state_interval`` in ``/etc/ironic/ironic.conf``."},{"line_number":466,"context_line":""},{"line_number":467,"context_line":".. _Ironic_RAID: https://docs.openstack.org/ironic/latest/admin/raid.html"},{"line_number":468,"context_line":".. _iDRAC: www.dell.com/idracmanuals"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_61ef6a87","line":468,"in_reply_to":"3fa7e38b_1bb14f90","updated":"2019-10-07 10:44:18.000000000","message":"done.","commit_id":"f83e2c7e41ee72e25de05122bd490256e4e70908"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"b8924120eeb60a36820ea787451073afdf4f809b","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Overview"},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":"The integrated Dell Remote Access Controller (iDRAC_) is an out-of-band"},{"line_number":8,"context_line":"management platform on Dell servers, and is supported directly by the"},{"line_number":9,"context_line":"``idrac`` hardware type.  This driver uses the Dell Web Services for"},{"line_number":10,"context_line":"Management (WSMAN) APIs to perform all of its functions."}],"source_content_type":"text/x-rst","patch_set":7,"id":"3fa7e38b_e801f607","line":7,"range":{"start_line":7,"start_character":57,"end_line":7,"end_character":71},"updated":"2019-10-07 16:04:03.000000000","message":"I think these do support both in-band and out-band management","commit_id":"d64359b4f9caf6f21b829954722a5297e22682b7"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"523954bf30325f364dd94d6adba034b411386070","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Overview"},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":"The integrated Dell Remote Access Controller (iDRAC_) is an out-of-band"},{"line_number":8,"context_line":"management platform on Dell servers, and is supported directly by the"},{"line_number":9,"context_line":"``idrac`` hardware type.  This driver uses the Dell Web Services for"},{"line_number":10,"context_line":"Management (WSMAN) APIs to perform all of its functions."}],"source_content_type":"text/x-rst","patch_set":7,"id":"3fa7e38b_a20d3991","line":7,"range":{"start_line":7,"start_character":57,"end_line":7,"end_character":71},"in_reply_to":"3fa7e38b_e801f607","updated":"2019-10-09 08:37:55.000000000","message":"Done","commit_id":"d64359b4f9caf6f21b829954722a5297e22682b7"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"b8924120eeb60a36820ea787451073afdf4f809b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":"The integrated Dell Remote Access Controller (iDRAC_) is an out-of-band"},{"line_number":8,"context_line":"management platform on Dell servers, and is supported directly by the"},{"line_number":9,"context_line":"``idrac`` hardware type.  This driver uses the Dell Web Services for"},{"line_number":10,"context_line":"Management (WSMAN) APIs to perform all of its functions."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"iDRAC_ hardware is also supported by the standard ``ipmi`` hardware type,"},{"line_number":13,"context_line":"though with a smaller feature set.  It is also supported by the ``redfish``"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3fa7e38b_bb1b4671","line":10,"range":{"start_line":9,"start_character":26,"end_line":10,"end_character":56},"updated":"2019-10-07 16:04:03.000000000","message":"We are using it for both redfish and WSMAN","commit_id":"d64359b4f9caf6f21b829954722a5297e22682b7"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"523954bf30325f364dd94d6adba034b411386070","unresolved":false,"context_lines":[{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":"The integrated Dell Remote Access Controller (iDRAC_) is an out-of-band"},{"line_number":8,"context_line":"management platform on Dell servers, and is supported directly by the"},{"line_number":9,"context_line":"``idrac`` hardware type.  This driver uses the Dell Web Services for"},{"line_number":10,"context_line":"Management (WSMAN) APIs to perform all of its functions."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"iDRAC_ hardware is also supported by the standard ``ipmi`` hardware type,"},{"line_number":13,"context_line":"though with a smaller feature set.  It is also supported by the ``redfish``"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3fa7e38b_c21075ab","line":10,"range":{"start_line":9,"start_character":26,"end_line":10,"end_character":56},"in_reply_to":"3fa7e38b_bb1b4671","updated":"2019-10-09 08:37:55.000000000","message":"Done","commit_id":"d64359b4f9caf6f21b829954722a5297e22682b7"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"b8924120eeb60a36820ea787451073afdf4f809b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Ironic Features"},{"line_number":29,"context_line":"---------------"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"The hardware type ``idrac`` supports the following Ironic interfaces:"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* `Inspect Interface`_: Hardware Inspection"},{"line_number":34,"context_line":"* `Management Interface`: Boot device management"},{"line_number":35,"context_line":"* `Power Interface`: Power management"},{"line_number":36,"context_line":"* `RAID Interface`_: RAID controller and disk management"},{"line_number":37,"context_line":"* `Vendor Interface`_: BIOS management"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Enabling"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3fa7e38b_9b4f6a69","line":37,"range":{"start_line":31,"start_character":0,"end_line":37,"end_character":38},"updated":"2019-10-07 16:04:03.000000000","message":"suggest adding the ones for redfish also.\n\nThe details for redfish can be done later in separate patch.","commit_id":"d64359b4f9caf6f21b829954722a5297e22682b7"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"523954bf30325f364dd94d6adba034b411386070","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Ironic Features"},{"line_number":29,"context_line":"---------------"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"The hardware type ``idrac`` supports the following Ironic interfaces:"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* `Inspect Interface`_: Hardware Inspection"},{"line_number":34,"context_line":"* `Management Interface`: Boot device management"},{"line_number":35,"context_line":"* `Power Interface`: Power management"},{"line_number":36,"context_line":"* `RAID Interface`_: RAID controller and disk management"},{"line_number":37,"context_line":"* `Vendor Interface`_: BIOS management"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Enabling"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3fa7e38b_62274114","line":37,"range":{"start_line":31,"start_character":0,"end_line":37,"end_character":38},"in_reply_to":"3fa7e38b_9b4f6a69","updated":"2019-10-09 08:37:55.000000000","message":"Done","commit_id":"d64359b4f9caf6f21b829954722a5297e22682b7"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"b8924120eeb60a36820ea787451073afdf4f809b","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Extra capabilities:"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"* ``boot_mode``: UEFI or BIOS boot mode."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"It also creates baremetal ports for each NIC port detected in the system"},{"line_number":107,"context_line":"and sets ``pxe-enabled`` to ``True`` on every baremetal port where PXE"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3fa7e38b_7ba06ea6","line":104,"range":{"start_line":104,"start_character":0,"end_line":104,"end_character":40},"updated":"2019-10-07 16:04:03.000000000","message":"should state what is the default?","commit_id":"d64359b4f9caf6f21b829954722a5297e22682b7"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"523954bf30325f364dd94d6adba034b411386070","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Extra capabilities:"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"* ``boot_mode``: UEFI or BIOS boot mode."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"It also creates baremetal ports for each NIC port detected in the system"},{"line_number":107,"context_line":"and sets ``pxe-enabled`` to ``True`` on every baremetal port where PXE"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3fa7e38b_82227d00","line":104,"range":{"start_line":104,"start_character":0,"end_line":104,"end_character":40},"in_reply_to":"3fa7e38b_7ba06ea6","updated":"2019-10-09 08:37:55.000000000","message":"Done","commit_id":"d64359b4f9caf6f21b829954722a5297e22682b7"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2356e3bce23149ef7ccbd6cb636492981d6fa1ee","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"iDRAC_ hardware is also supported by the standard ``ipmi`` hardware type,"},{"line_number":15,"context_line":"though with a smaller feature set.  It is also supported by the ``redfish``"},{"line_number":16,"context_line":"hardware type."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Key features of the Dell iDRAC:"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_b10a5776","line":16,"updated":"2019-10-09 20:38:56.000000000","message":"Can you change the above 3 lines to:\niDRAC_ hardware is also supported by the standard ``ipmi`` and ``redfish`` hardware types though with a smaller feature set.","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"5249b1ae9477b6f5b6bdf1e2d7f94bf6d908da24","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"iDRAC_ hardware is also supported by the standard ``ipmi`` hardware type,"},{"line_number":15,"context_line":"though with a smaller feature set.  It is also supported by the ``redfish``"},{"line_number":16,"context_line":"hardware type."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Key features of the Dell iDRAC:"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_667d00b1","line":16,"in_reply_to":"3fa7e38b_b10a5776","updated":"2019-10-10 12:59:29.000000000","message":"Done","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0c3058766e25df3c06d5c22e532c66289e2bd0b7","unresolved":false,"context_lines":[{"line_number":38,"context_line":"* `RAID Interface`_: RAID controller and disk management"},{"line_number":39,"context_line":"* `Vendor Interface`_: BIOS management"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The hardware type ``redfish`` supports the following Ironic interfaces:"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* `Inspect Interface`: Hardware Inspection"},{"line_number":44,"context_line":"* `Management Interface`: Boot device management"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_58b1d48e","line":41,"updated":"2019-10-09 09:07:57.000000000","message":"Do you mean it in the context of iDrac? I.e. that these features are fully supported with Dell hardware? If so, please phrase accordingly. Otherwise we can just like to the redfish page somewhere above where we first mention it.","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"5249b1ae9477b6f5b6bdf1e2d7f94bf6d908da24","unresolved":false,"context_lines":[{"line_number":38,"context_line":"* `RAID Interface`_: RAID controller and disk management"},{"line_number":39,"context_line":"* `Vendor Interface`_: BIOS management"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The hardware type ``redfish`` supports the following Ironic interfaces:"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* `Inspect Interface`: Hardware Inspection"},{"line_number":44,"context_line":"* `Management Interface`: Boot device management"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_09f53fed","line":41,"in_reply_to":"3fa7e38b_5149a3b4","updated":"2019-10-10 12:59:29.000000000","message":"Done","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2356e3bce23149ef7ccbd6cb636492981d6fa1ee","unresolved":false,"context_lines":[{"line_number":38,"context_line":"* `RAID Interface`_: RAID controller and disk management"},{"line_number":39,"context_line":"* `Vendor Interface`_: BIOS management"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The hardware type ``redfish`` supports the following Ironic interfaces:"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* `Inspect Interface`: Hardware Inspection"},{"line_number":44,"context_line":"* `Management Interface`: Boot device management"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_5149a3b4","line":41,"in_reply_to":"3fa7e38b_58b1d48e","updated":"2019-10-09 20:38:56.000000000","message":"I agree.  Let\u0027s remove this section about the redfish hardware type since it should be covered in that driver\u0027s documentation.","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2356e3bce23149ef7ccbd6cb636492981d6fa1ee","unresolved":false,"context_lines":[{"line_number":49,"context_line":"Enabling"},{"line_number":50,"context_line":"--------"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"The ``idrac`` hardware type requires the ``python-dracclient`` library to be"},{"line_number":53,"context_line":"installed, for example::"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    sudo pip install \u0027python-dracclient\u003e\u003d3.0.0\u0027"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_b19b3715","line":52,"updated":"2019-10-09 20:38:56.000000000","message":"Can you change the above line to:\nThe ``idrac`` hardware type requires the ``python-dracclient`` and ``sushy`` libraries to be","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"5249b1ae9477b6f5b6bdf1e2d7f94bf6d908da24","unresolved":false,"context_lines":[{"line_number":49,"context_line":"Enabling"},{"line_number":50,"context_line":"--------"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"The ``idrac`` hardware type requires the ``python-dracclient`` library to be"},{"line_number":53,"context_line":"installed, for example::"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    sudo pip install \u0027python-dracclient\u003e\u003d3.0.0\u0027"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_264dc899","line":52,"in_reply_to":"3fa7e38b_b19b3715","updated":"2019-10-10 12:59:29.000000000","message":"Done","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2356e3bce23149ef7ccbd6cb636492981d6fa1ee","unresolved":false,"context_lines":[{"line_number":52,"context_line":"The ``idrac`` hardware type requires the ``python-dracclient`` library to be"},{"line_number":53,"context_line":"installed, for example::"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    sudo pip install \u0027python-dracclient\u003e\u003d3.0.0\u0027"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"To enable the ``idrac`` hardware type, add the following to your"},{"line_number":58,"context_line":"``/etc/ironic/ironic.conf``:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_31a8a71e","line":55,"updated":"2019-10-09 20:38:56.000000000","message":"Can you change the above line to:\nsudo pip install \u0027python-dracclient\u003e\u003d3.0.0\u0027 \u0027sushy\u003e\u003d2.0.0\u0027","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"5249b1ae9477b6f5b6bdf1e2d7f94bf6d908da24","unresolved":false,"context_lines":[{"line_number":52,"context_line":"The ``idrac`` hardware type requires the ``python-dracclient`` library to be"},{"line_number":53,"context_line":"installed, for example::"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    sudo pip install \u0027python-dracclient\u003e\u003d3.0.0\u0027"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"To enable the ``idrac`` hardware type, add the following to your"},{"line_number":58,"context_line":"``/etc/ironic/ironic.conf``:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_e6425068","line":55,"in_reply_to":"3fa7e38b_31a8a71e","updated":"2019-10-10 12:59:29.000000000","message":"Done","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2356e3bce23149ef7ccbd6cb636492981d6fa1ee","unresolved":false,"context_lines":[{"line_number":53,"context_line":"installed, for example::"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    sudo pip install \u0027python-dracclient\u003e\u003d3.0.0\u0027"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"To enable the ``idrac`` hardware type, add the following to your"},{"line_number":58,"context_line":"``/etc/ironic/ironic.conf``:"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_147c7981","line":56,"updated":"2019-10-09 20:38:56.000000000","message":"Can you add this:\nThe iDRAC driver supports WSMAN for the inspect, management, power, raid, and vendor interfaces.  In addition, it supports Redfish for the inspect, power, and management interfaces.  The iDRAC driver allows you to mix and match which protocol to use for which interface.  To select WSMAN for an interface, specify ``idrac-wsman`` when enabling the interface.  To select Redfish for an interface, select ``idrac-redfish` when enabling the interface.\n\nNote that Redfish can only be selected for the inspect, power, and management interfaces at the present time.","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"5249b1ae9477b6f5b6bdf1e2d7f94bf6d908da24","unresolved":false,"context_lines":[{"line_number":53,"context_line":"installed, for example::"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    sudo pip install \u0027python-dracclient\u003e\u003d3.0.0\u0027"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"To enable the ``idrac`` hardware type, add the following to your"},{"line_number":58,"context_line":"``/etc/ironic/ironic.conf``:"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_8967efb7","line":56,"in_reply_to":"3fa7e38b_147c7981","updated":"2019-10-10 12:59:29.000000000","message":"Done","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2356e3bce23149ef7ccbd6cb636492981d6fa1ee","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    sudo pip install \u0027python-dracclient\u003e\u003d3.0.0\u0027"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"To enable the ``idrac`` hardware type, add the following to your"},{"line_number":58,"context_line":"``/etc/ironic/ironic.conf``:"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":".. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_14a1d9f8","line":57,"updated":"2019-10-09 20:38:56.000000000","message":"Can you change the above line to:\nTo enable the ``idrac`` hardware type with the minimum interfaces, which are configured to use WSMAN, add the following to your","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"5249b1ae9477b6f5b6bdf1e2d7f94bf6d908da24","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    sudo pip install \u0027python-dracclient\u003e\u003d3.0.0\u0027"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"To enable the ``idrac`` hardware type, add the following to your"},{"line_number":58,"context_line":"``/etc/ironic/ironic.conf``:"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":".. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_c9e40710","line":57,"in_reply_to":"3fa7e38b_14a1d9f8","updated":"2019-10-10 12:59:29.000000000","message":"Done","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2356e3bce23149ef7ccbd6cb636492981d6fa1ee","unresolved":false,"context_lines":[{"line_number":60,"context_line":".. code-block:: ini"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    [DEFAULT]"},{"line_number":63,"context_line":"    enabled_hardware_types\u003didrac"},{"line_number":64,"context_line":"    enabled_management_interfaces\u003didrac"},{"line_number":65,"context_line":"    enabled_power_interfaces\u003didrac"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_34b5f532","line":63,"updated":"2019-10-09 20:38:56.000000000","message":"Please change the above line to:\nenabled_hardware_types\u003didrac-wsman","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"5249b1ae9477b6f5b6bdf1e2d7f94bf6d908da24","unresolved":false,"context_lines":[{"line_number":60,"context_line":".. code-block:: ini"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    [DEFAULT]"},{"line_number":63,"context_line":"    enabled_hardware_types\u003didrac"},{"line_number":64,"context_line":"    enabled_management_interfaces\u003didrac"},{"line_number":65,"context_line":"    enabled_power_interfaces\u003didrac"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_29a27baf","line":63,"in_reply_to":"3fa7e38b_34b5f532","updated":"2019-10-10 12:59:29.000000000","message":"Done","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2356e3bce23149ef7ccbd6cb636492981d6fa1ee","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    [DEFAULT]"},{"line_number":63,"context_line":"    enabled_hardware_types\u003didrac"},{"line_number":64,"context_line":"    enabled_management_interfaces\u003didrac"},{"line_number":65,"context_line":"    enabled_power_interfaces\u003didrac"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"To enable all optional features (inspection, RAID and vendor passthru), use"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_54b2f14a","line":64,"updated":"2019-10-09 20:38:56.000000000","message":"Please change the above line to:\nenabled_management_interfaces\u003didrac-wsman","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"5249b1ae9477b6f5b6bdf1e2d7f94bf6d908da24","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    [DEFAULT]"},{"line_number":63,"context_line":"    enabled_hardware_types\u003didrac"},{"line_number":64,"context_line":"    enabled_management_interfaces\u003didrac"},{"line_number":65,"context_line":"    enabled_power_interfaces\u003didrac"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"To enable all optional features (inspection, RAID and vendor passthru), use"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_89c36f57","line":64,"in_reply_to":"3fa7e38b_54b2f14a","updated":"2019-10-10 12:59:29.000000000","message":"Done","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2356e3bce23149ef7ccbd6cb636492981d6fa1ee","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    [DEFAULT]"},{"line_number":63,"context_line":"    enabled_hardware_types\u003didrac"},{"line_number":64,"context_line":"    enabled_management_interfaces\u003didrac"},{"line_number":65,"context_line":"    enabled_power_interfaces\u003didrac"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"To enable all optional features (inspection, RAID and vendor passthru), use"},{"line_number":68,"context_line":"the following configuration:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_b47a4574","line":65,"updated":"2019-10-09 20:38:56.000000000","message":"Please change the above line to:\nenabled_power_interfaces\u003didrac-wsman","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"5249b1ae9477b6f5b6bdf1e2d7f94bf6d908da24","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    [DEFAULT]"},{"line_number":63,"context_line":"    enabled_hardware_types\u003didrac"},{"line_number":64,"context_line":"    enabled_management_interfaces\u003didrac"},{"line_number":65,"context_line":"    enabled_power_interfaces\u003didrac"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"To enable all optional features (inspection, RAID and vendor passthru), use"},{"line_number":68,"context_line":"the following configuration:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_69c6336b","line":65,"in_reply_to":"3fa7e38b_b47a4574","updated":"2019-10-10 12:59:29.000000000","message":"Done","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2356e3bce23149ef7ccbd6cb636492981d6fa1ee","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    enabled_management_interfaces\u003didrac"},{"line_number":65,"context_line":"    enabled_power_interfaces\u003didrac"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"To enable all optional features (inspection, RAID and vendor passthru), use"},{"line_number":68,"context_line":"the following configuration:"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":".. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_d4f4a1f3","line":67,"updated":"2019-10-09 20:38:56.000000000","message":"Can you change the above line to:\nTo enable all optional features (inspection, RAID and vendor passthru) using Redfish where it is supported and WSMAN where not, use","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"5249b1ae9477b6f5b6bdf1e2d7f94bf6d908da24","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    enabled_management_interfaces\u003didrac"},{"line_number":65,"context_line":"    enabled_power_interfaces\u003didrac"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"To enable all optional features (inspection, RAID and vendor passthru), use"},{"line_number":68,"context_line":"the following configuration:"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":".. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_49957732","line":67,"in_reply_to":"3fa7e38b_d4f4a1f3","updated":"2019-10-10 12:59:29.000000000","message":"Done","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2356e3bce23149ef7ccbd6cb636492981d6fa1ee","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    [DEFAULT]"},{"line_number":73,"context_line":"    enabled_hardware_types\u003didrac"},{"line_number":74,"context_line":"    enabled_inspect_interfaces\u003didrac"},{"line_number":75,"context_line":"    enabled_management_interfaces\u003didrac"},{"line_number":76,"context_line":"    enabled_power_interfaces\u003didrac"},{"line_number":77,"context_line":"    enabled_raid_interfaces\u003didrac"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_54e0b126","line":74,"updated":"2019-10-09 20:38:56.000000000","message":"Please change the above to:\nenabled_inspect_interfaces\u003didrac-redfish","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"5249b1ae9477b6f5b6bdf1e2d7f94bf6d908da24","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    [DEFAULT]"},{"line_number":73,"context_line":"    enabled_hardware_types\u003didrac"},{"line_number":74,"context_line":"    enabled_inspect_interfaces\u003didrac"},{"line_number":75,"context_line":"    enabled_management_interfaces\u003didrac"},{"line_number":76,"context_line":"    enabled_power_interfaces\u003didrac"},{"line_number":77,"context_line":"    enabled_raid_interfaces\u003didrac"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_29903b43","line":74,"in_reply_to":"3fa7e38b_54e0b126","updated":"2019-10-10 12:59:29.000000000","message":"Done","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2356e3bce23149ef7ccbd6cb636492981d6fa1ee","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    [DEFAULT]"},{"line_number":73,"context_line":"    enabled_hardware_types\u003didrac"},{"line_number":74,"context_line":"    enabled_inspect_interfaces\u003didrac"},{"line_number":75,"context_line":"    enabled_management_interfaces\u003didrac"},{"line_number":76,"context_line":"    enabled_power_interfaces\u003didrac"},{"line_number":77,"context_line":"    enabled_raid_interfaces\u003didrac"},{"line_number":78,"context_line":"    enabled_vendor_interfaces\u003didrac"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_d4cd81b7","line":75,"updated":"2019-10-09 20:38:56.000000000","message":"Please change the above to:\nenabled_management_interfaces\u003didrac-redfish","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"5249b1ae9477b6f5b6bdf1e2d7f94bf6d908da24","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    [DEFAULT]"},{"line_number":73,"context_line":"    enabled_hardware_types\u003didrac"},{"line_number":74,"context_line":"    enabled_inspect_interfaces\u003didrac"},{"line_number":75,"context_line":"    enabled_management_interfaces\u003didrac"},{"line_number":76,"context_line":"    enabled_power_interfaces\u003didrac"},{"line_number":77,"context_line":"    enabled_raid_interfaces\u003didrac"},{"line_number":78,"context_line":"    enabled_vendor_interfaces\u003didrac"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_e9954333","line":75,"in_reply_to":"3fa7e38b_d4cd81b7","updated":"2019-10-10 12:59:29.000000000","message":"Done","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2356e3bce23149ef7ccbd6cb636492981d6fa1ee","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    enabled_hardware_types\u003didrac"},{"line_number":74,"context_line":"    enabled_inspect_interfaces\u003didrac"},{"line_number":75,"context_line":"    enabled_management_interfaces\u003didrac"},{"line_number":76,"context_line":"    enabled_power_interfaces\u003didrac"},{"line_number":77,"context_line":"    enabled_raid_interfaces\u003didrac"},{"line_number":78,"context_line":"    enabled_vendor_interfaces\u003didrac"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_94c38989","line":76,"updated":"2019-10-09 20:38:56.000000000","message":"Please change the above to:\nenabled_power_interfaces\u003didrac-redfish","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"5249b1ae9477b6f5b6bdf1e2d7f94bf6d908da24","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    enabled_hardware_types\u003didrac"},{"line_number":74,"context_line":"    enabled_inspect_interfaces\u003didrac"},{"line_number":75,"context_line":"    enabled_management_interfaces\u003didrac"},{"line_number":76,"context_line":"    enabled_power_interfaces\u003didrac"},{"line_number":77,"context_line":"    enabled_raid_interfaces\u003didrac"},{"line_number":78,"context_line":"    enabled_vendor_interfaces\u003didrac"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_69a9537a","line":76,"in_reply_to":"3fa7e38b_94c38989","updated":"2019-10-10 12:59:29.000000000","message":"Done","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2356e3bce23149ef7ccbd6cb636492981d6fa1ee","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    enabled_inspect_interfaces\u003didrac"},{"line_number":75,"context_line":"    enabled_management_interfaces\u003didrac"},{"line_number":76,"context_line":"    enabled_power_interfaces\u003didrac"},{"line_number":77,"context_line":"    enabled_raid_interfaces\u003didrac"},{"line_number":78,"context_line":"    enabled_vendor_interfaces\u003didrac"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_5153e339","line":77,"updated":"2019-10-09 20:38:56.000000000","message":"The above line should be:\nenabled_raid_interfaces\u003didrac-wsman","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"5249b1ae9477b6f5b6bdf1e2d7f94bf6d908da24","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    enabled_inspect_interfaces\u003didrac"},{"line_number":75,"context_line":"    enabled_management_interfaces\u003didrac"},{"line_number":76,"context_line":"    enabled_power_interfaces\u003didrac"},{"line_number":77,"context_line":"    enabled_raid_interfaces\u003didrac"},{"line_number":78,"context_line":"    enabled_vendor_interfaces\u003didrac"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_89a60fab","line":77,"in_reply_to":"3fa7e38b_5153e339","updated":"2019-10-10 12:59:29.000000000","message":"Done","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2356e3bce23149ef7ccbd6cb636492981d6fa1ee","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    enabled_management_interfaces\u003didrac"},{"line_number":76,"context_line":"    enabled_power_interfaces\u003didrac"},{"line_number":77,"context_line":"    enabled_raid_interfaces\u003didrac"},{"line_number":78,"context_line":"    enabled_vendor_interfaces\u003didrac"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Enrolling"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_915ddb48","line":78,"updated":"2019-10-09 20:38:56.000000000","message":"The above line should be:\nenabled_vendor_interfaces\u003didrac-wsman","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"5249b1ae9477b6f5b6bdf1e2d7f94bf6d908da24","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    enabled_management_interfaces\u003didrac"},{"line_number":76,"context_line":"    enabled_power_interfaces\u003didrac"},{"line_number":77,"context_line":"    enabled_raid_interfaces\u003didrac"},{"line_number":78,"context_line":"    enabled_vendor_interfaces\u003didrac"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Enrolling"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_29b91bcb","line":78,"in_reply_to":"3fa7e38b_915ddb48","updated":"2019-10-10 12:59:29.000000000","message":"Done","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2356e3bce23149ef7ccbd6cb636492981d6fa1ee","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    enabled_raid_interfaces\u003didrac"},{"line_number":78,"context_line":"    enabled_vendor_interfaces\u003didrac"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Enrolling"},{"line_number":82,"context_line":"---------"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_94ce2958","line":80,"updated":"2019-10-09 20:38:56.000000000","message":"Need to add the following section here:\nProtocol Specific Authentication Parameters\n-------------------------------------------\nThe WSMAN and Redfish protocols require different parameters to be set on the node in Ironic to be able to communicate with the bare metal node.\nThe WSMAN protocol requires the following parameters:\n* ``drac_username``: The WSMAN user name to use when communicating with the iDRAC. Usually ``root``.\n* ``drac_password``: The password for the WSMAN user to use when communicating with the iDRAC.\n* ``drac_address``: The IP address of the iDRAC.\nThe Redfish protocol requires the following parameters:\n* ``redfish_username``: The Redfish user name to use when communicating with the iDRAC. Usually ``root``.\n* ``redfish_password``: The password for the Redfish user to use when communicating with the iDRAC.\n* ``redfish_address``: The URL to the Redfish service running on the iDRAC in the form: \"https://\u003cIP\u003e\".\n* ``redfish_system_id``: The Redfish ID of the server to be managed. This should always be: ``/redfish/v1/Systems/System.Embedded.1``.\n\nIf using only interfaces configured to use WSMAN (``idrac-wsman``), then only the WSMAN parameters must be supplied.  If using only interfaces configured to use Redfish (``idrac-redfish``) the only the Redfish parameters must be supplied.  If using a mix of interfaces where some use WSMAN and some use Redfish, both the WSMAN and Redfish parameters must be supplied.","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"5249b1ae9477b6f5b6bdf1e2d7f94bf6d908da24","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    enabled_raid_interfaces\u003didrac"},{"line_number":78,"context_line":"    enabled_vendor_interfaces\u003didrac"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Enrolling"},{"line_number":82,"context_line":"---------"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_292cbb00","line":80,"in_reply_to":"3fa7e38b_94ce2958","updated":"2019-10-10 12:59:29.000000000","message":"Done","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2356e3bce23149ef7ccbd6cb636492981d6fa1ee","unresolved":false,"context_lines":[{"line_number":82,"context_line":"---------"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"The following command will enroll a bare metal node with the ``idrac``"},{"line_number":85,"context_line":"hardware type:"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":".. code-block:: bash"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_141a39cb","line":85,"updated":"2019-10-09 20:38:56.000000000","message":"Can you change the above line to:\nhardware type assuming a mix of Redfish and WSMAN interfaces are used.","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"5249b1ae9477b6f5b6bdf1e2d7f94bf6d908da24","unresolved":false,"context_lines":[{"line_number":82,"context_line":"---------"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"The following command will enroll a bare metal node with the ``idrac``"},{"line_number":85,"context_line":"hardware type:"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":".. code-block:: bash"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_29159b9c","line":85,"in_reply_to":"3fa7e38b_141a39cb","updated":"2019-10-10 12:59:29.000000000","message":"Done","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2356e3bce23149ef7ccbd6cb636492981d6fa1ee","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    openstack baremetal node create --driver idrac \\"},{"line_number":90,"context_line":"        --driver-info drac_address\u003dhttp://drac.host \\"},{"line_number":91,"context_line":"        --driver-info drac_username\u003duser \\"},{"line_number":92,"context_line":"        --driver-info drac_password\u003dpa$$w0rd"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Inspect Interface"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_147f99e0","line":92,"updated":"2019-10-09 20:38:56.000000000","message":"Can you add the following to the above?\n--driver-info redfish_username\u003duser \\\n--driver-info redfish_password\u003dpa$$w0rd \\\n--driver-info redfish_address\u003dhttps://drac.host \\\n--driver-info redfish_system_id\u003d/redfish/v1/Systems/System.Embedded.1","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"5249b1ae9477b6f5b6bdf1e2d7f94bf6d908da24","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    openstack baremetal node create --driver idrac \\"},{"line_number":90,"context_line":"        --driver-info drac_address\u003dhttp://drac.host \\"},{"line_number":91,"context_line":"        --driver-info drac_username\u003duser \\"},{"line_number":92,"context_line":"        --driver-info drac_password\u003dpa$$w0rd"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Inspect Interface"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_69739317","line":92,"in_reply_to":"3fa7e38b_147f99e0","updated":"2019-10-10 12:59:29.000000000","message":"Done","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2356e3bce23149ef7ccbd6cb636492981d6fa1ee","unresolved":false,"context_lines":[{"line_number":98,"context_line":"The Dell iDRAC out-of-band inspection process catalogs all the same"},{"line_number":99,"context_line":"attributes of the server as the IPMI driver.  Unlike IPMI, it does this"},{"line_number":100,"context_line":"without requiring the system to be rebooted, or even in a power on"},{"line_number":101,"context_line":"state.  Inspection is performed using the Dell WSMAN API directly without"},{"line_number":102,"context_line":"affecting the operation of the system being inspected."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"The inspection discovers the following properties:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_14cd5930","line":101,"updated":"2019-10-09 20:38:56.000000000","message":"Can you change the above:\n... using the WSMAN or Redfish APIs directly ...","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"5249b1ae9477b6f5b6bdf1e2d7f94bf6d908da24","unresolved":false,"context_lines":[{"line_number":98,"context_line":"The Dell iDRAC out-of-band inspection process catalogs all the same"},{"line_number":99,"context_line":"attributes of the server as the IPMI driver.  Unlike IPMI, it does this"},{"line_number":100,"context_line":"without requiring the system to be rebooted, or even in a power on"},{"line_number":101,"context_line":"state.  Inspection is performed using the Dell WSMAN API directly without"},{"line_number":102,"context_line":"affecting the operation of the system being inspected."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"The inspection discovers the following properties:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_095e9f75","line":101,"in_reply_to":"3fa7e38b_14cd5930","updated":"2019-10-10 12:59:29.000000000","message":"Done","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2356e3bce23149ef7ccbd6cb636492981d6fa1ee","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Extra capabilities:"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"* ``boot_mode``: UEFI or BIOS boot mode. Default is the BIOS boot mode."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"It also creates baremetal ports for each NIC port detected in the system"},{"line_number":116,"context_line":"and sets ``pxe-enabled`` to ``True`` on every baremetal port where PXE"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_f4319d0c","line":113,"updated":"2019-10-09 20:38:56.000000000","message":"I think we should remove \"Default is the BIOS boot mode.\" since there really is no default.  We\u0027re just discovering what the server is configured for.","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"5249b1ae9477b6f5b6bdf1e2d7f94bf6d908da24","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Extra capabilities:"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"* ``boot_mode``: UEFI or BIOS boot mode. Default is the BIOS boot mode."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"It also creates baremetal ports for each NIC port detected in the system"},{"line_number":116,"context_line":"and sets ``pxe-enabled`` to ``True`` on every baremetal port where PXE"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_a9566b5b","line":113,"in_reply_to":"3fa7e38b_f4319d0c","updated":"2019-10-10 12:59:29.000000000","message":"Done.","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2356e3bce23149ef7ccbd6cb636492981d6fa1ee","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"* ``boot_mode``: UEFI or BIOS boot mode. Default is the BIOS boot mode."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"It also creates baremetal ports for each NIC port detected in the system"},{"line_number":116,"context_line":"and sets ``pxe-enabled`` to ``True`` on every baremetal port where PXE"},{"line_number":117,"context_line":"booting is enabled. ``pxe-enabled`` is set appropriately on the baremetal"},{"line_number":118,"context_line":"ports regardless of the boot mode of the system."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_34041518","line":115,"updated":"2019-10-09 20:38:56.000000000","message":"So, both WSMAN and Redfish inspection create the ports, so let\u0027s end the above line with a period \".\"","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"5249b1ae9477b6f5b6bdf1e2d7f94bf6d908da24","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"* ``boot_mode``: UEFI or BIOS boot mode. Default is the BIOS boot mode."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"It also creates baremetal ports for each NIC port detected in the system"},{"line_number":116,"context_line":"and sets ``pxe-enabled`` to ``True`` on every baremetal port where PXE"},{"line_number":117,"context_line":"booting is enabled. ``pxe-enabled`` is set appropriately on the baremetal"},{"line_number":118,"context_line":"ports regardless of the boot mode of the system."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_49cd772f","line":115,"in_reply_to":"3fa7e38b_34041518","updated":"2019-10-10 12:59:29.000000000","message":"Done","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0c3058766e25df3c06d5c22e532c66289e2bd0b7","unresolved":false,"context_lines":[{"line_number":113,"context_line":"* ``boot_mode``: UEFI or BIOS boot mode. Default is the BIOS boot mode."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"It also creates baremetal ports for each NIC port detected in the system"},{"line_number":116,"context_line":"and sets ``pxe-enabled`` to ``True`` on every baremetal port where PXE"},{"line_number":117,"context_line":"booting is enabled. ``pxe-enabled`` is set appropriately on the baremetal"},{"line_number":118,"context_line":"ports regardless of the boot mode of the system."},{"line_number":119,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_78acd034","line":116,"updated":"2019-10-09 09:07:57.000000000","message":"The field is called ``pxe_enabled`` (with underscore)","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"5249b1ae9477b6f5b6bdf1e2d7f94bf6d908da24","unresolved":false,"context_lines":[{"line_number":113,"context_line":"* ``boot_mode``: UEFI or BIOS boot mode. Default is the BIOS boot mode."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"It also creates baremetal ports for each NIC port detected in the system"},{"line_number":116,"context_line":"and sets ``pxe-enabled`` to ``True`` on every baremetal port where PXE"},{"line_number":117,"context_line":"booting is enabled. ``pxe-enabled`` is set appropriately on the baremetal"},{"line_number":118,"context_line":"ports regardless of the boot mode of the system."},{"line_number":119,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_a9dbcbea","line":116,"in_reply_to":"3fa7e38b_78acd034","updated":"2019-10-10 12:59:29.000000000","message":"Done","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2356e3bce23149ef7ccbd6cb636492981d6fa1ee","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"It also creates baremetal ports for each NIC port detected in the system"},{"line_number":116,"context_line":"and sets ``pxe-enabled`` to ``True`` on every baremetal port where PXE"},{"line_number":117,"context_line":"booting is enabled. ``pxe-enabled`` is set appropriately on the baremetal"},{"line_number":118,"context_line":"ports regardless of the boot mode of the system."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Examples"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_8faff6e1","line":117,"updated":"2019-10-09 20:38:56.000000000","message":"Only the WSMAN version of OOB introspection sets pxe_enabled on the ports.  The Redfish version does not currently.  Let\u0027s change lines 116-118 to:\nThe ``idrac-wsman`` inspect interface discovers which NIC ports are configured to PXE boot and sets ``pxe_enabled`` to True on these ports.  The ``idrac-redfish`` inspect interface does not curently set ``pxe_enabled`` on the ports.  The user should ensure that pxe_enabled is set correctly on the ports following inspection.","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"5249b1ae9477b6f5b6bdf1e2d7f94bf6d908da24","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"It also creates baremetal ports for each NIC port detected in the system"},{"line_number":116,"context_line":"and sets ``pxe-enabled`` to ``True`` on every baremetal port where PXE"},{"line_number":117,"context_line":"booting is enabled. ``pxe-enabled`` is set appropriately on the baremetal"},{"line_number":118,"context_line":"ports regardless of the boot mode of the system."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Examples"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_89f7ef59","line":117,"in_reply_to":"3fa7e38b_8faff6e1","updated":"2019-10-10 12:59:29.000000000","message":"Done","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0c3058766e25df3c06d5c22e532c66289e2bd0b7","unresolved":false,"context_lines":[{"line_number":115,"context_line":"It also creates baremetal ports for each NIC port detected in the system"},{"line_number":116,"context_line":"and sets ``pxe-enabled`` to ``True`` on every baremetal port where PXE"},{"line_number":117,"context_line":"booting is enabled. ``pxe-enabled`` is set appropriately on the baremetal"},{"line_number":118,"context_line":"ports regardless of the boot mode of the system."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Examples"},{"line_number":121,"context_line":"--------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_18ab5c1d","line":118,"updated":"2019-10-09 09:07:57.000000000","message":"nit: is it a usefull note? I don\u0027t quite see how boot mode is related to PXE enabled/disabled. If you think it\u0027s of value, let\u0027s convert it to a .. note:: and add more details?","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"5249b1ae9477b6f5b6bdf1e2d7f94bf6d908da24","unresolved":false,"context_lines":[{"line_number":115,"context_line":"It also creates baremetal ports for each NIC port detected in the system"},{"line_number":116,"context_line":"and sets ``pxe-enabled`` to ``True`` on every baremetal port where PXE"},{"line_number":117,"context_line":"booting is enabled. ``pxe-enabled`` is set appropriately on the baremetal"},{"line_number":118,"context_line":"ports regardless of the boot mode of the system."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Examples"},{"line_number":121,"context_line":"--------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_a9898bca","line":118,"in_reply_to":"3fa7e38b_18ab5c1d","updated":"2019-10-10 12:59:29.000000000","message":"Done","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2356e3bce23149ef7ccbd6cb636492981d6fa1ee","unresolved":false,"context_lines":[{"line_number":115,"context_line":"It also creates baremetal ports for each NIC port detected in the system"},{"line_number":116,"context_line":"and sets ``pxe-enabled`` to ``True`` on every baremetal port where PXE"},{"line_number":117,"context_line":"booting is enabled. ``pxe-enabled`` is set appropriately on the baremetal"},{"line_number":118,"context_line":"ports regardless of the boot mode of the system."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Examples"},{"line_number":121,"context_line":"--------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_548c31d6","line":118,"in_reply_to":"3fa7e38b_18ab5c1d","updated":"2019-10-09 20:38:56.000000000","message":"On Dell servers, the hardware configuration for enabling PXE booting on selected ports is different depending on if the server is configured for UEFI or Legacy boot mode.  That said, we probably don\u0027t need to go to that level of detail here.  Let\u0027s remove:\n``pxe-enabled`` is set appropriately on the baremetal\nports regardless of the boot mode of the system.","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"5249b1ae9477b6f5b6bdf1e2d7f94bf6d908da24","unresolved":false,"context_lines":[{"line_number":115,"context_line":"It also creates baremetal ports for each NIC port detected in the system"},{"line_number":116,"context_line":"and sets ``pxe-enabled`` to ``True`` on every baremetal port where PXE"},{"line_number":117,"context_line":"booting is enabled. ``pxe-enabled`` is set appropriately on the baremetal"},{"line_number":118,"context_line":"ports regardless of the boot mode of the system."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Examples"},{"line_number":121,"context_line":"--------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_09a1bf46","line":118,"in_reply_to":"3fa7e38b_548c31d6","updated":"2019-10-10 12:59:29.000000000","message":"Done","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0c3058766e25df3c06d5c22e532c66289e2bd0b7","unresolved":false,"context_lines":[{"line_number":120,"context_line":"Examples"},{"line_number":121,"context_line":"--------"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Listing the details of the PXE enabled baremetal ports:"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":".. code-block:: console"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_38a65855","line":123,"updated":"2019-10-09 09:07:57.000000000","message":"I think this is too generic to be useful. It will be too out of context for people who don\u0027t know about ports and too obvious for those who do. Let\u0027s remove this example.","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"5249b1ae9477b6f5b6bdf1e2d7f94bf6d908da24","unresolved":false,"context_lines":[{"line_number":120,"context_line":"Examples"},{"line_number":121,"context_line":"--------"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Listing the details of the PXE enabled baremetal ports:"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":".. code-block:: console"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_c98647ba","line":123,"in_reply_to":"3fa7e38b_2f8a8269","updated":"2019-10-10 12:59:29.000000000","message":"Done","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"5249b1ae9477b6f5b6bdf1e2d7f94bf6d908da24","unresolved":false,"context_lines":[{"line_number":120,"context_line":"Examples"},{"line_number":121,"context_line":"--------"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Listing the details of the PXE enabled baremetal ports:"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":".. code-block:: console"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_698f13cd","line":123,"in_reply_to":"3fa7e38b_38a65855","updated":"2019-10-10 12:59:29.000000000","message":"Done","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2356e3bce23149ef7ccbd6cb636492981d6fa1ee","unresolved":false,"context_lines":[{"line_number":120,"context_line":"Examples"},{"line_number":121,"context_line":"--------"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Listing the details of the PXE enabled baremetal ports:"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":".. code-block:: console"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_2f8a8269","line":123,"in_reply_to":"3fa7e38b_38a65855","updated":"2019-10-09 20:38:56.000000000","message":"I agree, let\u0027s remove this.","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0c3058766e25df3c06d5c22e532c66289e2bd0b7","unresolved":false,"context_lines":[{"line_number":154,"context_line":"Mandatory properties"},{"line_number":155,"context_line":"--------------------"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"* ``size_gb``: Size in GiB (Integer) for the logical disk. Use \u0027MAX\u0027 as size_gb"},{"line_number":158,"context_line":"  if this logical disk is supposed to use the rest of the space available."},{"line_number":159,"context_line":"* ``raid_level``: RAID level for the logical disk. Valid values are"},{"line_number":160,"context_line":"  \u00270\u0027, \u00271\u0027, \u00275\u0027, \u00276\u0027, \u00271+0\u0027, \u00275+0\u0027 and \u00276+0\u0027."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_d862a416","line":157,"updated":"2019-10-09 09:07:57.000000000","message":"nit: ``MAX`` (to highlight that it\u0027s a literal string)","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"5249b1ae9477b6f5b6bdf1e2d7f94bf6d908da24","unresolved":false,"context_lines":[{"line_number":154,"context_line":"Mandatory properties"},{"line_number":155,"context_line":"--------------------"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"* ``size_gb``: Size in GiB (Integer) for the logical disk. Use \u0027MAX\u0027 as size_gb"},{"line_number":158,"context_line":"  if this logical disk is supposed to use the rest of the space available."},{"line_number":159,"context_line":"* ``raid_level``: RAID level for the logical disk. Valid values are"},{"line_number":160,"context_line":"  \u00270\u0027, \u00271\u0027, \u00275\u0027, \u00276\u0027, \u00271+0\u0027, \u00275+0\u0027 and \u00276+0\u0027."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_09ba1f6d","line":157,"in_reply_to":"3fa7e38b_d862a416","updated":"2019-10-10 12:59:29.000000000","message":"Done","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0c3058766e25df3c06d5c22e532c66289e2bd0b7","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":".. NOTE::"},{"line_number":163,"context_line":"  \u0027JBOD\u0027 and \u00272\u0027 are not supported, and will fail with reason: Cannot"},{"line_number":164,"context_line":"  calculate spans for RAID level."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Optional properties"},{"line_number":167,"context_line":"-------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_f865201e","line":164,"updated":"2019-10-09 09:07:57.000000000","message":"nit: highlight the error message with some syntax, e.g. `Cannot ...`.","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"5249b1ae9477b6f5b6bdf1e2d7f94bf6d908da24","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":".. NOTE::"},{"line_number":163,"context_line":"  \u0027JBOD\u0027 and \u00272\u0027 are not supported, and will fail with reason: Cannot"},{"line_number":164,"context_line":"  calculate spans for RAID level."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Optional properties"},{"line_number":167,"context_line":"-------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_89a5af49","line":164,"in_reply_to":"3fa7e38b_f865201e","updated":"2019-10-10 12:59:29.000000000","message":"Done","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0c3058766e25df3c06d5c22e532c66289e2bd0b7","unresolved":false,"context_lines":[{"line_number":194,"context_line":"* ``physical_disks``: Optional. The names of the physical disks to use."},{"line_number":195,"context_line":""},{"line_number":196,"context_line":".. NOTE::"},{"line_number":197,"context_line":"  \u0027physical_disks\u0027 is a mandatory parameter if the property \u0027size_gb\u0027 is set to \u0027MAX\u0027."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"Examples"},{"line_number":200,"context_line":"--------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_986c2c09","line":197,"updated":"2019-10-09 09:07:57.000000000","message":"nit: ``physical_disks``, ``size_gb``, ``MAX``","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"5249b1ae9477b6f5b6bdf1e2d7f94bf6d908da24","unresolved":false,"context_lines":[{"line_number":194,"context_line":"* ``physical_disks``: Optional. The names of the physical disks to use."},{"line_number":195,"context_line":""},{"line_number":196,"context_line":".. NOTE::"},{"line_number":197,"context_line":"  \u0027physical_disks\u0027 is a mandatory parameter if the property \u0027size_gb\u0027 is set to \u0027MAX\u0027."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"Examples"},{"line_number":200,"context_line":"--------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_e969c3f7","line":197,"in_reply_to":"3fa7e38b_986c2c09","updated":"2019-10-10 12:59:29.000000000","message":"Done","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0c3058766e25df3c06d5c22e532c66289e2bd0b7","unresolved":false,"context_lines":[{"line_number":283,"context_line":"abandon_bios_config   DELETE         Abandon a BIOS configuration job"},{"line_number":284,"context_line":"commit_bios_config    POST           Commit a BIOS configuration job"},{"line_number":285,"context_line":"                                     submitted through set_bios_config."},{"line_number":286,"context_line":"                                     Required argument: \u0027reboot\u0027 -"},{"line_number":287,"context_line":"                                     indicates whether a reboot job"},{"line_number":288,"context_line":"                                     should be automatically created"},{"line_number":289,"context_line":"                                     with the config job. Returns a"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_b86fa8fa","line":286,"updated":"2019-10-09 09:07:57.000000000","message":"Let\u0027s format arguments with a proper list (same below)","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"5249b1ae9477b6f5b6bdf1e2d7f94bf6d908da24","unresolved":false,"context_lines":[{"line_number":283,"context_line":"abandon_bios_config   DELETE         Abandon a BIOS configuration job"},{"line_number":284,"context_line":"commit_bios_config    POST           Commit a BIOS configuration job"},{"line_number":285,"context_line":"                                     submitted through set_bios_config."},{"line_number":286,"context_line":"                                     Required argument: \u0027reboot\u0027 -"},{"line_number":287,"context_line":"                                     indicates whether a reboot job"},{"line_number":288,"context_line":"                                     should be automatically created"},{"line_number":289,"context_line":"                                     with the config job. Returns a"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_6056402d","line":286,"in_reply_to":"3fa7e38b_b86fa8fa","updated":"2019-10-10 12:59:29.000000000","message":"The arguments are illustrated in their respective formats later where these \u0027Methods\u0027 are separately explained.\nStill if you are of the view to make changes here as well, then please comment and I will make the required changes.","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0c3058766e25df3c06d5c22e532c66289e2bd0b7","unresolved":false,"context_lines":[{"line_number":497,"context_line":"the Ironic power state poll interval to 70 seconds. See"},{"line_number":498,"context_line":"``[conductor]sync_power_state_interval`` in ``/etc/ironic/ironic.conf``."},{"line_number":499,"context_line":""},{"line_number":500,"context_line":".. _Ironic_RAID: https://docs.openstack.org/ironic/latest/admin/raid.html"},{"line_number":501,"context_line":".. _iDRAC: https://www.dell.com/idracmanuals"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_5876b4da","line":500,"updated":"2019-10-09 09:07:57.000000000","message":"not needed, please use inter-doc links (:doc:`...` and :ref:`...`)","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"5249b1ae9477b6f5b6bdf1e2d7f94bf6d908da24","unresolved":false,"context_lines":[{"line_number":497,"context_line":"the Ironic power state poll interval to 70 seconds. See"},{"line_number":498,"context_line":"``[conductor]sync_power_state_interval`` in ``/etc/ironic/ironic.conf``."},{"line_number":499,"context_line":""},{"line_number":500,"context_line":".. _Ironic_RAID: https://docs.openstack.org/ironic/latest/admin/raid.html"},{"line_number":501,"context_line":".. _iDRAC: https://www.dell.com/idracmanuals"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_ecb23106","line":500,"in_reply_to":"3fa7e38b_5876b4da","updated":"2019-10-10 12:59:29.000000000","message":"I replaced this links :doc: and :ref: but found that these links are used for cross-reference within the same documents or different documents. Since here external web link is to be embeddeded in the document, it is done in this given way only.\nI referred this link for my understanding - https://sublime-and-sphinx-guide.readthedocs.io/en/latest/references.html","commit_id":"d39919e56974d7512efac64715ffe9a4730ba40c"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3647d002f3dcb63b770f4e66eef13b7319ca21fa","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Overview"},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":"The integrated Dell Remote Access Controller (iDRAC_) is the both an"},{"line_number":8,"context_line":"out-of-band management platform and an in-band management platform on"},{"line_number":9,"context_line":"Dell servers, and is supported directly by the ``idrac`` hardware type."},{"line_number":10,"context_line":"This driver uses the Dell Web Services for Management (WSMAN) APIs and"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_09da0277","line":7,"updated":"2019-10-11 15:44:13.000000000","message":"please leave one blank line here","commit_id":"5b973f6841c0a387860fdabec51103d2f417cf6a"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3647d002f3dcb63b770f4e66eef13b7319ca21fa","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Overview"},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":"The integrated Dell Remote Access Controller (iDRAC_) is the both an"},{"line_number":8,"context_line":"out-of-band management platform and an in-band management platform on"},{"line_number":9,"context_line":"Dell servers, and is supported directly by the ``idrac`` hardware type."},{"line_number":10,"context_line":"This driver uses the Dell Web Services for Management (WSMAN) APIs and"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_e9944646","line":7,"range":{"start_line":7,"start_character":57,"end_line":7,"end_character":60},"updated":"2019-10-11 15:44:13.000000000","message":"remove \u0027the\u0027","commit_id":"5b973f6841c0a387860fdabec51103d2f417cf6a"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"e6d1e00355d71f0ea721ddb77eb4fd4309348c13","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Overview"},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":"The integrated Dell Remote Access Controller (iDRAC_) is the both an"},{"line_number":8,"context_line":"out-of-band management platform and an in-band management platform on"},{"line_number":9,"context_line":"Dell servers, and is supported directly by the ``idrac`` hardware type."},{"line_number":10,"context_line":"This driver uses the Dell Web Services for Management (WSMAN) APIs and"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_c20fbcdd","line":7,"in_reply_to":"3fa7e38b_09da0277","updated":"2019-10-15 06:36:54.000000000","message":"Done","commit_id":"5b973f6841c0a387860fdabec51103d2f417cf6a"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"f328c4fe8005f1465dca7580f91fbf28619cfafd","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Overview"},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":"The integrated Dell Remote Access Controller (iDRAC_) is the both an"},{"line_number":8,"context_line":"out-of-band management platform and an in-band management platform on"},{"line_number":9,"context_line":"Dell servers, and is supported directly by the ``idrac`` hardware type."},{"line_number":10,"context_line":"This driver uses the Dell Web Services for Management (WSMAN) APIs and"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_2d6ecaff","line":7,"in_reply_to":"3fa7e38b_09da0277","updated":"2019-10-14 21:28:50.000000000","message":"I believe the blank line should be between lines 6 \u0026 7","commit_id":"5b973f6841c0a387860fdabec51103d2f417cf6a"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"e6d1e00355d71f0ea721ddb77eb4fd4309348c13","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Overview"},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":"The integrated Dell Remote Access Controller (iDRAC_) is the both an"},{"line_number":8,"context_line":"out-of-band management platform and an in-band management platform on"},{"line_number":9,"context_line":"Dell servers, and is supported directly by the ``idrac`` hardware type."},{"line_number":10,"context_line":"This driver uses the Dell Web Services for Management (WSMAN) APIs and"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_62e848e1","line":7,"in_reply_to":"3fa7e38b_2d6ecaff","updated":"2019-10-15 06:36:54.000000000","message":"Done","commit_id":"5b973f6841c0a387860fdabec51103d2f417cf6a"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"e6d1e00355d71f0ea721ddb77eb4fd4309348c13","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Overview"},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":"The integrated Dell Remote Access Controller (iDRAC_) is the both an"},{"line_number":8,"context_line":"out-of-band management platform and an in-band management platform on"},{"line_number":9,"context_line":"Dell servers, and is supported directly by the ``idrac`` hardware type."},{"line_number":10,"context_line":"This driver uses the Dell Web Services for Management (WSMAN) APIs and"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_220010ab","line":7,"range":{"start_line":7,"start_character":57,"end_line":7,"end_character":60},"in_reply_to":"3fa7e38b_e9944646","updated":"2019-10-15 06:36:54.000000000","message":"Done","commit_id":"5b973f6841c0a387860fdabec51103d2f417cf6a"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"e5da94718064925ad6e6cdaa251ae798f706f644","unresolved":false,"context_lines":[{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":"The integrated Dell Remote Access Controller (iDRAC_) is the both an"},{"line_number":8,"context_line":"out-of-band management platform and an in-band management platform on"},{"line_number":9,"context_line":"Dell servers, and is supported directly by the ``idrac`` hardware type."},{"line_number":10,"context_line":"This driver uses the Dell Web Services for Management (WSMAN) APIs and"},{"line_number":11,"context_line":"the standard Distributed Management Task Force (DMTF) Redfish APIs to"},{"line_number":12,"context_line":"perform all of its functions."}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_cddbacea","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":13},"updated":"2019-10-10 14:08:41.000000000","message":"Dell EMC PowerEdge servers","commit_id":"5b973f6841c0a387860fdabec51103d2f417cf6a"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"e6d1e00355d71f0ea721ddb77eb4fd4309348c13","unresolved":false,"context_lines":[{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":"The integrated Dell Remote Access Controller (iDRAC_) is the both an"},{"line_number":8,"context_line":"out-of-band management platform and an in-band management platform on"},{"line_number":9,"context_line":"Dell servers, and is supported directly by the ``idrac`` hardware type."},{"line_number":10,"context_line":"This driver uses the Dell Web Services for Management (WSMAN) APIs and"},{"line_number":11,"context_line":"the standard Distributed Management Task Force (DMTF) Redfish APIs to"},{"line_number":12,"context_line":"perform all of its functions."}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_a225e05d","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":13},"in_reply_to":"3fa7e38b_cddbacea","updated":"2019-10-15 06:36:54.000000000","message":"Done","commit_id":"5b973f6841c0a387860fdabec51103d2f417cf6a"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"e5da94718064925ad6e6cdaa251ae798f706f644","unresolved":false,"context_lines":[{"line_number":32,"context_line":"The hardware type ``idrac`` supports the following Ironic interfaces:"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* `Inspect Interface`_: Hardware Inspection"},{"line_number":35,"context_line":"* `Management Interface`: Boot device management"},{"line_number":36,"context_line":"* `Power Interface`: Power management"},{"line_number":37,"context_line":"* `RAID Interface`_: RAID controller and disk management"},{"line_number":38,"context_line":"* `Vendor Interface`_: BIOS management"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_cd772cd4","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":19},"updated":"2019-10-10 14:08:41.000000000","message":"Formating issue here. Some lines are underlined","commit_id":"5b973f6841c0a387860fdabec51103d2f417cf6a"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"e6d1e00355d71f0ea721ddb77eb4fd4309348c13","unresolved":false,"context_lines":[{"line_number":32,"context_line":"The hardware type ``idrac`` supports the following Ironic interfaces:"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* `Inspect Interface`_: Hardware Inspection"},{"line_number":35,"context_line":"* `Management Interface`: Boot device management"},{"line_number":36,"context_line":"* `Power Interface`: Power management"},{"line_number":37,"context_line":"* `RAID Interface`_: RAID controller and disk management"},{"line_number":38,"context_line":"* `Vendor Interface`_: BIOS management"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_e2bd18d8","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":19},"in_reply_to":"3fa7e38b_4d1c6677","updated":"2019-10-15 06:36:54.000000000","message":"Done","commit_id":"5b973f6841c0a387860fdabec51103d2f417cf6a"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"f328c4fe8005f1465dca7580f91fbf28619cfafd","unresolved":false,"context_lines":[{"line_number":32,"context_line":"The hardware type ``idrac`` supports the following Ironic interfaces:"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* `Inspect Interface`_: Hardware Inspection"},{"line_number":35,"context_line":"* `Management Interface`: Boot device management"},{"line_number":36,"context_line":"* `Power Interface`: Power management"},{"line_number":37,"context_line":"* `RAID Interface`_: RAID controller and disk management"},{"line_number":38,"context_line":"* `Vendor Interface`_: BIOS management"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_4d1c6677","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":19},"in_reply_to":"3fa7e38b_900b6ed3","updated":"2019-10-14 21:28:50.000000000","message":"The underlined are links that link the reader to sections below in this doc (or at least they do in my locally built version).  We don\u0027t have separate sections in this doc for the Management Interface or Power Interface though, so I believe these are showing up as broken links.\n\nLet\u0027s remove the backticks around Management Interface and Power Interface in the above 2 lines.  This will make them show up as normal text.","commit_id":"5b973f6841c0a387860fdabec51103d2f417cf6a"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"e6d1e00355d71f0ea721ddb77eb4fd4309348c13","unresolved":false,"context_lines":[{"line_number":32,"context_line":"The hardware type ``idrac`` supports the following Ironic interfaces:"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* `Inspect Interface`_: Hardware Inspection"},{"line_number":35,"context_line":"* `Management Interface`: Boot device management"},{"line_number":36,"context_line":"* `Power Interface`: Power management"},{"line_number":37,"context_line":"* `RAID Interface`_: RAID controller and disk management"},{"line_number":38,"context_line":"* `Vendor Interface`_: BIOS management"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_02d87450","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":19},"in_reply_to":"3fa7e38b_900b6ed3","updated":"2019-10-15 06:36:54.000000000","message":"Yes.","commit_id":"5b973f6841c0a387860fdabec51103d2f417cf6a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"78b120f630a7604039637c242edd6f4d90663e66","unresolved":false,"context_lines":[{"line_number":32,"context_line":"The hardware type ``idrac`` supports the following Ironic interfaces:"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* `Inspect Interface`_: Hardware Inspection"},{"line_number":35,"context_line":"* `Management Interface`: Boot device management"},{"line_number":36,"context_line":"* `Power Interface`: Power management"},{"line_number":37,"context_line":"* `RAID Interface`_: RAID controller and disk management"},{"line_number":38,"context_line":"* `Vendor Interface`_: BIOS management"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_900b6ed3","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":19},"in_reply_to":"3fa7e38b_cd772cd4","updated":"2019-10-11 18:24:37.000000000","message":"I wonder if the intent is for these to be links?","commit_id":"5b973f6841c0a387860fdabec51103d2f417cf6a"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"e6d1e00355d71f0ea721ddb77eb4fd4309348c13","unresolved":false,"context_lines":[{"line_number":32,"context_line":"The hardware type ``idrac`` supports the following Ironic interfaces:"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* `Inspect Interface`_: Hardware Inspection"},{"line_number":35,"context_line":"* `Management Interface`: Boot device management"},{"line_number":36,"context_line":"* `Power Interface`: Power management"},{"line_number":37,"context_line":"* `RAID Interface`_: RAID controller and disk management"},{"line_number":38,"context_line":"* `Vendor Interface`_: BIOS management"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_2219f020","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":19},"in_reply_to":"3fa7e38b_cd772cd4","updated":"2019-10-15 06:36:54.000000000","message":"These lines have no linking sections, hence written in such a way.","commit_id":"5b973f6841c0a387860fdabec51103d2f417cf6a"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"f328c4fe8005f1465dca7580f91fbf28619cfafd","unresolved":false,"context_lines":[{"line_number":43,"context_line":"The ``idrac`` hardware type requires the ``python-dracclient`` and"},{"line_number":44,"context_line":"``sushy`` libraries to be installed, for example::"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    sudo pip install \u0027python-dracclient\u003e\u003d3.0.0\u0027 \u0027sushy\u003e\u003d2.0.0\u0027"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"The iDRAC driver supports WSMAN for the inspect, management, power,"},{"line_number":49,"context_line":"raid, and vendor interfaces. In addition, it supports Redfish for"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_e80ae023","line":46,"updated":"2019-10-14 21:28:50.000000000","message":"Please update the python-dracclient version above to 3.1.0.","commit_id":"5b973f6841c0a387860fdabec51103d2f417cf6a"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"e6d1e00355d71f0ea721ddb77eb4fd4309348c13","unresolved":false,"context_lines":[{"line_number":43,"context_line":"The ``idrac`` hardware type requires the ``python-dracclient`` and"},{"line_number":44,"context_line":"``sushy`` libraries to be installed, for example::"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    sudo pip install \u0027python-dracclient\u003e\u003d3.0.0\u0027 \u0027sushy\u003e\u003d2.0.0\u0027"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"The iDRAC driver supports WSMAN for the inspect, management, power,"},{"line_number":49,"context_line":"raid, and vendor interfaces. In addition, it supports Redfish for"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_c2b6dcf9","line":46,"in_reply_to":"3fa7e38b_e80ae023","updated":"2019-10-15 06:36:54.000000000","message":"Done","commit_id":"5b973f6841c0a387860fdabec51103d2f417cf6a"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"f328c4fe8005f1465dca7580f91fbf28619cfafd","unresolved":false,"context_lines":[{"line_number":56,"context_line":".. NOTE::"},{"line_number":57,"context_line":"   Redfish for an interface can only be selected for the inspect,"},{"line_number":58,"context_line":"   power, and management interfaces at the present time."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"To enable the ``idrac`` hardware type with the minimum interfaces,"},{"line_number":61,"context_line":"which are configured to use WSMAN, add the following to your"},{"line_number":62,"context_line":"``/etc/ironic/ironic.conf``:"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_ce704da7","line":59,"updated":"2019-10-14 21:28:50.000000000","message":"Can you add the following NOTE here?:\nIf using WSMAN for the management interface, then WSMAN must be used for the power interace and vice versa.  It is currently not possible to use Redfish for one and WSMAN for the other.","commit_id":"5b973f6841c0a387860fdabec51103d2f417cf6a"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"e6d1e00355d71f0ea721ddb77eb4fd4309348c13","unresolved":false,"context_lines":[{"line_number":56,"context_line":".. NOTE::"},{"line_number":57,"context_line":"   Redfish for an interface can only be selected for the inspect,"},{"line_number":58,"context_line":"   power, and management interfaces at the present time."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"To enable the ``idrac`` hardware type with the minimum interfaces,"},{"line_number":61,"context_line":"which are configured to use WSMAN, add the following to your"},{"line_number":62,"context_line":"``/etc/ironic/ironic.conf``:"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_a2a8808b","line":59,"in_reply_to":"3fa7e38b_ce704da7","updated":"2019-10-15 06:36:54.000000000","message":"Done","commit_id":"5b973f6841c0a387860fdabec51103d2f417cf6a"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"f328c4fe8005f1465dca7580f91fbf28619cfafd","unresolved":false,"context_lines":[{"line_number":104,"context_line":"* ``redfish_password``: The password for the Redfish user to use"},{"line_number":105,"context_line":"  when communicating with the iDRAC."},{"line_number":106,"context_line":"* ``redfish_address``: The URL to the Redfish service running on"},{"line_number":107,"context_line":"  the iDRAC in the form: \"https://\u003cIP\u003e\"."},{"line_number":108,"context_line":"* ``redfish_system_id``: The Redfish ID of the server to be"},{"line_number":109,"context_line":"  managed. This should always be: ``/redfish/v1/Systems/System.Embedded.1``."},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_eed3c95e","line":107,"updated":"2019-10-14 21:28:50.000000000","message":"Let\u0027s replace the \" in the line above with two backticks like this:\n``https://\u003cIP\u003e``\nThis will make the formatting a little better.","commit_id":"5b973f6841c0a387860fdabec51103d2f417cf6a"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"e6d1e00355d71f0ea721ddb77eb4fd4309348c13","unresolved":false,"context_lines":[{"line_number":104,"context_line":"* ``redfish_password``: The password for the Redfish user to use"},{"line_number":105,"context_line":"  when communicating with the iDRAC."},{"line_number":106,"context_line":"* ``redfish_address``: The URL to the Redfish service running on"},{"line_number":107,"context_line":"  the iDRAC in the form: \"https://\u003cIP\u003e\"."},{"line_number":108,"context_line":"* ``redfish_system_id``: The Redfish ID of the server to be"},{"line_number":109,"context_line":"  managed. This should always be: ``/redfish/v1/Systems/System.Embedded.1``."},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_8291c454","line":107,"in_reply_to":"3fa7e38b_eed3c95e","updated":"2019-10-15 06:36:54.000000000","message":"Done","commit_id":"5b973f6841c0a387860fdabec51103d2f417cf6a"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"f328c4fe8005f1465dca7580f91fbf28619cfafd","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"The Dell iDRAC out-of-band inspection process catalogs all the same"},{"line_number":140,"context_line":"attributes of the server as the IPMI driver.  Unlike IPMI, it does this"},{"line_number":141,"context_line":"without requiring the system to be rebooted, or even in a power on"},{"line_number":142,"context_line":"state. Inspection is performed using the Dell WSMAN or Redfish API"},{"line_number":143,"context_line":"directly without affecting the operation of the system being inspected."},{"line_number":144,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_2ebd6101","line":141,"updated":"2019-10-14 21:28:50.000000000","message":"Can you change \"or even in\" to \"or even to be in\"?","commit_id":"5b973f6841c0a387860fdabec51103d2f417cf6a"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"e6d1e00355d71f0ea721ddb77eb4fd4309348c13","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"The Dell iDRAC out-of-band inspection process catalogs all the same"},{"line_number":140,"context_line":"attributes of the server as the IPMI driver.  Unlike IPMI, it does this"},{"line_number":141,"context_line":"without requiring the system to be rebooted, or even in a power on"},{"line_number":142,"context_line":"state. Inspection is performed using the Dell WSMAN or Redfish API"},{"line_number":143,"context_line":"directly without affecting the operation of the system being inspected."},{"line_number":144,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_a28160fd","line":141,"in_reply_to":"3fa7e38b_2ebd6101","updated":"2019-10-15 06:36:54.000000000","message":"Done","commit_id":"5b973f6841c0a387860fdabec51103d2f417cf6a"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"f328c4fe8005f1465dca7580f91fbf28619cfafd","unresolved":false,"context_lines":[{"line_number":158,"context_line":"configured to PXE boot and sets ``pxe_enabled`` to ``True`` on these ports."},{"line_number":159,"context_line":"The ``idrac-redfish`` inspect interface does not currently set ``pxe_enabled``"},{"line_number":160,"context_line":"on the ports.  The user should ensure that \u0027pxe_enabled\u0027 is set correctly"},{"line_number":161,"context_line":"on the ports following inspection."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"RAID Interface"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_ee6189aa","line":161,"updated":"2019-10-14 21:28:50.000000000","message":"Can you change \"following inspection.\" to:\n\"following inspection with the ``idrac-redfish`` inspect interface.\"","commit_id":"5b973f6841c0a387860fdabec51103d2f417cf6a"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"e6d1e00355d71f0ea721ddb77eb4fd4309348c13","unresolved":false,"context_lines":[{"line_number":158,"context_line":"configured to PXE boot and sets ``pxe_enabled`` to ``True`` on these ports."},{"line_number":159,"context_line":"The ``idrac-redfish`` inspect interface does not currently set ``pxe_enabled``"},{"line_number":160,"context_line":"on the ports.  The user should ensure that \u0027pxe_enabled\u0027 is set correctly"},{"line_number":161,"context_line":"on the ports following inspection."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"RAID Interface"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_0294f435","line":161,"in_reply_to":"3fa7e38b_ee6189aa","updated":"2019-10-15 06:36:54.000000000","message":"Done","commit_id":"5b973f6841c0a387860fdabec51103d2f417cf6a"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"f328c4fe8005f1465dca7580f91fbf28619cfafd","unresolved":false,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":"See :doc:`/admin/raid` for more information on backing disk hints."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"These are the machine-independent information. These hints are specified for"},{"line_number":198,"context_line":"each logical disk to let Ironic find the desired disks for RAID configuration."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"* ``disk_type``"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_ae0cf1eb","line":197,"updated":"2019-10-14 21:28:50.000000000","message":"Can you remove \"the\" in the above line?","commit_id":"5b973f6841c0a387860fdabec51103d2f417cf6a"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"e6d1e00355d71f0ea721ddb77eb4fd4309348c13","unresolved":false,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":"See :doc:`/admin/raid` for more information on backing disk hints."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"These are the machine-independent information. These hints are specified for"},{"line_number":198,"context_line":"each logical disk to let Ironic find the desired disks for RAID configuration."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"* ``disk_type``"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_22aa5070","line":197,"in_reply_to":"3fa7e38b_ae0cf1eb","updated":"2019-10-15 06:36:54.000000000","message":"Done","commit_id":"5b973f6841c0a387860fdabec51103d2f417cf6a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"78b120f630a7604039637c242edd6f4d90663e66","unresolved":false,"context_lines":[{"line_number":385,"context_line":""},{"line_number":386,"context_line":".. code-block:: bash"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"  openstack baremetal node passthru call ${node_uuid} set_bios_config \\"},{"line_number":389,"context_line":"    --arg \"ProcVirtualization\u003dEnabled\" \\"},{"line_number":390,"context_line":"    --arg \"SriovGlobalEnable\u003dEnabled\""},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"This returns a dictionary indicating what actions are required next:"},{"line_number":393,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_f033c2a9","line":390,"range":{"start_line":388,"start_character":0,"end_line":390,"end_character":37},"updated":"2019-10-11 18:24:37.000000000","message":"It really seems like Dell could very quickly create a native bios setting interface...","commit_id":"5b973f6841c0a387860fdabec51103d2f417cf6a"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"f328c4fe8005f1465dca7580f91fbf28619cfafd","unresolved":false,"context_lines":[{"line_number":385,"context_line":""},{"line_number":386,"context_line":".. code-block:: bash"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"  openstack baremetal node passthru call ${node_uuid} set_bios_config \\"},{"line_number":389,"context_line":"    --arg \"ProcVirtualization\u003dEnabled\" \\"},{"line_number":390,"context_line":"    --arg \"SriovGlobalEnable\u003dEnabled\""},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"This returns a dictionary indicating what actions are required next:"},{"line_number":393,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_8d901eef","line":390,"range":{"start_line":388,"start_character":0,"end_line":390,"end_character":37},"in_reply_to":"3fa7e38b_f033c2a9","updated":"2019-10-14 21:28:50.000000000","message":"Hey Julia, we do have that in our backlog, but we have other things that are higher priority at the present time.  Hopefully we will get to this soon.","commit_id":"5b973f6841c0a387860fdabec51103d2f417cf6a"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"f328c4fe8005f1465dca7580f91fbf28619cfafd","unresolved":false,"context_lines":[{"line_number":475,"context_line":"  data structures the BIOS uses to interact with I/O device firmware and"},{"line_number":476,"context_line":"  operating system software. The primary intent of UEFI is to eliminate"},{"line_number":477,"context_line":"  shortcomings in the traditional BIOS environment, enabling system firmware to"},{"line_number":478,"context_line":"  continue scaling with industry trends"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"The UEFI boot mode offers:"},{"line_number":481,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_6ee839e1","line":478,"updated":"2019-10-14 21:28:50.000000000","message":"Can you add a period at the end of the above line?","commit_id":"5b973f6841c0a387860fdabec51103d2f417cf6a"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"e6d1e00355d71f0ea721ddb77eb4fd4309348c13","unresolved":false,"context_lines":[{"line_number":475,"context_line":"  data structures the BIOS uses to interact with I/O device firmware and"},{"line_number":476,"context_line":"  operating system software. The primary intent of UEFI is to eliminate"},{"line_number":477,"context_line":"  shortcomings in the traditional BIOS environment, enabling system firmware to"},{"line_number":478,"context_line":"  continue scaling with industry trends"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"The UEFI boot mode offers:"},{"line_number":481,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_a2af207b","line":478,"in_reply_to":"3fa7e38b_6ee839e1","updated":"2019-10-15 06:36:54.000000000","message":"Done","commit_id":"5b973f6841c0a387860fdabec51103d2f417cf6a"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"918cacc5e222d093b78261153fb2b61db21d59af","unresolved":false,"context_lines":[{"line_number":322,"context_line":"                                     the key ``unfinished_jobs``; its value"},{"line_number":323,"context_line":"                                     is a list of dictionaries. Each"},{"line_number":324,"context_line":"                                     dictionary represents an unfinished"},{"line_number":325,"context_line":"                                     config Job object."},{"line_number":326,"context_line":"set_bios_config       POST           Change the BIOS configuration on"},{"line_number":327,"context_line":"                                     a node. Required argument: a"},{"line_number":328,"context_line":"                                     dictionary of {``AttributeName``:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3fa7e38b_a999396d","line":325,"updated":"2019-10-15 21:32:53.000000000","message":"nit: can you change \"Job\" to \"job\" in the line above?","commit_id":"32995ec033146e0324d1a90b91e8a810fdb27df9"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":322,"context_line":"                                     the key ``unfinished_jobs``; its value"},{"line_number":323,"context_line":"                                     is a list of dictionaries. Each"},{"line_number":324,"context_line":"                                     dictionary represents an unfinished"},{"line_number":325,"context_line":"                                     config Job object."},{"line_number":326,"context_line":"set_bios_config       POST           Change the BIOS configuration on"},{"line_number":327,"context_line":"                                     a node. Required argument: a"},{"line_number":328,"context_line":"                                     dictionary of {``AttributeName``:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3fa7e38b_4ac8b053","line":325,"in_reply_to":"3fa7e38b_a999396d","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"32995ec033146e0324d1a90b91e8a810fdb27df9"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"918cacc5e222d093b78261153fb2b61db21d59af","unresolved":false,"context_lines":[{"line_number":447,"context_line":"        \"id\": \"JID_499377293428\"}]}"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"Adandon BIOS Changes"},{"line_number":451,"context_line":"~~~~~~~~~~~~~~~~~~~~"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"Instead of committing, the pending change can also be rolled back"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3fa7e38b_e92f31f3","line":450,"updated":"2019-10-15 21:32:53.000000000","message":"nit: can you change \"Adandon\" to \"Abandon\" in the above line?","commit_id":"32995ec033146e0324d1a90b91e8a810fdb27df9"},{"author":{"_account_id":28370,"name":"Mark Beierl","email":"mark.beierl@canonical.com","username":"mbeierl"},"change_message_id":"ec703094511df1decef524d9d367bb174ab24fce","unresolved":false,"context_lines":[{"line_number":130,"context_line":".. code-block:: bash"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    openstack baremetal node create --driver idrac \\"},{"line_number":133,"context_line":"        --driver-info drac_address\u003dhttp://drac.host \\"},{"line_number":134,"context_line":"        --driver-info drac_username\u003duser \\"},{"line_number":135,"context_line":"        --driver-info drac_password\u003dpa$$w0rd"},{"line_number":136,"context_line":"        --driver-info redfish_username\u003duser \\"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3fa7e38b_75b6a4fb","line":133,"updated":"2019-10-16 15:53:55.000000000","message":"In line 104, drac_address is noted to be just the IP address, without HTTP.","commit_id":"dabf7c525905c74bccdc7ef03797af2dbd776635"},{"author":{"_account_id":28370,"name":"Mark Beierl","email":"mark.beierl@canonical.com","username":"mbeierl"},"change_message_id":"ec703094511df1decef524d9d367bb174ab24fce","unresolved":false,"context_lines":[{"line_number":352,"context_line":".. code-block:: json"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"  {\"ProcVirtualization\": {"},{"line_number":355,"context_line":"        \"current_value\": \"Disabled\","},{"line_number":356,"context_line":"        \"instance_id\": \"BIOS.Setup.1-1:ProcVirtualization\","},{"line_number":357,"context_line":"        \"name\": \"ProcVirtualization\","},{"line_number":358,"context_line":"        \"pending_value\": null,"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3fa7e38b_1596504d","line":355,"updated":"2019-10-16 15:53:55.000000000","message":"I think this should say Enabled.","commit_id":"dabf7c525905c74bccdc7ef03797af2dbd776635"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":5,"context_line":"Overview"},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"The Integrated Dell Remote Access Controller (iDRAC_) is both an"},{"line_number":9,"context_line":"out-of-band management platform and an in-band management platform on"},{"line_number":10,"context_line":"Dell EMC PowerEdge servers, and is supported directly by the ``idrac`` hardware type."},{"line_number":11,"context_line":"This driver uses the Dell Web Services for Management (WSMAN) APIs and"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_1474d5fd","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":5},"updated":"2019-10-21 23:03:47.000000000","message":"This should be lowercase \u0027integrated\u0027.","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":5,"context_line":"Overview"},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"The Integrated Dell Remote Access Controller (iDRAC_) is both an"},{"line_number":9,"context_line":"out-of-band management platform and an in-band management platform on"},{"line_number":10,"context_line":"Dell EMC PowerEdge servers, and is supported directly by the ``idrac`` hardware type."},{"line_number":11,"context_line":"This driver uses the Dell Web Services for Management (WSMAN) APIs and"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_8f174b46","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":5},"in_reply_to":"3fa7e38b_1474d5fd","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"The Integrated Dell Remote Access Controller (iDRAC_) is both an"},{"line_number":9,"context_line":"out-of-band management platform and an in-band management platform on"},{"line_number":10,"context_line":"Dell EMC PowerEdge servers, and is supported directly by the ``idrac`` hardware type."},{"line_number":11,"context_line":"This driver uses the Dell Web Services for Management (WSMAN) APIs and"},{"line_number":12,"context_line":"the standard Distributed Management Task Force (DMTF) Redfish APIs to"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_940be57b","line":9,"range":{"start_line":9,"start_character":39,"end_line":9,"end_character":57},"updated":"2019-10-21 23:03:47.000000000","message":"What is this referring to?","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"The Integrated Dell Remote Access Controller (iDRAC_) is both an"},{"line_number":9,"context_line":"out-of-band management platform and an in-band management platform on"},{"line_number":10,"context_line":"Dell EMC PowerEdge servers, and is supported directly by the ``idrac`` hardware type."},{"line_number":11,"context_line":"This driver uses the Dell Web Services for Management (WSMAN) APIs and"},{"line_number":12,"context_line":"the standard Distributed Management Task Force (DMTF) Redfish APIs to"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_c1b17e46","line":9,"range":{"start_line":9,"start_character":39,"end_line":9,"end_character":57},"in_reply_to":"3fa7e38b_940be57b","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"The Integrated Dell Remote Access Controller (iDRAC_) is both an"},{"line_number":9,"context_line":"out-of-band management platform and an in-band management platform on"},{"line_number":10,"context_line":"Dell EMC PowerEdge servers, and is supported directly by the ``idrac`` hardware type."},{"line_number":11,"context_line":"This driver uses the Dell Web Services for Management (WSMAN) APIs and"},{"line_number":12,"context_line":"the standard Distributed Management Task Force (DMTF) Redfish APIs to"},{"line_number":13,"context_line":"perform all of its functions."}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_b4d381d5","line":10,"range":{"start_line":10,"start_character":9,"end_line":10,"end_character":18},"updated":"2019-10-21 23:03:47.000000000","message":"Additional Dell EMC systems are supported by the iDRAC. A list is available at https://www.dell.com/support/article/us/en/04/sln308699/idrac-9-versions-and-release-notes?lang\u003den. The DSS 9000 is tested in the Dell EMC Ironic Third-party CI.\n\nShould this more generally describe the systems, specifically list those tested by that CI, or remain as-is?","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"The Integrated Dell Remote Access Controller (iDRAC_) is both an"},{"line_number":9,"context_line":"out-of-band management platform and an in-band management platform on"},{"line_number":10,"context_line":"Dell EMC PowerEdge servers, and is supported directly by the ``idrac`` hardware type."},{"line_number":11,"context_line":"This driver uses the Dell Web Services for Management (WSMAN) APIs and"},{"line_number":12,"context_line":"the standard Distributed Management Task Force (DMTF) Redfish APIs to"},{"line_number":13,"context_line":"perform all of its functions."}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_ef1fdf58","line":10,"range":{"start_line":10,"start_character":9,"end_line":10,"end_character":18},"in_reply_to":"3fa7e38b_b4d381d5","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":8,"context_line":"The Integrated Dell Remote Access Controller (iDRAC_) is both an"},{"line_number":9,"context_line":"out-of-band management platform and an in-band management platform on"},{"line_number":10,"context_line":"Dell EMC PowerEdge servers, and is supported directly by the ``idrac`` hardware type."},{"line_number":11,"context_line":"This driver uses the Dell Web Services for Management (WSMAN) APIs and"},{"line_number":12,"context_line":"the standard Distributed Management Task Force (DMTF) Redfish APIs to"},{"line_number":13,"context_line":"perform all of its functions."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_20174c54","line":11,"range":{"start_line":11,"start_character":62,"end_line":11,"end_character":66},"updated":"2019-10-21 23:03:47.000000000","message":"I am thinking \u0027protocol\u0027 should be used here, instead of \u0027APIs\u0027. Later in this documentation, WSMAN and Redfish are referred to as protocols without having been identified as such.","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":8,"context_line":"The Integrated Dell Remote Access Controller (iDRAC_) is both an"},{"line_number":9,"context_line":"out-of-band management platform and an in-band management platform on"},{"line_number":10,"context_line":"Dell EMC PowerEdge servers, and is supported directly by the ``idrac`` hardware type."},{"line_number":11,"context_line":"This driver uses the Dell Web Services for Management (WSMAN) APIs and"},{"line_number":12,"context_line":"the standard Distributed Management Task Force (DMTF) Redfish APIs to"},{"line_number":13,"context_line":"perform all of its functions."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_0f259bab","line":11,"range":{"start_line":11,"start_character":62,"end_line":11,"end_character":66},"in_reply_to":"3fa7e38b_20174c54","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":9,"context_line":"out-of-band management platform and an in-band management platform on"},{"line_number":10,"context_line":"Dell EMC PowerEdge servers, and is supported directly by the ``idrac`` hardware type."},{"line_number":11,"context_line":"This driver uses the Dell Web Services for Management (WSMAN) APIs and"},{"line_number":12,"context_line":"the standard Distributed Management Task Force (DMTF) Redfish APIs to"},{"line_number":13,"context_line":"perform all of its functions."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"iDRAC_ hardware is also supported by the standard ``ipmi`` and ``redfish``"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_8333aaf6","line":12,"range":{"start_line":12,"start_character":62,"end_line":12,"end_character":66},"updated":"2019-10-21 23:03:47.000000000","message":"Ditto","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":9,"context_line":"out-of-band management platform and an in-band management platform on"},{"line_number":10,"context_line":"Dell EMC PowerEdge servers, and is supported directly by the ``idrac`` hardware type."},{"line_number":11,"context_line":"This driver uses the Dell Web Services for Management (WSMAN) APIs and"},{"line_number":12,"context_line":"the standard Distributed Management Task Force (DMTF) Redfish APIs to"},{"line_number":13,"context_line":"perform all of its functions."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"iDRAC_ hardware is also supported by the standard ``ipmi`` and ``redfish``"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_ef54bf00","line":12,"range":{"start_line":12,"start_character":62,"end_line":12,"end_character":66},"in_reply_to":"3fa7e38b_8333aaf6","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":12,"context_line":"the standard Distributed Management Task Force (DMTF) Redfish APIs to"},{"line_number":13,"context_line":"perform all of its functions."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"iDRAC_ hardware is also supported by the standard ``ipmi`` and ``redfish``"},{"line_number":16,"context_line":"hardware types though with a smaller feature set."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Key features of the Dell iDRAC:"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_7afbb346","line":15,"range":{"start_line":15,"start_character":41,"end_line":15,"end_character":49},"updated":"2019-10-21 23:03:47.000000000","message":"I prefer \u0027generic\u0027, as used by the existing OpenStack Ironic installation documentation -- https://opendev.org/openstack/ironic/blame/commit/f85dc1b350f37306e33e587867a8796406f5e6ab/doc/source/install/enabling-drivers.rst#L10","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":12,"context_line":"the standard Distributed Management Task Force (DMTF) Redfish APIs to"},{"line_number":13,"context_line":"perform all of its functions."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"iDRAC_ hardware is also supported by the standard ``ipmi`` and ``redfish``"},{"line_number":16,"context_line":"hardware types though with a smaller feature set."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Key features of the Dell iDRAC:"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_cf3b03c6","line":15,"range":{"start_line":15,"start_character":41,"end_line":15,"end_character":49},"in_reply_to":"3fa7e38b_7afbb346","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":13,"context_line":"perform all of its functions."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"iDRAC_ hardware is also supported by the standard ``ipmi`` and ``redfish``"},{"line_number":16,"context_line":"hardware types though with a smaller feature set."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Key features of the Dell iDRAC:"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_14e295a1","line":16,"range":{"start_line":16,"start_character":9,"end_line":16,"end_character":14},"updated":"2019-10-21 23:03:47.000000000","message":"nit: Seems like a comma should follow \u0027types\u0027.","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":13,"context_line":"perform all of its functions."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"iDRAC_ hardware is also supported by the standard ``ipmi`` and ``redfish``"},{"line_number":16,"context_line":"hardware types though with a smaller feature set."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Key features of the Dell iDRAC:"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_ef6d9fcc","line":16,"range":{"start_line":16,"start_character":9,"end_line":16,"end_character":14},"in_reply_to":"3fa7e38b_14e295a1","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":15,"context_line":"iDRAC_ hardware is also supported by the standard ``ipmi`` and ``redfish``"},{"line_number":16,"context_line":"hardware types though with a smaller feature set."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Key features of the Dell iDRAC:"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"* Inventory and Monitoring"},{"line_number":21,"context_line":"* Configure and use virtual console and virtual media."}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_9a178f46","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":31},"updated":"2019-10-21 23:03:47.000000000","message":"The purpose of this bullet list is unclear to me. Is it meant to describe the key features of the iDRAC or the \u0027idrac\u0027 hardware type?\n\nThe iDRAC also supports boot mode management, boot device management, BIOS settings management, NIC configuration, lifecycle management including firmware and BIOS upgrade, sensor data reporting, log messages, alerts, and more.\n\nFor the \u0027idrac\u0027 hardware type, a feature is listed which is not currently supported, virtual console, and a few are missing, power management, boot device management, and BIOS settings management.","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":15,"context_line":"iDRAC_ hardware is also supported by the standard ``ipmi`` and ``redfish``"},{"line_number":16,"context_line":"hardware types though with a smaller feature set."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Key features of the Dell iDRAC:"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"* Inventory and Monitoring"},{"line_number":21,"context_line":"* Configure and use virtual console and virtual media."}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_92b6723e","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":31},"in_reply_to":"3fa7e38b_9a178f46","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":16,"context_line":"hardware types though with a smaller feature set."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Key features of the Dell iDRAC:"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"* Inventory and Monitoring"},{"line_number":21,"context_line":"* Configure and use virtual console and virtual media."},{"line_number":22,"context_line":"* Remotely configure storage devices attached to the system at run-time."}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_23eaf6ab","line":19,"updated":"2019-10-21 23:03:47.000000000","message":"nit: Either all of the bullet items below should end with a period or none of them should. Please be consistent.","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":16,"context_line":"hardware types though with a smaller feature set."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Key features of the Dell iDRAC:"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"* Inventory and Monitoring"},{"line_number":21,"context_line":"* Configure and use virtual console and virtual media."},{"line_number":22,"context_line":"* Remotely configure storage devices attached to the system at run-time."}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_af67a7ea","line":19,"in_reply_to":"3fa7e38b_23eaf6ab","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Key features of the Dell iDRAC:"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"* Inventory and Monitoring"},{"line_number":21,"context_line":"* Configure and use virtual console and virtual media."},{"line_number":22,"context_line":"* Remotely configure storage devices attached to the system at run-time."},{"line_number":23,"context_line":"* Physical and virtual disk management"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_c3c9a25a","line":20,"range":{"start_line":20,"start_character":16,"end_line":20,"end_character":17},"updated":"2019-10-21 23:03:47.000000000","message":"nit: lowercase?","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Key features of the Dell iDRAC:"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"* Inventory and Monitoring"},{"line_number":21,"context_line":"* Configure and use virtual console and virtual media."},{"line_number":22,"context_line":"* Remotely configure storage devices attached to the system at run-time."},{"line_number":23,"context_line":"* Physical and virtual disk management"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_efa27ffc","line":20,"range":{"start_line":20,"start_character":16,"end_line":20,"end_character":17},"in_reply_to":"3fa7e38b_c3c9a25a","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Key features of the Dell iDRAC:"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"* Inventory and Monitoring"},{"line_number":21,"context_line":"* Configure and use virtual console and virtual media."},{"line_number":22,"context_line":"* Remotely configure storage devices attached to the system at run-time."},{"line_number":23,"context_line":"* Physical and virtual disk management"},{"line_number":24,"context_line":"* RAID controller management"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_63bf8ed0","line":21,"range":{"start_line":21,"start_character":40,"end_line":21,"end_character":53},"updated":"2019-10-21 23:03:47.000000000","message":"The idrac hardware type does not offer virtual media support on stable/train. Depending on the purpose of this section, that could add a winkle to backporting this change to that branch.","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Key features of the Dell iDRAC:"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"* Inventory and Monitoring"},{"line_number":21,"context_line":"* Configure and use virtual console and virtual media."},{"line_number":22,"context_line":"* Remotely configure storage devices attached to the system at run-time."},{"line_number":23,"context_line":"* Physical and virtual disk management"},{"line_number":24,"context_line":"* RAID controller management"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_de539b6b","line":21,"range":{"start_line":21,"start_character":40,"end_line":21,"end_character":53},"in_reply_to":"3fa7e38b_63bf8ed0","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":24,"context_line":"* RAID controller management"},{"line_number":25,"context_line":"* PCIe SSD device management"},{"line_number":26,"context_line":"* Apply the device settings immediately, at next system reboot, at a"},{"line_number":27,"context_line":"  scheduled time, or as a pending operation to be applied as a"},{"line_number":28,"context_line":"  batch as part of a single job."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Ironic Features"},{"line_number":31,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_e38ffe2b","line":28,"range":{"start_line":27,"start_character":58,"end_line":28,"end_character":31},"updated":"2019-10-21 23:03:47.000000000","message":"This does not read clearly to me. Perhaps the following is meant:\n\n\"later as part of a single batch job\"","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":24,"context_line":"* RAID controller management"},{"line_number":25,"context_line":"* PCIe SSD device management"},{"line_number":26,"context_line":"* Apply the device settings immediately, at next system reboot, at a"},{"line_number":27,"context_line":"  scheduled time, or as a pending operation to be applied as a"},{"line_number":28,"context_line":"  batch as part of a single job."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Ironic Features"},{"line_number":31,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_af95678a","line":28,"range":{"start_line":27,"start_character":58,"end_line":28,"end_character":31},"in_reply_to":"3fa7e38b_e38ffe2b","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"The hardware type ``idrac`` supports the following Ironic interfaces:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* `Inspect Interface`_: Hardware Inspection"},{"line_number":36,"context_line":"* Management Interface : Boot device management"},{"line_number":37,"context_line":"* Power Interface : Power management"},{"line_number":38,"context_line":"* `RAID Interface`_: RAID controller and disk management"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_c3ce825a","line":35,"range":{"start_line":35,"start_character":33,"end_line":35,"end_character":34},"updated":"2019-10-21 23:03:47.000000000","message":"nit: lowercase","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"The hardware type ``idrac`` supports the following Ironic interfaces:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* `Inspect Interface`_: Hardware Inspection"},{"line_number":36,"context_line":"* Management Interface : Boot device management"},{"line_number":37,"context_line":"* Power Interface : Power management"},{"line_number":38,"context_line":"* `RAID Interface`_: RAID controller and disk management"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_6f8f6f75","line":35,"range":{"start_line":35,"start_character":33,"end_line":35,"end_character":34},"in_reply_to":"3fa7e38b_c3ce825a","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":42,"context_line":"--------"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"The ``idrac`` hardware type requires the ``python-dracclient`` and"},{"line_number":45,"context_line":"``sushy`` libraries to be installed, for example::"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    sudo pip install \u0027python-dracclient\u003e\u003d3.1.0\u0027 \u0027sushy\u003e\u003d2.0.0\u0027"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_fafd636e","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":9},"updated":"2019-10-21 23:03:47.000000000","message":"It is not really a hard dependency. sushy is required if an Ironic node is configured to use an \u0027idrac-redfish\u0027 interface implementation. That is something to consider for the user experience of those upgrading an existing installation or not planning to use Redfish.","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":42,"context_line":"--------"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"The ``idrac`` hardware type requires the ``python-dracclient`` and"},{"line_number":45,"context_line":"``sushy`` libraries to be installed, for example::"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    sudo pip install \u0027python-dracclient\u003e\u003d3.1.0\u0027 \u0027sushy\u003e\u003d2.0.0\u0027"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_c1665ebc","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":9},"in_reply_to":"3fa7e38b_fafd636e","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"The iDRAC driver supports WSMAN for the inspect, management, power,"},{"line_number":50,"context_line":"raid, and vendor interfaces. In addition, it supports Redfish for"},{"line_number":51,"context_line":"the inspect, power, and management interfaces. The iDRAC driver"},{"line_number":52,"context_line":"allows you to mix and match which protocol to use for which interface."},{"line_number":53,"context_line":"To select WSMAN for an interface, specify ``idrac-wsman`` when"},{"line_number":54,"context_line":"enabling the interface. To select Redfish for an interface, select"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_9a430fb0","line":51,"range":{"start_line":51,"start_character":13,"end_line":51,"end_character":34},"updated":"2019-10-21 23:03:47.000000000","message":"nit: Please consider swapping these so they are in alphabetical order, just like the preceding WSMAN list. It makes it easier for the reader and reviewer :) to compare and contrast.","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"The iDRAC driver supports WSMAN for the inspect, management, power,"},{"line_number":50,"context_line":"raid, and vendor interfaces. In addition, it supports Redfish for"},{"line_number":51,"context_line":"the inspect, power, and management interfaces. The iDRAC driver"},{"line_number":52,"context_line":"allows you to mix and match which protocol to use for which interface."},{"line_number":53,"context_line":"To select WSMAN for an interface, specify ``idrac-wsman`` when"},{"line_number":54,"context_line":"enabling the interface. To select Redfish for an interface, select"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_eff03f00","line":51,"range":{"start_line":51,"start_character":13,"end_line":51,"end_character":34},"in_reply_to":"3fa7e38b_9a430fb0","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":49,"context_line":"The iDRAC driver supports WSMAN for the inspect, management, power,"},{"line_number":50,"context_line":"raid, and vendor interfaces. In addition, it supports Redfish for"},{"line_number":51,"context_line":"the inspect, power, and management interfaces. The iDRAC driver"},{"line_number":52,"context_line":"allows you to mix and match which protocol to use for which interface."},{"line_number":53,"context_line":"To select WSMAN for an interface, specify ``idrac-wsman`` when"},{"line_number":54,"context_line":"enabling the interface. To select Redfish for an interface, select"},{"line_number":55,"context_line":"``idrac-redfish`` when enabling the interface."}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_e3505e61","line":52,"range":{"start_line":52,"start_character":28,"end_line":52,"end_character":69},"updated":"2019-10-21 23:03:47.000000000","message":"Consider changing this to the following:\n\n\"WSMAN and Redfish interfaces\"","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":49,"context_line":"The iDRAC driver supports WSMAN for the inspect, management, power,"},{"line_number":50,"context_line":"raid, and vendor interfaces. In addition, it supports Redfish for"},{"line_number":51,"context_line":"the inspect, power, and management interfaces. The iDRAC driver"},{"line_number":52,"context_line":"allows you to mix and match which protocol to use for which interface."},{"line_number":53,"context_line":"To select WSMAN for an interface, specify ``idrac-wsman`` when"},{"line_number":54,"context_line":"enabling the interface. To select Redfish for an interface, select"},{"line_number":55,"context_line":"``idrac-redfish`` when enabling the interface."}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_6fbd2f01","line":52,"range":{"start_line":52,"start_character":28,"end_line":52,"end_character":69},"in_reply_to":"3fa7e38b_e3505e61","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":50,"context_line":"raid, and vendor interfaces. In addition, it supports Redfish for"},{"line_number":51,"context_line":"the inspect, power, and management interfaces. The iDRAC driver"},{"line_number":52,"context_line":"allows you to mix and match which protocol to use for which interface."},{"line_number":53,"context_line":"To select WSMAN for an interface, specify ``idrac-wsman`` when"},{"line_number":54,"context_line":"enabling the interface. To select Redfish for an interface, select"},{"line_number":55,"context_line":"``idrac-redfish`` when enabling the interface."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":".. NOTE::"},{"line_number":58,"context_line":"   Redfish for an interface can only be selected for the inspect,"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_e3713ee0","line":55,"range":{"start_line":53,"start_character":0,"end_line":55,"end_character":46},"updated":"2019-10-21 23:03:47.000000000","message":"An interface must be enabled in the Ironic conductor in order for it to be available when configuring a node. Simply enabling an interface may not cause it to be selected for a node.\n\nSelection is affected by the collection of interfaces of the same type -- inspect, management, power, etc. -- which are enabled, configuration of the interface type\u0027s default implementation, the implementations supported by the driver, and whether or not a specific interface is specified when the node is enrolled.\n\nThe addition of the following enrollment examples would be helpful.\n\n1. All WSMAN\n2. Mix of WSMAN and Redfish\n3. All Redfish\n\nIt would also be useful to describe how to change interfaces after enrollment.","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":50,"context_line":"raid, and vendor interfaces. In addition, it supports Redfish for"},{"line_number":51,"context_line":"the inspect, power, and management interfaces. The iDRAC driver"},{"line_number":52,"context_line":"allows you to mix and match which protocol to use for which interface."},{"line_number":53,"context_line":"To select WSMAN for an interface, specify ``idrac-wsman`` when"},{"line_number":54,"context_line":"enabling the interface. To select Redfish for an interface, select"},{"line_number":55,"context_line":"``idrac-redfish`` when enabling the interface."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":".. NOTE::"},{"line_number":58,"context_line":"   Redfish for an interface can only be selected for the inspect,"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_12f12202","line":55,"range":{"start_line":53,"start_character":0,"end_line":55,"end_character":46},"in_reply_to":"3fa7e38b_e3713ee0","updated":"2019-10-23 14:31:57.000000000","message":"This comment is addressed in below section under heading \"Enrolling\" consisting examples of all combinations of wsman and redfish.","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":64,"context_line":"   to use Redfish for one and WSMAN for the other."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"To enable the ``idrac`` hardware type with the minimum interfaces,"},{"line_number":67,"context_line":"which are configured to use WSMAN, add the following to your"},{"line_number":68,"context_line":"``/etc/ironic/ironic.conf``:"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":".. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_bd71257a","line":67,"range":{"start_line":67,"start_character":6,"end_line":67,"end_character":24},"updated":"2019-10-21 23:03:47.000000000","message":"Their implementations use WSMAN. They cannot be configured otherwise. Therefore, this should be removed. Please consider the following phrasing.\n\n\"To enable the ``idrac`` hardware type with the minimum interfaces, all using WSMAN, add the following to your\"","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":64,"context_line":"   to use Redfish for one and WSMAN for the other."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"To enable the ``idrac`` hardware type with the minimum interfaces,"},{"line_number":67,"context_line":"which are configured to use WSMAN, add the following to your"},{"line_number":68,"context_line":"``/etc/ironic/ironic.conf``:"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":".. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_cf454317","line":67,"range":{"start_line":67,"start_character":6,"end_line":67,"end_character":24},"in_reply_to":"3fa7e38b_bd71257a","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    enabled_hardware_types\u003didrac-wsman"},{"line_number":74,"context_line":"    enabled_management_interfaces\u003didrac-wsman"},{"line_number":75,"context_line":"    enabled_power_interfaces\u003didrac-wsman"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"To enable all optional features (inspection, RAID and vendor passthru)"},{"line_number":78,"context_line":"using Redfish where it is supported and WSMAN where not, use the"},{"line_number":79,"context_line":"following configuration:"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_9a8d4fd5","line":76,"updated":"2019-10-21 23:03:47.000000000","message":"How about mentioning the \u0027idrac\u0027 is the legacy name of the WSMAN interface implementations, has been deprecated in favor of \u0027idrac-wsman\u0027, and may be removed in a future release?","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    enabled_hardware_types\u003didrac-wsman"},{"line_number":74,"context_line":"    enabled_management_interfaces\u003didrac-wsman"},{"line_number":75,"context_line":"    enabled_power_interfaces\u003didrac-wsman"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"To enable all optional features (inspection, RAID and vendor passthru)"},{"line_number":78,"context_line":"using Redfish where it is supported and WSMAN where not, use the"},{"line_number":79,"context_line":"following configuration:"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_aff6c7d7","line":76,"in_reply_to":"3fa7e38b_9a8d4fd5","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    enabled_raid_interfaces\u003didrac-wsman"},{"line_number":89,"context_line":"    enabled_vendor_interfaces\u003didrac-wsman"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Protocol Specific Authentication Parameters"},{"line_number":92,"context_line":"-------------------------------------------"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"The WSMAN and Redfish protocols require different parameters to be"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_4e50790b","line":91,"range":{"start_line":91,"start_character":33,"end_line":91,"end_character":43},"updated":"2019-10-21 23:03:47.000000000","message":"Properties","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    enabled_raid_interfaces\u003didrac-wsman"},{"line_number":89,"context_line":"    enabled_vendor_interfaces\u003didrac-wsman"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Protocol Specific Authentication Parameters"},{"line_number":92,"context_line":"-------------------------------------------"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"The WSMAN and Redfish protocols require different parameters to be"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_ee54c500","line":91,"range":{"start_line":91,"start_character":0,"end_line":91,"end_character":17},"updated":"2019-10-21 23:03:47.000000000","message":"Protocol-specific","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    enabled_raid_interfaces\u003didrac-wsman"},{"line_number":89,"context_line":"    enabled_vendor_interfaces\u003didrac-wsman"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Protocol Specific Authentication Parameters"},{"line_number":92,"context_line":"-------------------------------------------"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"The WSMAN and Redfish protocols require different parameters to be"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_0fb59bcd","line":91,"range":{"start_line":91,"start_character":33,"end_line":91,"end_character":43},"in_reply_to":"3fa7e38b_4e50790b","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    enabled_raid_interfaces\u003didrac-wsman"},{"line_number":89,"context_line":"    enabled_vendor_interfaces\u003didrac-wsman"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Protocol Specific Authentication Parameters"},{"line_number":92,"context_line":"-------------------------------------------"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"The WSMAN and Redfish protocols require different parameters to be"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_afc9e75a","line":91,"range":{"start_line":91,"start_character":0,"end_line":91,"end_character":17},"in_reply_to":"3fa7e38b_ee54c500","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":91,"context_line":"Protocol Specific Authentication Parameters"},{"line_number":92,"context_line":"-------------------------------------------"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"The WSMAN and Redfish protocols require different parameters to be"},{"line_number":95,"context_line":"set on the node in Ironic to be able to communicate with the bare"},{"line_number":96,"context_line":"metal node."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"The ``WSMAN protocol`` requires the following parameters:"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_e3c05e7f","line":96,"range":{"start_line":94,"start_character":0,"end_line":96,"end_character":11},"updated":"2019-10-21 23:03:47.000000000","message":"To put this in Ironic node configuration terms, I suggest it be changed to the following:\n\n\"The WSMAN and Redfish protocols require different properties to be specified in the Ironic node\u0027s ``driver_info`` field to communicate with the bare metal system\u0027s iDRAC.\"","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":91,"context_line":"Protocol Specific Authentication Parameters"},{"line_number":92,"context_line":"-------------------------------------------"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"The WSMAN and Redfish protocols require different parameters to be"},{"line_number":95,"context_line":"set on the node in Ironic to be able to communicate with the bare"},{"line_number":96,"context_line":"metal node."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"The ``WSMAN protocol`` requires the following parameters:"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_cf1c6315","line":96,"range":{"start_line":94,"start_character":0,"end_line":96,"end_character":11},"in_reply_to":"3fa7e38b_e3c05e7f","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":95,"context_line":"set on the node in Ironic to be able to communicate with the bare"},{"line_number":96,"context_line":"metal node."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"The ``WSMAN protocol`` requires the following parameters:"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"* ``drac_username``: The WSMAN user name to use when communicating"},{"line_number":101,"context_line":"  with the iDRAC. Usually ``root``."}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_a3ba6607","line":98,"range":{"start_line":98,"start_character":46,"end_line":98,"end_character":56},"updated":"2019-10-21 23:03:47.000000000","message":"properties","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":95,"context_line":"set on the node in Ironic to be able to communicate with the bare"},{"line_number":96,"context_line":"metal node."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"The ``WSMAN protocol`` requires the following parameters:"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"* ``drac_username``: The WSMAN user name to use when communicating"},{"line_number":101,"context_line":"  with the iDRAC. Usually ``root``."}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_2fd17730","line":98,"range":{"start_line":98,"start_character":46,"end_line":98,"end_character":56},"in_reply_to":"3fa7e38b_a3ba6607","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":103,"context_line":"  communicating with the iDRAC."},{"line_number":104,"context_line":"* ``drac_address``: The IP address of the iDRAC."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"The ``Redfish protocol`` requires the following parameters:"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"* ``redfish_username``: The Redfish user name to use when"},{"line_number":109,"context_line":"  communicating with the iDRAC. Usually ``root``."}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_633a2e99","line":106,"range":{"start_line":106,"start_character":48,"end_line":106,"end_character":58},"updated":"2019-10-21 23:03:47.000000000","message":"Ditto","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":103,"context_line":"  communicating with the iDRAC."},{"line_number":104,"context_line":"* ``drac_address``: The IP address of the iDRAC."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"The ``Redfish protocol`` requires the following parameters:"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"* ``redfish_username``: The Redfish user name to use when"},{"line_number":109,"context_line":"  communicating with the iDRAC. Usually ``root``."}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_efda7f49","line":106,"range":{"start_line":106,"start_character":48,"end_line":106,"end_character":58},"in_reply_to":"3fa7e38b_633a2e99","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":110,"context_line":"* ``redfish_password``: The password for the Redfish user to use"},{"line_number":111,"context_line":"  when communicating with the iDRAC."},{"line_number":112,"context_line":"* ``redfish_address``: The URL to the Redfish service running on"},{"line_number":113,"context_line":"  the iDRAC in the form: ``https://\u003cIP\u003e``."},{"line_number":114,"context_line":"* ``redfish_system_id``: The Redfish ID of the server to be"},{"line_number":115,"context_line":"  managed. This should always be: ``/redfish/v1/Systems/System.Embedded.1``."},{"line_number":116,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_fdb55d7f","line":113,"range":{"start_line":113,"start_character":27,"end_line":113,"end_character":35},"updated":"2019-10-21 23:03:47.000000000","message":"The scheme component of the URI, \u0027https\u0027, is not required. Simply providing the IP address is sufficient.\n\n[1] https://opendev.org/openstack/ironic/blame/branch/master/doc/source/admin/drivers/redfish.rst#L51-L54","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":110,"context_line":"* ``redfish_password``: The password for the Redfish user to use"},{"line_number":111,"context_line":"  when communicating with the iDRAC."},{"line_number":112,"context_line":"* ``redfish_address``: The URL to the Redfish service running on"},{"line_number":113,"context_line":"  the iDRAC in the form: ``https://\u003cIP\u003e``."},{"line_number":114,"context_line":"* ``redfish_system_id``: The Redfish ID of the server to be"},{"line_number":115,"context_line":"  managed. This should always be: ``/redfish/v1/Systems/System.Embedded.1``."},{"line_number":116,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_8f8d0bd5","line":113,"range":{"start_line":113,"start_character":27,"end_line":113,"end_character":35},"in_reply_to":"3fa7e38b_fdb55d7f","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":114,"context_line":"* ``redfish_system_id``: The Redfish ID of the server to be"},{"line_number":115,"context_line":"  managed. This should always be: ``/redfish/v1/Systems/System.Embedded.1``."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"If using only interfaces configured to use WSMAN (``idrac-wsman``), then"},{"line_number":118,"context_line":"only the WSMAN parameters must be supplied. If using only interfaces"},{"line_number":119,"context_line":"configured to use Redfish (``idrac-redfish``) then only the Redfish"},{"line_number":120,"context_line":"parameters must be supplied. If using a mix of interfaces where some"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_a34fc632","line":117,"range":{"start_line":117,"start_character":25,"end_line":117,"end_character":38},"updated":"2019-10-21 23:03:47.000000000","message":"Please change \"configured to\" to \"which\"","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":114,"context_line":"* ``redfish_system_id``: The Redfish ID of the server to be"},{"line_number":115,"context_line":"  managed. This should always be: ``/redfish/v1/Systems/System.Embedded.1``."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"If using only interfaces configured to use WSMAN (``idrac-wsman``), then"},{"line_number":118,"context_line":"only the WSMAN parameters must be supplied. If using only interfaces"},{"line_number":119,"context_line":"configured to use Redfish (``idrac-redfish``) then only the Redfish"},{"line_number":120,"context_line":"parameters must be supplied. If using a mix of interfaces where some"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_cf8f832c","line":117,"range":{"start_line":117,"start_character":25,"end_line":117,"end_character":38},"in_reply_to":"3fa7e38b_a34fc632","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":115,"context_line":"  managed. This should always be: ``/redfish/v1/Systems/System.Embedded.1``."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"If using only interfaces configured to use WSMAN (``idrac-wsman``), then"},{"line_number":118,"context_line":"only the WSMAN parameters must be supplied. If using only interfaces"},{"line_number":119,"context_line":"configured to use Redfish (``idrac-redfish``) then only the Redfish"},{"line_number":120,"context_line":"parameters must be supplied. If using a mix of interfaces where some"},{"line_number":121,"context_line":"use WSMAN and others use Redfish, both the WSMAN and Redfish parameters"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_63630eb3","line":118,"range":{"start_line":118,"start_character":15,"end_line":118,"end_character":25},"updated":"2019-10-21 23:03:47.000000000","message":"Ditto","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":115,"context_line":"  managed. This should always be: ``/redfish/v1/Systems/System.Embedded.1``."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"If using only interfaces configured to use WSMAN (``idrac-wsman``), then"},{"line_number":118,"context_line":"only the WSMAN parameters must be supplied. If using only interfaces"},{"line_number":119,"context_line":"configured to use Redfish (``idrac-redfish``) then only the Redfish"},{"line_number":120,"context_line":"parameters must be supplied. If using a mix of interfaces where some"},{"line_number":121,"context_line":"use WSMAN and others use Redfish, both the WSMAN and Redfish parameters"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_0f87db11","line":118,"range":{"start_line":118,"start_character":15,"end_line":118,"end_character":25},"in_reply_to":"3fa7e38b_63630eb3","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"If using only interfaces configured to use WSMAN (``idrac-wsman``), then"},{"line_number":118,"context_line":"only the WSMAN parameters must be supplied. If using only interfaces"},{"line_number":119,"context_line":"configured to use Redfish (``idrac-redfish``) then only the Redfish"},{"line_number":120,"context_line":"parameters must be supplied. If using a mix of interfaces where some"},{"line_number":121,"context_line":"use WSMAN and others use Redfish, both the WSMAN and Redfish parameters"},{"line_number":122,"context_line":"must be supplied."}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_03581af8","line":119,"range":{"start_line":119,"start_character":0,"end_line":119,"end_character":13},"updated":"2019-10-21 23:03:47.000000000","message":"Ditto","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"If using only interfaces configured to use WSMAN (``idrac-wsman``), then"},{"line_number":118,"context_line":"only the WSMAN parameters must be supplied. If using only interfaces"},{"line_number":119,"context_line":"configured to use Redfish (``idrac-redfish``) then only the Redfish"},{"line_number":120,"context_line":"parameters must be supplied. If using a mix of interfaces where some"},{"line_number":121,"context_line":"use WSMAN and others use Redfish, both the WSMAN and Redfish parameters"},{"line_number":122,"context_line":"must be supplied."}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_af7b2727","line":119,"range":{"start_line":119,"start_character":0,"end_line":119,"end_character":13},"in_reply_to":"3fa7e38b_03581af8","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":117,"context_line":"If using only interfaces configured to use WSMAN (``idrac-wsman``), then"},{"line_number":118,"context_line":"only the WSMAN parameters must be supplied. If using only interfaces"},{"line_number":119,"context_line":"configured to use Redfish (``idrac-redfish``) then only the Redfish"},{"line_number":120,"context_line":"parameters must be supplied. If using a mix of interfaces where some"},{"line_number":121,"context_line":"use WSMAN and others use Redfish, both the WSMAN and Redfish parameters"},{"line_number":122,"context_line":"must be supplied."},{"line_number":123,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_c32202bb","line":120,"range":{"start_line":120,"start_character":0,"end_line":120,"end_character":10},"updated":"2019-10-21 23:03:47.000000000","message":"Ditto","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":117,"context_line":"If using only interfaces configured to use WSMAN (``idrac-wsman``), then"},{"line_number":118,"context_line":"only the WSMAN parameters must be supplied. If using only interfaces"},{"line_number":119,"context_line":"configured to use Redfish (``idrac-redfish``) then only the Redfish"},{"line_number":120,"context_line":"parameters must be supplied. If using a mix of interfaces where some"},{"line_number":121,"context_line":"use WSMAN and others use Redfish, both the WSMAN and Redfish parameters"},{"line_number":122,"context_line":"must be supplied."},{"line_number":123,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_cf78e32c","line":120,"range":{"start_line":120,"start_character":0,"end_line":120,"end_character":10},"in_reply_to":"3fa7e38b_c32202bb","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":118,"context_line":"only the WSMAN parameters must be supplied. If using only interfaces"},{"line_number":119,"context_line":"configured to use Redfish (``idrac-redfish``) then only the Redfish"},{"line_number":120,"context_line":"parameters must be supplied. If using a mix of interfaces where some"},{"line_number":121,"context_line":"use WSMAN and others use Redfish, both the WSMAN and Redfish parameters"},{"line_number":122,"context_line":"must be supplied."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Enrolling"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_e36e1e95","line":121,"range":{"start_line":121,"start_character":61,"end_line":121,"end_character":71},"updated":"2019-10-21 23:03:47.000000000","message":"Ditto","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":118,"context_line":"only the WSMAN parameters must be supplied. If using only interfaces"},{"line_number":119,"context_line":"configured to use Redfish (``idrac-redfish``) then only the Redfish"},{"line_number":120,"context_line":"parameters must be supplied. If using a mix of interfaces where some"},{"line_number":121,"context_line":"use WSMAN and others use Redfish, both the WSMAN and Redfish parameters"},{"line_number":122,"context_line":"must be supplied."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Enrolling"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_8f72eb48","line":121,"range":{"start_line":121,"start_character":61,"end_line":121,"end_character":71},"in_reply_to":"3fa7e38b_e36e1e95","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        --driver-info drac_password\u003dpa$$w0rd"},{"line_number":136,"context_line":"        --driver-info redfish_username\u003duser \\"},{"line_number":137,"context_line":"        --driver-info redfish_password\u003dpa$$w0rd \\"},{"line_number":138,"context_line":"        --driver-info redfish_address\u003dhttps://drac.host \\"},{"line_number":139,"context_line":"        --driver-info redfish_system_id\u003d/redfish/v1/Systems/System.Embedded.1"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_6308eed8","line":138,"range":{"start_line":138,"start_character":38,"end_line":138,"end_character":55},"updated":"2019-10-21 23:03:47.000000000","message":"\u0027drac.host\u0027 is sufficient.","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        --driver-info drac_password\u003dpa$$w0rd"},{"line_number":136,"context_line":"        --driver-info redfish_username\u003duser \\"},{"line_number":137,"context_line":"        --driver-info redfish_password\u003dpa$$w0rd \\"},{"line_number":138,"context_line":"        --driver-info redfish_address\u003dhttps://drac.host \\"},{"line_number":139,"context_line":"        --driver-info redfish_system_id\u003d/redfish/v1/Systems/System.Embedded.1"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_6f90cfee","line":138,"range":{"start_line":138,"start_character":38,"end_line":138,"end_character":55},"in_reply_to":"3fa7e38b_6308eed8","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"The Dell iDRAC out-of-band inspection process catalogs all the same"},{"line_number":146,"context_line":"attributes of the server as the IPMI driver.  Unlike IPMI, it does this"},{"line_number":147,"context_line":"without requiring the system to be rebooted, or even to be in a power ON"},{"line_number":148,"context_line":"state. Inspection is performed using the Dell WSMAN or Redfish API"},{"line_number":149,"context_line":"directly without affecting the operation of the system being inspected."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"The inspection discovers the following properties:"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_832c0aad","line":148,"range":{"start_line":147,"start_character":59,"end_line":148,"end_character":5},"updated":"2019-10-21 23:03:47.000000000","message":"powered on?","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":145,"context_line":"The Dell iDRAC out-of-band inspection process catalogs all the same"},{"line_number":146,"context_line":"attributes of the server as the IPMI driver.  Unlike IPMI, it does this"},{"line_number":147,"context_line":"without requiring the system to be rebooted, or even to be in a power ON"},{"line_number":148,"context_line":"state. Inspection is performed using the Dell WSMAN or Redfish API"},{"line_number":149,"context_line":"directly without affecting the operation of the system being inspected."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"The inspection discovers the following properties:"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_a3fd86b2","line":148,"range":{"start_line":148,"start_character":63,"end_line":148,"end_character":66},"updated":"2019-10-21 23:03:47.000000000","message":"protocol","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"The Dell iDRAC out-of-band inspection process catalogs all the same"},{"line_number":146,"context_line":"attributes of the server as the IPMI driver.  Unlike IPMI, it does this"},{"line_number":147,"context_line":"without requiring the system to be rebooted, or even to be in a power ON"},{"line_number":148,"context_line":"state. Inspection is performed using the Dell WSMAN or Redfish API"},{"line_number":149,"context_line":"directly without affecting the operation of the system being inspected."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"The inspection discovers the following properties:"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_4fbb93c3","line":148,"range":{"start_line":147,"start_character":59,"end_line":148,"end_character":5},"in_reply_to":"3fa7e38b_832c0aad","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":145,"context_line":"The Dell iDRAC out-of-band inspection process catalogs all the same"},{"line_number":146,"context_line":"attributes of the server as the IPMI driver.  Unlike IPMI, it does this"},{"line_number":147,"context_line":"without requiring the system to be rebooted, or even to be in a power ON"},{"line_number":148,"context_line":"state. Inspection is performed using the Dell WSMAN or Redfish API"},{"line_number":149,"context_line":"directly without affecting the operation of the system being inspected."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"The inspection discovers the following properties:"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_efafdf7a","line":148,"range":{"start_line":148,"start_character":63,"end_line":148,"end_character":66},"in_reply_to":"3fa7e38b_a3fd86b2","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"* ``cpu_arch``: cpu architecture"},{"line_number":154,"context_line":"* ``cpus``: number of cpus"},{"line_number":155,"context_line":"* ``local_gb``: disk size"},{"line_number":156,"context_line":"* ``memory_mb``: memory size"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Extra capabilities:"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_c31f6207","line":155,"range":{"start_line":155,"start_character":16,"end_line":155,"end_character":25},"updated":"2019-10-21 23:03:47.000000000","message":"How about adding \"in gigabytes\"?","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"* ``cpu_arch``: cpu architecture"},{"line_number":154,"context_line":"* ``cpus``: number of cpus"},{"line_number":155,"context_line":"* ``local_gb``: disk size"},{"line_number":156,"context_line":"* ``memory_mb``: memory size"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Extra capabilities:"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_0fed9b8a","line":155,"range":{"start_line":155,"start_character":16,"end_line":155,"end_character":25},"in_reply_to":"3fa7e38b_c31f6207","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":153,"context_line":"* ``cpu_arch``: cpu architecture"},{"line_number":154,"context_line":"* ``cpus``: number of cpus"},{"line_number":155,"context_line":"* ``local_gb``: disk size"},{"line_number":156,"context_line":"* ``memory_mb``: memory size"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Extra capabilities:"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_e31cde14","line":156,"range":{"start_line":156,"start_character":17,"end_line":156,"end_character":28},"updated":"2019-10-21 23:03:47.000000000","message":"How about adding \"in megabytes\"?","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":153,"context_line":"* ``cpu_arch``: cpu architecture"},{"line_number":154,"context_line":"* ``cpus``: number of cpus"},{"line_number":155,"context_line":"* ``local_gb``: disk size"},{"line_number":156,"context_line":"* ``memory_mb``: memory size"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Extra capabilities:"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_af01e73b","line":156,"range":{"start_line":156,"start_character":17,"end_line":156,"end_character":28},"in_reply_to":"3fa7e38b_e31cde14","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"fcaae13bc817e9dde535f40f60c2926ba05cc663","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"It also creates baremetal ports for each NIC port detected in the system."},{"line_number":163,"context_line":"The ``idrac-wsman`` inspect interface discovers which NIC ports are"},{"line_number":164,"context_line":"configured to PXE boot and sets ``pxe_enabled`` to ``True`` on these ports."},{"line_number":165,"context_line":"The ``idrac-redfish`` inspect interface does not currently set ``pxe_enabled``"},{"line_number":166,"context_line":"on the ports.  The user should ensure that \u0027pxe_enabled\u0027 is set correctly on"},{"line_number":167,"context_line":"the ports following inspection with the ``idrac-redfish`` inspect interface."}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_43185283","line":164,"range":{"start_line":164,"start_character":63,"end_line":164,"end_character":68},"updated":"2019-10-21 23:03:47.000000000","message":"nit: those","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"d23143307ffda69f3531ba0c26704da6bfcd8b67","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"It also creates baremetal ports for each NIC port detected in the system."},{"line_number":163,"context_line":"The ``idrac-wsman`` inspect interface discovers which NIC ports are"},{"line_number":164,"context_line":"configured to PXE boot and sets ``pxe_enabled`` to ``True`` on these ports."},{"line_number":165,"context_line":"The ``idrac-redfish`` inspect interface does not currently set ``pxe_enabled``"},{"line_number":166,"context_line":"on the ports.  The user should ensure that \u0027pxe_enabled\u0027 is set correctly on"},{"line_number":167,"context_line":"the ports following inspection with the ``idrac-redfish`` inspect interface."}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fa7e38b_2fee578b","line":164,"range":{"start_line":164,"start_character":63,"end_line":164,"end_character":68},"in_reply_to":"3fa7e38b_43185283","updated":"2019-10-23 14:31:57.000000000","message":"Done","commit_id":"849c86ae3fe44c0e4f8a48907bdc80ae9a47ae32"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"18bdd3a9158ffb26ec6bd7ed7ecd917513daacda","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Force (DMTF) Redfish protocol to perform all of its functions."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"iDRAC_ hardware is also supported by the generic ``ipmi`` and ``redfish``"},{"line_number":15,"context_line":"hardware types, though with a smaller feature set."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Key features of the Dell iDRAC driver:"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_2ab61e8c","line":15,"range":{"start_line":15,"start_character":28,"end_line":15,"end_character":49},"updated":"2019-10-24 04:19:27.000000000","message":"nit: I believe this should be plural -- \"smaller feature sets\".","commit_id":"7ad5e22a6d33aa4e9b29cf99d400f356e79fdc03"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"be510d4ea97d402bb13cfe8e3d34f582f094da25","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Force (DMTF) Redfish protocol to perform all of its functions."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"iDRAC_ hardware is also supported by the generic ``ipmi`` and ``redfish``"},{"line_number":15,"context_line":"hardware types, though with a smaller feature set."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Key features of the Dell iDRAC driver:"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_b3a12698","line":15,"range":{"start_line":15,"start_character":28,"end_line":15,"end_character":49},"in_reply_to":"3fa7e38b_2ab61e8c","updated":"2019-10-24 07:49:05.000000000","message":"Done","commit_id":"7ad5e22a6d33aa4e9b29cf99d400f356e79fdc03"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"18bdd3a9158ffb26ec6bd7ed7ecd917513daacda","unresolved":false,"context_lines":[{"line_number":36,"context_line":"Enabling"},{"line_number":37,"context_line":"--------"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The ``idrac`` hardware type requires the ``python-dracclient`` library"},{"line_number":40,"context_line":"to be installed, for example::"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    sudo pip install \u0027python-dracclient\u003e\u003d3.1.0\u0027"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_5001c803","line":40,"range":{"start_line":39,"start_character":0,"end_line":40,"end_character":28},"updated":"2019-10-24 04:19:27.000000000","message":"Come to think of it, this is also not a hard dependency. python-dracclient is required if an Ironic node is configured to use an \u0027idrac-wsman\u0027 interface implementation. This could affect the user experience of new installations using only Redfish.","commit_id":"7ad5e22a6d33aa4e9b29cf99d400f356e79fdc03"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"18bdd3a9158ffb26ec6bd7ed7ecd917513daacda","unresolved":false,"context_lines":[{"line_number":37,"context_line":"--------"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The ``idrac`` hardware type requires the ``python-dracclient`` library"},{"line_number":40,"context_line":"to be installed, for example::"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    sudo pip install \u0027python-dracclient\u003e\u003d3.1.0\u0027"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_d0f298e3","line":40,"range":{"start_line":40,"start_character":6,"end_line":40,"end_character":15},"updated":"2019-10-24 04:19:27.000000000","message":"It must be installed on the ironic conductor node(s).","commit_id":"7ad5e22a6d33aa4e9b29cf99d400f356e79fdc03"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"be510d4ea97d402bb13cfe8e3d34f582f094da25","unresolved":false,"context_lines":[{"line_number":36,"context_line":"Enabling"},{"line_number":37,"context_line":"--------"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The ``idrac`` hardware type requires the ``python-dracclient`` library"},{"line_number":40,"context_line":"to be installed, for example::"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    sudo pip install \u0027python-dracclient\u003e\u003d3.1.0\u0027"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_f3331e61","line":40,"range":{"start_line":39,"start_character":0,"end_line":40,"end_character":28},"in_reply_to":"3fa7e38b_5001c803","updated":"2019-10-24 07:49:05.000000000","message":"Done","commit_id":"7ad5e22a6d33aa4e9b29cf99d400f356e79fdc03"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"be510d4ea97d402bb13cfe8e3d34f582f094da25","unresolved":false,"context_lines":[{"line_number":37,"context_line":"--------"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The ``idrac`` hardware type requires the ``python-dracclient`` library"},{"line_number":40,"context_line":"to be installed, for example::"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    sudo pip install \u0027python-dracclient\u003e\u003d3.1.0\u0027"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_1337da4f","line":40,"range":{"start_line":40,"start_character":6,"end_line":40,"end_character":15},"in_reply_to":"3fa7e38b_d0f298e3","updated":"2019-10-24 07:49:05.000000000","message":"Done","commit_id":"7ad5e22a6d33aa4e9b29cf99d400f356e79fdc03"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"18bdd3a9158ffb26ec6bd7ed7ecd917513daacda","unresolved":false,"context_lines":[{"line_number":36,"context_line":"Enabling"},{"line_number":37,"context_line":"--------"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The ``idrac`` hardware type requires the ``python-dracclient`` library"},{"line_number":40,"context_line":"to be installed, for example::"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    sudo pip install \u0027python-dracclient\u003e\u003d3.1.0\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Additionally, the ``idrac`` hardware type requires ``sushy`` library to"},{"line_number":45,"context_line":"be installed if an Ironic node is configured to use an ``idrac-redfish``"},{"line_number":46,"context_line":"interface implementation, for example::"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"   sudo pip install \u0027python-dracclient\u003e\u003d3.1.0\u0027 \u0027sushy\u003e\u003d2.0.0\u0027"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"The iDRAC driver supports WSMAN for the inspect, management, power,"},{"line_number":51,"context_line":"raid, and vendor interfaces. In addition, it supports Redfish for"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_f00d54e8","line":48,"range":{"start_line":39,"start_character":0,"end_line":48,"end_character":61},"updated":"2019-10-24 04:19:27.000000000","message":"This feels like it should be a separate subsection which appears before Enabling. It could be called \u0027Prerequisites\u0027. Please see the generic Redfish driver documentation for an example -- https://opendev.org/openstack/ironic/blame/branch/master/doc/source/admin/drivers/redfish.rst#L11-L22.","commit_id":"7ad5e22a6d33aa4e9b29cf99d400f356e79fdc03"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"be510d4ea97d402bb13cfe8e3d34f582f094da25","unresolved":false,"context_lines":[{"line_number":36,"context_line":"Enabling"},{"line_number":37,"context_line":"--------"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The ``idrac`` hardware type requires the ``python-dracclient`` library"},{"line_number":40,"context_line":"to be installed, for example::"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    sudo pip install \u0027python-dracclient\u003e\u003d3.1.0\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Additionally, the ``idrac`` hardware type requires ``sushy`` library to"},{"line_number":45,"context_line":"be installed if an Ironic node is configured to use an ``idrac-redfish``"},{"line_number":46,"context_line":"interface implementation, for example::"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"   sudo pip install \u0027python-dracclient\u003e\u003d3.1.0\u0027 \u0027sushy\u003e\u003d2.0.0\u0027"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"The iDRAC driver supports WSMAN for the inspect, management, power,"},{"line_number":51,"context_line":"raid, and vendor interfaces. In addition, it supports Redfish for"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_73472ebe","line":48,"range":{"start_line":39,"start_character":0,"end_line":48,"end_character":61},"in_reply_to":"3fa7e38b_f00d54e8","updated":"2019-10-24 07:49:05.000000000","message":"Done","commit_id":"7ad5e22a6d33aa4e9b29cf99d400f356e79fdc03"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"18bdd3a9158ffb26ec6bd7ed7ecd917513daacda","unresolved":false,"context_lines":[{"line_number":50,"context_line":"The iDRAC driver supports WSMAN for the inspect, management, power,"},{"line_number":51,"context_line":"raid, and vendor interfaces. In addition, it supports Redfish for"},{"line_number":52,"context_line":"the inspect, management, and power interfaces. The iDRAC driver"},{"line_number":53,"context_line":"allows you to mix and match WSMAN and Redfish interfaces. To select"},{"line_number":54,"context_line":"WSMAN for an interface, specify ``idrac-wsman`` when enabling the"},{"line_number":55,"context_line":"interface. To select Redfish for an interface, select ``idrac-redfish``"},{"line_number":56,"context_line":"when enabling the interface."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":".. NOTE::"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_504f8869","line":55,"range":{"start_line":53,"start_character":58,"end_line":55,"end_character":10},"updated":"2019-10-24 04:19:27.000000000","message":"Please consider changing this to the following:\n\n\"To use WSMAN for an interface, the ``idrac-wsman`` implementation must be enabled.\"","commit_id":"7ad5e22a6d33aa4e9b29cf99d400f356e79fdc03"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"be510d4ea97d402bb13cfe8e3d34f582f094da25","unresolved":false,"context_lines":[{"line_number":50,"context_line":"The iDRAC driver supports WSMAN for the inspect, management, power,"},{"line_number":51,"context_line":"raid, and vendor interfaces. In addition, it supports Redfish for"},{"line_number":52,"context_line":"the inspect, management, and power interfaces. The iDRAC driver"},{"line_number":53,"context_line":"allows you to mix and match WSMAN and Redfish interfaces. To select"},{"line_number":54,"context_line":"WSMAN for an interface, specify ``idrac-wsman`` when enabling the"},{"line_number":55,"context_line":"interface. To select Redfish for an interface, select ``idrac-redfish``"},{"line_number":56,"context_line":"when enabling the interface."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":".. NOTE::"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_931bcac8","line":55,"range":{"start_line":53,"start_character":58,"end_line":55,"end_character":10},"in_reply_to":"3fa7e38b_504f8869","updated":"2019-10-24 07:49:05.000000000","message":"Done","commit_id":"7ad5e22a6d33aa4e9b29cf99d400f356e79fdc03"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"18bdd3a9158ffb26ec6bd7ed7ecd917513daacda","unresolved":false,"context_lines":[{"line_number":52,"context_line":"the inspect, management, and power interfaces. The iDRAC driver"},{"line_number":53,"context_line":"allows you to mix and match WSMAN and Redfish interfaces. To select"},{"line_number":54,"context_line":"WSMAN for an interface, specify ``idrac-wsman`` when enabling the"},{"line_number":55,"context_line":"interface. To select Redfish for an interface, select ``idrac-redfish``"},{"line_number":56,"context_line":"when enabling the interface."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":".. NOTE::"},{"line_number":59,"context_line":"   Redfish for an interface can only be selected for the inspect,"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_90442049","line":56,"range":{"start_line":55,"start_character":11,"end_line":56,"end_character":28},"updated":"2019-10-24 04:19:27.000000000","message":"Ditto","commit_id":"7ad5e22a6d33aa4e9b29cf99d400f356e79fdc03"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"be510d4ea97d402bb13cfe8e3d34f582f094da25","unresolved":false,"context_lines":[{"line_number":52,"context_line":"the inspect, management, and power interfaces. The iDRAC driver"},{"line_number":53,"context_line":"allows you to mix and match WSMAN and Redfish interfaces. To select"},{"line_number":54,"context_line":"WSMAN for an interface, specify ``idrac-wsman`` when enabling the"},{"line_number":55,"context_line":"interface. To select Redfish for an interface, select ``idrac-redfish``"},{"line_number":56,"context_line":"when enabling the interface."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":".. NOTE::"},{"line_number":59,"context_line":"   Redfish for an interface can only be selected for the inspect,"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_3378d6f6","line":56,"range":{"start_line":55,"start_character":11,"end_line":56,"end_character":28},"in_reply_to":"3fa7e38b_90442049","updated":"2019-10-24 07:49:05.000000000","message":"Done","commit_id":"7ad5e22a6d33aa4e9b29cf99d400f356e79fdc03"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"18bdd3a9158ffb26ec6bd7ed7ecd917513daacda","unresolved":false,"context_lines":[{"line_number":56,"context_line":"when enabling the interface."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":".. NOTE::"},{"line_number":59,"context_line":"   Redfish for an interface can only be selected for the inspect,"},{"line_number":60,"context_line":"   management, and power interfaces at the present time."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":".. NOTE::"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_50eb0811","line":59,"range":{"start_line":59,"start_character":11,"end_line":59,"end_character":52},"updated":"2019-10-24 04:19:27.000000000","message":"Please consider changing this to the following:\n\n\"is supported for only\"","commit_id":"7ad5e22a6d33aa4e9b29cf99d400f356e79fdc03"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"be510d4ea97d402bb13cfe8e3d34f582f094da25","unresolved":false,"context_lines":[{"line_number":56,"context_line":"when enabling the interface."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":".. NOTE::"},{"line_number":59,"context_line":"   Redfish for an interface can only be selected for the inspect,"},{"line_number":60,"context_line":"   management, and power interfaces at the present time."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":".. NOTE::"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_13859acf","line":59,"range":{"start_line":59,"start_character":11,"end_line":59,"end_character":52},"in_reply_to":"3fa7e38b_50eb0811","updated":"2019-10-24 07:49:05.000000000","message":"Done","commit_id":"7ad5e22a6d33aa4e9b29cf99d400f356e79fdc03"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"18bdd3a9158ffb26ec6bd7ed7ecd917513daacda","unresolved":false,"context_lines":[{"line_number":59,"context_line":"   Redfish for an interface can only be selected for the inspect,"},{"line_number":60,"context_line":"   management, and power interfaces at the present time."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":".. NOTE::"},{"line_number":63,"context_line":"   If using WSMAN for the management interface, then WSMAN must be used"},{"line_number":64,"context_line":"   for the power interface and vice versa. It is currently not possible"},{"line_number":65,"context_line":"   to use Redfish for one and WSMAN for the other."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"To enable the ``idrac`` hardware type with the minimum interfaces,"},{"line_number":68,"context_line":"all using WSMAN, add the following to your ``/etc/ironic/ironic.conf``:"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_10cef0b3","line":65,"range":{"start_line":62,"start_character":0,"end_line":65,"end_character":50},"updated":"2019-10-24 04:19:27.000000000","message":"This note would be better placed in the Enrolling section. There is no limitation on the supported interfaces which can be enabled.","commit_id":"7ad5e22a6d33aa4e9b29cf99d400f356e79fdc03"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"be510d4ea97d402bb13cfe8e3d34f582f094da25","unresolved":false,"context_lines":[{"line_number":59,"context_line":"   Redfish for an interface can only be selected for the inspect,"},{"line_number":60,"context_line":"   management, and power interfaces at the present time."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":".. NOTE::"},{"line_number":63,"context_line":"   If using WSMAN for the management interface, then WSMAN must be used"},{"line_number":64,"context_line":"   for the power interface and vice versa. It is currently not possible"},{"line_number":65,"context_line":"   to use Redfish for one and WSMAN for the other."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"To enable the ``idrac`` hardware type with the minimum interfaces,"},{"line_number":68,"context_line":"all using WSMAN, add the following to your ``/etc/ironic/ironic.conf``:"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_56d46047","line":65,"range":{"start_line":62,"start_character":0,"end_line":65,"end_character":50},"in_reply_to":"3fa7e38b_10cef0b3","updated":"2019-10-24 07:49:05.000000000","message":"As there is no such limitation on enablement of supported interfaces, hence removing this note from the document.","commit_id":"7ad5e22a6d33aa4e9b29cf99d400f356e79fdc03"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"4f6e8359944170dba0a12a992a9f00e0d546f2e7","unresolved":false,"context_lines":[{"line_number":59,"context_line":"   Redfish for an interface can only be selected for the inspect,"},{"line_number":60,"context_line":"   management, and power interfaces at the present time."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":".. NOTE::"},{"line_number":63,"context_line":"   If using WSMAN for the management interface, then WSMAN must be used"},{"line_number":64,"context_line":"   for the power interface and vice versa. It is currently not possible"},{"line_number":65,"context_line":"   to use Redfish for one and WSMAN for the other."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"To enable the ``idrac`` hardware type with the minimum interfaces,"},{"line_number":68,"context_line":"all using WSMAN, add the following to your ``/etc/ironic/ironic.conf``:"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_76262a19","line":65,"range":{"start_line":62,"start_character":0,"end_line":65,"end_character":50},"in_reply_to":"3fa7e38b_56d46047","updated":"2019-10-24 20:36:58.000000000","message":"Hey Pranjali, we need to add this note back in.  There are 2 steps to using an interface.  The first step is to enable it in ironic.conf.  That\u0027s what this section is about.  The second step is to tag the node with the interfaces that you want to use.  This is done during enrollment. The note above is about this second step.  I would add this note immediately before the Inspect Interface section.","commit_id":"7ad5e22a6d33aa4e9b29cf99d400f356e79fdc03"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":59,"context_line":"   Redfish for an interface can only be selected for the inspect,"},{"line_number":60,"context_line":"   management, and power interfaces at the present time."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":".. NOTE::"},{"line_number":63,"context_line":"   If using WSMAN for the management interface, then WSMAN must be used"},{"line_number":64,"context_line":"   for the power interface and vice versa. It is currently not possible"},{"line_number":65,"context_line":"   to use Redfish for one and WSMAN for the other."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"To enable the ``idrac`` hardware type with the minimum interfaces,"},{"line_number":68,"context_line":"all using WSMAN, add the following to your ``/etc/ironic/ironic.conf``:"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_0c39e6a1","line":65,"range":{"start_line":62,"start_character":0,"end_line":65,"end_character":50},"in_reply_to":"3fa7e38b_76262a19","updated":"2019-10-25 04:36:18.000000000","message":"+1","commit_id":"7ad5e22a6d33aa4e9b29cf99d400f356e79fdc03"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"18bdd3a9158ffb26ec6bd7ed7ecd917513daacda","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    enabled_power_interfaces\u003didrac-redfish"},{"line_number":88,"context_line":"    enabled_raid_interfaces\u003didrac-wsman"},{"line_number":89,"context_line":"    enabled_vendor_interfaces\u003didrac-wsman"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":".. NOTE::"},{"line_number":92,"context_line":"   The ``idrac`` is the legacy name of the WSMAN interface, implementation"},{"line_number":93,"context_line":"   has been deprecated in favor of ``idrac-wsman`` and may be removed in"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_90a660ab","line":90,"updated":"2019-10-24 04:19:27.000000000","message":"The addition of a table here which lists the supported interface implementations in priority order would be helpful. It would further describe how the examples in the later Enrolling section depend on and are affected by the enabled interfaces.\n\nbios: no-bios\nboot: ipxe, pxe\nconsole: no-console\ndeploy: iscsi, direct, ansible, ramdisk\ninspect: idrac-wsman, idrac, idrac-redfish, inspector, no-inspect\nmanagement: idrac-wsman, idrac, idrac-redfish\nnetwork: flat, neutron, noop\npower:  idrac-wsman, idrac, idrac-redfish\nraid: idrac-wsman, idrac, no-raid\nrescue: no-rescue, agent\nstorage: noop, cinder, external\nvendor: idrac-wsman, idrac, no-vendor","commit_id":"7ad5e22a6d33aa4e9b29cf99d400f356e79fdc03"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"be510d4ea97d402bb13cfe8e3d34f582f094da25","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    enabled_power_interfaces\u003didrac-redfish"},{"line_number":88,"context_line":"    enabled_raid_interfaces\u003didrac-wsman"},{"line_number":89,"context_line":"    enabled_vendor_interfaces\u003didrac-wsman"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":".. NOTE::"},{"line_number":92,"context_line":"   The ``idrac`` is the legacy name of the WSMAN interface, implementation"},{"line_number":93,"context_line":"   has been deprecated in favor of ``idrac-wsman`` and may be removed in"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_b66834ba","line":90,"in_reply_to":"3fa7e38b_90a660ab","updated":"2019-10-24 07:49:05.000000000","message":"Done","commit_id":"7ad5e22a6d33aa4e9b29cf99d400f356e79fdc03"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"789d54df4536590a147f9e2039708abc8162e1b3","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    enabled_vendor_interfaces\u003didrac-wsman"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":".. NOTE::"},{"line_number":92,"context_line":"   The ``idrac`` is the legacy name of the WSMAN interface, implementation"},{"line_number":93,"context_line":"   has been deprecated in favor of ``idrac-wsman`` and may be removed in"},{"line_number":94,"context_line":"   future releases."},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_9b152a9e","line":92,"range":{"start_line":92,"start_character":58,"end_line":92,"end_character":74},"updated":"2019-10-23 19:09:36.000000000","message":". This implementation","commit_id":"7ad5e22a6d33aa4e9b29cf99d400f356e79fdc03"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"18bdd3a9158ffb26ec6bd7ed7ecd917513daacda","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    enabled_vendor_interfaces\u003didrac-wsman"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":".. NOTE::"},{"line_number":92,"context_line":"   The ``idrac`` is the legacy name of the WSMAN interface, implementation"},{"line_number":93,"context_line":"   has been deprecated in favor of ``idrac-wsman`` and may be removed in"},{"line_number":94,"context_line":"   future releases."},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_90eae0d5","line":92,"range":{"start_line":92,"start_character":3,"end_line":92,"end_character":7},"updated":"2019-10-24 04:19:27.000000000","message":"This word can be deleted.","commit_id":"7ad5e22a6d33aa4e9b29cf99d400f356e79fdc03"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"be510d4ea97d402bb13cfe8e3d34f582f094da25","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    enabled_vendor_interfaces\u003didrac-wsman"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":".. NOTE::"},{"line_number":92,"context_line":"   The ``idrac`` is the legacy name of the WSMAN interface, implementation"},{"line_number":93,"context_line":"   has been deprecated in favor of ``idrac-wsman`` and may be removed in"},{"line_number":94,"context_line":"   future releases."},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_33c69618","line":92,"range":{"start_line":92,"start_character":3,"end_line":92,"end_character":7},"in_reply_to":"3fa7e38b_90eae0d5","updated":"2019-10-24 07:49:05.000000000","message":"Done","commit_id":"7ad5e22a6d33aa4e9b29cf99d400f356e79fdc03"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"be510d4ea97d402bb13cfe8e3d34f582f094da25","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    enabled_vendor_interfaces\u003didrac-wsman"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":".. NOTE::"},{"line_number":92,"context_line":"   The ``idrac`` is the legacy name of the WSMAN interface, implementation"},{"line_number":93,"context_line":"   has been deprecated in favor of ``idrac-wsman`` and may be removed in"},{"line_number":94,"context_line":"   future releases."},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_93498ab8","line":92,"range":{"start_line":92,"start_character":58,"end_line":92,"end_character":74},"in_reply_to":"3fa7e38b_9b152a9e","updated":"2019-10-24 07:49:05.000000000","message":"Done","commit_id":"7ad5e22a6d33aa4e9b29cf99d400f356e79fdc03"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"18bdd3a9158ffb26ec6bd7ed7ecd917513daacda","unresolved":false,"context_lines":[{"line_number":93,"context_line":"   has been deprecated in favor of ``idrac-wsman`` and may be removed in"},{"line_number":94,"context_line":"   future releases."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Protocol-specific Authentication Properties"},{"line_number":97,"context_line":"-------------------------------------------"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"The WSMAN and Redfish protocols require different properties to be specific"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_50d46847","line":96,"range":{"start_line":96,"start_character":18,"end_line":96,"end_character":33},"updated":"2019-10-24 04:19:27.000000000","message":"Since the properties cover more than authentication, I suggest this word be deleted.","commit_id":"7ad5e22a6d33aa4e9b29cf99d400f356e79fdc03"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"be510d4ea97d402bb13cfe8e3d34f582f094da25","unresolved":false,"context_lines":[{"line_number":93,"context_line":"   has been deprecated in favor of ``idrac-wsman`` and may be removed in"},{"line_number":94,"context_line":"   future releases."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Protocol-specific Authentication Properties"},{"line_number":97,"context_line":"-------------------------------------------"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"The WSMAN and Redfish protocols require different properties to be specific"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_b3d926f5","line":96,"range":{"start_line":96,"start_character":18,"end_line":96,"end_character":33},"in_reply_to":"3fa7e38b_50d46847","updated":"2019-10-24 07:49:05.000000000","message":"Done","commit_id":"7ad5e22a6d33aa4e9b29cf99d400f356e79fdc03"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"789d54df4536590a147f9e2039708abc8162e1b3","unresolved":false,"context_lines":[{"line_number":96,"context_line":"Protocol-specific Authentication Properties"},{"line_number":97,"context_line":"-------------------------------------------"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"The WSMAN and Redfish protocols require different properties to be specific"},{"line_number":100,"context_line":"in the Ironic node\u0027s ``driver_info`` field to communicate with the bare"},{"line_number":101,"context_line":"metal system\u0027s iDRAC."},{"line_number":102,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_db4162a8","line":99,"range":{"start_line":99,"start_character":67,"end_line":99,"end_character":75},"updated":"2019-10-23 19:09:36.000000000","message":"specified","commit_id":"7ad5e22a6d33aa4e9b29cf99d400f356e79fdc03"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"be510d4ea97d402bb13cfe8e3d34f582f094da25","unresolved":false,"context_lines":[{"line_number":96,"context_line":"Protocol-specific Authentication Properties"},{"line_number":97,"context_line":"-------------------------------------------"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"The WSMAN and Redfish protocols require different properties to be specific"},{"line_number":100,"context_line":"in the Ironic node\u0027s ``driver_info`` field to communicate with the bare"},{"line_number":101,"context_line":"metal system\u0027s iDRAC."},{"line_number":102,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_d3d4e2bd","line":99,"range":{"start_line":99,"start_character":67,"end_line":99,"end_character":75},"in_reply_to":"3fa7e38b_db4162a8","updated":"2019-10-24 07:49:05.000000000","message":"Done","commit_id":"7ad5e22a6d33aa4e9b29cf99d400f356e79fdc03"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"18bdd3a9158ffb26ec6bd7ed7ecd917513daacda","unresolved":false,"context_lines":[{"line_number":114,"context_line":"  communicating with the iDRAC. Usually ``root``."},{"line_number":115,"context_line":"* ``redfish_password``: The password for the Redfish user to use"},{"line_number":116,"context_line":"  when communicating with the iDRAC."},{"line_number":117,"context_line":"* ``redfish_address``: The IP address of the iDRAC."},{"line_number":118,"context_line":"* ``redfish_system_id``: The Redfish ID of the server to be"},{"line_number":119,"context_line":"  managed. This should always be: ``/redfish/v1/Systems/System.Embedded.1``."},{"line_number":120,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_b03d9c2d","line":117,"range":{"start_line":117,"start_character":23,"end_line":117,"end_character":51},"updated":"2019-10-24 04:19:27.000000000","message":"Please consider heavily \"borrowing\" from the generic Redfish driver description of this property.\n\n\"The URL address of the iDRAC. It must include the authority portion of the URL, and can optionally include the scheme. If the scheme is missing, https is assumed.\"","commit_id":"7ad5e22a6d33aa4e9b29cf99d400f356e79fdc03"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"be510d4ea97d402bb13cfe8e3d34f582f094da25","unresolved":false,"context_lines":[{"line_number":114,"context_line":"  communicating with the iDRAC. Usually ``root``."},{"line_number":115,"context_line":"* ``redfish_password``: The password for the Redfish user to use"},{"line_number":116,"context_line":"  when communicating with the iDRAC."},{"line_number":117,"context_line":"* ``redfish_address``: The IP address of the iDRAC."},{"line_number":118,"context_line":"* ``redfish_system_id``: The Redfish ID of the server to be"},{"line_number":119,"context_line":"  managed. This should always be: ``/redfish/v1/Systems/System.Embedded.1``."},{"line_number":120,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_b387e6b6","line":117,"range":{"start_line":117,"start_character":23,"end_line":117,"end_character":51},"in_reply_to":"3fa7e38b_b03d9c2d","updated":"2019-10-24 07:49:05.000000000","message":"Done","commit_id":"7ad5e22a6d33aa4e9b29cf99d400f356e79fdc03"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"789d54df4536590a147f9e2039708abc8162e1b3","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"The Dell iDRAC out-of-band inspection process catalogs all the same"},{"line_number":178,"context_line":"attributes of the server as the IPMI driver.  Unlike IPMI, it does this"},{"line_number":179,"context_line":"without requiring the system to be rebooted, or even to be powered ON."},{"line_number":180,"context_line":"Inspection is performed using the Dell WSMAN or Redfish protocol directly"},{"line_number":181,"context_line":"without affecting the operation of the system being inspected."},{"line_number":182,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_9b63ea41","line":179,"range":{"start_line":179,"start_character":67,"end_line":179,"end_character":69},"updated":"2019-10-23 19:09:36.000000000","message":"on","commit_id":"7ad5e22a6d33aa4e9b29cf99d400f356e79fdc03"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"be510d4ea97d402bb13cfe8e3d34f582f094da25","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"The Dell iDRAC out-of-band inspection process catalogs all the same"},{"line_number":178,"context_line":"attributes of the server as the IPMI driver.  Unlike IPMI, it does this"},{"line_number":179,"context_line":"without requiring the system to be rebooted, or even to be powered ON."},{"line_number":180,"context_line":"Inspection is performed using the Dell WSMAN or Redfish protocol directly"},{"line_number":181,"context_line":"without affecting the operation of the system being inspected."},{"line_number":182,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_d382a2a5","line":179,"range":{"start_line":179,"start_character":67,"end_line":179,"end_character":69},"in_reply_to":"3fa7e38b_9b63ea41","updated":"2019-10-24 07:49:05.000000000","message":"Done","commit_id":"7ad5e22a6d33aa4e9b29cf99d400f356e79fdc03"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"18bdd3a9158ffb26ec6bd7ed7ecd917513daacda","unresolved":false,"context_lines":[{"line_number":195,"context_line":"The ``idrac-wsman`` inspect interface discovers which NIC ports are"},{"line_number":196,"context_line":"configured to PXE boot and sets ``pxe_enabled`` to ``True`` on those ports."},{"line_number":197,"context_line":"The ``idrac-redfish`` inspect interface does not currently set ``pxe_enabled``"},{"line_number":198,"context_line":"on the ports.  The user should ensure that \u0027pxe_enabled\u0027 is set correctly on"},{"line_number":199,"context_line":"the ports following inspection with the ``idrac-redfish`` inspect interface."},{"line_number":200,"context_line":""},{"line_number":201,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_f0b0f4df","line":198,"range":{"start_line":198,"start_character":43,"end_line":198,"end_character":56},"updated":"2019-10-24 04:19:27.000000000","message":"``pxe_enabled``","commit_id":"7ad5e22a6d33aa4e9b29cf99d400f356e79fdc03"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"be510d4ea97d402bb13cfe8e3d34f582f094da25","unresolved":false,"context_lines":[{"line_number":195,"context_line":"The ``idrac-wsman`` inspect interface discovers which NIC ports are"},{"line_number":196,"context_line":"configured to PXE boot and sets ``pxe_enabled`` to ``True`` on those ports."},{"line_number":197,"context_line":"The ``idrac-redfish`` inspect interface does not currently set ``pxe_enabled``"},{"line_number":198,"context_line":"on the ports.  The user should ensure that \u0027pxe_enabled\u0027 is set correctly on"},{"line_number":199,"context_line":"the ports following inspection with the ``idrac-redfish`` inspect interface."},{"line_number":200,"context_line":""},{"line_number":201,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_938c2ad8","line":198,"range":{"start_line":198,"start_character":43,"end_line":198,"end_character":56},"in_reply_to":"3fa7e38b_f0b0f4df","updated":"2019-10-24 07:49:05.000000000","message":"Done","commit_id":"7ad5e22a6d33aa4e9b29cf99d400f356e79fdc03"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":14,"context_line":"iDRAC_ hardware is also supported by the generic ``ipmi`` and ``redfish``"},{"line_number":15,"context_line":"hardware types, though with smaller feature sets."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Key features of the Dell iDRAC driver:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"* Out-of-band node inspection"},{"line_number":20,"context_line":"* Boot device management"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_9c63c7dd","line":17,"range":{"start_line":17,"start_character":31,"end_line":17,"end_character":37},"updated":"2019-10-25 04:36:18.000000000","message":"nit: s/driver/driver include/","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"iDRAC_ hardware is also supported by the generic ``ipmi`` and ``redfish``"},{"line_number":15,"context_line":"hardware types, though with smaller feature sets."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Key features of the Dell iDRAC driver:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"* Out-of-band node inspection"},{"line_number":20,"context_line":"* Boot device management"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_8cf2b6e2","line":17,"range":{"start_line":17,"start_character":31,"end_line":17,"end_character":37},"in_reply_to":"3fa7e38b_9c63c7dd","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Ironic Features"},{"line_number":26,"context_line":"---------------"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"The hardware type ``idrac`` supports the following Ironic interfaces:"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* `Inspect Interface`_: Hardware inspection"},{"line_number":31,"context_line":"* Management Interface : Boot device management"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_fc999bcf","line":28,"range":{"start_line":28,"start_character":18,"end_line":28,"end_character":27},"updated":"2019-10-25 04:36:18.000000000","message":"nit: Let us move this before the preceding \"hardware type\".","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Ironic Features"},{"line_number":26,"context_line":"---------------"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"The hardware type ``idrac`` supports the following Ironic interfaces:"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* `Inspect Interface`_: Hardware inspection"},{"line_number":31,"context_line":"* Management Interface : Boot device management"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_2c0142b0","line":28,"range":{"start_line":28,"start_character":18,"end_line":28,"end_character":27},"in_reply_to":"3fa7e38b_fc999bcf","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"The hardware type ``idrac`` supports the following Ironic interfaces:"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* `Inspect Interface`_: Hardware inspection"},{"line_number":31,"context_line":"* Management Interface : Boot device management"},{"line_number":32,"context_line":"* Power Interface : Power management"},{"line_number":33,"context_line":"* `RAID Interface`_: RAID controller and disk management"},{"line_number":34,"context_line":"* `Vendor Interface`_: BIOS management"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_bca32300","line":31,"range":{"start_line":31,"start_character":22,"end_line":31,"end_character":23},"updated":"2019-10-25 04:36:18.000000000","message":"nit: Extra space","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"The hardware type ``idrac`` supports the following Ironic interfaces:"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* `Inspect Interface`_: Hardware inspection"},{"line_number":31,"context_line":"* Management Interface : Boot device management"},{"line_number":32,"context_line":"* Power Interface : Power management"},{"line_number":33,"context_line":"* `RAID Interface`_: RAID controller and disk management"},{"line_number":34,"context_line":"* `Vendor Interface`_: BIOS management"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_ec2c8a4b","line":31,"range":{"start_line":31,"start_character":22,"end_line":31,"end_character":23},"in_reply_to":"3fa7e38b_bca32300","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* `Inspect Interface`_: Hardware inspection"},{"line_number":31,"context_line":"* Management Interface : Boot device management"},{"line_number":32,"context_line":"* Power Interface : Power management"},{"line_number":33,"context_line":"* `RAID Interface`_: RAID controller and disk management"},{"line_number":34,"context_line":"* `Vendor Interface`_: BIOS management"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_dca61f10","line":32,"range":{"start_line":32,"start_character":17,"end_line":32,"end_character":18},"updated":"2019-10-25 04:36:18.000000000","message":"Ditto","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* `Inspect Interface`_: Hardware inspection"},{"line_number":31,"context_line":"* Management Interface : Boot device management"},{"line_number":32,"context_line":"* Power Interface : Power management"},{"line_number":33,"context_line":"* `RAID Interface`_: RAID controller and disk management"},{"line_number":34,"context_line":"* `Vendor Interface`_: BIOS management"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_0c30069e","line":32,"range":{"start_line":32,"start_character":17,"end_line":32,"end_character":18},"in_reply_to":"3fa7e38b_dca61f10","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":37,"context_line":"-------------"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The ``idrac`` hardware type requires the ``python-dracclient`` library"},{"line_number":40,"context_line":"to be installed on the ironic conductor node(s) if configured to use an"},{"line_number":41,"context_line":"``idrac-wsman`` interface implementation, for example::"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    sudo pip install \u0027python-dracclient\u003e\u003d3.1.0\u0027"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_3ce5f338","line":40,"range":{"start_line":40,"start_character":51,"end_line":40,"end_character":61},"updated":"2019-10-25 04:36:18.000000000","message":"Please insert \"an Ironic node is\" immediately before this.","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"-------------"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The ``idrac`` hardware type requires the ``python-dracclient`` library"},{"line_number":40,"context_line":"to be installed on the ironic conductor node(s) if configured to use an"},{"line_number":41,"context_line":"``idrac-wsman`` interface implementation, for example::"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    sudo pip install \u0027python-dracclient\u003e\u003d3.1.0\u0027"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_8c1b961a","line":40,"range":{"start_line":40,"start_character":51,"end_line":40,"end_character":61},"in_reply_to":"3fa7e38b_3ce5f338","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    sudo pip install \u0027python-dracclient\u003e\u003d3.1.0\u0027"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Additionally, the ``idrac`` hardware type requires ``sushy`` library to"},{"line_number":46,"context_line":"be installed on the ironic conductor node(s) if configured to use an"},{"line_number":47,"context_line":"``idrac-redfish`` interface implementation, for example::"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_bcca439e","line":45,"range":{"start_line":45,"start_character":51,"end_line":45,"end_character":60},"updated":"2019-10-25 04:36:18.000000000","message":"Please insert \"the\" before this.","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    sudo pip install \u0027python-dracclient\u003e\u003d3.1.0\u0027"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Additionally, the ``idrac`` hardware type requires ``sushy`` library to"},{"line_number":46,"context_line":"be installed on the ironic conductor node(s) if configured to use an"},{"line_number":47,"context_line":"``idrac-redfish`` interface implementation, for example::"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_4c159ee4","line":45,"range":{"start_line":45,"start_character":51,"end_line":45,"end_character":60},"in_reply_to":"3fa7e38b_bcca439e","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    sudo pip install \u0027python-dracclient\u003e\u003d3.1.0\u0027"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Additionally, the ``idrac`` hardware type requires ``sushy`` library to"},{"line_number":46,"context_line":"be installed on the ironic conductor node(s) if configured to use an"},{"line_number":47,"context_line":"``idrac-redfish`` interface implementation, for example::"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"   sudo pip install \u0027python-dracclient\u003e\u003d3.1.0\u0027 \u0027sushy\u003e\u003d2.0.0\u0027"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_5ce0ef26","line":46,"range":{"start_line":46,"start_character":48,"end_line":46,"end_character":58},"updated":"2019-10-25 04:36:18.000000000","message":"Ditto","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    sudo pip install \u0027python-dracclient\u003e\u003d3.1.0\u0027"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Additionally, the ``idrac`` hardware type requires ``sushy`` library to"},{"line_number":46,"context_line":"be installed on the ironic conductor node(s) if configured to use an"},{"line_number":47,"context_line":"``idrac-redfish`` interface implementation, for example::"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"   sudo pip install \u0027python-dracclient\u003e\u003d3.1.0\u0027 \u0027sushy\u003e\u003d2.0.0\u0027"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_ecd1ea30","line":46,"range":{"start_line":46,"start_character":48,"end_line":46,"end_character":58},"in_reply_to":"3fa7e38b_5ce0ef26","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    enabled_management_interfaces\u003didrac-wsman"},{"line_number":75,"context_line":"    enabled_power_interfaces\u003didrac-wsman"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"To enable all optional features (inspection, RAID and vendor passthru)"},{"line_number":78,"context_line":"using Redfish where it is supported and WSMAN where not, use the"},{"line_number":79,"context_line":"following configuration:"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_892148ff","line":77,"range":{"start_line":77,"start_character":45,"end_line":77,"end_character":49},"updated":"2019-10-25 04:36:18.000000000","message":"nit: \u0027RAID,\u0027 with a comma","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    enabled_management_interfaces\u003didrac-wsman"},{"line_number":75,"context_line":"    enabled_power_interfaces\u003didrac-wsman"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"To enable all optional features (inspection, RAID and vendor passthru)"},{"line_number":78,"context_line":"using Redfish where it is supported and WSMAN where not, use the"},{"line_number":79,"context_line":"following configuration:"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_6ce5fa09","line":77,"range":{"start_line":77,"start_character":45,"end_line":77,"end_character":49},"in_reply_to":"3fa7e38b_892148ff","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    enabled_raid_interfaces\u003didrac-wsman"},{"line_number":89,"context_line":"    enabled_vendor_interfaces\u003didrac-wsman"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Below is the list of  ``supported interface implementations`` in priority"},{"line_number":92,"context_line":"order:"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d     \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_485351e3","line":91,"range":{"start_line":91,"start_character":22,"end_line":91,"end_character":61},"updated":"2019-10-25 04:36:18.000000000","message":"nit: Plain old text may be more appropriate. This is not a literal.","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    enabled_raid_interfaces\u003didrac-wsman"},{"line_number":89,"context_line":"    enabled_vendor_interfaces\u003didrac-wsman"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Below is the list of  ``supported interface implementations`` in priority"},{"line_number":92,"context_line":"order:"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d     \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_8ce076fa","line":91,"range":{"start_line":91,"start_character":22,"end_line":91,"end_character":61},"in_reply_to":"3fa7e38b_485351e3","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":92,"context_line":"order:"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d     \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":95,"context_line":"Interfaces       Supported implementations"},{"line_number":96,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d     \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":97,"context_line":"bios             no-bios"},{"line_number":98,"context_line":"boot             ipxe, pxe"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_4849115e","line":95,"range":{"start_line":95,"start_character":27,"end_line":95,"end_character":42},"updated":"2019-10-25 04:36:18.000000000","message":"nit: Let us capitalize the column headings, just like a table later in this documentation. Please change this to \u0027Implementations\u0027, with a capital \u0027I\u0027.","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":92,"context_line":"order:"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d     \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":95,"context_line":"Interfaces       Supported implementations"},{"line_number":96,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d     \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":97,"context_line":"bios             no-bios"},{"line_number":98,"context_line":"boot             ipxe, pxe"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_68164d4c","line":95,"range":{"start_line":95,"start_character":0,"end_line":95,"end_character":10},"updated":"2019-10-25 04:36:18.000000000","message":"nit: singular \u0027Interface\u0027, instead.","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":92,"context_line":"order:"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d     \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":95,"context_line":"Interfaces       Supported implementations"},{"line_number":96,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d     \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":97,"context_line":"bios             no-bios"},{"line_number":98,"context_line":"boot             ipxe, pxe"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_8cc9567a","line":95,"range":{"start_line":95,"start_character":27,"end_line":95,"end_character":42},"in_reply_to":"3fa7e38b_4849115e","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":92,"context_line":"order:"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d     \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":95,"context_line":"Interfaces       Supported implementations"},{"line_number":96,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d     \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":97,"context_line":"bios             no-bios"},{"line_number":98,"context_line":"boot             ipxe, pxe"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_2cc86272","line":95,"range":{"start_line":95,"start_character":0,"end_line":95,"end_character":10},"in_reply_to":"3fa7e38b_68164d4c","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":94,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d     \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":95,"context_line":"Interfaces       Supported implementations"},{"line_number":96,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d     \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":97,"context_line":"bios             no-bios"},{"line_number":98,"context_line":"boot             ipxe, pxe"},{"line_number":99,"context_line":"console          no-console"},{"line_number":100,"context_line":"deploy           iscsi, direct, ansible, ramdisk"},{"line_number":101,"context_line":"inspect          idrac-wsman, idrac, idrac-redfish, inspector, no-inspect"},{"line_number":102,"context_line":"management       idrac-wsman, idrac, idrac-redfish"},{"line_number":103,"context_line":"network          flat, neutron, noop"},{"line_number":104,"context_line":"power            idrac-wsman, idrac, idrac-redfish"},{"line_number":105,"context_line":"raid             idrac-wsman, idrac, no-raid"},{"line_number":106,"context_line":"rescue           no-rescue, agent"},{"line_number":107,"context_line":"storage          noop, cinder, external"},{"line_number":108,"context_line":"vendor           idrac-wsman, idrac, no-vendor"},{"line_number":109,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d     \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":".. NOTE::"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_289db5ba","line":108,"range":{"start_line":97,"start_character":0,"end_line":108,"end_character":46},"updated":"2019-10-25 04:36:18.000000000","message":"I am thinking these should be formatted as in-line literals, e.g.,\n\n    ``bios``             ``no-bios``","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":94,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d     \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":95,"context_line":"Interfaces       Supported implementations"},{"line_number":96,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d     \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":97,"context_line":"bios             no-bios"},{"line_number":98,"context_line":"boot             ipxe, pxe"},{"line_number":99,"context_line":"console          no-console"},{"line_number":100,"context_line":"deploy           iscsi, direct, ansible, ramdisk"},{"line_number":101,"context_line":"inspect          idrac-wsman, idrac, idrac-redfish, inspector, no-inspect"},{"line_number":102,"context_line":"management       idrac-wsman, idrac, idrac-redfish"},{"line_number":103,"context_line":"network          flat, neutron, noop"},{"line_number":104,"context_line":"power            idrac-wsman, idrac, idrac-redfish"},{"line_number":105,"context_line":"raid             idrac-wsman, idrac, no-raid"},{"line_number":106,"context_line":"rescue           no-rescue, agent"},{"line_number":107,"context_line":"storage          noop, cinder, external"},{"line_number":108,"context_line":"vendor           idrac-wsman, idrac, no-vendor"},{"line_number":109,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d     \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":".. NOTE::"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_4cc35e58","line":108,"range":{"start_line":97,"start_character":0,"end_line":108,"end_character":46},"in_reply_to":"3fa7e38b_289db5ba","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"4f6e8359944170dba0a12a992a9f00e0d546f2e7","unresolved":false,"context_lines":[{"line_number":109,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d     \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":".. NOTE::"},{"line_number":112,"context_line":"   This implementation ``idrac`` is the legacy name of the WSMAN interface"},{"line_number":113,"context_line":"   has been deprecated in favor of ``idrac-wsman`` and may be removed in"},{"line_number":114,"context_line":"   future releases."},{"line_number":115,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_5670ce08","line":112,"updated":"2019-10-24 20:36:58.000000000","message":"Please change this paragraph to:\n``idrac`` is the legacy name of the WSMAN interface.  It has been deprecated in favor of ``idrac-wsman`` and may be removed in future releases.","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":109,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d     \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":".. NOTE::"},{"line_number":112,"context_line":"   This implementation ``idrac`` is the legacy name of the WSMAN interface"},{"line_number":113,"context_line":"   has been deprecated in favor of ``idrac-wsman`` and may be removed in"},{"line_number":114,"context_line":"   future releases."},{"line_number":115,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_6902cc40","line":112,"in_reply_to":"3fa7e38b_5670ce08","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":".. NOTE::"},{"line_number":112,"context_line":"   This implementation ``idrac`` is the legacy name of the WSMAN interface"},{"line_number":113,"context_line":"   has been deprecated in favor of ``idrac-wsman`` and may be removed in"},{"line_number":114,"context_line":"   future releases."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Protocol-specific Properties"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_fc03dbbc","line":113,"range":{"start_line":113,"start_character":35,"end_line":113,"end_character":50},"updated":"2019-10-25 04:36:18.000000000","message":"nit: How about a comma after this second item?","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":111,"context_line":".. NOTE::"},{"line_number":112,"context_line":"   This implementation ``idrac`` is the legacy name of the WSMAN interface"},{"line_number":113,"context_line":"   has been deprecated in favor of ``idrac-wsman`` and may be removed in"},{"line_number":114,"context_line":"   future releases."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Protocol-specific Properties"},{"line_number":117,"context_line":"----------------------------"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_bc0d63e9","line":114,"range":{"start_line":114,"start_character":3,"end_line":114,"end_character":18},"updated":"2019-10-25 04:36:18.000000000","message":"nit: This could be singular, instead -- \"a future release\".","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":111,"context_line":".. NOTE::"},{"line_number":112,"context_line":"   This implementation ``idrac`` is the legacy name of the WSMAN interface"},{"line_number":113,"context_line":"   has been deprecated in favor of ``idrac-wsman`` and may be removed in"},{"line_number":114,"context_line":"   future releases."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Protocol-specific Properties"},{"line_number":117,"context_line":"----------------------------"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_0c8c8633","line":114,"range":{"start_line":114,"start_character":3,"end_line":114,"end_character":18},"in_reply_to":"3fa7e38b_bc0d63e9","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":120,"context_line":"in the Ironic node\u0027s ``driver_info`` field to communicate with the bare"},{"line_number":121,"context_line":"metal system\u0027s iDRAC."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"The ``WSMAN protocol`` requires the following properties:"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"* ``drac_username``: The WSMAN user name to use when communicating"},{"line_number":126,"context_line":"  with the iDRAC. Usually ``root``."}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_7cf7ebd5","line":123,"range":{"start_line":123,"start_character":4,"end_line":123,"end_character":22},"updated":"2019-10-25 04:36:18.000000000","message":"nit: Plain old text may be more appropriate, since this is not a literal.","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":120,"context_line":"in the Ironic node\u0027s ``driver_info`` field to communicate with the bare"},{"line_number":121,"context_line":"metal system\u0027s iDRAC."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"The ``WSMAN protocol`` requires the following properties:"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"* ``drac_username``: The WSMAN user name to use when communicating"},{"line_number":126,"context_line":"  with the iDRAC. Usually ``root``."}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_cc850e09","line":123,"range":{"start_line":123,"start_character":4,"end_line":123,"end_character":22},"in_reply_to":"3fa7e38b_7cf7ebd5","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":128,"context_line":"  communicating with the iDRAC."},{"line_number":129,"context_line":"* ``drac_address``: The IP address of the iDRAC."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"The ``Redfish protocol`` requires the following properties:"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"* ``redfish_username``: The Redfish user name to use when"},{"line_number":134,"context_line":"  communicating with the iDRAC. Usually ``root``."}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_5cfc6fb4","line":131,"range":{"start_line":131,"start_character":4,"end_line":131,"end_character":24},"updated":"2019-10-25 04:36:18.000000000","message":"Ditto","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":128,"context_line":"  communicating with the iDRAC."},{"line_number":129,"context_line":"* ``drac_address``: The IP address of the iDRAC."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"The ``Redfish protocol`` requires the following properties:"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"* ``redfish_username``: The Redfish user name to use when"},{"line_number":134,"context_line":"  communicating with the iDRAC. Usually ``root``."}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_6c7c1a20","line":131,"range":{"start_line":131,"start_character":4,"end_line":131,"end_character":24},"in_reply_to":"3fa7e38b_5cfc6fb4","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":149,"context_line":"Enrolling"},{"line_number":150,"context_line":"---------"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"The following command will enroll a bare metal node with the ``idrac``"},{"line_number":153,"context_line":"hardware type using ``WSMAN`` for all interfaces:"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":".. code-block:: bash"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_9c1bc71a","line":152,"range":{"start_line":152,"start_character":22,"end_line":152,"end_character":33},"updated":"2019-10-25 04:36:18.000000000","message":"nit: s/will enroll/enrolls/","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":149,"context_line":"Enrolling"},{"line_number":150,"context_line":"---------"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"The following command will enroll a bare metal node with the ``idrac``"},{"line_number":153,"context_line":"hardware type using ``WSMAN`` for all interfaces:"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":".. code-block:: bash"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_ec8d6a2a","line":152,"range":{"start_line":152,"start_character":22,"end_line":152,"end_character":33},"in_reply_to":"3fa7e38b_9c1bc71a","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        --driver-info drac_username\u003duser \\"},{"line_number":160,"context_line":"        --driver-info drac_password\u003dpa$$w0rd"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"The following command will enroll a bare metal node with the ``idrac``"},{"line_number":163,"context_line":"hardware type using ``Redfish`` for all interfaces:"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":".. code-block:: bash"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_3c1ad316","line":162,"range":{"start_line":162,"start_character":22,"end_line":162,"end_character":33},"updated":"2019-10-25 04:36:18.000000000","message":"Ditto","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        --driver-info drac_username\u003duser \\"},{"line_number":160,"context_line":"        --driver-info drac_password\u003dpa$$w0rd"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"The following command will enroll a bare metal node with the ``idrac``"},{"line_number":163,"context_line":"hardware type using ``Redfish`` for all interfaces:"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":".. code-block:: bash"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_0c91e646","line":162,"range":{"start_line":162,"start_character":22,"end_line":162,"end_character":33},"in_reply_to":"3fa7e38b_3c1ad316","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        --vendor-interface no-vendor \\"},{"line_number":176,"context_line":"        --raid-interface no-raid"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"The following command will enroll a bare metal node with the ``idrac``"},{"line_number":179,"context_line":"hardware type assuming a mix of ``Redfish and WSMAN`` interfaces are used:"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":".. code-block:: bash"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_fcbafbde","line":178,"range":{"start_line":178,"start_character":22,"end_line":178,"end_character":33},"updated":"2019-10-25 04:36:18.000000000","message":"Ditto","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        --vendor-interface no-vendor \\"},{"line_number":176,"context_line":"        --raid-interface no-raid"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"The following command will enroll a bare metal node with the ``idrac``"},{"line_number":179,"context_line":"hardware type assuming a mix of ``Redfish and WSMAN`` interfaces are used:"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":".. code-block:: bash"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_ac97723a","line":178,"range":{"start_line":178,"start_character":22,"end_line":178,"end_character":33},"in_reply_to":"3fa7e38b_fcbafbde","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"4f6e8359944170dba0a12a992a9f00e0d546f2e7","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        --inspect-interface idrac-redfish \\"},{"line_number":192,"context_line":"        --management-interface idrac-redfish \\"},{"line_number":193,"context_line":"        --power-interface idrac-redfish"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"Inspect Interface"},{"line_number":197,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_167b36f4","line":194,"updated":"2019-10-24 20:36:58.000000000","message":"Please add this note here:\n.. NOTE::\n   If using WSMAN for the management interface, then WSMAN must be used\n   for the power interface and vice versa. It is currently not possible\n   to use Redfish for one and WSMAN for the other.","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        --inspect-interface idrac-redfish \\"},{"line_number":192,"context_line":"        --management-interface idrac-redfish \\"},{"line_number":193,"context_line":"        --power-interface idrac-redfish"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"Inspect Interface"},{"line_number":197,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_49f7d05a","line":194,"in_reply_to":"3fa7e38b_167b36f4","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"See :doc:`/admin/raid` for more information on Ironic RAID support."},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"The following properties are supported by the iDRAC RAID driver:"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"Mandatory properties"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_2975b4fa","line":229,"range":{"start_line":229,"start_character":46,"end_line":229,"end_character":63},"updated":"2019-10-25 04:36:18.000000000","message":"Actually, they are supported by the iDRAC WSMAN raid interface implementation, idrac-wsman.","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"See :doc:`/admin/raid` for more information on Ironic RAID support."},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"The following properties are supported by the iDRAC RAID driver:"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"Mandatory properties"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_6ca17a95","line":229,"range":{"start_line":229,"start_character":46,"end_line":229,"end_character":63},"in_reply_to":"3fa7e38b_2975b4fa","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":232,"context_line":"Mandatory properties"},{"line_number":233,"context_line":"--------------------"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"* ``size_gb``: Size in GiB (Integer) for the logical disk. Use ``MAX`` as"},{"line_number":236,"context_line":"  size_gb if this logical disk is supposed to use the rest of the space available."},{"line_number":237,"context_line":"* ``raid_level``: RAID level for the logical disk. Valid values are"},{"line_number":238,"context_line":"  \u00270\u0027, \u00271\u0027, \u00275\u0027, \u00276\u0027, \u00271+0\u0027, \u00275+0\u0027 and \u00276+0\u0027."}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_89fdc83c","line":235,"range":{"start_line":235,"start_character":23,"end_line":235,"end_character":36},"updated":"2019-10-25 04:36:18.000000000","message":"nit: \"gigabytes (integer)\"","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":232,"context_line":"Mandatory properties"},{"line_number":233,"context_line":"--------------------"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"* ``size_gb``: Size in GiB (Integer) for the logical disk. Use ``MAX`` as"},{"line_number":236,"context_line":"  size_gb if this logical disk is supposed to use the rest of the space available."},{"line_number":237,"context_line":"* ``raid_level``: RAID level for the logical disk. Valid values are"},{"line_number":238,"context_line":"  \u00270\u0027, \u00271\u0027, \u00275\u0027, \u00276\u0027, \u00271+0\u0027, \u00275+0\u0027 and \u00276+0\u0027."}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_4ca6fead","line":235,"range":{"start_line":235,"start_character":23,"end_line":235,"end_character":36},"in_reply_to":"3fa7e38b_89fdc83c","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":233,"context_line":"--------------------"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"* ``size_gb``: Size in GiB (Integer) for the logical disk. Use ``MAX`` as"},{"line_number":236,"context_line":"  size_gb if this logical disk is supposed to use the rest of the space available."},{"line_number":237,"context_line":"* ``raid_level``: RAID level for the logical disk. Valid values are"},{"line_number":238,"context_line":"  \u00270\u0027, \u00271\u0027, \u00275\u0027, \u00276\u0027, \u00271+0\u0027, \u00275+0\u0027 and \u00276+0\u0027."},{"line_number":239,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_c9a0a045","line":236,"range":{"start_line":236,"start_character":2,"end_line":236,"end_character":9},"updated":"2019-10-25 04:36:18.000000000","message":"Literal?","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":233,"context_line":"--------------------"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"* ``size_gb``: Size in GiB (Integer) for the logical disk. Use ``MAX`` as"},{"line_number":236,"context_line":"  size_gb if this logical disk is supposed to use the rest of the space available."},{"line_number":237,"context_line":"* ``raid_level``: RAID level for the logical disk. Valid values are"},{"line_number":238,"context_line":"  \u00270\u0027, \u00271\u0027, \u00275\u0027, \u00276\u0027, \u00271+0\u0027, \u00275+0\u0027 and \u00276+0\u0027."},{"line_number":239,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_2cc4e23f","line":236,"range":{"start_line":236,"start_character":2,"end_line":236,"end_character":9},"in_reply_to":"3fa7e38b_c9a0a045","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":235,"context_line":"* ``size_gb``: Size in GiB (Integer) for the logical disk. Use ``MAX`` as"},{"line_number":236,"context_line":"  size_gb if this logical disk is supposed to use the rest of the space available."},{"line_number":237,"context_line":"* ``raid_level``: RAID level for the logical disk. Valid values are"},{"line_number":238,"context_line":"  \u00270\u0027, \u00271\u0027, \u00275\u0027, \u00276\u0027, \u00271+0\u0027, \u00275+0\u0027 and \u00276+0\u0027."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":".. NOTE::"},{"line_number":241,"context_line":"  \u0027JBOD\u0027 and \u00272\u0027 are not supported, and will fail with reason: \u0027Cannot"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_e9931cff","line":238,"range":{"start_line":238,"start_character":2,"end_line":238,"end_character":44},"updated":"2019-10-25 04:36:18.000000000","message":"Should these be literals, e.g., ``0``?","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":235,"context_line":"* ``size_gb``: Size in GiB (Integer) for the logical disk. Use ``MAX`` as"},{"line_number":236,"context_line":"  size_gb if this logical disk is supposed to use the rest of the space available."},{"line_number":237,"context_line":"* ``raid_level``: RAID level for the logical disk. Valid values are"},{"line_number":238,"context_line":"  \u00270\u0027, \u00271\u0027, \u00275\u0027, \u00276\u0027, \u00271+0\u0027, \u00275+0\u0027 and \u00276+0\u0027."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":".. NOTE::"},{"line_number":241,"context_line":"  \u0027JBOD\u0027 and \u00272\u0027 are not supported, and will fail with reason: \u0027Cannot"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_cce8aeb4","line":238,"range":{"start_line":238,"start_character":2,"end_line":238,"end_character":44},"in_reply_to":"3fa7e38b_e9931cff","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":238,"context_line":"  \u00270\u0027, \u00271\u0027, \u00275\u0027, \u00276\u0027, \u00271+0\u0027, \u00275+0\u0027 and \u00276+0\u0027."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":".. NOTE::"},{"line_number":241,"context_line":"  \u0027JBOD\u0027 and \u00272\u0027 are not supported, and will fail with reason: \u0027Cannot"},{"line_number":242,"context_line":"  calculate spans for RAID level.\u0027"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"Optional properties"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_a99d240b","line":241,"range":{"start_line":241,"start_character":2,"end_line":241,"end_character":16},"updated":"2019-10-25 04:36:18.000000000","message":"Ditto","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":238,"context_line":"  \u00270\u0027, \u00271\u0027, \u00275\u0027, \u00276\u0027, \u00271+0\u0027, \u00275+0\u0027 and \u00276+0\u0027."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":".. NOTE::"},{"line_number":241,"context_line":"  \u0027JBOD\u0027 and \u00272\u0027 are not supported, and will fail with reason: \u0027Cannot"},{"line_number":242,"context_line":"  calculate spans for RAID level.\u0027"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"Optional properties"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_6ccf3a57","line":241,"range":{"start_line":241,"start_character":2,"end_line":241,"end_character":16},"in_reply_to":"3fa7e38b_a99d240b","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":245,"context_line":"-------------------"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"* ``is_root_volume``: Optional. Specifies whether this disk is a root volume."},{"line_number":248,"context_line":"  By default, this is False."},{"line_number":249,"context_line":"* ``volume_name``: Optional. Name of the volume to be created. If this is not"},{"line_number":250,"context_line":"  specified, it will be auto-generated."},{"line_number":251,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_29061422","line":248,"range":{"start_line":248,"start_character":22,"end_line":248,"end_character":27},"updated":"2019-10-25 04:36:18.000000000","message":"Literal?","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":245,"context_line":"-------------------"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"* ``is_root_volume``: Optional. Specifies whether this disk is a root volume."},{"line_number":248,"context_line":"  By default, this is False."},{"line_number":249,"context_line":"* ``volume_name``: Optional. Name of the volume to be created. If this is not"},{"line_number":250,"context_line":"  specified, it will be auto-generated."},{"line_number":251,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_8ccab643","line":248,"range":{"start_line":248,"start_character":22,"end_line":248,"end_character":27},"in_reply_to":"3fa7e38b_29061422","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"See :doc:`/admin/raid` for more information on backing disk hints."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"These are machine-independent information. These hints are specified for each"},{"line_number":258,"context_line":"logical disk to let Ironic find the desired disks for RAID configuration."},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"* ``disk_type``"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_49011006","line":257,"range":{"start_line":257,"start_character":43,"end_line":257,"end_character":48},"updated":"2019-10-25 04:36:18.000000000","message":"nit: s/These/The/","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"See :doc:`/admin/raid` for more information on backing disk hints."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"These are machine-independent information. These hints are specified for each"},{"line_number":258,"context_line":"logical disk to let Ironic find the desired disks for RAID configuration."},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"* ``disk_type``"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_4cd4bee9","line":257,"range":{"start_line":257,"start_character":43,"end_line":257,"end_character":48},"in_reply_to":"3fa7e38b_49011006","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":255,"context_line":"See :doc:`/admin/raid` for more information on backing disk hints."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"These are machine-independent information. These hints are specified for each"},{"line_number":258,"context_line":"logical disk to let Ironic find the desired disks for RAID configuration."},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"* ``disk_type``"},{"line_number":261,"context_line":"* ``interface_type``"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_8982a8a4","line":258,"range":{"start_line":258,"start_character":16,"end_line":258,"end_character":19},"updated":"2019-10-25 04:36:18.000000000","message":"nit: s/let/help/","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":255,"context_line":"See :doc:`/admin/raid` for more information on backing disk hints."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"These are machine-independent information. These hints are specified for each"},{"line_number":258,"context_line":"logical disk to let Ironic find the desired disks for RAID configuration."},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"* ``disk_type``"},{"line_number":261,"context_line":"* ``interface_type``"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_ec048a80","line":258,"range":{"start_line":258,"start_character":16,"end_line":258,"end_character":19},"in_reply_to":"3fa7e38b_8982a8a4","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":265,"context_line":"Backing physical disks"},{"line_number":266,"context_line":"----------------------"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"These are Dell RAID controller specific values and must match the"},{"line_number":269,"context_line":"names as provided by the iDRAC."},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"* ``controller``: Mandatory. The name of the controller to use."}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_299134f2","line":268,"range":{"start_line":268,"start_character":20,"end_line":268,"end_character":39},"updated":"2019-10-25 04:36:18.000000000","message":"\u0027controller-specific\u0027, with a hyphen?","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":265,"context_line":"Backing physical disks"},{"line_number":266,"context_line":"----------------------"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"These are Dell RAID controller specific values and must match the"},{"line_number":269,"context_line":"names as provided by the iDRAC."},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"* ``controller``: Mandatory. The name of the controller to use."}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_0c08068f","line":268,"range":{"start_line":268,"start_character":20,"end_line":268,"end_character":39},"in_reply_to":"3fa7e38b_299134f2","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":266,"context_line":"----------------------"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"These are Dell RAID controller specific values and must match the"},{"line_number":269,"context_line":"names as provided by the iDRAC."},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"* ``controller``: Mandatory. The name of the controller to use."},{"line_number":272,"context_line":"* ``physical_disks``: Optional. The names of the physical disks to use."}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_498cb0d6","line":269,"range":{"start_line":269,"start_character":6,"end_line":269,"end_character":9},"updated":"2019-10-25 04:36:18.000000000","message":"I believe this word is unnecessary.","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":266,"context_line":"----------------------"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"These are Dell RAID controller specific values and must match the"},{"line_number":269,"context_line":"names as provided by the iDRAC."},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"* ``controller``: Mandatory. The name of the controller to use."},{"line_number":272,"context_line":"* ``physical_disks``: Optional. The names of the physical disks to use."}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_acfe9268","line":269,"range":{"start_line":269,"start_character":6,"end_line":269,"end_character":9},"in_reply_to":"3fa7e38b_498cb0d6","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":277,"context_line":"Examples"},{"line_number":278,"context_line":"--------"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"Creation of RAID 1+0 logical disk with 6 disks on one controller:"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":".. code-block:: json"},{"line_number":283,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_09c0f8df","line":280,"range":{"start_line":280,"start_character":39,"end_line":280,"end_character":40},"updated":"2019-10-25 04:36:18.000000000","message":"nit: Please spell this out -- \u0027six\u0027.","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":277,"context_line":"Examples"},{"line_number":278,"context_line":"--------"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"Creation of RAID 1+0 logical disk with 6 disks on one controller:"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":".. code-block:: json"},{"line_number":283,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_e9bc7c6d","line":280,"range":{"start_line":280,"start_character":17,"end_line":280,"end_character":20},"updated":"2019-10-25 04:36:18.000000000","message":"nit: literal?","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":277,"context_line":"Examples"},{"line_number":278,"context_line":"--------"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"Creation of RAID 1+0 logical disk with 6 disks on one controller:"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":".. code-block:: json"},{"line_number":283,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_6cf89a7b","line":280,"range":{"start_line":280,"start_character":39,"end_line":280,"end_character":40},"in_reply_to":"3fa7e38b_09c0f8df","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":277,"context_line":"Examples"},{"line_number":278,"context_line":"--------"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"Creation of RAID 1+0 logical disk with 6 disks on one controller:"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":".. code-block:: json"},{"line_number":283,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_8cf3969f","line":280,"range":{"start_line":280,"start_character":17,"end_line":280,"end_character":20},"in_reply_to":"3fa7e38b_e9bc7c6d","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":298,"context_line":"Manual RAID Invocation"},{"line_number":299,"context_line":"----------------------"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"The following command can be used to delete any existing RAID configuration:"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":".. code-block:: bash"},{"line_number":304,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_6c117a53","line":301,"range":{"start_line":301,"start_character":37,"end_line":301,"end_character":75},"updated":"2019-10-25 04:36:18.000000000","message":"Do we want to provide a bit more detail about what this entails, deletion of all virtual disks/RAID volumes, unassignment of all hot spare physical disks, and clearing of foreign configuration?","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":298,"context_line":"Manual RAID Invocation"},{"line_number":299,"context_line":"----------------------"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"The following command can be used to delete any existing RAID configuration:"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":".. code-block:: bash"},{"line_number":304,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_5fd9bef1","line":301,"range":{"start_line":301,"start_character":37,"end_line":301,"end_character":75},"in_reply_to":"3fa7e38b_6c117a53","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":329,"context_line":"    \u0027[{\"interface\": \"raid\", \"step\": \"create_configuration\"}]\u0027 ${node_uuid}"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"In the case where the physical disk names or controller names are not"},{"line_number":333,"context_line":"known, the following python code example shows how the python-dracclient"},{"line_number":334,"context_line":"can be used to fetch the information directly from the Dell server:"},{"line_number":335,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_6923acbf","line":332,"range":{"start_line":332,"start_character":0,"end_line":332,"end_character":17},"updated":"2019-10-25 04:36:18.000000000","message":"Could this be simplified to \u0027When\u0027?","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":329,"context_line":"    \u0027[{\"interface\": \"raid\", \"step\": \"create_configuration\"}]\u0027 ${node_uuid}"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"In the case where the physical disk names or controller names are not"},{"line_number":333,"context_line":"known, the following python code example shows how the python-dracclient"},{"line_number":334,"context_line":"can be used to fetch the information directly from the Dell server:"},{"line_number":335,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_4ced9eb5","line":332,"range":{"start_line":332,"start_character":0,"end_line":332,"end_character":17},"in_reply_to":"3fa7e38b_6923acbf","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":330,"context_line":""},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"In the case where the physical disk names or controller names are not"},{"line_number":333,"context_line":"known, the following python code example shows how the python-dracclient"},{"line_number":334,"context_line":"can be used to fetch the information directly from the Dell server:"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":".. code-block:: python"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_8907081e","line":333,"range":{"start_line":333,"start_character":55,"end_line":333,"end_character":72},"updated":"2019-10-25 04:36:18.000000000","message":"Literal, ``python-dracclient``?","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":330,"context_line":""},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"In the case where the physical disk names or controller names are not"},{"line_number":333,"context_line":"known, the following python code example shows how the python-dracclient"},{"line_number":334,"context_line":"can be used to fetch the information directly from the Dell server:"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":".. code-block:: python"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_891e2872","line":333,"range":{"start_line":333,"start_character":21,"end_line":333,"end_character":27},"updated":"2019-10-25 04:36:18.000000000","message":"Python","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":330,"context_line":""},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"In the case where the physical disk names or controller names are not"},{"line_number":333,"context_line":"known, the following python code example shows how the python-dracclient"},{"line_number":334,"context_line":"can be used to fetch the information directly from the Dell server:"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":".. code-block:: python"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_ec29eaf1","line":333,"range":{"start_line":333,"start_character":55,"end_line":333,"end_character":72},"in_reply_to":"3fa7e38b_8907081e","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":330,"context_line":""},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"In the case where the physical disk names or controller names are not"},{"line_number":333,"context_line":"known, the following python code example shows how the python-dracclient"},{"line_number":334,"context_line":"can be used to fetch the information directly from the Dell server:"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":".. code-block:: python"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_0c2d66fc","line":333,"range":{"start_line":333,"start_character":21,"end_line":333,"end_character":27},"in_reply_to":"3fa7e38b_891e2872","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":331,"context_line":""},{"line_number":332,"context_line":"In the case where the physical disk names or controller names are not"},{"line_number":333,"context_line":"known, the following python code example shows how the python-dracclient"},{"line_number":334,"context_line":"can be used to fetch the information directly from the Dell server:"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":".. code-block:: python"},{"line_number":337,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_e918fc84","line":334,"range":{"start_line":334,"start_character":60,"end_line":334,"end_character":66},"updated":"2019-10-25 04:36:18.000000000","message":"s/server/bare metal/","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":331,"context_line":""},{"line_number":332,"context_line":"In the case where the physical disk names or controller names are not"},{"line_number":333,"context_line":"known, the following python code example shows how the python-dracclient"},{"line_number":334,"context_line":"can be used to fetch the information directly from the Dell server:"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":".. code-block:: python"},{"line_number":337,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_ac33f261","line":334,"range":{"start_line":334,"start_character":60,"end_line":334,"end_character":66},"in_reply_to":"3fa7e38b_e918fc84","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":343,"context_line":"      username\u003d\"root\","},{"line_number":344,"context_line":"      password\u003d\"calvin\")"},{"line_number":345,"context_line":"  controllers \u003d client.list_raid_controllers()"},{"line_number":346,"context_line":"  print (controllers)"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"  physical_disks \u003d client.list_physical_disks()"},{"line_number":349,"context_line":"  print (physical_disks)"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_ac20d29c","line":346,"range":{"start_line":346,"start_character":7,"end_line":346,"end_character":8},"updated":"2019-10-25 04:36:18.000000000","message":"nit: Extra space.","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":343,"context_line":"      username\u003d\"root\","},{"line_number":344,"context_line":"      password\u003d\"calvin\")"},{"line_number":345,"context_line":"  controllers \u003d client.list_raid_controllers()"},{"line_number":346,"context_line":"  print (controllers)"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"  physical_disks \u003d client.list_physical_disks()"},{"line_number":349,"context_line":"  print (physical_disks)"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_8c38763b","line":346,"range":{"start_line":346,"start_character":7,"end_line":346,"end_character":8},"in_reply_to":"3fa7e38b_ac20d29c","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"818c5f6f628b3c54ba6d053d6e992aad9135aad0","unresolved":false,"context_lines":[{"line_number":346,"context_line":"  print (controllers)"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"  physical_disks \u003d client.list_physical_disks()"},{"line_number":349,"context_line":"  print (physical_disks)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"Vendor Interface"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_cc23cea6","line":349,"range":{"start_line":349,"start_character":7,"end_line":349,"end_character":8},"updated":"2019-10-25 04:36:18.000000000","message":"Ditto","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":31021,"name":"Pranjali Srivastava","email":"srivastavapranjali@ymail.com","username":"spranjali"},"change_message_id":"815bcf398765e12da633dfb7025685cf00f95c2c","unresolved":false,"context_lines":[{"line_number":346,"context_line":"  print (controllers)"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"  physical_disks \u003d client.list_physical_disks()"},{"line_number":349,"context_line":"  print (physical_disks)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"Vendor Interface"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3fa7e38b_2c4702bf","line":349,"range":{"start_line":349,"start_character":7,"end_line":349,"end_character":8},"in_reply_to":"3fa7e38b_cc23cea6","updated":"2019-10-25 07:26:37.000000000","message":"Done","commit_id":"0e37a63e3fc4f3af41e5738d08365463b3d961c5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"75d05ee7d39b3db4f85e2fd9d13bf8ac4ed0ae6b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"-------------"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The ``idrac`` hardware type requires the ``python-dracclient`` library"},{"line_number":40,"context_line":"to be installed on the ironic conductor node(s) if an Ironic node is"},{"line_number":41,"context_line":"configured to use an ``idrac-wsman`` interface implementation, for example::"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    sudo pip install \u0027python-dracclient\u003e\u003d3.1.0\u0027"}],"source_content_type":"text/x-rst","patch_set":17,"id":"3fa7e38b_70d91281","line":40,"range":{"start_line":40,"start_character":54,"end_line":40,"end_character":61},"updated":"2019-10-29 21:30:17.000000000","message":"nit: ironic should be lower case.","commit_id":"d114c75d83e83075991fadc0d23286030ae136e9"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"75d05ee7d39b3db4f85e2fd9d13bf8ac4ed0ae6b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    sudo pip install \u0027python-dracclient\u003e\u003d3.1.0\u0027"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Additionally, the ``idrac`` hardware type requires the ``sushy`` library"},{"line_number":46,"context_line":"to be installed on the ironic conductor node(s) if an Ironic node is"},{"line_number":47,"context_line":"configured to use an ``idrac-redfish`` interface implementation, for example::"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"   sudo pip install \u0027python-dracclient\u003e\u003d3.1.0\u0027 \u0027sushy\u003e\u003d2.0.0\u0027"}],"source_content_type":"text/x-rst","patch_set":17,"id":"3fa7e38b_f0d6624f","line":46,"range":{"start_line":46,"start_character":54,"end_line":46,"end_character":60},"updated":"2019-10-29 21:30:17.000000000","message":"nit: should be lower case","commit_id":"d114c75d83e83075991fadc0d23286030ae136e9"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"75d05ee7d39b3db4f85e2fd9d13bf8ac4ed0ae6b","unresolved":false,"context_lines":[{"line_number":94,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d     \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":95,"context_line":"Interface            Supported Implementations"},{"line_number":96,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d     \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":97,"context_line":"``bios``             ``no-bios``"},{"line_number":98,"context_line":"``boot``             ``ipxe``, ``pxe``"},{"line_number":99,"context_line":"``console``          ``no-console``"},{"line_number":100,"context_line":"``deploy``           ``iscsi``, ``direct``, ``ansible``, ``ramdisk``"}],"source_content_type":"text/x-rst","patch_set":17,"id":"3fa7e38b_10bbfe0e","line":97,"updated":"2019-10-29 21:30:17.000000000","message":"It would be nice if there was an interface for bios, just saying :)","commit_id":"d114c75d83e83075991fadc0d23286030ae136e9"}]}