)]}'
{"devstack/lib/ironic":[{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"f61f8026174c62fde38126aff384016560348124","unresolved":false,"context_lines":[{"line_number":1148,"context_line":""},{"line_number":1149,"context_line":"    # Create the logs directory when saving the deploy logs to the filesystem"},{"line_number":1150,"context_line":"    if [[ \"$IRONIC_DEPLOY_LOGS_STORAGE_BACKEND\" \u003d\u003d \"local\" \u0026\u0026 \"$IRONIC_DEPLOY_LOGS_COLLECT\" !\u003d \"never\" ]]; then"},{"line_number":1151,"context_line":"        install -d -o $STACK_USER $IRONIC_DEPLOY_LOGS_LOCAL_PATH"},{"line_number":1152,"context_line":"    fi"},{"line_number":1153,"context_line":"}"},{"line_number":1154,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7faddb67_5f0f0587","line":1151,"updated":"2019-07-19 18:03:46.000000000","message":"This setup is required for Hardware as well","commit_id":"0913c948423ed6c8ba147cf4e2a5a4de6945ec96"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"f180927e90480e1b606232502b302161054aa384","unresolved":false,"context_lines":[{"line_number":1148,"context_line":""},{"line_number":1149,"context_line":"    # Create the logs directory when saving the deploy logs to the filesystem"},{"line_number":1150,"context_line":"    if [[ \"$IRONIC_DEPLOY_LOGS_STORAGE_BACKEND\" \u003d\u003d \"local\" \u0026\u0026 \"$IRONIC_DEPLOY_LOGS_COLLECT\" !\u003d \"never\" ]]; then"},{"line_number":1151,"context_line":"        install -d -o $STACK_USER $IRONIC_DEPLOY_LOGS_LOCAL_PATH"},{"line_number":1152,"context_line":"    fi"},{"line_number":1153,"context_line":"}"},{"line_number":1154,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7faddb67_858c4a36","line":1151,"in_reply_to":"7faddb67_5f0f0587","updated":"2019-07-19 18:04:02.000000000","message":"We reverted this patch on our Dell EMC Ironic CI builds and the UEFI builds are now passing. I recommend that we revert this patch","commit_id":"0913c948423ed6c8ba147cf4e2a5a4de6945ec96"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0387de428ed4151ab11706af57f8b9c5ee385ef1","unresolved":false,"context_lines":[{"line_number":1148,"context_line":""},{"line_number":1149,"context_line":"    # Create the logs directory when saving the deploy logs to the filesystem"},{"line_number":1150,"context_line":"    if [[ \"$IRONIC_DEPLOY_LOGS_STORAGE_BACKEND\" \u003d\u003d \"local\" \u0026\u0026 \"$IRONIC_DEPLOY_LOGS_COLLECT\" !\u003d \"never\" ]]; then"},{"line_number":1151,"context_line":"        install -d -o $STACK_USER $IRONIC_DEPLOY_LOGS_LOCAL_PATH"},{"line_number":1152,"context_line":"    fi"},{"line_number":1153,"context_line":"}"},{"line_number":1154,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7faddb67_90048716","line":1151,"in_reply_to":"7faddb67_858c4a36","updated":"2019-07-19 22:08:22.000000000","message":"Looks like the comment is for 1130. I think if 1145 and 1146 are excluded, then that should be fine. the isue is likely 1140?","commit_id":"0913c948423ed6c8ba147cf4e2a5a4de6945ec96"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"26d595b8e4d76db0feda0fe3e0fc312d9408a51a","unresolved":false,"context_lines":[{"line_number":1148,"context_line":""},{"line_number":1149,"context_line":"    # Create the logs directory when saving the deploy logs to the filesystem"},{"line_number":1150,"context_line":"    if [[ \"$IRONIC_DEPLOY_LOGS_STORAGE_BACKEND\" \u003d\u003d \"local\" \u0026\u0026 \"$IRONIC_DEPLOY_LOGS_COLLECT\" !\u003d \"never\" ]]; then"},{"line_number":1151,"context_line":"        install -d -o $STACK_USER $IRONIC_DEPLOY_LOGS_LOCAL_PATH"},{"line_number":1152,"context_line":"    fi"},{"line_number":1153,"context_line":"}"},{"line_number":1154,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7faddb67_2fed298b","line":1151,"in_reply_to":"7faddb67_90048716","updated":"2019-07-22 04:39:09.000000000","message":"If \"$IRONIC_BOOT_MODE \u003d\u003d uefi\", lines 1131 \u0026 from 1135 to 1140 are required regardless of whether Ironic node is HW or not.\nHowever, another lines between 1130 and 1146 are needed when Ironic node is VM.\n\nI\u0027ll create new patch in which\n\n  1) if clause checks \"$IRONIC_BOOT_MODE \u003d\u003d uefi\" and, if true, do followings\n  2) do works related to uefi_boot_file (lines 1131 \u0026 from 1135 to 1140 above)\n  3) if clause checks \"$IRONIC_IS_HARDWARE \u003d\u003d false\" and, if true, do works related to OVMF images (lines between 1130 and 1146 excluding lines 1131 \u0026 from 1135 to 1140).","commit_id":"0913c948423ed6c8ba147cf4e2a5a4de6945ec96"}]}