)]}'
{"devstack/lib/ironic":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f5395139fda92f5295ebb0c971d6e53b09322bcc","unresolved":false,"context_lines":[{"line_number":509,"context_line":""},{"line_number":510,"context_line":"# Handle architecture specific package installs"},{"line_number":511,"context_line":"if [[ $IRONIC_HW_ARCH \u003d\u003d \"x86_64\" ]]; then"},{"line_number":512,"context_line":"    if is_ubuntu; then"},{"line_number":513,"context_line":"        install_package shim"},{"line_number":514,"context_line":"        install_package grub-efi-amd64-signed"},{"line_number":515,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7faddb67_14bc92b9","line":512,"updated":"2019-07-11 09:33:03.000000000","message":"My fedora has shim-x64, `dnf install shim` redirects to it. Similarly, installing grub2-efi redirects to grub2-efi-x64. Maybe we should use these? Or add them to files/rpms/ironic?","commit_id":"c6f76c35b3304ef497286b5aa35ae13c56222c82"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d8e73d40449a0938d7fe7b32d12a7d8fce486ab5","unresolved":false,"context_lines":[{"line_number":509,"context_line":""},{"line_number":510,"context_line":"# Handle architecture specific package installs"},{"line_number":511,"context_line":"if [[ $IRONIC_HW_ARCH \u003d\u003d \"x86_64\" ]]; then"},{"line_number":512,"context_line":"    if is_ubuntu; then"},{"line_number":513,"context_line":"        install_package shim"},{"line_number":514,"context_line":"        install_package grub-efi-amd64-signed"},{"line_number":515,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7faddb67_c3e722e4","line":512,"range":{"start_line":512,"start_character":7,"end_line":512,"end_character":16},"updated":"2019-07-11 05:48:32.000000000","message":"Why are we restricting this to just Ubuntu? Wont this be applicable to other OSes like Fedora? We do support Fedora through this script.","commit_id":"c6f76c35b3304ef497286b5aa35ae13c56222c82"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"3f64e76b354b7faf884af2809fab6c5a2e0ac3e6","unresolved":false,"context_lines":[{"line_number":509,"context_line":""},{"line_number":510,"context_line":"# Handle architecture specific package installs"},{"line_number":511,"context_line":"if [[ $IRONIC_HW_ARCH \u003d\u003d \"x86_64\" ]]; then"},{"line_number":512,"context_line":"    if is_ubuntu; then"},{"line_number":513,"context_line":"        install_package shim"},{"line_number":514,"context_line":"        install_package grub-efi-amd64-signed"},{"line_number":515,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7faddb67_35774805","line":512,"in_reply_to":"7faddb67_14bc92b9","updated":"2019-07-11 13:20:24.000000000","message":"done","commit_id":"c6f76c35b3304ef497286b5aa35ae13c56222c82"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"bef5ad1ddd85210be06944686d4c15c95df85d87","unresolved":false,"context_lines":[{"line_number":509,"context_line":""},{"line_number":510,"context_line":"# Handle architecture specific package installs"},{"line_number":511,"context_line":"if [[ $IRONIC_HW_ARCH \u003d\u003d \"x86_64\" ]]; then"},{"line_number":512,"context_line":"    if is_ubuntu; then"},{"line_number":513,"context_line":"        install_package shim"},{"line_number":514,"context_line":"        install_package grub-efi-amd64-signed"},{"line_number":515,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7faddb67_a93c47bf","line":512,"range":{"start_line":512,"start_character":7,"end_line":512,"end_character":16},"in_reply_to":"7faddb67_23c2b6ea","updated":"2019-07-11 08:13:57.000000000","message":"I thought it was this check was introduced as part of that package movement. Was there any more patches that dealt with CentOS?\nhttps://github.com/openstack/ironic/commit/bc84b7bce6ae97641b3049a1c608e01f831ce8ed#diff-fb50fd952d51d577ae0be49196b05e5a","commit_id":"c6f76c35b3304ef497286b5aa35ae13c56222c82"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"3f64e76b354b7faf884af2809fab6c5a2e0ac3e6","unresolved":false,"context_lines":[{"line_number":509,"context_line":""},{"line_number":510,"context_line":"# Handle architecture specific package installs"},{"line_number":511,"context_line":"if [[ $IRONIC_HW_ARCH \u003d\u003d \"x86_64\" ]]; then"},{"line_number":512,"context_line":"    if is_ubuntu; then"},{"line_number":513,"context_line":"        install_package shim"},{"line_number":514,"context_line":"        install_package grub-efi-amd64-signed"},{"line_number":515,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7faddb67_b55c987e","line":512,"range":{"start_line":512,"start_character":7,"end_line":512,"end_character":16},"in_reply_to":"7faddb67_a93c47bf","updated":"2019-07-11 13:20:24.000000000","message":"I couldn\u0027t find any equivalent cent patch. I\u0027ve added grub2-efi as per the doc and dtantsur\u0027s comment below and hopefully that sorts it out.","commit_id":"c6f76c35b3304ef497286b5aa35ae13c56222c82"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"866d4594ebc0c8cd5f02659d68319f8099fae0ad","unresolved":false,"context_lines":[{"line_number":509,"context_line":""},{"line_number":510,"context_line":"# Handle architecture specific package installs"},{"line_number":511,"context_line":"if [[ $IRONIC_HW_ARCH \u003d\u003d \"x86_64\" ]]; then"},{"line_number":512,"context_line":"    if is_ubuntu; then"},{"line_number":513,"context_line":"        install_package shim"},{"line_number":514,"context_line":"        install_package grub-efi-amd64-signed"},{"line_number":515,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7faddb67_23c2b6ea","line":512,"range":{"start_line":512,"start_character":7,"end_line":512,"end_character":16},"in_reply_to":"7faddb67_c3e722e4","updated":"2019-07-11 06:10:27.000000000","message":"A change was merged last week that moves some packages from files/debs into lib/ironic which breaks devstack on Centos, this patch is isolating those changes to Ubuntu, since presumably cent/fedora are already installing what they need via dependencies.","commit_id":"c6f76c35b3304ef497286b5aa35ae13c56222c82"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"7c91e234d52c86ac52b76063ae09fbb2477e4d5f","unresolved":false,"context_lines":[{"line_number":510,"context_line":"# Handle architecture specific package installs"},{"line_number":511,"context_line":"if [[ $IRONIC_HW_ARCH \u003d\u003d \"x86_64\" ]]; then"},{"line_number":512,"context_line":"    if is_ubuntu; then"},{"line_number":513,"context_line":"        install_package shim"},{"line_number":514,"context_line":"        install_package grub-efi-amd64-signed"},{"line_number":515,"context_line":"    fi"},{"line_number":516,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7faddb67_e0125409","line":513,"range":{"start_line":513,"start_character":24,"end_line":513,"end_character":28},"updated":"2019-07-11 02:40:41.000000000","message":"according to commit message, the latter (I think it refers to grub-efi-amd64-signed) is not available in rpm based systems, so should we move shim out of this scope?","commit_id":"c6f76c35b3304ef497286b5aa35ae13c56222c82"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"9fee5a12a559e68fc1bbf93dfd383b17bb52733b","unresolved":false,"context_lines":[{"line_number":510,"context_line":"# Handle architecture specific package installs"},{"line_number":511,"context_line":"if [[ $IRONIC_HW_ARCH \u003d\u003d \"x86_64\" ]]; then"},{"line_number":512,"context_line":"    if is_ubuntu; then"},{"line_number":513,"context_line":"        install_package shim"},{"line_number":514,"context_line":"        install_package grub-efi-amd64-signed"},{"line_number":515,"context_line":"    fi"},{"line_number":516,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7faddb67_c341620d","line":513,"range":{"start_line":513,"start_character":24,"end_line":513,"end_character":28},"in_reply_to":"7faddb67_20c2acea","updated":"2019-07-11 05:00:01.000000000","message":"Make sense to me, thanks for the clarification.","commit_id":"c6f76c35b3304ef497286b5aa35ae13c56222c82"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"940c236845ab4e91a1d13995edf0fb5c46725fcc","unresolved":false,"context_lines":[{"line_number":510,"context_line":"# Handle architecture specific package installs"},{"line_number":511,"context_line":"if [[ $IRONIC_HW_ARCH \u003d\u003d \"x86_64\" ]]; then"},{"line_number":512,"context_line":"    if is_ubuntu; then"},{"line_number":513,"context_line":"        install_package shim"},{"line_number":514,"context_line":"        install_package grub-efi-amd64-signed"},{"line_number":515,"context_line":"    fi"},{"line_number":516,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7faddb67_20c2acea","line":513,"range":{"start_line":513,"start_character":24,"end_line":513,"end_character":28},"in_reply_to":"7faddb67_e0125409","updated":"2019-07-11 04:21:24.000000000","message":"Change I73cab832cf8099c02b3e29df84618c88e5fb5065 moved shim and grub-efi-amd64-signed from files/debs to lib/ironic, but didn\u0027t touch anything on the rpm side, so my assumption is that if it were not needed before, it is not needed now. I don\u0027t see an obvious equivalent under files/rpm so my guess is the functionality is covered by dependencies somewhere.","commit_id":"c6f76c35b3304ef497286b5aa35ae13c56222c82"}]}