)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4a652c6ea9983cc765574e4c0198ccc922bf37ed","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     mvpnitesh \u003cparimalanitesh@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-07-25 08:10:08 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Creates boot entry and loads OS for UEFI systems for wholedisk images"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In case of Pure UEFI systems or the systems with multiple disks,"},{"line_number":10,"context_line":"it doesn\u0027t know what is the default disk and in which disk the image"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_1351f336","line":7,"range":{"start_line":7,"start_character":19,"end_line":7,"end_character":48},"updated":"2019-08-15 02:47:20.000000000","message":"s/ and loads OS for UEFI systems / on bare metal in UEFI boot mode /","commit_id":"f36bdc81725743bb4c634c029280b467975dc4d5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4a652c6ea9983cc765574e4c0198ccc922bf37ed","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Creates boot entry and loads OS for UEFI systems for wholedisk images"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In case of Pure UEFI systems or the systems with multiple disks,"},{"line_number":10,"context_line":"it doesn\u0027t know what is the default disk and in which disk the image"},{"line_number":11,"context_line":"is written by Ironic. In such cases the OS doesnot boot. But we know"},{"line_number":12,"context_line":"into which disk Ironic has written the image and  i am find the partuuid"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_b341ff65","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":20},"updated":"2019-08-15 02:47:20.000000000","message":"s/ Pure UEFI / UEFI only /","commit_id":"f36bdc81725743bb4c634c029280b467975dc4d5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4a652c6ea9983cc765574e4c0198ccc922bf37ed","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Creates boot entry and loads OS for UEFI systems for wholedisk images"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In case of Pure UEFI systems or the systems with multiple disks,"},{"line_number":10,"context_line":"it doesn\u0027t know what is the default disk and in which disk the image"},{"line_number":11,"context_line":"is written by Ironic. In such cases the OS doesnot boot. But we know"},{"line_number":12,"context_line":"into which disk Ironic has written the image and  i am find the partuuid"},{"line_number":13,"context_line":"of the EFI partition on that disk and creating the boot entry using"},{"line_number":14,"context_line":"\u0027efibootmgr\u0027 command and thus the OS is loaded in UEFI systems, when"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_735f0741","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":22},"updated":"2019-08-15 02:47:20.000000000","message":"Can this be:-\ns/ \u0027it doesn\u0027t know what is the default disk and in which disk the image is written by Ironic.\u0027 / \u0027system is not aware of default disk or the disk where image was written\u0027 /","commit_id":"f36bdc81725743bb4c634c029280b467975dc4d5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4a652c6ea9983cc765574e4c0198ccc922bf37ed","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In case of Pure UEFI systems or the systems with multiple disks,"},{"line_number":10,"context_line":"it doesn\u0027t know what is the default disk and in which disk the image"},{"line_number":11,"context_line":"is written by Ironic. In such cases the OS doesnot boot. But we know"},{"line_number":12,"context_line":"into which disk Ironic has written the image and  i am find the partuuid"},{"line_number":13,"context_line":"of the EFI partition on that disk and creating the boot entry using"},{"line_number":14,"context_line":"\u0027efibootmgr\u0027 command and thus the OS is loaded in UEFI systems, when"},{"line_number":15,"context_line":"we provision wholedisk images and boot option as local."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Depends-On: I02a1c033d2fa1fdf063594efc7977cfdbe05fb6a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_53520b37","line":14,"range":{"start_line":11,"start_character":57,"end_line":14,"end_character":62},"updated":"2019-08-15 02:47:20.000000000","message":"Can this be:-\ns/ \u0027But we know into which disk Ironic has written the image and i am find the partuuid of the EFI partition on that disk and creating the boot entry using \u0027efibootmgr\u0027 command and thus the OS is loaded in UEFI systems\u0027 / \u0027This can be resolved by creating boot entry on the system using partuuid of the EFI partition with the help of \u0027efibootmgr\u0027 command\u0027 /","commit_id":"f36bdc81725743bb4c634c029280b467975dc4d5"}],"ironic/drivers/modules/agent_base_vendor.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4a652c6ea9983cc765574e4c0198ccc922bf37ed","unresolved":false,"context_lines":[{"line_number":807,"context_line":"                       {\u0027node\u0027: node.uuid,"},{"line_number":808,"context_line":"                        \u0027error\u0027: result[\u0027command_error\u0027]})"},{"line_number":809,"context_line":"                log_and_raise_deployment_error(task, msg)"},{"line_number":810,"context_line":"        elif (node.driver_internal_info.get(\u0027is_whole_disk_image\u0027) and"},{"line_number":811,"context_line":"                deploy_utils.get_boot_option(node) \u003d\u003d \"local\"):"},{"line_number":812,"context_line":"                result \u003d self._client.create_boot_entry(node,"},{"line_number":813,"context_line":"                                                        efi_system_part_uuid)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_d3ea7b72","line":810,"range":{"start_line":810,"start_character":8,"end_line":810,"end_character":66},"updated":"2019-08-15 02:47:20.000000000","message":"This can be:\nelif (whole_disk_image and ...):\n    ...","commit_id":"f36bdc81725743bb4c634c029280b467975dc4d5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4a652c6ea9983cc765574e4c0198ccc922bf37ed","unresolved":false,"context_lines":[{"line_number":809,"context_line":"                log_and_raise_deployment_error(task, msg)"},{"line_number":810,"context_line":"        elif (node.driver_internal_info.get(\u0027is_whole_disk_image\u0027) and"},{"line_number":811,"context_line":"                deploy_utils.get_boot_option(node) \u003d\u003d \"local\"):"},{"line_number":812,"context_line":"                result \u003d self._client.create_boot_entry(node,"},{"line_number":813,"context_line":"                                                        efi_system_part_uuid)"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_33a74f53","line":812,"range":{"start_line":812,"start_character":38,"end_line":812,"end_character":55},"updated":"2019-08-15 02:47:20.000000000","message":"This is a synchronous command, need to handle the command result.","commit_id":"f36bdc81725743bb4c634c029280b467975dc4d5"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4a652c6ea9983cc765574e4c0198ccc922bf37ed","unresolved":false,"context_lines":[{"line_number":439,"context_line":"            disk_utils.create_config_drive_partition(node_uuid, dev,"},{"line_number":440,"context_line":"                                                     configdrive)"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"        if boot_mode \u003d\u003d \u0027uefi\u0027:"},{"line_number":443,"context_line":"            if boot_option \u003d\u003d \"local\":"},{"line_number":444,"context_line":"                disk_identifiers \u003d disk_utils.get_root_and_efi_partuuid(dev)"},{"line_number":445,"context_line":"                return {\u0027root uuid\u0027: disk_identifiers.get(\u0027root_uuid\u0027),"},{"line_number":446,"context_line":"                        \u0027efi system partition uuid\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_136813f3","line":443,"range":{"start_line":442,"start_character":8,"end_line":443,"end_character":38},"updated":"2019-08-15 02:47:20.000000000","message":"if (boot_mode \u003d\u003d \u0027uefi\u0027 and boot_option \u003d\u003d \"local\"):","commit_id":"f36bdc81725743bb4c634c029280b467975dc4d5"},{"author":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"change_message_id":"21904de4e47e4aaf98f501deda0bd5f9fbe9fdc7","unresolved":false,"context_lines":[{"line_number":439,"context_line":"            disk_utils.create_config_drive_partition(node_uuid, dev,"},{"line_number":440,"context_line":"                                                     configdrive)"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"        if boot_mode \u003d\u003d \u0027uefi\u0027:"},{"line_number":443,"context_line":"            if boot_option \u003d\u003d \"local\":"},{"line_number":444,"context_line":"                disk_identifiers \u003d disk_utils.get_root_and_efi_partuuid(dev)"},{"line_number":445,"context_line":"                return {\u0027root uuid\u0027: disk_identifiers.get(\u0027root_uuid\u0027),"},{"line_number":446,"context_line":"                        \u0027efi system partition uuid\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_b4b57e80","line":443,"range":{"start_line":442,"start_character":8,"end_line":443,"end_character":38},"in_reply_to":"7faddb67_136813f3","updated":"2019-08-29 10:39:03.000000000","message":"Not changing anything, because for \u0027netboot\u0027 as boot_option, it has to  execute \u0027disk_identifiers \u003d disk_utils.get_uefo_disk_identifier(dev)\u0027 and for \u0027bios\u0027 it has to execute \u0027disk_identifier \u003d disk_utils.get_disk_identifier(dev)\u0027","commit_id":"f36bdc81725743bb4c634c029280b467975dc4d5"}]}