)]}'
{"ironic/common/images.py":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a19973651b40ef8ad744458484b8602096dd4d41","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                e_img_rel_path \u003d EFIBOOT_LOCATION"},{"line_number":273,"context_line":"                grub_rel_path \u003d CONF.grub_config_path.lstrip(\u0027 \u0027 + os.sep)"},{"line_number":274,"context_line":"                grub_cfg \u003d os.path.join(tmpdir, grub_rel_path)"},{"line_number":275,"context_line":"                grub_dir \u003d grub_cfg[:(grub_cfg.rfind(os.sep))]"},{"line_number":276,"context_line":"                if not os.path.exists(grub_dir):"},{"line_number":277,"context_line":"                    os.makedirs(grub_dir)"},{"line_number":278,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_f732d8f1","line":275,"range":{"start_line":275,"start_character":27,"end_line":275,"end_character":62},"updated":"2019-07-16 10:26:24.000000000","message":"Can it be `os.path.dirname`?","commit_id":"029479d238c4238d77e5f47a9a14d8e0ffcca53a"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a19973651b40ef8ad744458484b8602096dd4d41","unresolved":false,"context_lines":[{"line_number":274,"context_line":"                grub_cfg \u003d os.path.join(tmpdir, grub_rel_path)"},{"line_number":275,"context_line":"                grub_dir \u003d grub_cfg[:(grub_cfg.rfind(os.sep))]"},{"line_number":276,"context_line":"                if not os.path.exists(grub_dir):"},{"line_number":277,"context_line":"                    os.makedirs(grub_dir)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"                uefi_path_info \u003d {"},{"line_number":280,"context_line":"                    esp_image: e_img_rel_path"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_97804448","line":277,"range":{"start_line":277,"start_character":23,"end_line":277,"end_character":31},"updated":"2019-07-16 10:26:24.000000000","message":"Alternatively, may be we can do it declaratively like\n\nrefi_path_info \u003d {\n    \u0027/dev/zero\u0027: grub_cfg\n}\n\nto align with the rest of the code...","commit_id":"029479d238c4238d77e5f47a9a14d8e0ffcca53a"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a19973651b40ef8ad744458484b8602096dd4d41","unresolved":false,"context_lines":[{"line_number":274,"context_line":"                grub_cfg \u003d os.path.join(tmpdir, grub_rel_path)"},{"line_number":275,"context_line":"                grub_dir \u003d grub_cfg[:(grub_cfg.rfind(os.sep))]"},{"line_number":276,"context_line":"                if not os.path.exists(grub_dir):"},{"line_number":277,"context_line":"                    os.makedirs(grub_dir)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"                uefi_path_info \u003d {"},{"line_number":280,"context_line":"                    esp_image: e_img_rel_path"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_57adece6","line":277,"range":{"start_line":277,"start_character":23,"end_line":277,"end_character":31},"updated":"2019-07-16 10:26:24.000000000","message":"Should we better move this after L#292?","commit_id":"029479d238c4238d77e5f47a9a14d8e0ffcca53a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7681c828bdc397c57bd47d469cd3576996c54ce9","unresolved":false,"context_lines":[{"line_number":274,"context_line":"                grub_cfg \u003d os.path.join(tmpdir, grub_rel_path)"},{"line_number":275,"context_line":"                grub_dir \u003d grub_cfg[:(grub_cfg.rfind(os.sep))]"},{"line_number":276,"context_line":"                if not os.path.exists(grub_dir):"},{"line_number":277,"context_line":"                    os.makedirs(grub_dir)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"                uefi_path_info \u003d {"},{"line_number":280,"context_line":"                    esp_image: e_img_rel_path"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_6139fba1","line":277,"range":{"start_line":277,"start_character":23,"end_line":277,"end_character":31},"in_reply_to":"7faddb67_97804448","updated":"2019-07-20 15:21:13.000000000","message":"+1","commit_id":"029479d238c4238d77e5f47a9a14d8e0ffcca53a"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"4ea665e1d1c03d35505a67c536cbda9b49c000b6","unresolved":false,"context_lines":[{"line_number":275,"context_line":""},{"line_number":276,"context_line":"                uefi_path_info \u003d {"},{"line_number":277,"context_line":"                    esp_image: e_img_rel_path,"},{"line_number":278,"context_line":"                    \u0027/dev/zero\u0027: grub_rel_path"},{"line_number":279,"context_line":"                }"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_8eba0ddf","line":278,"range":{"start_line":278,"start_character":20,"end_line":278,"end_character":46},"updated":"2019-07-23 02:30:35.000000000","message":"Hi Shivanand, it might be a dumb question, how it works or what we want to achieve here? it seems to be an issue if we copy /dev/zero as a file, it will not stop (and I guess it will end up with disk full).","commit_id":"aec7e66464fdfe8e125e2d66a3c3b8e54f629dc4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"acb042cd251ba834052cc84e8ec77c0d19f5974e","unresolved":false,"context_lines":[{"line_number":275,"context_line":""},{"line_number":276,"context_line":"                uefi_path_info \u003d {"},{"line_number":277,"context_line":"                    esp_image: e_img_rel_path,"},{"line_number":278,"context_line":"                    \u0027/dev/zero\u0027: grub_rel_path"},{"line_number":279,"context_line":"                }"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_aeca6917","line":278,"range":{"start_line":278,"start_character":20,"end_line":278,"end_character":46},"in_reply_to":"7faddb67_8eba0ddf","updated":"2019-07-23 04:05:07.000000000","message":"Oops, it should be /dev/null. Its to create a zero byte file.","commit_id":"aec7e66464fdfe8e125e2d66a3c3b8e54f629dc4"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"5570160fa1e3cc0445d88f9e0e0e4de10d9e5477","unresolved":false,"context_lines":[{"line_number":275,"context_line":""},{"line_number":276,"context_line":"                uefi_path_info \u003d {"},{"line_number":277,"context_line":"                    esp_image: e_img_rel_path,"},{"line_number":278,"context_line":"                    \u0027/dev/zero\u0027: grub_rel_path"},{"line_number":279,"context_line":"                }"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_a998231b","line":278,"range":{"start_line":278,"start_character":20,"end_line":278,"end_character":46},"in_reply_to":"7faddb67_aeca6917","updated":"2019-07-23 06:46:54.000000000","message":"Ah, sorry, that\u0027s my bug! Of course I meant to propose `/dev/null`.","commit_id":"aec7e66464fdfe8e125e2d66a3c3b8e54f629dc4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"10730726a342a57af21c2477b6ca62d3b2aa851a","unresolved":false,"context_lines":[{"line_number":275,"context_line":""},{"line_number":276,"context_line":"                uefi_path_info \u003d {"},{"line_number":277,"context_line":"                    esp_image: e_img_rel_path,"},{"line_number":278,"context_line":"                    \u0027/dev/null\u0027: grub_rel_path"},{"line_number":279,"context_line":"                }"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_50e8f614","line":278,"updated":"2019-07-26 08:24:18.000000000","message":"let\u0027s leave a comment on what /dev/null implies here. I cannot figure out even right now, even less in a year..","commit_id":"ffcb60364615d35d47697a5830d6e97d71e165dd"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"bc6adf7a1d2effc43a7eaabf745965d6177a422d","unresolved":false,"context_lines":[{"line_number":275,"context_line":""},{"line_number":276,"context_line":"                uefi_path_info \u003d {"},{"line_number":277,"context_line":"                    esp_image: e_img_rel_path,"},{"line_number":278,"context_line":"                    \u0027/dev/null\u0027: grub_rel_path"},{"line_number":279,"context_line":"                }"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_068801c4","line":278,"in_reply_to":"7faddb67_50e8f614","updated":"2019-07-26 14:36:40.000000000","message":"Done","commit_id":"ffcb60364615d35d47697a5830d6e97d71e165dd"}]}