)]}'
{"ironic/drivers/modules/redfish/boot.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"ff8f080cc570956c1ce0c4d136f45a0b7fbaed57","unresolved":false,"context_lines":[{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        image_url \u003d swift_api.get_temp_url(container, object_name, timeout)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        image_url \u003d cls._append_filename_param(image_url, \u0027bootme.img\u0027)"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"        LOG.debug(\"Created floppy image %(name)s in Swift for node %(node)s, \""},{"line_number":301,"context_line":"                  \"exposed as temporary URL \""}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_9bbb2e71","line":298,"range":{"start_line":298,"start_character":8,"end_line":298,"end_character":71},"updated":"2019-07-23 08:04:46.000000000","message":"Would it be better to control this through configuration parameter, so that it can be enabled only for BMC\u0027s that need it.","commit_id":"be7793b49297c2bc9e493d9cb3530c0488fc1f1f"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"0a6e07dd9367cb8bbb28f6e893eccbc110e0f854","unresolved":false,"context_lines":[{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        image_url \u003d swift_api.get_temp_url(container, object_name, timeout)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        image_url \u003d cls._append_filename_param(image_url, \u0027bootme.img\u0027)"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"        LOG.debug(\"Created floppy image %(name)s in Swift for node %(node)s, \""},{"line_number":301,"context_line":"                  \"exposed as temporary URL \""}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_71a3f101","line":298,"range":{"start_line":298,"start_character":8,"end_line":298,"end_character":71},"in_reply_to":"7faddb67_9bbb2e71","updated":"2019-07-23 09:30:23.000000000","message":"It could, but on the other hand, adding this parameter should not hurt anyway. From Swift docs it seems [1] that adding \u0027filename\u0027 into query string is a suggested way to guide file download.\n\n1. https://docs.openstack.org/swift/latest/api/temporary_url_middleware.html#temporary-url-format","commit_id":"be7793b49297c2bc9e493d9cb3530c0488fc1f1f"}],"ironic/tests/unit/drivers/modules/redfish/test_boot.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"ff8f080cc570956c1ce0c4d136f45a0b7fbaed57","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            mock_swift_api \u003d mock_swift.SwiftAPI.return_value"},{"line_number":154,"context_line":"            mock_swift_api.get_temp_url.return_value \u003d \u0027https://a.b/c.f?e\u003df\u0027"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"            task.driver.boot._prepare_floppy_image(task)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"            mock_swift.SwiftAPI.assert_called_once_with()"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_3b879ab9","line":156,"range":{"start_line":156,"start_character":12,"end_line":156,"end_character":56},"updated":"2019-07-23 08:04:46.000000000","message":"Check return value of this method to ensure that \u0027filename\u0027 query parameter is added.","commit_id":"be7793b49297c2bc9e493d9cb3530c0488fc1f1f"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"0a6e07dd9367cb8bbb28f6e893eccbc110e0f854","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            mock_swift_api \u003d mock_swift.SwiftAPI.return_value"},{"line_number":154,"context_line":"            mock_swift_api.get_temp_url.return_value \u003d \u0027https://a.b/c.f?e\u003df\u0027"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"            task.driver.boot._prepare_floppy_image(task)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"            mock_swift.SwiftAPI.assert_called_once_with()"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_31db397e","line":156,"range":{"start_line":156,"start_character":12,"end_line":156,"end_character":56},"in_reply_to":"7faddb67_3b879ab9","updated":"2019-07-23 09:30:23.000000000","message":"Done","commit_id":"be7793b49297c2bc9e493d9cb3530c0488fc1f1f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"ff8f080cc570956c1ce0c4d136f45a0b7fbaed57","unresolved":false,"context_lines":[{"line_number":189,"context_line":"            mock_swift_api \u003d mock_swift.SwiftAPI.return_value"},{"line_number":190,"context_line":"            mock_swift_api.get_temp_url.return_value \u003d \u0027https://a.b/c.f?e\u003df\u0027"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"            task.driver.boot._prepare_iso_image("},{"line_number":193,"context_line":"                task, \u0027http://kernel/img\u0027, \u0027http://ramdisk/img\u0027,"},{"line_number":194,"context_line":"                \u0027http://bootloader/img\u0027, root_uuid\u003dtask.node.uuid)"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_dbc1a6e6","line":192,"range":{"start_line":192,"start_character":12,"end_line":192,"end_character":48},"updated":"2019-07-23 08:04:46.000000000","message":"ditto","commit_id":"be7793b49297c2bc9e493d9cb3530c0488fc1f1f"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"0a6e07dd9367cb8bbb28f6e893eccbc110e0f854","unresolved":false,"context_lines":[{"line_number":189,"context_line":"            mock_swift_api \u003d mock_swift.SwiftAPI.return_value"},{"line_number":190,"context_line":"            mock_swift_api.get_temp_url.return_value \u003d \u0027https://a.b/c.f?e\u003df\u0027"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"            task.driver.boot._prepare_iso_image("},{"line_number":193,"context_line":"                task, \u0027http://kernel/img\u0027, \u0027http://ramdisk/img\u0027,"},{"line_number":194,"context_line":"                \u0027http://bootloader/img\u0027, root_uuid\u003dtask.node.uuid)"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_51d8357e","line":192,"range":{"start_line":192,"start_character":12,"end_line":192,"end_character":48},"in_reply_to":"7faddb67_dbc1a6e6","updated":"2019-07-23 09:30:23.000000000","message":"Done","commit_id":"be7793b49297c2bc9e493d9cb3530c0488fc1f1f"}]}