)]}'
{"devstack/tools/ironic/scripts/configure-vm.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"6027d3d4de5e3ee15d77d3b9b33bd1cb0d2df7da","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    images \u003d list(zip(args.image, string.ascii_lowercase))"},{"line_number":98,"context_line":"    if not images or len(images) \u003e 6:"},{"line_number":99,"context_line":"        # 6 is an artificial limitation because of the way we generate PCI IDs"},{"line_number":100,"context_line":"        sys.exit(\"Up to 6 images are required\")"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    params \u003d {"},{"line_number":103,"context_line":"        \u0027name\u0027: args.name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_1c6d10cb","line":100,"range":{"start_line":100,"start_character":18,"end_line":100,"end_character":45},"updated":"2019-08-07 02:33:37.000000000","message":"this doesn\u0027t match the checking above, \"up to\" means \"at least\" if I make it right :)","commit_id":"645895a7a715126ca1ffc05bafe9b9fe6e138094"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1dbf431600ad45efeffd2bfee864be78dfe968af","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    images \u003d list(zip(args.image, string.ascii_lowercase))"},{"line_number":98,"context_line":"    if not images or len(images) \u003e 6:"},{"line_number":99,"context_line":"        # 6 is an artificial limitation because of the way we generate PCI IDs"},{"line_number":100,"context_line":"        sys.exit(\"Up to 6 images are required\")"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    params \u003d {"},{"line_number":103,"context_line":"        \u0027name\u0027: args.name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_29020971","line":100,"range":{"start_line":100,"start_character":18,"end_line":100,"end_character":45},"in_reply_to":"7faddb67_1c6d10cb","updated":"2019-08-07 07:12:29.000000000","message":"Not really, \"up to\" means \"not more than\": https://dictionary.cambridge.org/dictionary/english/up-to","commit_id":"645895a7a715126ca1ffc05bafe9b9fe6e138094"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"451bfc3601639f25cf9605a2069f9b4d371567b0","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    template \u003d env.get_template(\u0027vm.xml\u0027)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    images \u003d list(zip(args.image, string.ascii_lowercase))"},{"line_number":98,"context_line":"    if not images or len(images) \u003e 6:"},{"line_number":99,"context_line":"        # 6 is an artificial limitation because of the way we generate PCI IDs"},{"line_number":100,"context_line":"        sys.exit(\"Up to 6 images are required\")"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_a9535939","line":98,"updated":"2019-08-07 07:25:26.000000000","message":"maybe apply this check to args.image before even creating images ?","commit_id":"c7bd03cf688c7059c694e07da34506f4a64a21ac"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"1801f2d8cd8228081841f1d2cd14d5ca56f1a762","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    template \u003d env.get_template(\u0027vm.xml\u0027)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    images \u003d list(zip(args.image, string.ascii_lowercase))"},{"line_number":98,"context_line":"    if not images or len(images) \u003e 6:"},{"line_number":99,"context_line":"        # 6 is an artificial limitation because of the way we generate PCI IDs"},{"line_number":100,"context_line":"        sys.exit(\"Up to 6 images are required\")"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_4f874514","line":98,"in_reply_to":"7faddb67_a9535939","updated":"2019-08-07 09:08:19.000000000","message":"I think it\u0027s a good idea, since we are sticking to 1 volume here, there should be patch followed, we could do it there.","commit_id":"c7bd03cf688c7059c694e07da34506f4a64a21ac"}],"devstack/tools/ironic/templates/vm.xml":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"6027d3d4de5e3ee15d77d3b9b33bd1cb0d2df7da","unresolved":false,"context_lines":[{"line_number":38,"context_line":"           not work with UEFI, so let\u0027s use IDE. --\u003e"},{"line_number":39,"context_line":"      {% if uefi_loader %}"},{"line_number":40,"context_line":"          \u003ctarget dev\u003d\u0027vd{{ letter }}\u0027 bus\u003d\u0027ide\u0027/\u003e"},{"line_number":41,"context_line":"          \u003caddress type\u003d\u0027drive\u0027 controller\u003d\u00270\u0027 bus\u003d\u00270\u0027 target\u003d\u00270\u0027 unit\u003d\u00270\u0027/\u003e"},{"line_number":42,"context_line":"      {% else %}"},{"line_number":43,"context_line":"          \u003ctarget dev\u003d\u0027vd{{ letter }}\u0027 bus\u003d\u0027virtio\u0027/\u003e"},{"line_number":44,"context_line":"          \u003caddress type\u003d\u0027pci\u0027 domain\u003d\u00270x0000\u0027 bus\u003d\u00270x00\u0027 slot\u003d\u00270x0{{ letter }}\u0027 function\u003d\u00270x0\u0027/\u003e"}],"source_content_type":"application/xml","patch_set":4,"id":"7faddb67_6196dbf2","line":41,"range":{"start_line":41,"start_character":66,"end_line":41,"end_character":74},"updated":"2019-08-07 02:33:37.000000000","message":"this will lead to duplicate address for multiple disks, something like slot below needs to be done.","commit_id":"645895a7a715126ca1ffc05bafe9b9fe6e138094"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1dbf431600ad45efeffd2bfee864be78dfe968af","unresolved":false,"context_lines":[{"line_number":38,"context_line":"           not work with UEFI, so let\u0027s use IDE. --\u003e"},{"line_number":39,"context_line":"      {% if uefi_loader %}"},{"line_number":40,"context_line":"          \u003ctarget dev\u003d\u0027vd{{ letter }}\u0027 bus\u003d\u0027ide\u0027/\u003e"},{"line_number":41,"context_line":"          \u003caddress type\u003d\u0027drive\u0027 controller\u003d\u00270\u0027 bus\u003d\u00270\u0027 target\u003d\u00270\u0027 unit\u003d\u00270\u0027/\u003e"},{"line_number":42,"context_line":"      {% else %}"},{"line_number":43,"context_line":"          \u003ctarget dev\u003d\u0027vd{{ letter }}\u0027 bus\u003d\u0027virtio\u0027/\u003e"},{"line_number":44,"context_line":"          \u003caddress type\u003d\u0027pci\u0027 domain\u003d\u00270x0000\u0027 bus\u003d\u00270x00\u0027 slot\u003d\u00270x0{{ letter }}\u0027 function\u003d\u00270x0\u0027/\u003e"}],"source_content_type":"application/xml","patch_set":4,"id":"7faddb67_298529d0","line":41,"range":{"start_line":41,"start_character":66,"end_line":41,"end_character":74},"in_reply_to":"7faddb67_6196dbf2","updated":"2019-08-07 07:12:29.000000000","message":"Done","commit_id":"645895a7a715126ca1ffc05bafe9b9fe6e138094"}]}