)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"da9b998e4cb7e6074295544fd39a9c29082263ff","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nisha Brahmankar \u003cnisha.ee.iitb@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-08-01 23:42:54 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Uses IPA-B to build insted of CoreOS"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: https://review.opendev.org/#/c/669213/"},{"line_number":10,"context_line":"Task: 29752"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7faddb67_1f7f5815","line":7,"updated":"2019-08-06 08:56:23.000000000","message":"It\u0027s not instead of CoreOS, but in addition to it.","commit_id":"fb8bcbce9deb59636c398ad6858937b070718714"}],"devstack/lib/ironic":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4ec209c03a5722ddf9319141b3c779b42c74ba37","unresolved":false,"context_lines":[{"line_number":2510,"context_line":"    if is_deploy_iso_required; then"},{"line_number":2511,"context_line":"        IRONIC_DIB_RAMDISK_OPTIONS+\u003d\" iso\""},{"line_number":2512,"context_line":"    fi"},{"line_number":2513,"context_line":"    git_clone $IRONIC_PYTHON_AGENT_BUILDER_REPO $IRONIC_PYTHON_AGENT_BUILDER_DIR $IRONIC_PYTHON_AGENT_BUILDER_BRANCH"},{"line_number":2514,"context_line":"    cd $IRONIC_PYTHON_AGENT_BUILDER_DIR/dib"},{"line_number":2515,"context_line":"    export ELEMENTS_PATH\u003d${ELEMENTS_PATH:-`pwd`}"},{"line_number":2516,"context_line":"    disk-image-create \"$IRONIC_DIB_RAMDISK_OPTIONS\" \\"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7faddb67_e4554f51","line":2513,"range":{"start_line":2513,"start_character":81,"end_line":2513,"end_character":116},"updated":"2019-08-01 07:58:07.000000000","message":"this won\u0027t work, if you want to clone a specific branch, you need to use the --branch option\nalthough at the moment we don\u0027t have stable branches for the ironic-python-agent-builder","commit_id":"0a6a7b4089d467ddf8d4af84ca93e7e08d63466c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"53e4a69cde86c0fdbd647fce5a9f5ba104005acb","unresolved":false,"context_lines":[{"line_number":2510,"context_line":"    if is_deploy_iso_required; then"},{"line_number":2511,"context_line":"        IRONIC_DIB_RAMDISK_OPTIONS+\u003d\" iso\""},{"line_number":2512,"context_line":"    fi"},{"line_number":2513,"context_line":"    git_clone $IRONIC_PYTHON_AGENT_BUILDER_REPO $IRONIC_PYTHON_AGENT_BUILDER_DIR $IRONIC_PYTHON_AGENT_BUILDER_BRANCH"},{"line_number":2514,"context_line":"    cd $IRONIC_PYTHON_AGENT_BUILDER_DIR/dib"},{"line_number":2515,"context_line":"    export ELEMENTS_PATH\u003d${ELEMENTS_PATH:-`pwd`}"},{"line_number":2516,"context_line":"    disk-image-create \"$IRONIC_DIB_RAMDISK_OPTIONS\" \\"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7faddb67_06ac2beb","line":2513,"updated":"2019-08-01 14:00:49.000000000","message":"yep, let\u0027s ignore branches for now.","commit_id":"0a6a7b4089d467ddf8d4af84ca93e7e08d63466c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"53e4a69cde86c0fdbd647fce5a9f5ba104005acb","unresolved":false,"context_lines":[{"line_number":2512,"context_line":"    fi"},{"line_number":2513,"context_line":"    git_clone $IRONIC_PYTHON_AGENT_BUILDER_REPO $IRONIC_PYTHON_AGENT_BUILDER_DIR $IRONIC_PYTHON_AGENT_BUILDER_BRANCH"},{"line_number":2514,"context_line":"    cd $IRONIC_PYTHON_AGENT_BUILDER_DIR/dib"},{"line_number":2515,"context_line":"    export ELEMENTS_PATH\u003d${ELEMENTS_PATH:-`pwd`}"},{"line_number":2516,"context_line":"    disk-image-create \"$IRONIC_DIB_RAMDISK_OPTIONS\" \\"},{"line_number":2517,"context_line":"                    -o  \"$tempdir/ironic-python-agent-ramdisk\" \\"},{"line_number":2518,"context_line":"                    ironic-python-agent-ramdisk"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7faddb67_a6b43737","line":2515,"updated":"2019-08-01 14:00:49.000000000","message":"cd is not needed, and let\u0027s not export this variable for the whole duration. rather\n\n IRONIC_DIB_ELEMENTS\u003d\"$IRONIC_PYTHON_AGENT_BUILDER_DIR/dib\"\n ELEMENTS_PATH\u003d$IRONIC_DIB_ELEMENTS disk-image-create .....","commit_id":"0a6a7b4089d467ddf8d4af84ca93e7e08d63466c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"53e4a69cde86c0fdbd647fce5a9f5ba104005acb","unresolved":false,"context_lines":[{"line_number":2514,"context_line":"    cd $IRONIC_PYTHON_AGENT_BUILDER_DIR/dib"},{"line_number":2515,"context_line":"    export ELEMENTS_PATH\u003d${ELEMENTS_PATH:-`pwd`}"},{"line_number":2516,"context_line":"    disk-image-create \"$IRONIC_DIB_RAMDISK_OPTIONS\" \\"},{"line_number":2517,"context_line":"                    -o  \"$tempdir/ironic-python-agent-ramdisk\" \\"},{"line_number":2518,"context_line":"                    ironic-python-agent-ramdisk"},{"line_number":2519,"context_line":"    chmod -R +r $tempdir"},{"line_number":2520,"context_line":"    mv \"$tempdir/ironic-python-agent-ramdisk.kernel\" \"$kernel_path\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7faddb67_c6b13346","line":2517,"updated":"2019-08-01 14:00:49.000000000","message":"let\u0027s keep the old output name for simplicity","commit_id":"0a6a7b4089d467ddf8d4af84ca93e7e08d63466c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"da9b998e4cb7e6074295544fd39a9c29082263ff","unresolved":false,"context_lines":[{"line_number":2513,"context_line":"    git_clone $IRONIC_PYTHON_AGENT_BUILDER_REPO $IRONIC_PYTHON_AGENT_BUILDER_DIR"},{"line_number":2514,"context_line":"    IRONIC_DIB_ELEMENTS\u003d\"$IRONIC_PYTHON_AGENT_DIR/dib\""},{"line_number":2515,"context_line":"    ELEMENTS_PATH\u003d$IRONIC_DIB_ELEMENTS"},{"line_number":2516,"context_line":"    disk-image-create \"$IRONIC_DIB_RAMDISK_OPTIONS\" \\"},{"line_number":2517,"context_line":"                    -o  \"$tempdir/ironic-agent\" \\"},{"line_number":2518,"context_line":"                    ironic-python-agent-ramdisk"},{"line_number":2519,"context_line":"    chmod -R +r $tempdir"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"7faddb67_3f7a5423","line":2516,"updated":"2019-08-06 08:56:23.000000000","message":"This has to be on the same line as the previous statement, otherwise ELEMENTS_PATH won\u0027t have effect. The bash syntax is\n\n VAR1\u003dvalue1 VAR2\u003dvalue2 command-to-run-with-vars \u003carguments...\u003e","commit_id":"fb8bcbce9deb59636c398ad6858937b070718714"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"15e5b729d978e50321c9d807884956098cc9d7e1","unresolved":false,"context_lines":[{"line_number":2511,"context_line":"        IRONIC_DIB_RAMDISK_OPTIONS+\u003d\" iso\""},{"line_number":2512,"context_line":"    fi"},{"line_number":2513,"context_line":"    git_clone $IRONIC_PYTHON_AGENT_BUILDER_REPO $IRONIC_PYTHON_AGENT_BUILDER_DIR"},{"line_number":2514,"context_line":"    IRONIC_DIB_ELEMENTS\u003d\"$IRONIC_PYTHON_AGENT_DIR/dib\" ELEMENTS_PATH\u003d$IRONIC_DIB_ELEMENTS \\"},{"line_number":2515,"context_line":"            disk-image-create \"$IRONIC_DIB_RAMDISK_OPTIONS\" \\"},{"line_number":2516,"context_line":"            -o  \"$tempdir/ironic-agent\" \\"},{"line_number":2517,"context_line":"            ironic-python-agent-ramdisk"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7faddb67_2cb457d1","line":2514,"updated":"2019-08-07 08:07:33.000000000","message":"should be IRONIC_PYTHON_AGENT_BUILDER_DIR\n\nalso you can use only one variable - ELEMENTS_PATH","commit_id":"4a0210a64fc7df3f19266f8d201b1618cb66a220"}]}