)]}'
{"ironic/drivers/modules/ilo/bios.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"68279db16aa201813f422b9f6dad780b808138cd","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        if step not in (\u0027apply_configuration\u0027, \u0027factory_reset\u0027):"},{"line_number":79,"context_line":"            errmsg \u003d _(\u0027Could not find the step %(step)s for the \u0027"},{"line_number":80,"context_line":"                       \u0027node %(node)s.\u0027)"},{"line_number":81,"context_line":"            if node.clean_step:"},{"line_number":82,"context_line":"                raise exception.NodeCleaningFailure("},{"line_number":83,"context_line":"                    errmsg % {\u0027step\u0027: step, \u0027node\u0027: node.uuid})"},{"line_number":84,"context_line":"            raise exception.InstanceDeployFailure("}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_1b846cd2","line":81,"updated":"2019-08-02 21:28:13.000000000","message":"does node.deploy_step have no impact on this?","commit_id":"84ca920bff0d6a90d69aefe65d678444ffe1fcfd"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"64db3cfbd8b71398dce6278f05c166e0403ed4c7","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        if step not in (\u0027apply_configuration\u0027, \u0027factory_reset\u0027):"},{"line_number":79,"context_line":"            errmsg \u003d _(\u0027Could not find the step %(step)s for the \u0027"},{"line_number":80,"context_line":"                       \u0027node %(node)s.\u0027)"},{"line_number":81,"context_line":"            if node.clean_step:"},{"line_number":82,"context_line":"                raise exception.NodeCleaningFailure("},{"line_number":83,"context_line":"                    errmsg % {\u0027step\u0027: step, \u0027node\u0027: node.uuid})"},{"line_number":84,"context_line":"            raise exception.InstanceDeployFailure("}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_1997943c","line":81,"in_reply_to":"7faddb67_1b846cd2","updated":"2019-08-03 06:09:39.000000000","message":"No, it gets set only during manual cleaning and is cleared when cleaning is complete or failed [1] [2]. The node.deploy_step gets used during deployment. During execution, only one of them would be set based on cleaning or deployment operation.  \n[1] https://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L1437-L1446\n[2] https://github.com/openstack/ironic/blob/master/ironic/conductor/utils.py#L402-L403","commit_id":"84ca920bff0d6a90d69aefe65d678444ffe1fcfd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a70ea8f1b757ac1209b2ebf8d81e89fe549f262b","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            errmsg \u003d (_(\u0027Could not find the step %(step)s for the \u0027"},{"line_number":80,"context_line":"                        \u0027node %(node)s.\u0027)"},{"line_number":81,"context_line":"                      % {\u0027step\u0027: step, \u0027node\u0027: node.uuid})"},{"line_number":82,"context_line":"            if node.clean_step:"},{"line_number":83,"context_line":"                raise exception.NodeCleaningFailure(errmsg)"},{"line_number":84,"context_line":"            raise exception.InstanceDeployFailure(reason\u003derrmsg)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        try:"},{"line_number":87,"context_line":"            ilo_object \u003d ilo_common.get_ilo_object(node)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7faddb67_e918cdcd","line":84,"range":{"start_line":82,"start_character":0,"end_line":84,"end_character":64},"updated":"2019-09-02 14:26:51.000000000","message":"nit: it seems that a helper would be handy for this as well","commit_id":"f546e8f1686a87bac71b561390068b3c1ec4aae1"}]}