)]}'
{"ironic/drivers/modules/ilo/raid.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"11f7348ca31df23f33e9e1fa14a76e9b1b466787","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                            delete_existing\u003dTrue):"},{"line_number":97,"context_line":"        return super(Ilo5RAID, self).apply_configuration("},{"line_number":98,"context_line":"            task, raid_config, create_root_volume, create_nonroot_volumes,"},{"line_number":99,"context_line":"            delete_existing)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    @METRICS.timer(\u0027Ilo5RAID.create_configuration\u0027)"},{"line_number":102,"context_line":"    @base.clean_step(priority\u003d0, abortable\u003dFalse, argsinfo\u003d{"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_dd131664","line":99,"updated":"2019-08-20 20:50:40.000000000","message":"just to avoid confusion/errors wrt order of args, let\u0027s call super.. with  create_root_volume\u003dcreate_root_volume, create_nonroot_volumes\u003dcreate_nonroot_volumes, delete_existing\u003ddelete_existing","commit_id":"6573a1dccf5eae8b89aab3623395a64b3b495f85"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2c878245467de7b93e837903a092f5f8fe1548d3","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                            delete_existing\u003dTrue):"},{"line_number":97,"context_line":"        return super(Ilo5RAID, self).apply_configuration("},{"line_number":98,"context_line":"            task, raid_config, create_root_volume, create_nonroot_volumes,"},{"line_number":99,"context_line":"            delete_existing)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    @METRICS.timer(\u0027Ilo5RAID.create_configuration\u0027)"},{"line_number":102,"context_line":"    @base.clean_step(priority\u003d0, abortable\u003dFalse, argsinfo\u003d{"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_9658188a","line":99,"in_reply_to":"7faddb67_dd131664","updated":"2019-08-21 06:44:10.000000000","message":"Done","commit_id":"6573a1dccf5eae8b89aab3623395a64b3b495f85"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"11f7348ca31df23f33e9e1fa14a76e9b1b466787","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            if node.clean_step:"},{"line_number":155,"context_line":"                raise exception.NodeCleaningFailure(msg % {\u0027node\u0027: node.uuid})"},{"line_number":156,"context_line":"            else:"},{"line_number":157,"context_line":"                raise exception.InstanceDeployFailure(reason\u003dmsg)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        target_raid_config \u003d raid.filter_target_raid_config("},{"line_number":160,"context_line":"            node, create_root_volume\u003dcreate_root_volume,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_fd8a9218","line":157,"updated":"2019-08-20 20:50:40.000000000","message":"this will be missing the node.uuid. Maybe change L150 to msg \u003d _(..) % {\u0027node\u0027: node.uuid}, and L155 to just \u0027msg\u0027.","commit_id":"6573a1dccf5eae8b89aab3623395a64b3b495f85"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2c878245467de7b93e837903a092f5f8fe1548d3","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            if node.clean_step:"},{"line_number":155,"context_line":"                raise exception.NodeCleaningFailure(msg % {\u0027node\u0027: node.uuid})"},{"line_number":156,"context_line":"            else:"},{"line_number":157,"context_line":"                raise exception.InstanceDeployFailure(reason\u003dmsg)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        target_raid_config \u003d raid.filter_target_raid_config("},{"line_number":160,"context_line":"            node, create_root_volume\u003dcreate_root_volume,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_7651dc61","line":157,"in_reply_to":"7faddb67_fd8a9218","updated":"2019-08-21 06:44:10.000000000","message":"Done","commit_id":"6573a1dccf5eae8b89aab3623395a64b3b495f85"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"11f7348ca31df23f33e9e1fa14a76e9b1b466787","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                        fields.append(\u0027skip_current_clean_step\u0027)"},{"line_number":199,"context_line":"                    else:"},{"line_number":200,"context_line":"                        fields.append(\u0027skip_current_deploy_step\u0027)"},{"line_number":201,"context_line":"                    self._pop_driver_internal_values(task, *fields)"},{"line_number":202,"context_line":"                    msg \u003d _(\"Step create_configuration failed \""},{"line_number":203,"context_line":"                            \"on node %(node)s with error: %(err)s\")"},{"line_number":204,"context_line":"                    if node.clean_step:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_1d0a0e89","line":201,"updated":"2019-08-20 20:50:40.000000000","message":"Looks to me like L196-201 are repeated above in L187-192. I\u0027m not sure you want to pop those values before L184. but you could set up fields before the \u0027if\u0027 at L183.","commit_id":"6573a1dccf5eae8b89aab3623395a64b3b495f85"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2c878245467de7b93e837903a092f5f8fe1548d3","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                        fields.append(\u0027skip_current_clean_step\u0027)"},{"line_number":199,"context_line":"                    else:"},{"line_number":200,"context_line":"                        fields.append(\u0027skip_current_deploy_step\u0027)"},{"line_number":201,"context_line":"                    self._pop_driver_internal_values(task, *fields)"},{"line_number":202,"context_line":"                    msg \u003d _(\"Step create_configuration failed \""},{"line_number":203,"context_line":"                            \"on node %(node)s with error: %(err)s\")"},{"line_number":204,"context_line":"                    if node.clean_step:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_168f48cd","line":201,"in_reply_to":"7faddb67_1d0a0e89","updated":"2019-08-21 06:44:10.000000000","message":"Done","commit_id":"6573a1dccf5eae8b89aab3623395a64b3b495f85"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"11f7348ca31df23f33e9e1fa14a76e9b1b466787","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                            msg % {\u0027node\u0027: node.uuid, \u0027err\u0027: msg})"},{"line_number":207,"context_line":"                    else:"},{"line_number":208,"context_line":"                        raise exception.InstanceDeployFailure("},{"line_number":209,"context_line":"                            reason\u003d(msg % {\u0027node\u0027: node.uuid, \u0027err\u0027: msg}))"},{"line_number":210,"context_line":"        except ilo_error.IloError as ilo_exception:"},{"line_number":211,"context_line":"            operation \u003d (_(\"Failed to create raid configuration on node %s\")"},{"line_number":212,"context_line":"                         % node.uuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_1d99ae1d","line":209,"updated":"2019-08-20 20:50:40.000000000","message":"you need the message regardless, so might as well do that once at L202. msg \u003d _(..) % {\u0027node\u0027...}\n\nhmm. Do you have two msg? L195 and L202? Which do you want? And... I think there is something wrong with this, msg seems a bit recursive:\n    msg % {\u0027node\u0027: node.uuid, \u0027err\u0027: msg}","commit_id":"6573a1dccf5eae8b89aab3623395a64b3b495f85"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2c878245467de7b93e837903a092f5f8fe1548d3","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                            msg % {\u0027node\u0027: node.uuid, \u0027err\u0027: msg})"},{"line_number":207,"context_line":"                    else:"},{"line_number":208,"context_line":"                        raise exception.InstanceDeployFailure("},{"line_number":209,"context_line":"                            reason\u003d(msg % {\u0027node\u0027: node.uuid, \u0027err\u0027: msg}))"},{"line_number":210,"context_line":"        except ilo_error.IloError as ilo_exception:"},{"line_number":211,"context_line":"            operation \u003d (_(\"Failed to create raid configuration on node %s\")"},{"line_number":212,"context_line":"                         % node.uuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_96b49883","line":209,"in_reply_to":"7faddb67_1d99ae1d","updated":"2019-08-21 06:44:10.000000000","message":"Done","commit_id":"6573a1dccf5eae8b89aab3623395a64b3b495f85"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"11f7348ca31df23f33e9e1fa14a76e9b1b466787","unresolved":false,"context_lines":[{"line_number":271,"context_line":"                            err_msg % {\u0027node\u0027: node.uuid, \u0027err\u0027: msg})"},{"line_number":272,"context_line":"                    else:"},{"line_number":273,"context_line":"                        raise exception.InstanceDeployFailure("},{"line_number":274,"context_line":"                            reason\u003d(err_msg % {\u0027node\u0027: node.uuid, \u0027err\u0027: msg}))"},{"line_number":275,"context_line":"        except ilo_error.IloLogicalDriveNotFoundError:"},{"line_number":276,"context_line":"            LOG.info(\"No logical drive found to delete on node %(node)s\","},{"line_number":277,"context_line":"                     {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_980e0c30","line":274,"updated":"2019-08-20 20:50:40.000000000","message":"similar comments as in create_configuration()","commit_id":"6573a1dccf5eae8b89aab3623395a64b3b495f85"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2c878245467de7b93e837903a092f5f8fe1548d3","unresolved":false,"context_lines":[{"line_number":271,"context_line":"                            err_msg % {\u0027node\u0027: node.uuid, \u0027err\u0027: msg})"},{"line_number":272,"context_line":"                    else:"},{"line_number":273,"context_line":"                        raise exception.InstanceDeployFailure("},{"line_number":274,"context_line":"                            reason\u003d(err_msg % {\u0027node\u0027: node.uuid, \u0027err\u0027: msg}))"},{"line_number":275,"context_line":"        except ilo_error.IloLogicalDriveNotFoundError:"},{"line_number":276,"context_line":"            LOG.info(\"No logical drive found to delete on node %(node)s\","},{"line_number":277,"context_line":"                     {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_d1d3fa36","line":274,"in_reply_to":"7faddb67_980e0c30","updated":"2019-08-21 06:44:10.000000000","message":"Done","commit_id":"6573a1dccf5eae8b89aab3623395a64b3b495f85"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"62d6563d3462ead7807d313d469dd649e2d62a19","unresolved":false,"context_lines":[{"line_number":248,"context_line":"                    node.raid_config \u003d {}"},{"line_number":249,"context_line":"                    LOG.debug(\"Node %(uuid)s raid delete clean step is done.\","},{"line_number":250,"context_line":"                              {\u0027uuid\u0027: node.uuid})"},{"line_number":251,"context_line":"                    fields \u003d [\u0027ilo_raid_delete_in_progress\u0027]"},{"line_number":252,"context_line":"                    if node.clean_step:"},{"line_number":253,"context_line":"                        fields.append(\u0027skip_current_clean_step\u0027)"},{"line_number":254,"context_line":"                    else:"},{"line_number":255,"context_line":"                        fields.append(\u0027skip_current_deploy_step\u0027)"},{"line_number":256,"context_line":"                    self._pop_driver_internal_values(task, *fields)"},{"line_number":257,"context_line":"                else:"},{"line_number":258,"context_line":"                    # Raid configuration failed"},{"line_number":259,"context_line":"                    err_msg \u003d (_(\"Step delete_configuration failed \""}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_ce8d8c31","line":256,"range":{"start_line":251,"start_character":1,"end_line":256,"end_character":67},"updated":"2019-08-21 14:57:22.000000000","message":"We don\u0027t need these lines.","commit_id":"26a06b6d77f2b6e1c61cc9927fb48074d03e60df"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"698cdefdffcfae7dc4ff516a88e8affbe538dcd4","unresolved":false,"context_lines":[{"line_number":248,"context_line":"                    node.raid_config \u003d {}"},{"line_number":249,"context_line":"                    LOG.debug(\"Node %(uuid)s raid delete clean step is done.\","},{"line_number":250,"context_line":"                              {\u0027uuid\u0027: node.uuid})"},{"line_number":251,"context_line":"                    fields \u003d [\u0027ilo_raid_delete_in_progress\u0027]"},{"line_number":252,"context_line":"                    if node.clean_step:"},{"line_number":253,"context_line":"                        fields.append(\u0027skip_current_clean_step\u0027)"},{"line_number":254,"context_line":"                    else:"},{"line_number":255,"context_line":"                        fields.append(\u0027skip_current_deploy_step\u0027)"},{"line_number":256,"context_line":"                    self._pop_driver_internal_values(task, *fields)"},{"line_number":257,"context_line":"                else:"},{"line_number":258,"context_line":"                    # Raid configuration failed"},{"line_number":259,"context_line":"                    err_msg \u003d (_(\"Step delete_configuration failed \""}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_70ff8b00","line":256,"range":{"start_line":251,"start_character":1,"end_line":256,"end_character":67},"in_reply_to":"7faddb67_ce8d8c31","updated":"2019-08-22 04:46:54.000000000","message":"Oops. Sorry for that.","commit_id":"26a06b6d77f2b6e1c61cc9927fb48074d03e60df"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"93d37a684cd33694e83cbb62eeaa3818b9f14cad","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                            create_nonroot_volumes\u003dFalse,"},{"line_number":93,"context_line":"                            delete_existing\u003dTrue):"},{"line_number":94,"context_line":"        return super(Ilo5RAID, self).apply_configuration("},{"line_number":95,"context_line":"            task, raid_config, create_root_volume\u003dcreate_root_volume,"},{"line_number":96,"context_line":"            create_nonroot_volumes\u003dcreate_nonroot_volumes,"},{"line_number":97,"context_line":"            delete_existing\u003ddelete_existing)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    @METRICS.timer(\u0027Ilo5RAID.create_configuration\u0027)"},{"line_number":100,"context_line":"    @base.clean_step(priority\u003d0, abortable\u003dFalse, argsinfo\u003d{"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_c925035e","line":97,"range":{"start_line":95,"start_character":31,"end_line":97,"end_character":44},"updated":"2019-08-29 09:06:29.000000000","message":"this can be specified as non-keyword args","commit_id":"e043490184efd4dda2de8cf30fc3318f9c338f4a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d225de97f49c61e3831b412832f6369925be6484","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                            create_nonroot_volumes\u003dFalse,"},{"line_number":93,"context_line":"                            delete_existing\u003dTrue):"},{"line_number":94,"context_line":"        return super(Ilo5RAID, self).apply_configuration("},{"line_number":95,"context_line":"            task, raid_config, create_root_volume\u003dcreate_root_volume,"},{"line_number":96,"context_line":"            create_nonroot_volumes\u003dcreate_nonroot_volumes,"},{"line_number":97,"context_line":"            delete_existing\u003ddelete_existing)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    @METRICS.timer(\u0027Ilo5RAID.create_configuration\u0027)"},{"line_number":100,"context_line":"    @base.clean_step(priority\u003d0, abortable\u003dFalse, argsinfo\u003d{"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_b498ec1a","line":97,"range":{"start_line":95,"start_character":31,"end_line":97,"end_character":44},"in_reply_to":"7faddb67_4908017f","updated":"2019-09-02 16:26:05.000000000","message":"Done","commit_id":"e043490184efd4dda2de8cf30fc3318f9c338f4a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f7f5d07b54c70a9ca1785162be7674cc1e6e80d5","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                            create_nonroot_volumes\u003dFalse,"},{"line_number":93,"context_line":"                            delete_existing\u003dTrue):"},{"line_number":94,"context_line":"        return super(Ilo5RAID, self).apply_configuration("},{"line_number":95,"context_line":"            task, raid_config, create_root_volume\u003dcreate_root_volume,"},{"line_number":96,"context_line":"            create_nonroot_volumes\u003dcreate_nonroot_volumes,"},{"line_number":97,"context_line":"            delete_existing\u003ddelete_existing)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    @METRICS.timer(\u0027Ilo5RAID.create_configuration\u0027)"},{"line_number":100,"context_line":"    @base.clean_step(priority\u003d0, abortable\u003dFalse, argsinfo\u003d{"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_4908017f","line":97,"range":{"start_line":95,"start_character":31,"end_line":97,"end_character":44},"in_reply_to":"7faddb67_5b10f24f","updated":"2019-09-02 14:24:10.000000000","message":"I agree with Ruby.\n\nAnother comment: delete_existing is not supported, let\u0027s remove it.","commit_id":"e043490184efd4dda2de8cf30fc3318f9c338f4a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4cdc1116ad13616c572aa5cbf2a3fc7d59484708","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                            create_nonroot_volumes\u003dFalse,"},{"line_number":93,"context_line":"                            delete_existing\u003dTrue):"},{"line_number":94,"context_line":"        return super(Ilo5RAID, self).apply_configuration("},{"line_number":95,"context_line":"            task, raid_config, create_root_volume\u003dcreate_root_volume,"},{"line_number":96,"context_line":"            create_nonroot_volumes\u003dcreate_nonroot_volumes,"},{"line_number":97,"context_line":"            delete_existing\u003ddelete_existing)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    @METRICS.timer(\u0027Ilo5RAID.create_configuration\u0027)"},{"line_number":100,"context_line":"    @base.clean_step(priority\u003d0, abortable\u003dFalse, argsinfo\u003d{"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_5b10f24f","line":97,"range":{"start_line":95,"start_character":31,"end_line":97,"end_character":44},"in_reply_to":"7faddb67_c925035e","updated":"2019-08-29 15:58:11.000000000","message":"they can, but prefer that we don\u0027t. if non-keyword, the order of the args is important. since the method itself has keyword args we should call it that way. I\u0027ve seen errors due to specifying non-keyword and the method being called gets updated with new args or whatever, and things break.","commit_id":"e043490184efd4dda2de8cf30fc3318f9c338f4a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f7f5d07b54c70a9ca1785162be7674cc1e6e80d5","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            ),"},{"line_number":113,"context_line":"            \u0027required\u0027: False"},{"line_number":114,"context_line":"        },"},{"line_number":115,"context_line":"        \"delete_existing\": {"},{"line_number":116,"context_line":"            \"description\": ("},{"line_number":117,"context_line":"                \"Setting this to \u0027True\u0027 indicates to delete existing RAID \""},{"line_number":118,"context_line":"                \"configuration prior to creating the new configuration. \""},{"line_number":119,"context_line":"                \"Default value is \u0027True\u0027.\""},{"line_number":120,"context_line":"            ),"},{"line_number":121,"context_line":"            \"required\": False,"},{"line_number":122,"context_line":"        }"},{"line_number":123,"context_line":"    })"},{"line_number":124,"context_line":"    def create_configuration(self, task, create_root_volume\u003dTrue,"},{"line_number":125,"context_line":"                             create_nonroot_volumes\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_a91735a3","line":122,"range":{"start_line":115,"start_character":0,"end_line":122,"end_character":9},"updated":"2019-09-02 14:24:10.000000000","message":"Only True is supported, what\u0027s the point of having it at all?","commit_id":"e043490184efd4dda2de8cf30fc3318f9c338f4a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d225de97f49c61e3831b412832f6369925be6484","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            ),"},{"line_number":113,"context_line":"            \u0027required\u0027: False"},{"line_number":114,"context_line":"        },"},{"line_number":115,"context_line":"        \"delete_existing\": {"},{"line_number":116,"context_line":"            \"description\": ("},{"line_number":117,"context_line":"                \"Setting this to \u0027True\u0027 indicates to delete existing RAID \""},{"line_number":118,"context_line":"                \"configuration prior to creating the new configuration. \""},{"line_number":119,"context_line":"                \"Default value is \u0027True\u0027.\""},{"line_number":120,"context_line":"            ),"},{"line_number":121,"context_line":"            \"required\": False,"},{"line_number":122,"context_line":"        }"},{"line_number":123,"context_line":"    })"},{"line_number":124,"context_line":"    def create_configuration(self, task, create_root_volume\u003dTrue,"},{"line_number":125,"context_line":"                             create_nonroot_volumes\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_f4f42457","line":122,"range":{"start_line":115,"start_character":0,"end_line":122,"end_character":9},"in_reply_to":"7faddb67_a91735a3","updated":"2019-09-02 16:26:05.000000000","message":"Done","commit_id":"e043490184efd4dda2de8cf30fc3318f9c338f4a"}]}