)]}'
{"ironic/drivers/modules/ilo/management.py":[{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"5e392eb6f24ffaa4a79f42b14afde72fa4454eed","unresolved":false,"context_lines":[{"line_number":67,"context_line":"_RESET_ILO_CREDENTIALS_ARGSINFO \u003d {"},{"line_number":68,"context_line":"    \u0027ilo_password\u0027: {"},{"line_number":69,"context_line":"        \u0027description\u0027: ("},{"line_number":70,"context_line":"            \u0027Password string for iLO user with administrative previleges \u0027"},{"line_number":71,"context_line":"            \u0027being set in the driver_info property \"ilo_username\".\u0027"},{"line_number":72,"context_line":"        ),"},{"line_number":73,"context_line":"        \u0027required\u0027: True"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_a9df6736","line":70,"range":{"start_line":70,"start_character":62,"end_line":70,"end_character":72},"updated":"2019-08-29 09:17:06.000000000","message":"s/previleges/privileges/","commit_id":"1328e0e039358872cd10cedf9f28499781116230"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2dfda69e95221bf7d9018336a674a7ee91904b00","unresolved":false,"context_lines":[{"line_number":67,"context_line":"_RESET_ILO_CREDENTIALS_ARGSINFO \u003d {"},{"line_number":68,"context_line":"    \u0027ilo_password\u0027: {"},{"line_number":69,"context_line":"        \u0027description\u0027: ("},{"line_number":70,"context_line":"            \u0027Password string for iLO user with administrative previleges \u0027"},{"line_number":71,"context_line":"            \u0027being set in the driver_info property \"ilo_username\".\u0027"},{"line_number":72,"context_line":"        ),"},{"line_number":73,"context_line":"        \u0027required\u0027: True"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_94613014","line":70,"range":{"start_line":70,"start_character":62,"end_line":70,"end_character":72},"in_reply_to":"7faddb67_a9df6736","updated":"2019-09-02 16:26:44.000000000","message":"Done","commit_id":"1328e0e039358872cd10cedf9f28499781116230"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"19b2572fa1fa86c280b7ff2fa4466fe80eb93e3d","unresolved":false,"context_lines":[{"line_number":323,"context_line":"    @METRICS.timer(\u0027IloManagement.reset_ilo_credential\u0027)"},{"line_number":324,"context_line":"    @base.deploy_step(priority\u003d0, argsinfo\u003d_RESET_ILO_CREDENTIALS_ARGSINFO)"},{"line_number":325,"context_line":"    @base.clean_step(priority\u003dCONF.ilo.clean_priority_reset_ilo_credential)"},{"line_number":326,"context_line":"    def reset_ilo_credential(self, task, **kwargs):"},{"line_number":327,"context_line":"        \"\"\"Resets the iLO password."},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        :param task: a task from TaskManager."}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_c94951b8","line":326,"range":{"start_line":326,"start_character":41,"end_line":326,"end_character":49},"updated":"2019-09-02 14:29:59.000000000","message":"nit: you can use `ilo_change_password\u003dNone`. Speaking of which, you don\u0027t have to prefix is with ilo_.","commit_id":"1328e0e039358872cd10cedf9f28499781116230"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2dfda69e95221bf7d9018336a674a7ee91904b00","unresolved":false,"context_lines":[{"line_number":323,"context_line":"    @METRICS.timer(\u0027IloManagement.reset_ilo_credential\u0027)"},{"line_number":324,"context_line":"    @base.deploy_step(priority\u003d0, argsinfo\u003d_RESET_ILO_CREDENTIALS_ARGSINFO)"},{"line_number":325,"context_line":"    @base.clean_step(priority\u003dCONF.ilo.clean_priority_reset_ilo_credential)"},{"line_number":326,"context_line":"    def reset_ilo_credential(self, task, **kwargs):"},{"line_number":327,"context_line":"        \"\"\"Resets the iLO password."},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        :param task: a task from TaskManager."}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_cf5dd116","line":326,"range":{"start_line":326,"start_character":41,"end_line":326,"end_character":49},"in_reply_to":"7faddb67_c94951b8","updated":"2019-09-02 16:26:44.000000000","message":"Done","commit_id":"1328e0e039358872cd10cedf9f28499781116230"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"19b2572fa1fa86c280b7ff2fa4466fe80eb93e3d","unresolved":false,"context_lines":[{"line_number":393,"context_line":"        \"\"\""},{"line_number":394,"context_line":"        return _execute_ilo_step(task.node, \u0027clear_secure_boot_keys\u0027)"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"    @METRICS.timer(\u0027IloManagement.activate_license\u0027)"},{"line_number":397,"context_line":"    @base.deploy_step(priority\u003d0, argsinfo\u003d_ACTIVATE_ILO_LICENSE_ARGSINFO)"},{"line_number":398,"context_line":"    @base.clean_step(priority\u003d0, abortable\u003dFalse,"},{"line_number":399,"context_line":"                     argsinfo\u003d_ACTIVATE_ILO_LICENSE_ARGSINFO)"},{"line_number":400,"context_line":"    def activate_license(self, task, **kwargs):"},{"line_number":401,"context_line":"        \"\"\"Activates iLO Advanced license."},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        :param task: a TaskManager object."}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_89603937","line":400,"range":{"start_line":396,"start_character":0,"end_line":400,"end_character":47},"updated":"2019-09-02 14:29:59.000000000","message":"What\u0027s the use case for making this a deploy step? I don\u0027t think you\u0027ll want your users to pick an activation via Nova?","commit_id":"1328e0e039358872cd10cedf9f28499781116230"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2dfda69e95221bf7d9018336a674a7ee91904b00","unresolved":false,"context_lines":[{"line_number":393,"context_line":"        \"\"\""},{"line_number":394,"context_line":"        return _execute_ilo_step(task.node, \u0027clear_secure_boot_keys\u0027)"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"    @METRICS.timer(\u0027IloManagement.activate_license\u0027)"},{"line_number":397,"context_line":"    @base.deploy_step(priority\u003d0, argsinfo\u003d_ACTIVATE_ILO_LICENSE_ARGSINFO)"},{"line_number":398,"context_line":"    @base.clean_step(priority\u003d0, abortable\u003dFalse,"},{"line_number":399,"context_line":"                     argsinfo\u003d_ACTIVATE_ILO_LICENSE_ARGSINFO)"},{"line_number":400,"context_line":"    def activate_license(self, task, **kwargs):"},{"line_number":401,"context_line":"        \"\"\"Activates iLO Advanced license."},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        :param task: a TaskManager object."}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_4f1c8165","line":400,"range":{"start_line":396,"start_character":0,"end_line":400,"end_character":47},"in_reply_to":"7faddb67_89603937","updated":"2019-09-02 16:26:44.000000000","message":"Makes sense. Removed.","commit_id":"1328e0e039358872cd10cedf9f28499781116230"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"5e392eb6f24ffaa4a79f42b14afde72fa4454eed","unresolved":false,"context_lines":[{"line_number":432,"context_line":"        :param task: a TaskManager object."},{"line_number":433,"context_line":"        :raises: InvalidParameterValue if update firmware mode is not \u0027ilo\u0027."},{"line_number":434,"context_line":"                 Even applicable for invalid input cases."},{"line_number":435,"context_line":"        :raises: NodeCleaningFailure, on failure to execute step."},{"line_number":436,"context_line":"        :raises: NodeCleaningFailure, on failure to execute of clean step."},{"line_number":437,"context_line":"        :raises: InstanceDeployFailure, on failure to execute of deploy step."},{"line_number":438,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_49759331","line":435,"range":{"start_line":435,"start_character":8,"end_line":435,"end_character":65},"updated":"2019-08-29 09:17:06.000000000","message":"Duplicate statement. Please remove this.","commit_id":"1328e0e039358872cd10cedf9f28499781116230"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2dfda69e95221bf7d9018336a674a7ee91904b00","unresolved":false,"context_lines":[{"line_number":432,"context_line":"        :param task: a TaskManager object."},{"line_number":433,"context_line":"        :raises: InvalidParameterValue if update firmware mode is not \u0027ilo\u0027."},{"line_number":434,"context_line":"                 Even applicable for invalid input cases."},{"line_number":435,"context_line":"        :raises: NodeCleaningFailure, on failure to execute step."},{"line_number":436,"context_line":"        :raises: NodeCleaningFailure, on failure to execute of clean step."},{"line_number":437,"context_line":"        :raises: InstanceDeployFailure, on failure to execute of deploy step."},{"line_number":438,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_8f4b595d","line":435,"range":{"start_line":435,"start_character":8,"end_line":435,"end_character":65},"in_reply_to":"7faddb67_49759331","updated":"2019-09-02 16:26:44.000000000","message":"Done","commit_id":"1328e0e039358872cd10cedf9f28499781116230"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a2c07d71a2712db3b2e46087184429c9b784d24d","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            \"The list of firmware component filenames. If not specified, \""},{"line_number":120,"context_line":"            \"SUM updates all the firmware components.\""},{"line_number":121,"context_line":"        ),"},{"line_number":122,"context_line":"        \u0027required\u0027: False}"},{"line_number":123,"context_line":"}"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_0bd04ff7","line":122,"updated":"2019-09-17 15:56:32.000000000","message":"nit, you\u0027re a bit inconsistent here, in the above, the closing bracket is on a separate line.","commit_id":"a70fab4a262aea02304a23e76bfd4371fa1869b6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4dd4a46bcab939a22f897af4830ef2e0a85c829b","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            \"The list of firmware component filenames. If not specified, \""},{"line_number":120,"context_line":"            \"SUM updates all the firmware components.\""},{"line_number":121,"context_line":"        ),"},{"line_number":122,"context_line":"        \u0027required\u0027: False}"},{"line_number":123,"context_line":"}"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_fd3496e0","line":122,"in_reply_to":"3fa7e38b_0bd04ff7","updated":"2019-09-17 16:22:39.000000000","message":"Done","commit_id":"a70fab4a262aea02304a23e76bfd4371fa1869b6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a2c07d71a2712db3b2e46087184429c9b784d24d","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"def _execute_ilo_step(node, step, *args, **kwargs):"},{"line_number":127,"context_line":"    \"\"\"Executes a particular clean step."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    :param node: an Ironic node object."},{"line_number":130,"context_line":"    :param step: a clean step to be executed."}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_8b051f7d","line":127,"updated":"2019-09-17 15:56:32.000000000","message":"it isn\u0027t just a clean step, right? deploy or clean step?","commit_id":"a70fab4a262aea02304a23e76bfd4371fa1869b6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4dd4a46bcab939a22f897af4830ef2e0a85c829b","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"def _execute_ilo_step(node, step, *args, **kwargs):"},{"line_number":127,"context_line":"    \"\"\"Executes a particular clean step."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    :param node: an Ironic node object."},{"line_number":130,"context_line":"    :param step: a clean step to be executed."}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_dd519a10","line":127,"in_reply_to":"3fa7e38b_8b051f7d","updated":"2019-09-17 16:22:39.000000000","message":"Done","commit_id":"a70fab4a262aea02304a23e76bfd4371fa1869b6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a2c07d71a2712db3b2e46087184429c9b784d24d","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    \"\"\"Executes a particular clean step."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    :param node: an Ironic node object."},{"line_number":130,"context_line":"    :param step: a clean step to be executed."},{"line_number":131,"context_line":"    :param args: The args to be passed to the clean step."},{"line_number":132,"context_line":"    :param kwargs: The kwargs to be passed to the clean step."},{"line_number":133,"context_line":"    :raises: NodeCleaningFailure, on failure to execute of clean step."}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_4bff2767","line":130,"updated":"2019-09-17 15:56:32.000000000","message":"s/clean //","commit_id":"a70fab4a262aea02304a23e76bfd4371fa1869b6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4dd4a46bcab939a22f897af4830ef2e0a85c829b","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    \"\"\"Executes a particular clean step."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    :param node: an Ironic node object."},{"line_number":130,"context_line":"    :param step: a clean step to be executed."},{"line_number":131,"context_line":"    :param args: The args to be passed to the clean step."},{"line_number":132,"context_line":"    :param kwargs: The kwargs to be passed to the clean step."},{"line_number":133,"context_line":"    :raises: NodeCleaningFailure, on failure to execute of clean step."}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_3d40ee35","line":130,"in_reply_to":"3fa7e38b_4bff2767","updated":"2019-09-17 16:22:39.000000000","message":"Done","commit_id":"a70fab4a262aea02304a23e76bfd4371fa1869b6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a2c07d71a2712db3b2e46087184429c9b784d24d","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    :param node: an Ironic node object."},{"line_number":130,"context_line":"    :param step: a clean step to be executed."},{"line_number":131,"context_line":"    :param args: The args to be passed to the clean step."},{"line_number":132,"context_line":"    :param kwargs: The kwargs to be passed to the clean step."},{"line_number":133,"context_line":"    :raises: NodeCleaningFailure, on failure to execute of clean step."},{"line_number":134,"context_line":"    :raises: InstanceDeployFailure, on failure to execute of deploy step."}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_2bf66b91","line":131,"updated":"2019-09-17 15:56:32.000000000","message":"s/clean //","commit_id":"a70fab4a262aea02304a23e76bfd4371fa1869b6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4dd4a46bcab939a22f897af4830ef2e0a85c829b","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    :param node: an Ironic node object."},{"line_number":130,"context_line":"    :param step: a clean step to be executed."},{"line_number":131,"context_line":"    :param args: The args to be passed to the clean step."},{"line_number":132,"context_line":"    :param kwargs: The kwargs to be passed to the clean step."},{"line_number":133,"context_line":"    :raises: NodeCleaningFailure, on failure to execute of clean step."},{"line_number":134,"context_line":"    :raises: InstanceDeployFailure, on failure to execute of deploy step."}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_fd49f65f","line":131,"in_reply_to":"3fa7e38b_2bf66b91","updated":"2019-09-17 16:22:39.000000000","message":"Done","commit_id":"a70fab4a262aea02304a23e76bfd4371fa1869b6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a2c07d71a2712db3b2e46087184429c9b784d24d","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    :param node: an Ironic node object."},{"line_number":130,"context_line":"    :param step: a clean step to be executed."},{"line_number":131,"context_line":"    :param args: The args to be passed to the clean step."},{"line_number":132,"context_line":"    :param kwargs: The kwargs to be passed to the clean step."},{"line_number":133,"context_line":"    :raises: NodeCleaningFailure, on failure to execute of clean step."},{"line_number":134,"context_line":"    :raises: InstanceDeployFailure, on failure to execute of deploy step."},{"line_number":135,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_cbf2379b","line":132,"updated":"2019-09-17 15:56:32.000000000","message":"s/clean //","commit_id":"a70fab4a262aea02304a23e76bfd4371fa1869b6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4dd4a46bcab939a22f897af4830ef2e0a85c829b","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    :param node: an Ironic node object."},{"line_number":130,"context_line":"    :param step: a clean step to be executed."},{"line_number":131,"context_line":"    :param args: The args to be passed to the clean step."},{"line_number":132,"context_line":"    :param kwargs: The kwargs to be passed to the clean step."},{"line_number":133,"context_line":"    :raises: NodeCleaningFailure, on failure to execute of clean step."},{"line_number":134,"context_line":"    :raises: InstanceDeployFailure, on failure to execute of deploy step."},{"line_number":135,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_bd75be9a","line":132,"in_reply_to":"3fa7e38b_cbf2379b","updated":"2019-09-17 16:22:39.000000000","message":"Done","commit_id":"a70fab4a262aea02304a23e76bfd4371fa1869b6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a2c07d71a2712db3b2e46087184429c9b784d24d","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    :param step: a clean step to be executed."},{"line_number":131,"context_line":"    :param args: The args to be passed to the clean step."},{"line_number":132,"context_line":"    :param kwargs: The kwargs to be passed to the clean step."},{"line_number":133,"context_line":"    :raises: NodeCleaningFailure, on failure to execute of clean step."},{"line_number":134,"context_line":"    :raises: InstanceDeployFailure, on failure to execute of deploy step."},{"line_number":135,"context_line":"    \"\"\""},{"line_number":136,"context_line":"    ilo_object \u003d ilo_common.get_ilo_object(node)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_8b78bff8","line":133,"updated":"2019-09-17 15:56:32.000000000","message":"nit s/of clean/the clean/ ?","commit_id":"a70fab4a262aea02304a23e76bfd4371fa1869b6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4dd4a46bcab939a22f897af4830ef2e0a85c829b","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    :param step: a clean step to be executed."},{"line_number":131,"context_line":"    :param args: The args to be passed to the clean step."},{"line_number":132,"context_line":"    :param kwargs: The kwargs to be passed to the clean step."},{"line_number":133,"context_line":"    :raises: NodeCleaningFailure, on failure to execute of clean step."},{"line_number":134,"context_line":"    :raises: InstanceDeployFailure, on failure to execute of deploy step."},{"line_number":135,"context_line":"    \"\"\""},{"line_number":136,"context_line":"    ilo_object \u003d ilo_common.get_ilo_object(node)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_7d6f46c5","line":133,"in_reply_to":"3fa7e38b_8b78bff8","updated":"2019-09-17 16:22:39.000000000","message":"Done","commit_id":"a70fab4a262aea02304a23e76bfd4371fa1869b6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a2c07d71a2712db3b2e46087184429c9b784d24d","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    :param args: The args to be passed to the clean step."},{"line_number":132,"context_line":"    :param kwargs: The kwargs to be passed to the clean step."},{"line_number":133,"context_line":"    :raises: NodeCleaningFailure, on failure to execute of clean step."},{"line_number":134,"context_line":"    :raises: InstanceDeployFailure, on failure to execute of deploy step."},{"line_number":135,"context_line":"    \"\"\""},{"line_number":136,"context_line":"    ilo_object \u003d ilo_common.get_ilo_object(node)"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_4b82c7ca","line":134,"updated":"2019-09-17 15:56:32.000000000","message":"ditto","commit_id":"a70fab4a262aea02304a23e76bfd4371fa1869b6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4dd4a46bcab939a22f897af4830ef2e0a85c829b","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    :param args: The args to be passed to the clean step."},{"line_number":132,"context_line":"    :param kwargs: The kwargs to be passed to the clean step."},{"line_number":133,"context_line":"    :raises: NodeCleaningFailure, on failure to execute of clean step."},{"line_number":134,"context_line":"    :raises: InstanceDeployFailure, on failure to execute of deploy step."},{"line_number":135,"context_line":"    \"\"\""},{"line_number":136,"context_line":"    ilo_object \u003d ilo_common.get_ilo_object(node)"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_5d660af0","line":134,"in_reply_to":"3fa7e38b_4b82c7ca","updated":"2019-09-17 16:22:39.000000000","message":"Done","commit_id":"a70fab4a262aea02304a23e76bfd4371fa1869b6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a2c07d71a2712db3b2e46087184429c9b784d24d","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    try:"},{"line_number":150,"context_line":"        step_method(*args, **kwargs)"},{"line_number":151,"context_line":"    except ilo_error.IloCommandNotSupportedError:"},{"line_number":152,"context_line":"        # This clean step is not supported on Gen8 and below servers."},{"line_number":153,"context_line":"        # Log the failure and continue with cleaning."},{"line_number":154,"context_line":"        LOG.warning(\"\u0027%(step)s\u0027 step is not supported on node \""},{"line_number":155,"context_line":"                    \"%(uuid)s. Skipping the step.\","}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_ab66db50","line":152,"updated":"2019-09-17 15:56:32.000000000","message":"s/clean //","commit_id":"a70fab4a262aea02304a23e76bfd4371fa1869b6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4dd4a46bcab939a22f897af4830ef2e0a85c829b","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    try:"},{"line_number":150,"context_line":"        step_method(*args, **kwargs)"},{"line_number":151,"context_line":"    except ilo_error.IloCommandNotSupportedError:"},{"line_number":152,"context_line":"        # This clean step is not supported on Gen8 and below servers."},{"line_number":153,"context_line":"        # Log the failure and continue with cleaning."},{"line_number":154,"context_line":"        LOG.warning(\"\u0027%(step)s\u0027 step is not supported on node \""},{"line_number":155,"context_line":"                    \"%(uuid)s. Skipping the step.\","}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_dd9f5ab2","line":152,"in_reply_to":"3fa7e38b_ab66db50","updated":"2019-09-17 16:22:39.000000000","message":"Done","commit_id":"a70fab4a262aea02304a23e76bfd4371fa1869b6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a2c07d71a2712db3b2e46087184429c9b784d24d","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        step_method(*args, **kwargs)"},{"line_number":151,"context_line":"    except ilo_error.IloCommandNotSupportedError:"},{"line_number":152,"context_line":"        # This clean step is not supported on Gen8 and below servers."},{"line_number":153,"context_line":"        # Log the failure and continue with cleaning."},{"line_number":154,"context_line":"        LOG.warning(\"\u0027%(step)s\u0027 step is not supported on node \""},{"line_number":155,"context_line":"                    \"%(uuid)s. Skipping the step.\","},{"line_number":156,"context_line":"                    {\u0027step\u0027: step, \u0027uuid\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_6b60e333","line":153,"updated":"2019-09-17 15:56:32.000000000","message":"s/cleaning/cleaning or deployment/ ?","commit_id":"a70fab4a262aea02304a23e76bfd4371fa1869b6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4dd4a46bcab939a22f897af4830ef2e0a85c829b","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        step_method(*args, **kwargs)"},{"line_number":151,"context_line":"    except ilo_error.IloCommandNotSupportedError:"},{"line_number":152,"context_line":"        # This clean step is not supported on Gen8 and below servers."},{"line_number":153,"context_line":"        # Log the failure and continue with cleaning."},{"line_number":154,"context_line":"        LOG.warning(\"\u0027%(step)s\u0027 step is not supported on node \""},{"line_number":155,"context_line":"                    \"%(uuid)s. Skipping the step.\","},{"line_number":156,"context_line":"                    {\u0027step\u0027: step, \u0027uuid\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_5dab6ad5","line":153,"in_reply_to":"3fa7e38b_6b60e333","updated":"2019-09-17 16:22:39.000000000","message":"Done","commit_id":"a70fab4a262aea02304a23e76bfd4371fa1869b6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a2c07d71a2712db3b2e46087184429c9b784d24d","unresolved":false,"context_lines":[{"line_number":506,"context_line":"            for fw_loc_obj_n_comp_tup in fw_location_objs_n_components:"},{"line_number":507,"context_line":"                fw_loc_obj_n_comp_tup[0].remove()"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"        # Firmware might have ejected the virtual media, if its was used."},{"line_number":510,"context_line":"        # Re-create the environment for agent boot, if required"},{"line_number":511,"context_line":"        task.driver.boot.clean_up_ramdisk(task)"},{"line_number":512,"context_line":"        deploy_opts \u003d deploy_utils.build_agent_options(node)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_0b884fc4","line":509,"updated":"2019-09-17 15:56:32.000000000","message":"nit s/its/it/","commit_id":"a70fab4a262aea02304a23e76bfd4371fa1869b6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4dd4a46bcab939a22f897af4830ef2e0a85c829b","unresolved":false,"context_lines":[{"line_number":506,"context_line":"            for fw_loc_obj_n_comp_tup in fw_location_objs_n_components:"},{"line_number":507,"context_line":"                fw_loc_obj_n_comp_tup[0].remove()"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"        # Firmware might have ejected the virtual media, if its was used."},{"line_number":510,"context_line":"        # Re-create the environment for agent boot, if required"},{"line_number":511,"context_line":"        task.driver.boot.clean_up_ramdisk(task)"},{"line_number":512,"context_line":"        deploy_opts \u003d deploy_utils.build_agent_options(node)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_9d82424f","line":509,"in_reply_to":"3fa7e38b_0b884fc4","updated":"2019-09-17 16:22:39.000000000","message":"Done","commit_id":"a70fab4a262aea02304a23e76bfd4371fa1869b6"}],"releasenotes/notes/add-deploy-steps-ilo-management-interface-9d0f45954eda643a.yaml":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a2c07d71a2712db3b2e46087184429c9b784d24d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Adds support for deploy steps to ``management`` interface of ``ilo``"},{"line_number":5,"context_line":"    hardware type. The methods ``reset_ilo``, ``reset_ilo_credential``,"},{"line_number":6,"context_line":"    ``reset_bios_to_default``, ``reset_secure_boot_keys_to_default``,"},{"line_number":7,"context_line":"    ``clear_secure_boot_keys``, ``activate_license`` and"},{"line_number":8,"context_line":"    ``update_firmware`` can be used as deploy steps."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_2b73cbe9","line":7,"updated":"2019-09-17 15:56:32.000000000","message":"could you confirm? I don\u0027t see activate_license() as a deploy step; I see clean_step only.","commit_id":"a70fab4a262aea02304a23e76bfd4371fa1869b6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4dd4a46bcab939a22f897af4830ef2e0a85c829b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Adds support for deploy steps to ``management`` interface of ``ilo``"},{"line_number":5,"context_line":"    hardware type. The methods ``reset_ilo``, ``reset_ilo_credential``,"},{"line_number":6,"context_line":"    ``reset_bios_to_default``, ``reset_secure_boot_keys_to_default``,"},{"line_number":7,"context_line":"    ``clear_secure_boot_keys``, ``activate_license`` and"},{"line_number":8,"context_line":"    ``update_firmware`` can be used as deploy steps."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_7df2e608","line":7,"in_reply_to":"3fa7e38b_2b73cbe9","updated":"2019-09-17 16:22:39.000000000","message":"Done","commit_id":"a70fab4a262aea02304a23e76bfd4371fa1869b6"}]}