)]}'
{"ironic/drivers/modules/ansible/playbooks/roles/deploy/files/partition_configdrive.sh":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"bcda9ff74968d3f91357e941608b2c4d722663da","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        sgdisk -n 0:-64MB:0 -c 0:$PARTLABEL $DEVICE || fail \"creating configdrive on ${DEVICE}\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if [[ -b /dev/disk/by-partlabel/$PARTLABEL ]];then"},{"line_number":72,"context_line":"            ISO_PARTITION\u003d/dev/disk/by-partlabel/$PARTLABEL"},{"line_number":73,"context_line":"        else"},{"line_number":74,"context_line":"            # In some cases like md arrays (or any other logical device)"},{"line_number":75,"context_line":"            # /dev/disk/by-partlabel/$PARTLABEL file is not created."}],"source_content_type":"text/x-sh","patch_set":4,"id":"7faddb67_4247331e","line":72,"updated":"2019-08-06 09:33:38.000000000","message":"if you define ISO_PARTITION before the if block you can simplify the statement using a negative test with ISO_PARTITION itself and save a couple of lines","commit_id":"322bb9c1e1f12458d2daec821a437d8969e8c109"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"fb1ed118b91333d929e1ab57e3bdc0a38e10b7af","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        sgdisk -n 0:-64MB:0 -c 0:$PARTLABEL $DEVICE || fail \"creating configdrive on ${DEVICE}\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        ISO_PARTITION\u003d/dev/disk/by-partlabel/$PARTLABEL"},{"line_number":72,"context_line":"        if ! [ -b $ISO_PARTITION ];then"},{"line_number":73,"context_line":"            # In some cases like md arrays (or any other logical device)"},{"line_number":74,"context_line":"            # /dev/disk/by-partlabel/$PARTLABEL file is not created."},{"line_number":75,"context_line":"            # In such case, we fallback to this method. Note: this method could"}],"source_content_type":"text/x-sh","patch_set":7,"id":"7faddb67_8e85f809","line":72,"updated":"2019-08-12 08:28:41.000000000","message":"nit: add blank space for better readability","commit_id":"ff8f4b2e9d90976e848d8c1e7c6c03cfe3a0f18e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fa5f146c2614f5962d4302fa2f931ac54cd087f8","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            # The call below is not useless: for some unexplained reason, not"},{"line_number":81,"context_line":"            # calling blkid here causes the next subshell blkid calls to"},{"line_number":82,"context_line":"            # sometimes output outdated info... (sleeps, retries, partprobe or"},{"line_number":83,"context_line":"            # partx calls don\u0027t change the outcome...)."},{"line_number":84,"context_line":"            # If anyone knows why, please feel free to replace the workaround"},{"line_number":85,"context_line":"            # below with the proper fix."},{"line_number":86,"context_line":"            blkid \u003e/dev/null 2\u003e\u00261"}],"source_content_type":"text/x-sh","patch_set":7,"id":"7faddb67_a27ec0ac","line":83,"updated":"2019-08-12 14:57:36.000000000","message":"Fun..","commit_id":"ff8f4b2e9d90976e848d8c1e7c6c03cfe3a0f18e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8652e93ba00e6e747ec0b851a8f44cd16d9d9f6c","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            # partx calls don\u0027t change the outcome...)."},{"line_number":84,"context_line":"            # If anyone knows why, please feel free to replace the workaround"},{"line_number":85,"context_line":"            # below with the proper fix."},{"line_number":86,"context_line":"            blkid \u003e/dev/null 2\u003e\u00261"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"            ISO_PARTITION\u003d$(blkid -l -o device -t PARTLABEL\u003d$PARTLABEL)"},{"line_number":89,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":8,"id":"7faddb67_00be85d3","line":86,"updated":"2019-08-14 11:58:53.000000000","message":"Less of a hack than you think, if my memory is correct because it causing the kernel to reconcile where as partprobe has some limitations in doing so with devices that are open/locked. Partprobe will try to scan them, but the kernel then never updates the partition table because the device is in use.","commit_id":"ff3f328f0b7be39d4a53473b7f18d052323bfae1"}],"releasenotes/notes/bug-2006334-0cd8f59073f56241.yaml":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"bcda9ff74968d3f91357e941608b2c4d722663da","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"      A bug regarding the ``ansible`` deploy interface."},{"line_number":5,"context_line":"      If the node root device was set to some logical device (like an md array)"},{"line_number":6,"context_line":"      the forged ISO_PARTITION was not correct, due to"},{"line_number":7,"context_line":"      /dev/disk/by-partlabel/$PARTLABEL not being created."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_22c79798","line":4,"updated":"2019-08-06 09:33:38.000000000","message":"maybe start with \"Fixes an issue where....\"","commit_id":"322bb9c1e1f12458d2daec821a437d8969e8c109"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fa5f146c2614f5962d4302fa2f931ac54cd087f8","unresolved":false,"context_lines":[{"line_number":5,"context_line":"      configdrive partition could not be correctly built in some specific"},{"line_number":6,"context_line":"      cases. If the node root device was set to some logical device (like an md"},{"line_number":7,"context_line":"      array) the forged ISO_PARTITION was not correct, due to"},{"line_number":8,"context_line":"      /dev/disk/by-partlabel/$PARTLABEL not being created."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_c2797cc5","line":8,"updated":"2019-08-12 14:57:36.000000000","message":"can be a follow-up","commit_id":"ff8f4b2e9d90976e848d8c1e7c6c03cfe3a0f18e"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"fb1ed118b91333d929e1ab57e3bdc0a38e10b7af","unresolved":false,"context_lines":[{"line_number":5,"context_line":"      configdrive partition could not be correctly built in some specific"},{"line_number":6,"context_line":"      cases. If the node root device was set to some logical device (like an md"},{"line_number":7,"context_line":"      array) the forged ISO_PARTITION was not correct, due to"},{"line_number":8,"context_line":"      /dev/disk/by-partlabel/$PARTLABEL not being created."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_4e9ce05a","line":8,"range":{"start_line":8,"start_character":6,"end_line":8,"end_character":39},"updated":"2019-08-12 08:28:41.000000000","message":"can you please add an explanation on what this represents?","commit_id":"ff8f4b2e9d90976e848d8c1e7c6c03cfe3a0f18e"},{"author":{"_account_id":15064,"name":"raphael.glon","email":"raphael.glon@corp.ovh.com","username":"raphael"},"change_message_id":"51fe3ff81f96e66d466a6ba7bebf4d8553b6e4da","unresolved":false,"context_lines":[{"line_number":5,"context_line":"      configdrive partition could not be correctly built in some specific"},{"line_number":6,"context_line":"      cases. If the node root device was set to some logical device (like an md"},{"line_number":7,"context_line":"      array) the forged ISO_PARTITION was not correct, due to"},{"line_number":8,"context_line":"      /dev/disk/by-partlabel/$PARTLABEL not being created."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_57154548","line":8,"range":{"start_line":8,"start_character":6,"end_line":8,"end_character":39},"in_reply_to":"7faddb67_4e9ce05a","updated":"2019-08-13 00:23:31.000000000","message":"Done: I just removed it as actually, no need for such details.","commit_id":"ff8f4b2e9d90976e848d8c1e7c6c03cfe3a0f18e"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"fb1ed118b91333d929e1ab57e3bdc0a38e10b7af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7faddb67_eeaa6c6f","line":9,"updated":"2019-08-12 08:28:41.000000000","message":"nit: add link to story","commit_id":"ff8f4b2e9d90976e848d8c1e7c6c03cfe3a0f18e"},{"author":{"_account_id":15064,"name":"raphael.glon","email":"raphael.glon@corp.ovh.com","username":"raphael"},"change_message_id":"51fe3ff81f96e66d466a6ba7bebf4d8553b6e4da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7faddb67_971bbd7e","line":9,"in_reply_to":"7faddb67_eeaa6c6f","updated":"2019-08-13 00:23:31.000000000","message":"Done","commit_id":"ff8f4b2e9d90976e848d8c1e7c6c03cfe3a0f18e"}]}