)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1f39e70a3a04ffe3d9ab5f46c38627c6a6a024e7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     paresh-sao \u003cparesh.sao@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-08-07 07:49:29 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixed problem with UEFI iSCSI boot for nic adapters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit enhanced UEFI iSCSI boot to support multiple"},{"line_number":10,"context_line":"nic adapter by adding \u0027mac\u0027 optional parameter while"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_2b47c879","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":51},"updated":"2019-08-15 18:57:11.000000000","message":"This subject does not match the commit body, nor the related change in review in proliantutils. This is an enhancement, it is not a fix according to what is written here.","commit_id":"a9a1f7322c29b15ed5619ddf73a60e69aee67e88"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"999eb15c2cc583ea2ce60308d6b120b1dd7db1b4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     paresh-sao \u003cparesh.sao@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-08-07 07:49:29 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixed problem with UEFI iSCSI boot for nic adapters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit enhanced UEFI iSCSI boot to support multiple"},{"line_number":10,"context_line":"nic adapter by adding \u0027mac\u0027 optional parameter while"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_4395ce31","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":51},"in_reply_to":"7faddb67_2b47c879","updated":"2019-08-23 05:25:45.000000000","message":"Done","commit_id":"a9a1f7322c29b15ed5619ddf73a60e69aee67e88"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1f39e70a3a04ffe3d9ab5f46c38627c6a6a024e7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This commit enhanced UEFI iSCSI boot to support multiple"},{"line_number":10,"context_line":"nic adapter by adding \u0027mac\u0027 optional parameter while"},{"line_number":11,"context_line":"[un]set iSCSI target."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Id533a476ac376dea68955b2a0de070212285b9e8"},{"line_number":14,"context_line":"Story: #2006349"},{"line_number":15,"context_line":"Task: #36114"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_8b7cbcb6","line":12,"updated":"2019-08-15 18:57:11.000000000","message":"This change is dependent upon https://review.opendev.org/#/c/671662/  As such a depends-on tag should be added and proliantutils will need to be released prior to the requirements freeze for openstack for this change to be available to ironic.","commit_id":"a9a1f7322c29b15ed5619ddf73a60e69aee67e88"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"999eb15c2cc583ea2ce60308d6b120b1dd7db1b4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This commit enhanced UEFI iSCSI boot to support multiple"},{"line_number":10,"context_line":"nic adapter by adding \u0027mac\u0027 optional parameter while"},{"line_number":11,"context_line":"[un]set iSCSI target."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Id533a476ac376dea68955b2a0de070212285b9e8"},{"line_number":14,"context_line":"Story: #2006349"},{"line_number":15,"context_line":"Task: #36114"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_c3a8de79","line":12,"in_reply_to":"7faddb67_8b7cbcb6","updated":"2019-08-23 05:25:45.000000000","message":"I have added depends-on, and as soon proliant patch get merged will release proliantutils too","commit_id":"a9a1f7322c29b15ed5619ddf73a60e69aee67e88"}],"ironic/drivers/modules/ilo/management.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1b1954dca4b67731fb301821617544a7d811dbfd","unresolved":false,"context_lines":[{"line_number":551,"context_line":"            auth_method \u003d \u0027CHAP\u0027 if username else None"},{"line_number":552,"context_line":"            ilo_object.set_iscsi_info("},{"line_number":553,"context_line":"                iqn, lun, host, port, auth_method\u003dauth_method,"},{"line_number":554,"context_line":"                username\u003dusername, password\u003dpassword, macs\u003dmacs)"},{"line_number":555,"context_line":"        except ilo_error.IloCommandNotSupportedInBiosError as ilo_exception:"},{"line_number":556,"context_line":"            operation \u003d (_(\"Setting of target IQN %(target_iqn)s for node \""},{"line_number":557,"context_line":"                           \"%(node)s\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_9e55df52","line":554,"updated":"2019-08-15 18:52:55.000000000","message":"I\u0027m feeling super strong deja vu here....","commit_id":"a9a1f7322c29b15ed5619ddf73a60e69aee67e88"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"999eb15c2cc583ea2ce60308d6b120b1dd7db1b4","unresolved":false,"context_lines":[{"line_number":551,"context_line":"            auth_method \u003d \u0027CHAP\u0027 if username else None"},{"line_number":552,"context_line":"            ilo_object.set_iscsi_info("},{"line_number":553,"context_line":"                iqn, lun, host, port, auth_method\u003dauth_method,"},{"line_number":554,"context_line":"                username\u003dusername, password\u003dpassword, macs\u003dmacs)"},{"line_number":555,"context_line":"        except ilo_error.IloCommandNotSupportedInBiosError as ilo_exception:"},{"line_number":556,"context_line":"            operation \u003d (_(\"Setting of target IQN %(target_iqn)s for node \""},{"line_number":557,"context_line":"                           \"%(node)s\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_a3904244","line":554,"in_reply_to":"7faddb67_6b6860f4","updated":"2019-08-23 05:25:45.000000000","message":"Since proliant servers has limitation of 4 nic sources even system has multiple nic adapters, the UEFI iSCSI boot will fail as in current implementation it will try to set for all mac address. So i added changes to pass ironic ports only where will set iscsi target","commit_id":"a9a1f7322c29b15ed5619ddf73a60e69aee67e88"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"de0b285ec7ee5794d5172a87bac18722585cd0e0","unresolved":false,"context_lines":[{"line_number":551,"context_line":"            auth_method \u003d \u0027CHAP\u0027 if username else None"},{"line_number":552,"context_line":"            ilo_object.set_iscsi_info("},{"line_number":553,"context_line":"                iqn, lun, host, port, auth_method\u003dauth_method,"},{"line_number":554,"context_line":"                username\u003dusername, password\u003dpassword, macs\u003dmacs)"},{"line_number":555,"context_line":"        except ilo_error.IloCommandNotSupportedInBiosError as ilo_exception:"},{"line_number":556,"context_line":"            operation \u003d (_(\"Setting of target IQN %(target_iqn)s for node \""},{"line_number":557,"context_line":"                           \"%(node)s\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_6b6860f4","line":554,"in_reply_to":"7faddb67_9e55df52","updated":"2019-08-15 18:55:13.000000000","message":"Looks like the current attempt to do this is https://review.opendev.org/#/c/671662/9/proliantutils/ilo/operations.py","commit_id":"a9a1f7322c29b15ed5619ddf73a60e69aee67e88"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a1ec1b77d1d93834a0ef45837bcaa657e3206b80","unresolved":false,"context_lines":[{"line_number":551,"context_line":"            auth_method \u003d \u0027CHAP\u0027 if username else None"},{"line_number":552,"context_line":"            ilo_object.set_iscsi_info("},{"line_number":553,"context_line":"                iqn, lun, host, port, auth_method\u003dauth_method,"},{"line_number":554,"context_line":"                username\u003dusername, password\u003dpassword, macs\u003dmacs)"},{"line_number":555,"context_line":"        except ilo_error.IloCommandNotSupportedInBiosError as ilo_exception:"},{"line_number":556,"context_line":"            operation \u003d (_(\"Setting of target IQN %(target_iqn)s for node \""},{"line_number":557,"context_line":"                           \"%(node)s\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_11bf1dab","line":554,"in_reply_to":"7faddb67_a3904244","updated":"2019-08-23 11:41:56.000000000","message":"Okay, please add a release note to indicate this so that people understand why the change has occured and why the updated proliantutils requirement has chagned.","commit_id":"a9a1f7322c29b15ed5619ddf73a60e69aee67e88"}],"ironic/tests/unit/drivers/modules/ilo/test_management.py":[{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"ddd0c91228ab5cdb4206f7cea0abc901b9d78e05","unresolved":false,"context_lines":[{"line_number":744,"context_line":"                \u0027fake_iqn\u0027, 0, \u0027fake_host\u0027, \u00273260\u0027,"},{"line_number":745,"context_line":"                auth_method\u003d\u0027CHAP\u0027, username\u003d\u0027fake_username\u0027,"},{"line_number":746,"context_line":"                password\u003d\u0027fake_password\u0027, macs\u003d[\u002752:54:00:cf:2d:31\u0027])"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"    @mock.patch.object(ilo_common, \u0027get_ilo_object\u0027, spec_set\u003dTrue,"},{"line_number":749,"context_line":"                       autospec\u003dTrue)"},{"line_number":750,"context_line":"    def test_set_iscsi_boot_target_without_auth(self, get_ilo_object_mock):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_c9ef9faf","line":747,"updated":"2019-08-23 07:57:37.000000000","message":"Is it possible to add a test for multiple nics?","commit_id":"2e181eda545ddfa921a803f2ee536a2d0e13eb5d"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"f88557c0623f81990cd32cd980a8b259894aecb5","unresolved":false,"context_lines":[{"line_number":744,"context_line":"                \u0027fake_iqn\u0027, 0, \u0027fake_host\u0027, \u00273260\u0027,"},{"line_number":745,"context_line":"                auth_method\u003d\u0027CHAP\u0027, username\u003d\u0027fake_username\u0027,"},{"line_number":746,"context_line":"                password\u003d\u0027fake_password\u0027, macs\u003d[\u002752:54:00:cf:2d:31\u0027])"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"    @mock.patch.object(ilo_common, \u0027get_ilo_object\u0027, spec_set\u003dTrue,"},{"line_number":749,"context_line":"                       autospec\u003dTrue)"},{"line_number":750,"context_line":"    def test_set_iscsi_boot_target_without_auth(self, get_ilo_object_mock):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_02ec82b9","line":747,"in_reply_to":"7faddb67_71e3f1d9","updated":"2019-08-30 07:11:06.000000000","message":"Done","commit_id":"2e181eda545ddfa921a803f2ee536a2d0e13eb5d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d15cb2d8ded123ca236147f2447d518926184048","unresolved":false,"context_lines":[{"line_number":744,"context_line":"                \u0027fake_iqn\u0027, 0, \u0027fake_host\u0027, \u00273260\u0027,"},{"line_number":745,"context_line":"                auth_method\u003d\u0027CHAP\u0027, username\u003d\u0027fake_username\u0027,"},{"line_number":746,"context_line":"                password\u003d\u0027fake_password\u0027, macs\u003d[\u002752:54:00:cf:2d:31\u0027])"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"    @mock.patch.object(ilo_common, \u0027get_ilo_object\u0027, spec_set\u003dTrue,"},{"line_number":749,"context_line":"                       autospec\u003dTrue)"},{"line_number":750,"context_line":"    def test_set_iscsi_boot_target_without_auth(self, get_ilo_object_mock):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_71e3f1d9","line":747,"in_reply_to":"7faddb67_c9ef9faf","updated":"2019-08-23 11:45:29.000000000","message":"++ or even change a single test to pass multiple nics.","commit_id":"2e181eda545ddfa921a803f2ee536a2d0e13eb5d"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"f88557c0623f81990cd32cd980a8b259894aecb5","unresolved":false,"context_lines":[{"line_number":744,"context_line":"                \u0027fake_iqn\u0027, 0, \u0027fake_host\u0027, \u00273260\u0027,"},{"line_number":745,"context_line":"                auth_method\u003d\u0027CHAP\u0027, username\u003d\u0027fake_username\u0027,"},{"line_number":746,"context_line":"                password\u003d\u0027fake_password\u0027, macs\u003d[\u002752:54:00:cf:2d:31\u0027])"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"    @mock.patch.object(ilo_common, \u0027get_ilo_object\u0027, spec_set\u003dTrue,"},{"line_number":749,"context_line":"                       autospec\u003dTrue)"},{"line_number":750,"context_line":"    def test_set_iscsi_boot_target_without_auth(self, get_ilo_object_mock):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_e2f04694","line":747,"in_reply_to":"7faddb67_c9ef9faf","updated":"2019-08-30 07:11:06.000000000","message":"Done","commit_id":"2e181eda545ddfa921a803f2ee536a2d0e13eb5d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d15cb2d8ded123ca236147f2447d518926184048","unresolved":false,"context_lines":[{"line_number":843,"context_line":"            ilo_object_mock \u003d get_ilo_object_mock.return_value"},{"line_number":844,"context_line":""},{"line_number":845,"context_line":"            task.driver.management.clear_iscsi_boot_target(task)"},{"line_number":846,"context_line":"            ilo_object_mock.unset_iscsi_info.assert_called_once("},{"line_number":847,"context_line":"                [\u002752:54:00:cf:2d:31\u0027])"},{"line_number":848,"context_line":""},{"line_number":849,"context_line":"    @mock.patch.object(ilo_common, \u0027get_ilo_object\u0027, spec_set\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_71fc5172","line":846,"range":{"start_line":846,"start_character":45,"end_line":846,"end_character":63},"updated":"2019-08-23 11:45:29.000000000","message":"I believe the unit tests are failing here...\n\nOne of the tox checks indicate this is getting called twice.","commit_id":"2e181eda545ddfa921a803f2ee536a2d0e13eb5d"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"f88557c0623f81990cd32cd980a8b259894aecb5","unresolved":false,"context_lines":[{"line_number":843,"context_line":"            ilo_object_mock \u003d get_ilo_object_mock.return_value"},{"line_number":844,"context_line":""},{"line_number":845,"context_line":"            task.driver.management.clear_iscsi_boot_target(task)"},{"line_number":846,"context_line":"            ilo_object_mock.unset_iscsi_info.assert_called_once("},{"line_number":847,"context_line":"                [\u002752:54:00:cf:2d:31\u0027])"},{"line_number":848,"context_line":""},{"line_number":849,"context_line":"    @mock.patch.object(ilo_common, \u0027get_ilo_object\u0027, spec_set\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_ab5429c7","line":846,"range":{"start_line":846,"start_character":45,"end_line":846,"end_character":63},"in_reply_to":"7faddb67_71fc5172","updated":"2019-08-30 07:11:06.000000000","message":"Done","commit_id":"2e181eda545ddfa921a803f2ee536a2d0e13eb5d"}]}