)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6623,"name":"Roman Prykhodchenko","email":"me@romcheg.me","username":"prykhodchenko"},"change_message_id":"f56c33bf2c6178839a9403840b2ba07082a07084","unresolved":false,"context_lines":[{"line_number":15,"context_line":"mentioning that already."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I4fb1cd5c226cee2f9e0977e83cf2ffa7786b3b4a"},{"line_number":18,"context_line":"Closes-Bug: #1270160"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2FFRE%3D","line":18,"updated":"2014-01-17 16:16:38.000000000","message":"This should go before Change-Id.","commit_id":"3ad6a8c67319a3c68d23461bbc9538da65bb10a4"},{"author":{"_account_id":6623,"name":"Roman Prykhodchenko","email":"me@romcheg.me","username":"prykhodchenko"},"change_message_id":"8b2a503406e6fda244bc0b596f501feded859244","unresolved":false,"context_lines":[{"line_number":15,"context_line":"mentioning that already."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I4fb1cd5c226cee2f9e0977e83cf2ffa7786b3b4a"},{"line_number":18,"context_line":"Closes-Bug: #1270160"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2FFJU%3D","line":18,"in_reply_to":"AAAAUH%2F%2FFK8%3D","updated":"2014-01-17 16:31:05.000000000","message":"That\u0027s why I didn\u0027t put -1 for this.","commit_id":"3ad6a8c67319a3c68d23461bbc9538da65bb10a4"},{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"d90bcca137ee5574dc937fd3963c7be9f6b0afbc","unresolved":false,"context_lines":[{"line_number":15,"context_line":"mentioning that already."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I4fb1cd5c226cee2f9e0977e83cf2ffa7786b3b4a"},{"line_number":18,"context_line":"Closes-Bug: #1270160"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2FFK8%3D","line":18,"in_reply_to":"AAAAUH%2F%2FFRE%3D","updated":"2014-01-17 16:30:03.000000000","message":"Not mandatory :) I saw a lot of patches with such arrangement which are ok","commit_id":"3ad6a8c67319a3c68d23461bbc9538da65bb10a4"}],"ironic/tests/api/test_nodes.py":[{"author":{"_account_id":6623,"name":"Roman Prykhodchenko","email":"me@romcheg.me","username":"prykhodchenko"},"change_message_id":"f56c33bf2c6178839a9403840b2ba07082a07084","unresolved":false,"context_lines":[{"line_number":669,"context_line":"                                 {\u0027target\u0027: states.POWER_ON})"},{"line_number":670,"context_line":"        self.assertEqual(response.content_type, \u0027application/json\u0027)"},{"line_number":671,"context_line":"        self.assertEqual(response.status_code, 202)"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":"        self.mock_cnps.assert_called_once_with(mock.ANY,"},{"line_number":674,"context_line":"                                               self.node[\u0027uuid\u0027],"},{"line_number":675,"context_line":"                                               states.POWER_ON,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FFRk%3D","side":"PARENT","line":672,"updated":"2014-01-17 16:16:38.000000000","message":"Maybe it\u0027s reasonable to put a check here that there is really no content?","commit_id":"dde3e6f615f36a218afd8a0ea520011d11598bd5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ffaecd11b2563acfcc0406ea3077ddd9e9142350","unresolved":false,"context_lines":[{"line_number":669,"context_line":"                                 {\u0027target\u0027: states.POWER_ON})"},{"line_number":670,"context_line":"        self.assertEqual(response.content_type, \u0027application/json\u0027)"},{"line_number":671,"context_line":"        self.assertEqual(response.status_code, 202)"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":"        self.mock_cnps.assert_called_once_with(mock.ANY,"},{"line_number":674,"context_line":"                                               self.node[\u0027uuid\u0027],"},{"line_number":675,"context_line":"                                               states.POWER_ON,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BPQA%3D","side":"PARENT","line":672,"in_reply_to":"AAAAUH%2F%2BPno%3D","updated":"2014-01-28 19:42:20.000000000","message":"+1, I agreed! I will submit a new patch with those checks.\n\n@Ruby, I will add it in this patch with a note in the commit message, since it\u0027s a small change I don\u0027t see any problem with that. Thank you for pointing that out.","commit_id":"dde3e6f615f36a218afd8a0ea520011d11598bd5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"97e54258592856e8a14ded833fde2c5efc55f8f5","unresolved":false,"context_lines":[{"line_number":669,"context_line":"                                 {\u0027target\u0027: states.POWER_ON})"},{"line_number":670,"context_line":"        self.assertEqual(response.content_type, \u0027application/json\u0027)"},{"line_number":671,"context_line":"        self.assertEqual(response.status_code, 202)"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":"        self.mock_cnps.assert_called_once_with(mock.ANY,"},{"line_number":674,"context_line":"                                               self.node[\u0027uuid\u0027],"},{"line_number":675,"context_line":"                                               states.POWER_ON,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BPno%3D","side":"PARENT","line":672,"in_reply_to":"AAAAUH%2F%2FFRk%3D","updated":"2014-01-28 18:42:58.000000000","message":"I think it would be good to do that, so it is explicit that there shouldn\u0027t be any content. I looked at the provision_state tests, and there isn\u0027t any check for that there either. Would be good to put a similar check there, but I don\u0027t know if that ought to be done in a diff review or not.","commit_id":"dde3e6f615f36a218afd8a0ea520011d11598bd5"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"946694677346d52d4fb8e846737624f6a2878c7e","unresolved":false,"context_lines":[{"line_number":685,"context_line":"        response \u003d self.put_json(\u0027/nodes/%s/states/power\u0027 % self.node[\u0027uuid\u0027],"},{"line_number":686,"context_line":"                                 {\u0027target\u0027: states.POWER_ON})"},{"line_number":687,"context_line":"        self.assertEqual(202, response.status_code)"},{"line_number":688,"context_line":"        self.assertEqual(response.body, \u0027\u0027)"},{"line_number":689,"context_line":"        self.mock_cnps.assert_called_once_with(mock.ANY,"},{"line_number":690,"context_line":"                                               self.node[\u0027uuid\u0027],"},{"line_number":691,"context_line":"                                               states.POWER_ON,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2Fjs8%3D","line":688,"updated":"2014-02-12 11:23:44.000000000","message":"Probably need to change the order in assertEqual, which makes this patch https://review.openstack.org/#/c/71486","commit_id":"ef234fff867f76bc85c64c58aee4a97809bbf59d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"444c1ea9e1e0f71035f31b3ef91b0b5ba5ae4f03","unresolved":false,"context_lines":[{"line_number":685,"context_line":"        response \u003d self.put_json(\u0027/nodes/%s/states/power\u0027 % self.node[\u0027uuid\u0027],"},{"line_number":686,"context_line":"                                 {\u0027target\u0027: states.POWER_ON})"},{"line_number":687,"context_line":"        self.assertEqual(202, response.status_code)"},{"line_number":688,"context_line":"        self.assertEqual(response.body, \u0027\u0027)"},{"line_number":689,"context_line":"        self.mock_cnps.assert_called_once_with(mock.ANY,"},{"line_number":690,"context_line":"                                               self.node[\u0027uuid\u0027],"},{"line_number":691,"context_line":"                                               states.POWER_ON,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FjiY%3D","line":688,"in_reply_to":"AAAAUX%2F%2Fjpc%3D","updated":"2014-02-12 11:43:55.000000000","message":"+++ Will fix :)","commit_id":"ef234fff867f76bc85c64c58aee4a97809bbf59d"},{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"24106fa9db72ae2fd64553a4f3afc142bb7eb756","unresolved":false,"context_lines":[{"line_number":685,"context_line":"        response \u003d self.put_json(\u0027/nodes/%s/states/power\u0027 % self.node[\u0027uuid\u0027],"},{"line_number":686,"context_line":"                                 {\u0027target\u0027: states.POWER_ON})"},{"line_number":687,"context_line":"        self.assertEqual(202, response.status_code)"},{"line_number":688,"context_line":"        self.assertEqual(response.body, \u0027\u0027)"},{"line_number":689,"context_line":"        self.mock_cnps.assert_called_once_with(mock.ANY,"},{"line_number":690,"context_line":"                                               self.node[\u0027uuid\u0027],"},{"line_number":691,"context_line":"                                               states.POWER_ON,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2Fjpc%3D","line":688,"in_reply_to":"AAAAUX%2F%2Fjs8%3D","updated":"2014-02-12 11:26:28.000000000","message":"Well, I tend to agree. After rebase we already have correct order in other places, so this should be update for consistency","commit_id":"ef234fff867f76bc85c64c58aee4a97809bbf59d"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"946694677346d52d4fb8e846737624f6a2878c7e","unresolved":false,"context_lines":[{"line_number":725,"context_line":"        ret \u003d self.put_json(\u0027/nodes/%s/states/provision\u0027 % self.node.uuid,"},{"line_number":726,"context_line":"                            {\u0027target\u0027: states.ACTIVE})"},{"line_number":727,"context_line":"        self.assertEqual(202, ret.status_code)"},{"line_number":728,"context_line":"        self.assertEqual(ret.body, \u0027\u0027)"},{"line_number":729,"context_line":"        self.mock_dnd.assert_called_once_with("},{"line_number":730,"context_line":"                mock.ANY, self.node.uuid, \u0027test-topic\u0027)"},{"line_number":731,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FjtU%3D","line":728,"updated":"2014-02-12 11:23:44.000000000","message":"ditto","commit_id":"ef234fff867f76bc85c64c58aee4a97809bbf59d"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"946694677346d52d4fb8e846737624f6a2878c7e","unresolved":false,"context_lines":[{"line_number":733,"context_line":"        ret \u003d self.put_json(\u0027/nodes/%s/states/provision\u0027 % self.node.uuid,"},{"line_number":734,"context_line":"                            {\u0027target\u0027: states.DELETED})"},{"line_number":735,"context_line":"        self.assertEqual(202, ret.status_code)"},{"line_number":736,"context_line":"        self.assertEqual(ret.body, \u0027\u0027)"},{"line_number":737,"context_line":"        self.mock_dntd.assert_called_once_with("},{"line_number":738,"context_line":"                mock.ANY, self.node.uuid, \u0027test-topic\u0027)"},{"line_number":739,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FjtA%3D","line":736,"updated":"2014-02-12 11:23:44.000000000","message":"ditto","commit_id":"ef234fff867f76bc85c64c58aee4a97809bbf59d"}]}