)]}'
{"ironic/conductor/manager.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"61e85d5224c9c2332700703da082761c69f6c385","unresolved":false,"context_lines":[{"line_number":2335,"context_line":"        with task_manager.acquire(context, port.node_id,"},{"line_number":2336,"context_line":"                                  purpose\u003d\u0027port deletion\u0027) as task:"},{"line_number":2337,"context_line":"            node \u003d task.node"},{"line_number":2338,"context_line":"            bound \u003d True if port.internal_info.get(\u0027tenant_vif_port_id\u0027) \\"},{"line_number":2339,"context_line":"                is not None else False"},{"line_number":2340,"context_line":"            if ((node.provision_state \u003d\u003d states.ACTIVE or node.instance_uuid)"},{"line_number":2341,"context_line":"                and not node.maintenance and bound):"},{"line_number":2342,"context_line":"                    msg \u003d _(\"Cannot delete the port %(port)s as node \""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_37c11e4f","line":2339,"range":{"start_line":2338,"start_character":12,"end_line":2339,"end_character":38},"updated":"2019-08-21 08:52:54.000000000","message":"bound \u003d port.internal_info.get(\u0027tenant_vif_port_id\u0027) is not None\n\nAlternatively, this might be better. It will also get provisioning, cleaning or rescuing ports, but they shouldn\u0027t be present if the node is active.\n\ntask.driver.network.get_current_vif(task, port) is not None","commit_id":"f9c1d0fd83a20188c2e378429e816c063b75f185"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"1f6b3e3af9a83864441e8c62a515c98c476a20a0","unresolved":false,"context_lines":[{"line_number":2335,"context_line":"        with task_manager.acquire(context, port.node_id,"},{"line_number":2336,"context_line":"                                  purpose\u003d\u0027port deletion\u0027) as task:"},{"line_number":2337,"context_line":"            node \u003d task.node"},{"line_number":2338,"context_line":"            bound \u003d True if port.internal_info.get(\u0027tenant_vif_port_id\u0027) \\"},{"line_number":2339,"context_line":"                is not None else False"},{"line_number":2340,"context_line":"            if ((node.provision_state \u003d\u003d states.ACTIVE or node.instance_uuid)"},{"line_number":2341,"context_line":"                and not node.maintenance and bound):"},{"line_number":2342,"context_line":"                    msg \u003d _(\"Cannot delete the port %(port)s as node \""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_eb694cbd","line":2339,"range":{"start_line":2338,"start_character":12,"end_line":2339,"end_character":38},"in_reply_to":"7faddb67_37c11e4f","updated":"2019-08-22 05:46:11.000000000","message":"Done","commit_id":"f9c1d0fd83a20188c2e378429e816c063b75f185"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e3ca1196ef29e3f4bb533602bfbdfdc21a5ce3e8","unresolved":false,"context_lines":[{"line_number":2340,"context_line":"                and not node.maintenance and vif):"},{"line_number":2341,"context_line":"                    msg \u003d _(\"Cannot delete the port %(port)s as node \""},{"line_number":2342,"context_line":"                            \"%(node)s is active or has \""},{"line_number":2343,"context_line":"                            \"instance UUID assigned or port is bound \""},{"line_number":2344,"context_line":"                            \"to vif %(vif)s\")"},{"line_number":2345,"context_line":"                    raise exception.InvalidState(msg % {\u0027node\u0027: node.uuid,"},{"line_number":2346,"context_line":"                                                        \u0027port\u0027: port.uuid,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_661b4e80","line":2343,"updated":"2019-08-22 09:51:25.000000000","message":"s/or/and/ (it\u0027s not alternative to being active).","commit_id":"f7595726882d631b861cb7dbe71d478cf232e976"}]}
