)]}'
{"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"63513ae188540dd1ab585dc9bca5f0eafaab86b8","unresolved":false,"context_lines":[{"line_number":864,"context_line":"    # generally fall to image default or conductor default."},{"line_number":865,"context_line":"    if is_software_raid(node):"},{"line_number":866,"context_line":"        return \u0027local\u0027"},{"line_number":867,"context_line":"    capabilities \u003d utils.parse_instance_info_capabilities(node)"},{"line_number":868,"context_line":"    return capabilities.get(\u0027boot_option\u0027, get_default_boot_option()).lower()"},{"line_number":869,"context_line":""},{"line_number":870,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_bbdd6642","line":867,"updated":"2019-08-29 16:13:24.000000000","message":"wondering if it makes sense to use any \u0027boot_option\u0027 value from the capabilities, and if not specified, then use \u0027local\u0027. Or we could just log something?","commit_id":"9223b5bebf62cfd0580e83628dc0f3a0ad49c8b7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6ed94572e1ee4bba5b0fcdd2efe72375a80d108b","unresolved":false,"context_lines":[{"line_number":864,"context_line":"    # generally fall to image default or conductor default."},{"line_number":865,"context_line":"    if is_software_raid(node):"},{"line_number":866,"context_line":"        return \u0027local\u0027"},{"line_number":867,"context_line":"    capabilities \u003d utils.parse_instance_info_capabilities(node)"},{"line_number":868,"context_line":"    return capabilities.get(\u0027boot_option\u0027, get_default_boot_option()).lower()"},{"line_number":869,"context_line":""},{"line_number":870,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_f15bef82","line":867,"in_reply_to":"7faddb67_bbdd6642","updated":"2019-08-30 12:58:53.000000000","message":"Instance info properties is the user requested state... so I\u0027m really not quite sure what your thinking.","commit_id":"9223b5bebf62cfd0580e83628dc0f3a0ad49c8b7"}],"ironic/tests/unit/drivers/modules/test_deploy_utils.py":[{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"fbced9fa189312bddc46422f7017fbab57b1eb97","unresolved":false,"context_lines":[{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"    @mock.patch.object(utils, \u0027is_software_raid\u0027, autospec\u003dTrue)"},{"line_number":1259,"context_line":"    def test_get_boot_option_software_raid(self, mock_is_software_raid):"},{"line_number":1260,"context_line":"        mock_is_software_raid.return_value \u003d \u0027local\u0027"},{"line_number":1261,"context_line":"        cfg.CONF.set_override(\u0027default_boot_option\u0027, \u0027netboot\u0027, \u0027deploy\u0027)"},{"line_number":1262,"context_line":"        result \u003d utils.get_boot_option(self.node)"},{"line_number":1263,"context_line":"        self.assertEqual(\"local\", result)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_48f33f6e","line":1260,"range":{"start_line":1260,"start_character":45,"end_line":1260,"end_character":52},"updated":"2019-12-27 07:49:48.000000000","message":"Though it is technically correct but the value should be either True or False based on the definition of is_software_daid method.","commit_id":"523823e0865e2d6c2037bb0b4ce13e7b566d5f0b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fb3e7225d4c20dd21068f27633258ac41106caf3","unresolved":false,"context_lines":[{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"    @mock.patch.object(utils, \u0027is_software_raid\u0027, autospec\u003dTrue)"},{"line_number":1259,"context_line":"    def test_get_boot_option_software_raid(self, mock_is_software_raid):"},{"line_number":1260,"context_line":"        mock_is_software_raid.return_value \u003d \u0027local\u0027"},{"line_number":1261,"context_line":"        cfg.CONF.set_override(\u0027default_boot_option\u0027, \u0027netboot\u0027, \u0027deploy\u0027)"},{"line_number":1262,"context_line":"        result \u003d utils.get_boot_option(self.node)"},{"line_number":1263,"context_line":"        self.assertEqual(\"local\", result)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_0398b317","line":1260,"range":{"start_line":1260,"start_character":45,"end_line":1260,"end_character":52},"in_reply_to":"3fa7e38b_48f33f6e","updated":"2020-01-02 22:06:23.000000000","message":"Good catch, thanks!","commit_id":"523823e0865e2d6c2037bb0b4ce13e7b566d5f0b"}],"releasenotes/notes/fixes-get-boot-option-for-software-raid-baa2cffd95e1f624.yaml":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"63513ae188540dd1ab585dc9bca5f0eafaab86b8","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes a minor issue with ``get_boot_option`` logic that did not account"},{"line_number":5,"context_line":"    for Software RAID. This can erroniously cause the deployment to take the"},{"line_number":6,"context_line":"    the incorrect deployment path and attempt to install a boot loader."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_1b8fda75","line":5,"updated":"2019-08-29 16:13:24.000000000","message":"s/erroniously/erroneously/","commit_id":"9223b5bebf62cfd0580e83628dc0f3a0ad49c8b7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"63513ae188540dd1ab585dc9bca5f0eafaab86b8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes a minor issue with ``get_boot_option`` logic that did not account"},{"line_number":5,"context_line":"    for Software RAID. This can erroniously cause the deployment to take the"},{"line_number":6,"context_line":"    the incorrect deployment path and attempt to install a boot loader."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_3b8ad663","line":6,"updated":"2019-08-29 16:13:24.000000000","message":"s/the //","commit_id":"9223b5bebf62cfd0580e83628dc0f3a0ad49c8b7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ff0ea07acf53320b4250ca7082174d097ac9700d","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes a minor issue with ``get_boot_option`` logic that did not account"},{"line_number":5,"context_line":"    for Software RAID. This can erroniously cause the deployment to take the"},{"line_number":6,"context_line":"    the incorrect deployment path and attempt to install a boot loader."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_f1e9af7e","line":6,"in_reply_to":"7faddb67_3b8ad663","updated":"2019-08-30 12:59:33.000000000","message":"I\u0027m running out of time before I go on leave, so I think these will need to be a follow-up. :\\","commit_id":"9223b5bebf62cfd0580e83628dc0f3a0ad49c8b7"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3963c0fa764185e29f39b150c3def9397ea8cb99","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes a minor issue with ``get_boot_option`` logic that did not account"},{"line_number":5,"context_line":"    for Software RAID. This can erroniously cause the deployment to take the"},{"line_number":6,"context_line":"    the incorrect deployment path and attempt to install a boot loader."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa7e38b_572d01fb","line":5,"range":{"start_line":5,"start_character":32,"end_line":5,"end_character":43},"updated":"2020-01-03 09:44:18.000000000","message":"nit: erroneously","commit_id":"721aab48da451a65c957ca2289328363b647c6df"}]}