)]}'
{"ironic/drivers/modules/pxe.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"600be2917d886b1c408173ea8d19a1ea982a2d4c","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    # Internal use only"},{"line_number":121,"context_line":"    d_info[\u0027deploy_key\u0027] \u003d info.get(\u0027pxe_deploy_key\u0027, None)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    d_info[\u0027instance_name\u0027] \u003d info.get(\u0027pxe_instance_name\u0027, None)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    #TODO(ghe): Should we get rid of swap partition?"},{"line_number":126,"context_line":"    d_info[\u0027swap_mb\u0027] \u003d info.get(\u0027pxe_swap_mb\u0027, 1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2B2nM%3D","line":123,"updated":"2014-01-21 12:19:41.000000000","message":"Hi Ghe,\n\nAs we are not going to use this parameter anywhere, I think we might want to complete remove it, or do you think there\u0027s still use for this parameter to live in driver options?","commit_id":"05709429bd4ab67caa05cf7776721807d43f5501"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2ffe5911936259721c8cef2b38dcf5b12be24cfb","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    # Internal use only"},{"line_number":121,"context_line":"    d_info[\u0027deploy_key\u0027] \u003d info.get(\u0027pxe_deploy_key\u0027, None)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    d_info[\u0027instance_name\u0027] \u003d info.get(\u0027pxe_instance_name\u0027, None)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    #TODO(ghe): Should we get rid of swap partition?"},{"line_number":126,"context_line":"    d_info[\u0027swap_mb\u0027] \u003d info.get(\u0027pxe_swap_mb\u0027, 1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BvMg%3D","line":123,"in_reply_to":"AAAAUH%2F%2B1g0%3D","updated":"2014-01-22 16:52:56.000000000","message":"ack","commit_id":"05709429bd4ab67caa05cf7776721807d43f5501"},{"author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"change_message_id":"7ad14299153f746c573843fadefac1c92104bb2d","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    # Internal use only"},{"line_number":121,"context_line":"    d_info[\u0027deploy_key\u0027] \u003d info.get(\u0027pxe_deploy_key\u0027, None)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    d_info[\u0027instance_name\u0027] \u003d info.get(\u0027pxe_instance_name\u0027, None)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    #TODO(ghe): Should we get rid of swap partition?"},{"line_number":126,"context_line":"    d_info[\u0027swap_mb\u0027] \u003d info.get(\u0027pxe_swap_mb\u0027, 1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2B1g0%3D","line":123,"in_reply_to":"AAAAUH%2F%2B2nM%3D","updated":"2014-01-21 15:43:54.000000000","message":"I would leave it for now. It\u0027s also referenced in the db schema, so it would be a deeper change.","commit_id":"05709429bd4ab67caa05cf7776721807d43f5501"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"600be2917d886b1c408173ea8d19a1ea982a2d4c","unresolved":false,"context_lines":[{"line_number":335,"context_line":"    d_info \u003d _parse_driver_info(node)"},{"line_number":336,"context_line":"    fileutils.ensure_tree("},{"line_number":337,"context_line":"        os.path.join(CONF.pxe.tftp_root, node.uuid))"},{"line_number":338,"context_line":"    LOG.debug(_(\"Fetching kernel and ramdisk for instance %s\") %"},{"line_number":339,"context_line":"              d_info[\u0027instance_name\u0027])"},{"line_number":340,"context_line":"    for label in pxe_info:"},{"line_number":341,"context_line":"        (uuid, path) \u003d pxe_info[label]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2B2oE%3D","line":338,"updated":"2014-01-21 12:19:41.000000000","message":"I think we should use the instance_uuid from nodes here since instance_name, since it\u0027s not mandatory it\u0027s very likely to it to be None when logging this message here.","commit_id":"05709429bd4ab67caa05cf7776721807d43f5501"},{"author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"change_message_id":"7ad14299153f746c573843fadefac1c92104bb2d","unresolved":false,"context_lines":[{"line_number":335,"context_line":"    d_info \u003d _parse_driver_info(node)"},{"line_number":336,"context_line":"    fileutils.ensure_tree("},{"line_number":337,"context_line":"        os.path.join(CONF.pxe.tftp_root, node.uuid))"},{"line_number":338,"context_line":"    LOG.debug(_(\"Fetching kernel and ramdisk for instance %s\") %"},{"line_number":339,"context_line":"              d_info[\u0027instance_name\u0027])"},{"line_number":340,"context_line":"    for label in pxe_info:"},{"line_number":341,"context_line":"        (uuid, path) \u003d pxe_info[label]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2B1h0%3D","line":338,"in_reply_to":"AAAAUH%2F%2B2oE%3D","updated":"2014-01-21 15:43:54.000000000","message":"Done","commit_id":"05709429bd4ab67caa05cf7776721807d43f5501"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"600be2917d886b1c408173ea8d19a1ea982a2d4c","unresolved":false,"context_lines":[{"line_number":365,"context_line":"    image_path \u003d _get_image_file_path(node.uuid)"},{"line_number":366,"context_line":"    uuid \u003d d_info[\u0027image_source\u0027]"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    LOG.debug(_(\"Fetching image %(ami)s for instance %(name)s\") %"},{"line_number":369,"context_line":"              {\u0027ami\u0027: uuid, \u0027name\u0027: d_info[\u0027instance_name\u0027]})"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    if not os.path.exists(image_path):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2B2n4%3D","line":368,"updated":"2014-01-21 12:19:41.000000000","message":"Same as l339","commit_id":"05709429bd4ab67caa05cf7776721807d43f5501"},{"author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"change_message_id":"7ad14299153f746c573843fadefac1c92104bb2d","unresolved":false,"context_lines":[{"line_number":365,"context_line":"    image_path \u003d _get_image_file_path(node.uuid)"},{"line_number":366,"context_line":"    uuid \u003d d_info[\u0027image_source\u0027]"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    LOG.debug(_(\"Fetching image %(ami)s for instance %(name)s\") %"},{"line_number":369,"context_line":"              {\u0027ami\u0027: uuid, \u0027name\u0027: d_info[\u0027instance_name\u0027]})"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    if not os.path.exists(image_path):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2B1hw%3D","line":368,"in_reply_to":"AAAAUH%2F%2B2n4%3D","updated":"2014-01-21 15:43:54.000000000","message":"Done","commit_id":"05709429bd4ab67caa05cf7776721807d43f5501"}]}