)]}'
{"ironic/drivers/modules/drac/inspect.py":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"53a1d5f93393bc6eda33ee2942a65ee5b5e4d93a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    specific incompatibilities and introduction of vendor value added"},{"line_number":45,"context_line":"    should be implemented by this class."},{"line_number":46,"context_line":"    \"\"\""},{"line_number":47,"context_line":"    pass"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class DracWSManInspect(base.InspectInterface):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_579b3a71","line":47,"updated":"2019-09-18 09:04:30.000000000","message":"nit: pass is not necessary","commit_id":"62579800fbb5ef3001185a071c3e85238d462770"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"346bb3bc9f2e65221693210e6847a461adefb239","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    specific incompatibilities and introduction of vendor value added"},{"line_number":45,"context_line":"    should be implemented by this class."},{"line_number":46,"context_line":"    \"\"\""},{"line_number":47,"context_line":"    pass"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class DracWSManInspect(base.InspectInterface):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_ddb66bda","line":47,"in_reply_to":"3fa7e38b_579b3a71","updated":"2019-09-18 11:01:55.000000000","message":"I believe \u0027pass\u0027 is necessary. All of my experimentation without including \u0027pass\u0027 failed to produce working code. And the documentation for an \"empty class\" supports that finding. [1]\n\n[1] https://docs.python.org/3/tutorial/classes.html#odds-and-ends","commit_id":"62579800fbb5ef3001185a071c3e85238d462770"}],"releasenotes/notes/idrac-add-redfish-inspect-support-ce74bd3d4a97b588.yaml":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"53a1d5f93393bc6eda33ee2942a65ee5b5e4d93a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    (WS-Man) OOB management protocol. The new \u0027idrac-redfish\u0027"},{"line_number":15,"context_line":"    immediately follows those. It now supports the following inspect"},{"line_number":16,"context_line":"    interface implementations, listed in priority order from highest to"},{"line_number":17,"context_line":"    lowest: ``idrac-wsman``, ``idrac``, ``idrac-redfish``,"},{"line_number":18,"context_line":"    ``inspector``, and ``no-inspect``."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_17e2a2d6","line":17,"updated":"2019-09-18 09:04:30.000000000","message":"I hope `lowest:` is not taken as a yaml keyword.","commit_id":"62579800fbb5ef3001185a071c3e85238d462770"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"346bb3bc9f2e65221693210e6847a461adefb239","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    (WS-Man) OOB management protocol. The new \u0027idrac-redfish\u0027"},{"line_number":15,"context_line":"    immediately follows those. It now supports the following inspect"},{"line_number":16,"context_line":"    interface implementations, listed in priority order from highest to"},{"line_number":17,"context_line":"    lowest: ``idrac-wsman``, ``idrac``, ``idrac-redfish``,"},{"line_number":18,"context_line":"    ``inspector``, and ``no-inspect``."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_ddebcbad","line":17,"in_reply_to":"3fa7e38b_17e2a2d6","updated":"2019-09-18 11:01:55.000000000","message":"I successfully built it and viewed the result in a browser. It looks good to me.","commit_id":"62579800fbb5ef3001185a071c3e85238d462770"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f9c529d7a18d7624d673643f1231e68ddb314bc1","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    (WS-Man) OOB management protocol. The new \u0027idrac-redfish\u0027"},{"line_number":15,"context_line":"    immediately follows those. It now supports the following inspect"},{"line_number":16,"context_line":"    interface implementations, listed in priority order from highest to"},{"line_number":17,"context_line":"    lowest: ``idrac-wsman``, ``idrac``, ``idrac-redfish``,"},{"line_number":18,"context_line":"    ``inspector``, and ``no-inspect``."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_37e47eac","line":17,"in_reply_to":"3fa7e38b_17e2a2d6","updated":"2019-09-18 09:11:47.000000000","message":"Shouldn\u0027t be - | is a block literal string.","commit_id":"62579800fbb5ef3001185a071c3e85238d462770"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3e5a666a5e36fd2772f2d0cc29843bf845bf552e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    (WS-Man) OOB management protocol. The new \u0027idrac-redfish\u0027"},{"line_number":15,"context_line":"    immediately follows those. It now supports the following inspect"},{"line_number":16,"context_line":"    interface implementations, listed in priority order from highest to"},{"line_number":17,"context_line":"    lowest: ``idrac-wsman``, ``idrac``, ``idrac-redfish``,"},{"line_number":18,"context_line":"    ``inspector``, and ``no-inspect``."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_3dc9bf77","line":17,"in_reply_to":"3fa7e38b_37e47eac","updated":"2019-09-18 10:59:55.000000000","message":"yep, should work okay","commit_id":"62579800fbb5ef3001185a071c3e85238d462770"}]}