)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"1c8868589f7d95a6f78c7b8a6957849c5b55f0fb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Run mkfs as root"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The the mkfs command requires root permission to write the filesystem on"},{"line_number":10,"context_line":"certain devices. This patch is adding the run_as_root\u003dTrue flag for the"},{"line_number":11,"context_line":"execute() in the mkfs() function in common.utils.py, and is also adding"},{"line_number":12,"context_line":"the mkfs to the rootwrap filters."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAUH%2F%2B0m8%3D","line":9,"updated":"2014-01-21 18:48:25.000000000","message":"Typo: double \"the\"","commit_id":"aa5255f54d2f3f3701b7fce3aaf51dc884b7eb6b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0ad73d622fe747745363f273048cca38904ad3a6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Run mkfs as root"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The the mkfs command requires root permission to write the filesystem on"},{"line_number":10,"context_line":"certain devices. This patch is adding the run_as_root\u003dTrue flag for the"},{"line_number":11,"context_line":"execute() in the mkfs() function in common.utils.py, and is also adding"},{"line_number":12,"context_line":"the mkfs to the rootwrap filters."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAUH%2F%2B0eU%3D","line":9,"in_reply_to":"AAAAUH%2F%2B0m8%3D","updated":"2014-01-21 19:11:49.000000000","message":"done","commit_id":"aa5255f54d2f3f3701b7fce3aaf51dc884b7eb6b"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"1c8868589f7d95a6f78c7b8a6957849c5b55f0fb","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The the mkfs command requires root permission to write the filesystem on"},{"line_number":10,"context_line":"certain devices. This patch is adding the run_as_root\u003dTrue flag for the"},{"line_number":11,"context_line":"execute() in the mkfs() function in common.utils.py, and is also adding"},{"line_number":12,"context_line":"the mkfs to the rootwrap filters."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1271243"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAUH%2F%2B0m4%3D","line":11,"updated":"2014-01-21 18:48:25.000000000","message":"common/utils.py","commit_id":"aa5255f54d2f3f3701b7fce3aaf51dc884b7eb6b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0ad73d622fe747745363f273048cca38904ad3a6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The the mkfs command requires root permission to write the filesystem on"},{"line_number":10,"context_line":"certain devices. This patch is adding the run_as_root\u003dTrue flag for the"},{"line_number":11,"context_line":"execute() in the mkfs() function in common.utils.py, and is also adding"},{"line_number":12,"context_line":"the mkfs to the rootwrap filters."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1271243"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAUH%2F%2B0eQ%3D","line":11,"in_reply_to":"AAAAUH%2F%2B0m4%3D","updated":"2014-01-21 19:11:49.000000000","message":"done","commit_id":"aa5255f54d2f3f3701b7fce3aaf51dc884b7eb6b"}],"ironic/common/utils.py":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"1e7cc1360c1b41455cc0f55154f0c94f6aabd4a8","unresolved":false,"context_lines":[{"line_number":422,"context_line":"            label_opt \u003d \u0027-L\u0027"},{"line_number":423,"context_line":"        args.extend([label_opt, label])"},{"line_number":424,"context_line":"    args.append(path)"},{"line_number":425,"context_line":"    execute(*args, run_as_root\u003dTrue)"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"def unlink_without_raise(path):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2Bsy0%3D","line":425,"updated":"2014-01-23 01:53:31.000000000","message":"Lucas,\n\nHow do you think if \"check_exit_code\u003d[0]\" is required here to auto-check the return code? Yes, this should not be this patch coverage:)\n\nThanks","commit_id":"7553dbfd6802a797bc52091994882bf8e3dd956c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3e5384db11e5869ebb7694cb129a313d4ac1460d","unresolved":false,"context_lines":[{"line_number":422,"context_line":"            label_opt \u003d \u0027-L\u0027"},{"line_number":423,"context_line":"        args.extend([label_opt, label])"},{"line_number":424,"context_line":"    args.append(path)"},{"line_number":425,"context_line":"    execute(*args, run_as_root\u003dTrue)"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"def unlink_without_raise(path):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2BohE%3D","line":425,"in_reply_to":"AAAAUH%2F%2Bsy0%3D","updated":"2014-01-23 17:59:03.000000000","message":"Hi Haomeng,\n\nThanks for the suggestion, by default the processutils.execute() (which is called by the execute() function in this file, L66) already sets the \"check_exit_code\u003d[0]\" by default. So I don\u0027t see the need to explicit set it here or in another subsequent patch.\n\nhttps://github.com/openstack/ironic/blob/master/ironic/openstack/common/processutils.py#L85-L88 \n\nCheers for pointing it out anyway :)","commit_id":"7553dbfd6802a797bc52091994882bf8e3dd956c"}]}