)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8e5f3b3130c8698520a4c184621b68a01d4ee416","unresolved":false,"context_lines":[{"line_number":9,"context_line":"It is completely normal for IPA to heartbeat in these states while"},{"line_number":10,"context_line":"ironic is busy doing something with the node. Just ignore it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially reverts commit 2b8581af8c4faec1ca4b2c9714c6c2b491c5578a."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I2d7218285de97f4769a0e42797c272af95413fa2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_590dc58e","line":12,"updated":"2019-09-17 11:01:38.000000000","message":"nit: it\u0027s not really reverting the code, more the effect.","commit_id":"f8074d808b209743518d6c936b47bafee5700d0d"}],"ironic/drivers/modules/agent_base_vendor.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"aa7f49a0fbb030dfe0b622802558394ce71e5c5d","unresolved":false,"context_lines":[{"line_number":80,"context_line":"_FASTTRACK_HEARTBEAT_ALLOWED \u003d (states.DEPLOYWAIT, states.CLEANWAIT,"},{"line_number":81,"context_line":"                                states.RESCUEWAIT, states.ENROLL,"},{"line_number":82,"context_line":"                                states.MANAGEABLE, states.AVAILABLE,"},{"line_number":83,"context_line":"                                states.DEPLOYING)"},{"line_number":84,"context_line":"FASTTRACK_HEARTBEAT_ALLOWED \u003d frozenset(_FASTTRACK_HEARTBEAT_ALLOWED)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_4a6c0508","line":83,"updated":"2019-09-17 13:47:56.000000000","message":"fasttrack skips cleaning, right? And isn\u0027t involved in rescuing?","commit_id":"93bd867bef984e6b65f834f0c42068140b3f7b0c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9970ea06ff5b76dbd1200f2de79b4d46fecf97b5","unresolved":false,"context_lines":[{"line_number":80,"context_line":"_FASTTRACK_HEARTBEAT_ALLOWED \u003d (states.DEPLOYWAIT, states.CLEANWAIT,"},{"line_number":81,"context_line":"                                states.RESCUEWAIT, states.ENROLL,"},{"line_number":82,"context_line":"                                states.MANAGEABLE, states.AVAILABLE,"},{"line_number":83,"context_line":"                                states.DEPLOYING)"},{"line_number":84,"context_line":"FASTTRACK_HEARTBEAT_ALLOWED \u003d frozenset(_FASTTRACK_HEARTBEAT_ALLOWED)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_da22aea4","line":83,"in_reply_to":"3fa7e38b_4a6c0508","updated":"2019-09-21 14:23:20.000000000","message":"More like, you can skip the reboot if you roll through cleaning.","commit_id":"93bd867bef984e6b65f834f0c42068140b3f7b0c"}],"ironic/tests/unit/drivers/modules/test_agent_base_vendor.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"aa7f49a0fbb030dfe0b622802558394ce71e5c5d","unresolved":false,"context_lines":[{"line_number":241,"context_line":"    def test_heartbeat_noops_in_wrong_state(self, ncrc_mock, rti_mock,"},{"line_number":242,"context_line":"                                            cd_mock, log_mock):"},{"line_number":243,"context_line":"        allowed \u003d {states.DEPLOYWAIT, states.CLEANWAIT, states.RESCUEWAIT,"},{"line_number":244,"context_line":"                   states.DEPLOYING, states.CLEANING, states.RESCUING}"},{"line_number":245,"context_line":"        for state in set(states.machine.states) - allowed:"},{"line_number":246,"context_line":"            for m in (ncrc_mock, rti_mock, cd_mock, log_mock):"},{"line_number":247,"context_line":"                m.reset_mock()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_0a24cdc5","line":244,"updated":"2019-09-17 13:47:56.000000000","message":"this is / should be the same as agent_base_vendor.HEARTBEAT_ALLOWED, right?","commit_id":"93bd867bef984e6b65f834f0c42068140b3f7b0c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9970ea06ff5b76dbd1200f2de79b4d46fecf97b5","unresolved":false,"context_lines":[{"line_number":241,"context_line":"    def test_heartbeat_noops_in_wrong_state(self, ncrc_mock, rti_mock,"},{"line_number":242,"context_line":"                                            cd_mock, log_mock):"},{"line_number":243,"context_line":"        allowed \u003d {states.DEPLOYWAIT, states.CLEANWAIT, states.RESCUEWAIT,"},{"line_number":244,"context_line":"                   states.DEPLOYING, states.CLEANING, states.RESCUING}"},{"line_number":245,"context_line":"        for state in set(states.machine.states) - allowed:"},{"line_number":246,"context_line":"            for m in (ncrc_mock, rti_mock, cd_mock, log_mock):"},{"line_number":247,"context_line":"                m.reset_mock()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_9a3c36c9","line":244,"in_reply_to":"3fa7e38b_0a24cdc5","updated":"2019-09-21 14:23:20.000000000","message":"It does seem that way... #confused","commit_id":"93bd867bef984e6b65f834f0c42068140b3f7b0c"}]}