)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e1968e9fee7cfe8f49196d890791286f5637e4f8","unresolved":false,"context_lines":[{"line_number":12,"context_line":"not actually evaluating the contents of the disk to achieve the desired"},{"line_number":13,"context_line":"end state which is always to boot an instance."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"That being said, disks imagle should always have boot loaders, and we"},{"line_number":16,"context_line":"should always thus setup boot from local disk as opposed to set PXE."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"*** This change makes sense for something backportable, but"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"df33271e_6629e499","line":15,"range":{"start_line":15,"start_character":23,"end_line":15,"end_character":29},"updated":"2020-03-30 04:29:01.000000000","message":"s/ imagle / image /","commit_id":"c80122bfd1567209686c32428817563e4983914d"}],"ironic/drivers/modules/ipxe.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"be21e0230aab3fca7f2010562909cfc7710abf45","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        boot_mode_utils.sync_boot_mode(task)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        node \u003d task.node"},{"line_number":205,"context_line":"        boot_option \u003d deploy_utils.get_boot_option(node)"},{"line_number":206,"context_line":"        boot_device \u003d None"},{"line_number":207,"context_line":"        instance_image_info \u003d {}"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_4487dc10","line":205,"range":{"start_line":205,"start_character":22,"end_line":205,"end_character":50},"updated":"2019-09-20 09:47:13.000000000","message":"maybe move this logic to get_boot_option?","commit_id":"609c29218148cc6e5c48669add6e3b5a9ef1e6c5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"be21e0230aab3fca7f2010562909cfc7710abf45","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                # This is for the takeover scenario for active nodes."},{"line_number":227,"context_line":"                instance_image_info \u003d pxe_utils.get_instance_image_info("},{"line_number":228,"context_line":"                    task, ipxe_enabled\u003dTrue)"},{"line_number":229,"context_line":"                pxe_utils.cache_ramdisk_kernel(task, instance_image_info,"},{"line_number":230,"context_line":"                                               ipxe_enabled\u003dTrue)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"            # If it\u0027s going to PXE boot we need to update the DHCP server"},{"line_number":233,"context_line":"            dhcp_opts \u003d pxe_utils.dhcp_options_for_instance(task,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_049ec453","line":230,"range":{"start_line":229,"start_character":0,"end_line":230,"end_character":65},"updated":"2019-09-20 09:47:13.000000000","message":"I really wonder what this does for whole-disk images..","commit_id":"609c29218148cc6e5c48669add6e3b5a9ef1e6c5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4f6f8b473b0b808875a4c9ca24944c2260749f90","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                # This is for the takeover scenario for active nodes."},{"line_number":227,"context_line":"                instance_image_info \u003d pxe_utils.get_instance_image_info("},{"line_number":228,"context_line":"                    task, ipxe_enabled\u003dTrue)"},{"line_number":229,"context_line":"                pxe_utils.cache_ramdisk_kernel(task, instance_image_info,"},{"line_number":230,"context_line":"                                               ipxe_enabled\u003dTrue)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"            # If it\u0027s going to PXE boot we need to update the DHCP server"},{"line_number":233,"context_line":"            dhcp_opts \u003d pxe_utils.dhcp_options_for_instance(task,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_f31c8814","line":230,"range":{"start_line":229,"start_character":0,"end_line":230,"end_character":65},"in_reply_to":"3fa7e38b_049ec453","updated":"2019-09-20 13:47:03.000000000","message":"I think... we download it again :\\ or at least it looks for a kernel/ramdisk pair.... hmm.","commit_id":"609c29218148cc6e5c48669add6e3b5a9ef1e6c5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"be21e0230aab3fca7f2010562909cfc7710abf45","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            except KeyError:"},{"line_number":244,"context_line":"                if not task.driver.storage.should_write_image(task):"},{"line_number":245,"context_line":"                    pass"},{"line_number":246,"context_line":"                elif not iwdi:"},{"line_number":247,"context_line":"                    LOG.warning(\"The UUID for the root partition can\u0027t be \""},{"line_number":248,"context_line":"                                \"found, unable to switch the pxe config from \""},{"line_number":249,"context_line":"                                \"deployment mode to service (boot) mode for \""},{"line_number":250,"context_line":"                                \"node %(node)s\", {\"node\": task.node.uuid})"},{"line_number":251,"context_line":"                else:"},{"line_number":252,"context_line":"                    LOG.warning(\"The disk id for the whole disk image can\u0027t \""},{"line_number":253,"context_line":"                                \"be found, unable to switch the pxe config \""},{"line_number":254,"context_line":"                                \"from deployment mode to service (boot) mode \""},{"line_number":255,"context_line":"                                \"for node %(node)s. Booting the instance \""},{"line_number":256,"context_line":"                                \"from disk.\", {\"node\": task.node.uuid})"},{"line_number":257,"context_line":"                    pxe_utils.clean_up_pxe_config(task, ipxe_enabled\u003dTrue)"},{"line_number":258,"context_line":"                    boot_device \u003d boot_devices.DISK"},{"line_number":259,"context_line":"            else:"},{"line_number":260,"context_line":"                pxe_utils.build_service_pxe_config(task, instance_image_info,"},{"line_number":261,"context_line":"                                                   root_uuid_or_disk_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_2484200c","line":258,"range":{"start_line":246,"start_character":0,"end_line":258,"end_character":51},"updated":"2019-09-20 09:47:13.000000000","message":"We can now get rid of all this (also why on Earth are these just warnings??)","commit_id":"609c29218148cc6e5c48669add6e3b5a9ef1e6c5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4f6f8b473b0b808875a4c9ca24944c2260749f90","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            except KeyError:"},{"line_number":244,"context_line":"                if not task.driver.storage.should_write_image(task):"},{"line_number":245,"context_line":"                    pass"},{"line_number":246,"context_line":"                elif not iwdi:"},{"line_number":247,"context_line":"                    LOG.warning(\"The UUID for the root partition can\u0027t be \""},{"line_number":248,"context_line":"                                \"found, unable to switch the pxe config from \""},{"line_number":249,"context_line":"                                \"deployment mode to service (boot) mode for \""},{"line_number":250,"context_line":"                                \"node %(node)s\", {\"node\": task.node.uuid})"},{"line_number":251,"context_line":"                else:"},{"line_number":252,"context_line":"                    LOG.warning(\"The disk id for the whole disk image can\u0027t \""},{"line_number":253,"context_line":"                                \"be found, unable to switch the pxe config \""},{"line_number":254,"context_line":"                                \"from deployment mode to service (boot) mode \""},{"line_number":255,"context_line":"                                \"for node %(node)s. Booting the instance \""},{"line_number":256,"context_line":"                                \"from disk.\", {\"node\": task.node.uuid})"},{"line_number":257,"context_line":"                    pxe_utils.clean_up_pxe_config(task, ipxe_enabled\u003dTrue)"},{"line_number":258,"context_line":"                    boot_device \u003d boot_devices.DISK"},{"line_number":259,"context_line":"            else:"},{"line_number":260,"context_line":"                pxe_utils.build_service_pxe_config(task, instance_image_info,"},{"line_number":261,"context_line":"                                                   root_uuid_or_disk_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_f3e1e8fd","line":258,"range":{"start_line":246,"start_character":0,"end_line":258,"end_character":51},"in_reply_to":"3fa7e38b_2484200c","updated":"2019-09-20 13:47:03.000000000","message":"warnings because the intent was to have operator default boot option override the image type.","commit_id":"609c29218148cc6e5c48669add6e3b5a9ef1e6c5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d944024355aa16152b3850ef8174600e07a57a8a","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            except KeyError:"},{"line_number":244,"context_line":"                if not task.driver.storage.should_write_image(task):"},{"line_number":245,"context_line":"                    pass"},{"line_number":246,"context_line":"                elif not iwdi:"},{"line_number":247,"context_line":"                    LOG.warning(\"The UUID for the root partition can\u0027t be \""},{"line_number":248,"context_line":"                                \"found, unable to switch the pxe config from \""},{"line_number":249,"context_line":"                                \"deployment mode to service (boot) mode for \""},{"line_number":250,"context_line":"                                \"node %(node)s\", {\"node\": task.node.uuid})"},{"line_number":251,"context_line":"                else:"},{"line_number":252,"context_line":"                    LOG.warning(\"The disk id for the whole disk image can\u0027t \""},{"line_number":253,"context_line":"                                \"be found, unable to switch the pxe config \""},{"line_number":254,"context_line":"                                \"from deployment mode to service (boot) mode \""},{"line_number":255,"context_line":"                                \"for node %(node)s. Booting the instance \""},{"line_number":256,"context_line":"                                \"from disk.\", {\"node\": task.node.uuid})"},{"line_number":257,"context_line":"                    pxe_utils.clean_up_pxe_config(task, ipxe_enabled\u003dTrue)"},{"line_number":258,"context_line":"                    boot_device \u003d boot_devices.DISK"},{"line_number":259,"context_line":"            else:"},{"line_number":260,"context_line":"                pxe_utils.build_service_pxe_config(task, instance_image_info,"},{"line_number":261,"context_line":"                                                   root_uuid_or_disk_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_7abb7a0d","line":258,"range":{"start_line":246,"start_character":0,"end_line":258,"end_character":51},"in_reply_to":"3fa7e38b_f3e1e8fd","updated":"2019-09-21 14:41:09.000000000","message":"Lets nuke the warnings after we change the default boot option.","commit_id":"609c29218148cc6e5c48669add6e3b5a9ef1e6c5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"be21e0230aab3fca7f2010562909cfc7710abf45","unresolved":false,"context_lines":[{"line_number":262,"context_line":"                                                   ipxe_enabled\u003dTrue)"},{"line_number":263,"context_line":"                boot_device \u003d boot_devices.PXE"},{"line_number":264,"context_line":"            if iwdi:"},{"line_number":265,"context_line":"                # For some reason we\u0027ve decided that we should forever honor"},{"line_number":266,"context_line":"                # boot option.... We shouldn\u0027t have done that."},{"line_number":267,"context_line":"                boot_device \u003d boot_devices.DISK"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_44aefc98","line":266,"range":{"start_line":265,"start_character":0,"end_line":266,"end_character":62},"updated":"2019-09-20 09:47:13.000000000","message":"nit: this comment only makes sense in the context of this patch.","commit_id":"609c29218148cc6e5c48669add6e3b5a9ef1e6c5"}],"ironic/drivers/modules/pxe_base.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e1968e9fee7cfe8f49196d890791286f5637e4f8","unresolved":false,"context_lines":[{"line_number":297,"context_line":"                    task, instance_image_info, root_uuid_or_disk_id,"},{"line_number":298,"context_line":"                    ipxe_enabled\u003dself.ipxe_enabled)"},{"line_number":299,"context_line":"                boot_device \u003d boot_devices.PXE"},{"line_number":300,"context_line":"            if iwdi:"},{"line_number":301,"context_line":"                # TODO(TheJulia): Maybe we should remove the PXE config?"},{"line_number":302,"context_line":"                # ... Or we could just clean this all up with moving the"},{"line_number":303,"context_line":"                # default boot_option."},{"line_number":304,"context_line":"                boot_device \u003d boot_devices.DISK"},{"line_number":305,"context_line":"        else:"},{"line_number":306,"context_line":"            # If it\u0027s going to boot from the local disk, we don\u0027t need"},{"line_number":307,"context_line":"            # PXE config files. They still need to be generated as part"}],"source_content_type":"text/x-python","patch_set":8,"id":"df33271e_3a6890b7","line":304,"range":{"start_line":300,"start_character":12,"end_line":304,"end_character":47},"updated":"2020-03-30 04:29:01.000000000","message":"Can we move this block to L267. If its whole disk image just set the boot device to disk.\nif iwdi:\n    boot_device \u003d boot_devices.DISK\nelse:\n    try:\n        root_uuid_or_disk_id \u003d task.node.driver_internal_info[\u0027root_uuid_or_disk_id\u0027]\n        ...","commit_id":"c80122bfd1567209686c32428817563e4983914d"}]}