)]}'
{"ironic/conductor/task_manager.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1d202ad8d28eff677a07daf8e3028a4229740ecd","unresolved":false,"context_lines":[{"line_number":496,"context_line":"                        \u0027previous\u0027: self._prev_provision_state})"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"        if \u0027failed\u0027 in self.node.provision_state:"},{"line_number":499,"context_line":"            LOG.error(log_message)"},{"line_number":500,"context_line":"        else:"},{"line_number":501,"context_line":"            LOG.info(log_message)"},{"line_number":502,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_d6fa3341","line":499,"updated":"2019-09-26 13:47:27.000000000","message":"you need to split the message and the parameters, otherwise you\u0027re logging a tuple","commit_id":"5564a80de8be1a368f2780a55ca46ffe4c377542"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a5f33a8d0d9b0813fca8805a1777f339befd46b9","unresolved":false,"context_lines":[{"line_number":495,"context_line":"                        \u0027target\u0027: self.node.target_provision_state,"},{"line_number":496,"context_line":"                        \u0027previous\u0027: self._prev_provision_state})"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"        if self.node.provision_state.find(\u0027failed\u0027) !\u003d -1:"},{"line_number":499,"context_line":"            LOG.error(log_message)"},{"line_number":500,"context_line":"        else:"},{"line_number":501,"context_line":"            LOG.info(log_message)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_16b3eb99","line":498,"updated":"2019-09-26 13:48:55.000000000","message":"I\u0027d prefer to use endswith(\u0027 failed\u0027). also \u0027error\u0027 is an error state","commit_id":"ad555a9d36adb022b455a6d5b909e214d7a1510d"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a6443a0b681801b65b5f20e3757f36ca072257e8","unresolved":false,"context_lines":[{"line_number":495,"context_line":"                        \u0027target\u0027: self.node.target_provision_state,"},{"line_number":496,"context_line":"                        \u0027previous\u0027: self._prev_provision_state})"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"        if self.node.provision_state.find(\u0027failed\u0027) !\u003d -1:"},{"line_number":499,"context_line":"            LOG.error(log_message)"},{"line_number":500,"context_line":"        else:"},{"line_number":501,"context_line":"            LOG.info(log_message)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_5c1ae516","line":498,"in_reply_to":"3fa7e38b_16b3eb99","updated":"2019-09-26 14:07:02.000000000","message":"I agree and yup, forgot about the actual error state!","commit_id":"ad555a9d36adb022b455a6d5b909e214d7a1510d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a5f33a8d0d9b0813fca8805a1777f339befd46b9","unresolved":false,"context_lines":[{"line_number":496,"context_line":"                        \u0027previous\u0027: self._prev_provision_state})"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"        if self.node.provision_state.find(\u0027failed\u0027) !\u003d -1:"},{"line_number":499,"context_line":"            LOG.error(log_message)"},{"line_number":500,"context_line":"        else:"},{"line_number":501,"context_line":"            LOG.info(log_message)"},{"line_number":502,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_36b0678a","line":499,"updated":"2019-09-26 13:48:55.000000000","message":"see previous patchset","commit_id":"ad555a9d36adb022b455a6d5b909e214d7a1510d"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a6443a0b681801b65b5f20e3757f36ca072257e8","unresolved":false,"context_lines":[{"line_number":496,"context_line":"                        \u0027previous\u0027: self._prev_provision_state})"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"        if self.node.provision_state.find(\u0027failed\u0027) !\u003d -1:"},{"line_number":499,"context_line":"            LOG.error(log_message)"},{"line_number":500,"context_line":"        else:"},{"line_number":501,"context_line":"            LOG.info(log_message)"},{"line_number":502,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_fcde313c","line":499,"in_reply_to":"3fa7e38b_36b0678a","updated":"2019-09-26 14:07:02.000000000","message":"yeah, didn\u0027t read before pushing the new set, going to change that :/","commit_id":"ad555a9d36adb022b455a6d5b909e214d7a1510d"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"e280a6e804731ab48e0048b0816a111f7f0cce5e","unresolved":false,"context_lines":[{"line_number":497,"context_line":""},{"line_number":498,"context_line":"        if (self.node.provision_state.endswith(\u0027failed\u0027) or"},{"line_number":499,"context_line":"                self.node.provision_state \u003d\u003d \u0027error\u0027):"},{"line_number":500,"context_line":"            LOG.error(log_message)"},{"line_number":501,"context_line":"        else:"},{"line_number":502,"context_line":"            LOG.info(log_message)"},{"line_number":503,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_f12ac87c","line":500,"updated":"2019-09-27 09:05:07.000000000","message":"Great, this will be helpful.","commit_id":"b8fa188a29481b11b2f3117cdeecfd920a8f5a0e"}]}