)]}'
{"devstack/lib/ironic":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"240d0152b69d11452ab919f9bd46bc2a98233cb6","unresolved":false,"context_lines":[{"line_number":2520,"context_line":"    if is_deploy_iso_required; then"},{"line_number":2521,"context_line":"        IRONIC_DIB_RAMDISK_OPTIONS+\u003d\" iso\""},{"line_number":2522,"context_line":"    fi"},{"line_number":2523,"context_line":"    git_clone $IRONIC_PYTHON_AGENT_BUILDER_REPO $IRONIC_PYTHON_AGENT_BUILDER_DIR $IRONIC_PYTHON_AGENT_BUILDER_BRANCH"},{"line_number":2524,"context_line":"    ELEMENTS_PATH\u003d\"$IRONIC_PYTHON_AGENT_BUILDER_DIR/dib\" \\"},{"line_number":2525,"context_line":"        DIB_DHCP_TIMEOUT\u003d$IRONIC_DIB_DHCP_TIMEOUT \\"},{"line_number":2526,"context_line":"        disk-image-create \"$IRONIC_DIB_RAMDISK_OPTIONS\" \\"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_19f8ad7a","line":2523,"updated":"2019-10-02 09:09:36.000000000","message":"won\u0027t this cause a \"Too many arguments\" error ?\nAFAIK the correct way to checkout a single branch is:\ngit clone --single-branch -b \u003cbranch\u003e \u003crepo\u003e \u003cdir\u003e","commit_id":"dab47f9ce143fa1d7fb7c51608bb69332464d914"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"cbb4ad27b7073ca5332889515be2de9389d3de35","unresolved":false,"context_lines":[{"line_number":2520,"context_line":"    if is_deploy_iso_required; then"},{"line_number":2521,"context_line":"        IRONIC_DIB_RAMDISK_OPTIONS+\u003d\" iso\""},{"line_number":2522,"context_line":"    fi"},{"line_number":2523,"context_line":"    git_clone $IRONIC_PYTHON_AGENT_BUILDER_REPO $IRONIC_PYTHON_AGENT_BUILDER_DIR $IRONIC_PYTHON_AGENT_BUILDER_BRANCH"},{"line_number":2524,"context_line":"    ELEMENTS_PATH\u003d\"$IRONIC_PYTHON_AGENT_BUILDER_DIR/dib\" \\"},{"line_number":2525,"context_line":"        DIB_DHCP_TIMEOUT\u003d$IRONIC_DIB_DHCP_TIMEOUT \\"},{"line_number":2526,"context_line":"        disk-image-create \"$IRONIC_DIB_RAMDISK_OPTIONS\" \\"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_70f68efc","line":2523,"in_reply_to":"3fa7e38b_19f8ad7a","updated":"2019-10-02 14:08:27.000000000","message":"Nope!  The error is that there are not enough arguments passed to git clone.  Specifically, the command ends up being:\ngit clone ... --branch\nWhich is invalid because it is not specifying the branch to checkout.  This change makes it so that the branch is specified.\nThis change was basically copied from the command used in the build_tinyipa_ramdisk() method here:\nhttps://github.com/openstack/ironic/blob/master/devstack/lib/ironic#L2466","commit_id":"dab47f9ce143fa1d7fb7c51608bb69332464d914"}]}