)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"74d1af82695a93eba22722e802a97908eb462ab2","unresolved":false,"context_lines":[{"line_number":19,"context_line":"to be patched."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I69bd53aa24b7b10384dc1399a0acaa21d38d6bd9"},{"line_number":22,"context_line":"Story: #2006649"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_19a56947","line":22,"updated":"2019-10-11 22:29:09.000000000","message":"Task please :)","commit_id":"dd68d9a725586dc56e346d566cd9b620763d960b"}],"ironic/drivers/modules/agent_base_vendor.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"2284471f3b491194bcc44fef090958854a72a93e","unresolved":false,"context_lines":[{"line_number":848,"context_line":"                LOG.warning(\u0027Could not get \\\u0027rootfs_uuid\\\u0027 property for \u0027"},{"line_number":849,"context_line":"                            \u0027image %(image)s from Glance: %(error)s.\u0027,"},{"line_number":850,"context_line":"                            {\u0027image\u0027: image_source, \u0027error\u0027: e})"},{"line_number":851,"context_line":"                root_uuid \u003d internal_info.get(\u0027root_uuid_or_disk_id\u0027)"},{"line_number":852,"context_line":"                LOG.debug(\u0027Got rootfs_uuid from driver internal info: \u0027"},{"line_number":853,"context_line":"                          \u0027 %s\u0027, root_uuid)"},{"line_number":854,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_79b49d82","line":851,"updated":"2019-10-11 22:28:52.000000000","message":"Is there any reason it wouldn\u0027t already be the same? I could see someone manually setting data in glance which is incorrect and see that causing failed deployments...","commit_id":"dd68d9a725586dc56e346d566cd9b620763d960b"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"8c93c4a320e2d6393d099ed5c39b298573c98ebf","unresolved":false,"context_lines":[{"line_number":848,"context_line":"                LOG.warning(\u0027Could not get \\\u0027rootfs_uuid\\\u0027 property for \u0027"},{"line_number":849,"context_line":"                            \u0027image %(image)s from Glance: %(error)s.\u0027,"},{"line_number":850,"context_line":"                            {\u0027image\u0027: image_source, \u0027error\u0027: e})"},{"line_number":851,"context_line":"                root_uuid \u003d internal_info.get(\u0027root_uuid_or_disk_id\u0027)"},{"line_number":852,"context_line":"                LOG.debug(\u0027Got rootfs_uuid from driver internal info: \u0027"},{"line_number":853,"context_line":"                          \u0027 %s\u0027, root_uuid)"},{"line_number":854,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_d419d3d6","line":851,"in_reply_to":"3fa7e38b_79b49d82","updated":"2019-10-12 10:13:39.000000000","message":"I have never seen this field set to anything but 0x00000 (hence the patch in the IPA to hardcode the first partition when dealing with md devices (which this patch is aiming to remove)).\nIs this field supposed to be set for whole disk images?\nIf so, where/when is that done (since it looks like tied to a node)?\n\nAlso: apart from the fact that this is for s/w RAID deployments only: if an operator set the metadata on the image, I\u0027m pretty sure the error message will mean sth :)","commit_id":"dd68d9a725586dc56e346d566cd9b620763d960b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fc3e7a36a5fbec30580ad41cb01a2c9c5766a6f5","unresolved":false,"context_lines":[{"line_number":848,"context_line":"                LOG.warning(\u0027Could not get \\\u0027rootfs_uuid\\\u0027 property for \u0027"},{"line_number":849,"context_line":"                            \u0027image %(image)s from Glance: %(error)s.\u0027,"},{"line_number":850,"context_line":"                            {\u0027image\u0027: image_source, \u0027error\u0027: e})"},{"line_number":851,"context_line":"                root_uuid \u003d internal_info.get(\u0027root_uuid_or_disk_id\u0027)"},{"line_number":852,"context_line":"                LOG.debug(\u0027Got rootfs_uuid from driver internal info: \u0027"},{"line_number":853,"context_line":"                          \u0027 %s\u0027, root_uuid)"},{"line_number":854,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_01f35de9","line":851,"in_reply_to":"3fa7e38b_d419d3d6","updated":"2019-10-17 21:43:38.000000000","message":"So yes, it can be set on whole disk images to identify the root partition, such that grub can be run to update metadata.  Where... I just don\u0027t quite remember right now.","commit_id":"dd68d9a725586dc56e346d566cd9b620763d960b"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"6b2de2f5af49ca21913e716a13ff32390e3e1fe0","unresolved":false,"context_lines":[{"line_number":837,"context_line":"            image_source \u003d node.instance_info.get(\u0027image_source\u0027)"},{"line_number":838,"context_line":"            try:"},{"line_number":839,"context_line":"                context \u003d task.context"},{"line_number":840,"context_line":"                context.is_admin \u003d True"},{"line_number":841,"context_line":"                glance \u003d image_service.GlanceImageService("},{"line_number":842,"context_line":"                    context\u003dcontext)"},{"line_number":843,"context_line":"                image_info \u003d glance.show(image_source)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_9e5786cb","line":840,"range":{"start_line":840,"start_character":16,"end_line":840,"end_character":39},"updated":"2019-10-21 15:51:03.000000000","message":"What about this one? Is this a sensible way to get access to the image meta data? I was actually surprised to see that the token is empty at this point ... sth is clearing it or is the token lost on the way?\n\nIronic just downloaded the image, so it had access earlier ...","commit_id":"ea877a7c2528e4a0601bdb1e8e831020103cdc8d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a49baf4c9ad225595ce9f08befdee3ace7a2cf2c","unresolved":false,"context_lines":[{"line_number":844,"context_line":"                image_properties \u003d image_info.get(\u0027properties\u0027)"},{"line_number":845,"context_line":"                root_uuid \u003d image_properties[\u0027rootfs_uuid\u0027]"},{"line_number":846,"context_line":"                LOG.debug(\u0027Got rootfs_uuid from Glance: %s\u0027, root_uuid)"},{"line_number":847,"context_line":"            except Exception as e:"},{"line_number":848,"context_line":"                LOG.warning(\u0027Could not get \\\u0027rootfs_uuid\\\u0027 property for \u0027"},{"line_number":849,"context_line":"                            \u0027image %(image)s from Glance: %(error)s.\u0027,"},{"line_number":850,"context_line":"                            {\u0027image\u0027: image_source, \u0027error\u0027: e})"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_e11e410c","line":847,"range":{"start_line":847,"start_character":20,"end_line":847,"end_character":28},"updated":"2019-10-17 21:45:51.000000000","message":"I suspect some reviewers might want this to be more strict, it could be failing on a few different lines right now for software raid deploys.","commit_id":"ea877a7c2528e4a0601bdb1e8e831020103cdc8d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a49baf4c9ad225595ce9f08befdee3ace7a2cf2c","unresolved":false,"context_lines":[{"line_number":850,"context_line":"                            {\u0027image\u0027: image_source, \u0027error\u0027: e})"},{"line_number":851,"context_line":"                root_uuid \u003d internal_info.get(\u0027root_uuid_or_disk_id\u0027)"},{"line_number":852,"context_line":"                LOG.debug(\u0027Got rootfs_uuid from driver internal info: \u0027"},{"line_number":853,"context_line":"                          \u0027 %s\u0027, root_uuid)"},{"line_number":854,"context_line":""},{"line_number":855,"context_line":"        whole_disk_image \u003d internal_info.get(\u0027is_whole_disk_image\u0027)"},{"line_number":856,"context_line":"        if software_raid or (root_uuid and not whole_disk_image):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_2125395d","line":853,"updated":"2019-10-17 21:45:51.000000000","message":"LGTM, just needs unit test to for the parts covered by the If statement.","commit_id":"ea877a7c2528e4a0601bdb1e8e831020103cdc8d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b56c23f9f2641605b948e4cad452f9f3a2886ed4","unresolved":false,"context_lines":[{"line_number":838,"context_line":"            try:"},{"line_number":839,"context_line":"                context \u003d task.context"},{"line_number":840,"context_line":"                context.is_admin \u003d True"},{"line_number":841,"context_line":"                glance \u003d image_service.GlanceImageService("},{"line_number":842,"context_line":"                    context\u003dcontext)"},{"line_number":843,"context_line":"                image_info \u003d glance.show(image_source)"},{"line_number":844,"context_line":"                image_properties \u003d image_info.get(\u0027properties\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_06bd76b0","line":841,"updated":"2019-12-02 12:45:45.000000000","message":"there is a bit more generic https://github.com/openstack/ironic/blob/master/ironic/common/images.py#L400-L417 get_image_properties","commit_id":"defc4a8761e116bdc61af528a79b11d47b4e6768"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1e122b27b7bfc117b317fda233b95c57b180e872","unresolved":false,"context_lines":[{"line_number":843,"context_line":"                image_info \u003d glance.show(image_source)"},{"line_number":844,"context_line":"                image_properties \u003d image_info.get(\u0027properties\u0027)"},{"line_number":845,"context_line":"                root_uuid \u003d image_properties[\u0027rootfs_uuid\u0027]"},{"line_number":846,"context_line":"                LOG.debug(\u0027Got rootfs_uuid from Glance: %s\u0027, root_uuid)"},{"line_number":847,"context_line":"            except Exception as e:"},{"line_number":848,"context_line":"                LOG.warning(\u0027Could not get \\\u0027rootfs_uuid\\\u0027 property for \u0027"},{"line_number":849,"context_line":"                            \u0027image %(image)s from Glance: %(error)s.\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_bb2a7be3","line":846,"updated":"2019-12-02 11:31:38.000000000","message":"nit: mention node UUID","commit_id":"defc4a8761e116bdc61af528a79b11d47b4e6768"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1e122b27b7bfc117b317fda233b95c57b180e872","unresolved":false,"context_lines":[{"line_number":847,"context_line":"            except Exception as e:"},{"line_number":848,"context_line":"                LOG.warning(\u0027Could not get \\\u0027rootfs_uuid\\\u0027 property for \u0027"},{"line_number":849,"context_line":"                            \u0027image %(image)s from Glance: %(error)s.\u0027,"},{"line_number":850,"context_line":"                            {\u0027image\u0027: image_source, \u0027error\u0027: e})"},{"line_number":851,"context_line":"                root_uuid \u003d internal_info.get(\u0027root_uuid_or_disk_id\u0027)"},{"line_number":852,"context_line":"                LOG.debug(\u0027Got rootfs_uuid from driver internal info: \u0027"},{"line_number":853,"context_line":"                          \u0027 %s\u0027, root_uuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_5b310759","line":850,"updated":"2019-12-02 11:31:38.000000000","message":"ditto (also maybe include exception class name)","commit_id":"defc4a8761e116bdc61af528a79b11d47b4e6768"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1e122b27b7bfc117b317fda233b95c57b180e872","unresolved":false,"context_lines":[{"line_number":850,"context_line":"                            {\u0027image\u0027: image_source, \u0027error\u0027: e})"},{"line_number":851,"context_line":"                root_uuid \u003d internal_info.get(\u0027root_uuid_or_disk_id\u0027)"},{"line_number":852,"context_line":"                LOG.debug(\u0027Got rootfs_uuid from driver internal info: \u0027"},{"line_number":853,"context_line":"                          \u0027 %s\u0027, root_uuid)"},{"line_number":854,"context_line":""},{"line_number":855,"context_line":"        whole_disk_image \u003d internal_info.get(\u0027is_whole_disk_image\u0027)"},{"line_number":856,"context_line":"        if software_raid or (root_uuid and not whole_disk_image):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_7b34034a","line":853,"updated":"2019-12-02 11:31:38.000000000","message":"ditto","commit_id":"defc4a8761e116bdc61af528a79b11d47b4e6768"}],"releasenotes/notes/sofware_raid_use_rootfs_uuid-f61eb671d696d251.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1e122b27b7bfc117b317fda233b95c57b180e872","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    the UUID passed from the conductor. Operators need hence to make sure"},{"line_number":11,"context_line":"    that the conductor has the correct UUID (which either comes from the"},{"line_number":12,"context_line":"    \u0027rootfs_uuid\u0027 field in the image metadata or from the"},{"line_number":13,"context_line":"    \u0027root_uuid_or_disk_id\u0027 in the nodes \u0027internal_driver_info\u0027.)"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_1b3b8f39","line":13,"updated":"2019-12-02 11:31:38.000000000","message":"Operators cannot set driver_internal_info. Does it mean they should update glance? Maybe add this to software RAID documentation? Is there a way to make it work for standalone deployments?","commit_id":"defc4a8761e116bdc61af528a79b11d47b4e6768"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"af39a01d5bcedf9788034708a5f377b282986ef3","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    the UUID passed from the conductor. Operators need hence to make sure"},{"line_number":11,"context_line":"    that the conductor has the correct UUID (which either comes from the"},{"line_number":12,"context_line":"    \u0027rootfs_uuid\u0027 field in the image metadata or from the"},{"line_number":13,"context_line":"    \u0027root_uuid_or_disk_id\u0027 in the nodes \u0027internal_driver_info\u0027.)"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_4e65ebae","line":13,"in_reply_to":"3fa7e38b_1b3b8f39","updated":"2019-12-17 09:26:18.000000000","message":"We probably have different definitions of \u0027operator\u0027. My operator has admin access :)\n\nHow is the UUID passed stand-alone deployments, for partition images, for instance? I\u0027d think the very same mechanism should work here.\n\nGood point about the docs, will add a doc patch.","commit_id":"defc4a8761e116bdc61af528a79b11d47b4e6768"}]}