)]}'
{"ironic/drivers/modules/ansible/playbooks/library/root_hints.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2bf88acd6ba07989efa2c9e09bcf762842bce08e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"def root_hint(hints, devices):"},{"line_number":46,"context_line":"    hint \u003d None"},{"line_number":47,"context_line":"    name \u003d hints.pop(\u0027name\u0027, None)"},{"line_number":48,"context_line":"    for device in devices.sort():"},{"line_number":49,"context_line":"        for key in hints:"},{"line_number":50,"context_line":"            if hints[key] !\u003d devices[device].get(key):"},{"line_number":51,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_aee49fe1","line":48,"updated":"2019-10-20 15:19:54.000000000","message":"dicts do not have sort() (why doesn\u0027t it blow up in the CI?), you need sorted(devices)","commit_id":"64946c0fadcc430e545924351e01ae07c0104c41"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"b8e667e3aae074d5a94a263e724e4edfee0a73ad","unresolved":false,"context_lines":[{"line_number":45,"context_line":"def root_hint(hints, devices):"},{"line_number":46,"context_line":"    hint \u003d None"},{"line_number":47,"context_line":"    name \u003d hints.pop(\u0027name\u0027, None)"},{"line_number":48,"context_line":"    for device in devices.sort():"},{"line_number":49,"context_line":"        for key in hints:"},{"line_number":50,"context_line":"            if hints[key] !\u003d devices[device].get(key):"},{"line_number":51,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_ee2857ef","line":48,"in_reply_to":"3fa7e38b_aee49fe1","updated":"2019-10-20 16:11:34.000000000","message":"Strange that the CI didn\u0027t fail, maybe we can convert the dict in an OrderedDict?","commit_id":"64946c0fadcc430e545924351e01ae07c0104c41"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ebd53f2089888dfacfb9e43bbbe07e410a589af0","unresolved":false,"context_lines":[{"line_number":45,"context_line":"def root_hint(hints, devices):"},{"line_number":46,"context_line":"    hint \u003d None"},{"line_number":47,"context_line":"    name \u003d hints.pop(\u0027name\u0027, None)"},{"line_number":48,"context_line":"    for device in devices.sort():"},{"line_number":49,"context_line":"        for key in hints:"},{"line_number":50,"context_line":"            if hints[key] !\u003d devices[device].get(key):"},{"line_number":51,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_b25e3974","line":48,"in_reply_to":"3fa7e38b_ee2857ef","updated":"2019-10-21 13:28:13.000000000","message":"very strange. For some reason I was thinking the devices was just a list. :(  I definitely needed more coffee on friday :(","commit_id":"64946c0fadcc430e545924351e01ae07c0104c41"}]}