)]}'
{"ironic/conductor/manager.py":[{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"c3d6f80b464821b84dde0fb568323a644982eb86","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        with task_manager.acquire(context, node_id, shared\u003dTrue) as task:"},{"line_number":218,"context_line":"            try:"},{"line_number":219,"context_line":"                if getattr(task.driver, \u0027vendor\u0027, None):"},{"line_number":220,"context_line":"                    return task.driver.vendor.validate(task, task.node,"},{"line_number":221,"context_line":"                                                       method\u003ddriver_method,"},{"line_number":222,"context_line":"                                                       **info)"},{"line_number":223,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2Fnl0%3D","line":220,"updated":"2014-02-11 23:28:20.000000000","message":"Can we remove node parameter with this patch - e.g. to use task.node inside validate. Because currently this may be misleading - validate will gain task resources such as node\u0027s ports, but we may actually pass different node by mistake, not the same as task.has\n\nMakes sense?","commit_id":"5eeb6d6b61decdad7bb6a81a720557f5f5df7625"},{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"c2c1d222dc105382f6501e3d39972bfe8b74adf7","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        with task_manager.acquire(context, node_id, shared\u003dTrue) as task:"},{"line_number":218,"context_line":"            try:"},{"line_number":219,"context_line":"                if getattr(task.driver, \u0027vendor\u0027, None):"},{"line_number":220,"context_line":"                    return task.driver.vendor.validate(task, task.node,"},{"line_number":221,"context_line":"                                                       method\u003ddriver_method,"},{"line_number":222,"context_line":"                                                       **info)"},{"line_number":223,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2FYL4%3D","line":220,"in_reply_to":"AAAAUX%2F%2FYVM%3D","updated":"2014-02-13 16:11:13.000000000","message":"I agree, separate patch would be great.\n\nAlso there is a bug for this https://bugs.launchpad.net/ironic/+bug/1259346 so we may tag those patch with this bug","commit_id":"5eeb6d6b61decdad7bb6a81a720557f5f5df7625"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"42f9317a9f7bf47896a5a0a4b7b8f11986342612","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        with task_manager.acquire(context, node_id, shared\u003dTrue) as task:"},{"line_number":218,"context_line":"            try:"},{"line_number":219,"context_line":"                if getattr(task.driver, \u0027vendor\u0027, None):"},{"line_number":220,"context_line":"                    return task.driver.vendor.validate(task, task.node,"},{"line_number":221,"context_line":"                                                       method\u003ddriver_method,"},{"line_number":222,"context_line":"                                                       **info)"},{"line_number":223,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2FYVM%3D","line":220,"in_reply_to":"AAAAUX%2F%2Fnl0%3D","updated":"2014-02-13 15:59:44.000000000","message":"Hi Max, idk, I think it would be better to do it in a separated patch removing the node from all methods since \"node\" is not needed by any of the methods not only validate.\n\nWhat you think?","commit_id":"5eeb6d6b61decdad7bb6a81a720557f5f5df7625"}]}
