)]}'
{"ironic/drivers/modules/redfish/boot.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e000100a4df7fdfc2e8f64005b86278c6f0fc8ee","unresolved":false,"context_lines":[{"line_number":792,"context_line":""},{"line_number":793,"context_line":"        d_info \u003d self._parse_driver_info(node)"},{"line_number":794,"context_line":""},{"line_number":795,"context_line":"        config_via_floppy \u003d d_info.get(\u0027config_via_floppy\u0027)"},{"line_number":796,"context_line":""},{"line_number":797,"context_line":"        if config_via_floppy:"},{"line_number":798,"context_line":"            self._prepare_and_insert_floppy(task, params\u003dparams)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_82c89256","line":795,"range":{"start_line":795,"start_character":40,"end_line":795,"end_character":57},"updated":"2019-11-07 23:56:45.000000000","message":"I\u0027m not sure if we should use same configuration to pass the information during instance boot. So far this is used only during deploy. As this needs could be useful only for the special user images which can read the data from vmedia floppy. Would it be better to have a separate config indicating that instance parameters would be passed via floppy?","commit_id":"ccbd318d7ef960cc58360f545c83cc37a452bd95"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"e08a217366f9f4cfcbcfc8aa21d4a9e4dd31e03b","unresolved":false,"context_lines":[{"line_number":792,"context_line":""},{"line_number":793,"context_line":"        d_info \u003d self._parse_driver_info(node)"},{"line_number":794,"context_line":""},{"line_number":795,"context_line":"        config_via_floppy \u003d d_info.get(\u0027config_via_floppy\u0027)"},{"line_number":796,"context_line":""},{"line_number":797,"context_line":"        if config_via_floppy:"},{"line_number":798,"context_line":"            self._prepare_and_insert_floppy(task, params\u003dparams)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_8d2eb03f","line":795,"range":{"start_line":795,"start_character":40,"end_line":795,"end_character":57},"in_reply_to":"3fa7e38b_82c89256","updated":"2020-01-10 19:07:30.000000000","message":"Yes, may be this is all wrong! Let\u0027s discuss config-drive idea in the next patch?","commit_id":"ccbd318d7ef960cc58360f545c83cc37a452bd95"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e000100a4df7fdfc2e8f64005b86278c6f0fc8ee","unresolved":false,"context_lines":[{"line_number":794,"context_line":""},{"line_number":795,"context_line":"        config_via_floppy \u003d d_info.get(\u0027config_via_floppy\u0027)"},{"line_number":796,"context_line":""},{"line_number":797,"context_line":"        if config_via_floppy:"},{"line_number":798,"context_line":"            self._prepare_and_insert_floppy(task, params\u003dparams)"},{"line_number":799,"context_line":""},{"line_number":800,"context_line":"        iso_ref \u003d self._prepare_boot_iso(task, **params)"},{"line_number":801,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_a28eee2f","line":798,"range":{"start_line":797,"start_character":8,"end_line":798,"end_character":64},"updated":"2019-11-07 23:56:45.000000000","message":"How this data will be consumed? Would instance image have special handling to read data from floppy?","commit_id":"ccbd318d7ef960cc58360f545c83cc37a452bd95"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"e08a217366f9f4cfcbcfc8aa21d4a9e4dd31e03b","unresolved":false,"context_lines":[{"line_number":794,"context_line":""},{"line_number":795,"context_line":"        config_via_floppy \u003d d_info.get(\u0027config_via_floppy\u0027)"},{"line_number":796,"context_line":""},{"line_number":797,"context_line":"        if config_via_floppy:"},{"line_number":798,"context_line":"            self._prepare_and_insert_floppy(task, params\u003dparams)"},{"line_number":799,"context_line":""},{"line_number":800,"context_line":"        iso_ref \u003d self._prepare_boot_iso(task, **params)"},{"line_number":801,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_2d21bc4f","line":798,"range":{"start_line":797,"start_character":8,"end_line":798,"end_character":64},"in_reply_to":"3fa7e38b_a28eee2f","updated":"2020-01-10 19:07:30.000000000","message":"Right, may be we should stick to cloud-init to have anything consumed automatically.","commit_id":"ccbd318d7ef960cc58360f545c83cc37a452bd95"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a194b6e5f4d3a776987209b93baaae99d7a4ce0e","unresolved":false,"context_lines":[{"line_number":728,"context_line":""},{"line_number":729,"context_line":"        mode \u003d deploy_utils.rescue_or_deploy_mode(node)"},{"line_number":730,"context_line":""},{"line_number":731,"context_line":"        iso_ref \u003d self._prepare_deploy_iso(task, ramdisk_params, mode)"},{"line_number":732,"context_line":""},{"line_number":733,"context_line":"        self._eject_vmedia(task, sushy.VIRTUAL_MEDIA_CD)"},{"line_number":734,"context_line":"        self._insert_vmedia(task, iso_ref, sushy.VIRTUAL_MEDIA_CD)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_7c4d843a","line":731,"range":{"start_line":731,"start_character":8,"end_line":731,"end_character":70},"updated":"2020-01-03 05:49:10.000000000","message":"Is this redundant? We pass the ramdisk_params into iso even if its passed through floppy.","commit_id":"7264cefe49436dac352f56022a4c1ba3df6ec9e4"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"e08a217366f9f4cfcbcfc8aa21d4a9e4dd31e03b","unresolved":false,"context_lines":[{"line_number":728,"context_line":""},{"line_number":729,"context_line":"        mode \u003d deploy_utils.rescue_or_deploy_mode(node)"},{"line_number":730,"context_line":""},{"line_number":731,"context_line":"        iso_ref \u003d self._prepare_deploy_iso(task, ramdisk_params, mode)"},{"line_number":732,"context_line":""},{"line_number":733,"context_line":"        self._eject_vmedia(task, sushy.VIRTUAL_MEDIA_CD)"},{"line_number":734,"context_line":"        self._insert_vmedia(task, iso_ref, sushy.VIRTUAL_MEDIA_CD)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_a114de9f","line":731,"range":{"start_line":731,"start_character":8,"end_line":731,"end_character":70},"in_reply_to":"3fa7e38b_7c4d843a","updated":"2020-01-10 19:07:30.000000000","message":"I think passing params via iso is the only operational way for now. These params are up in kernel cmdline (via grub2 config), IPA reads them from there.","commit_id":"7264cefe49436dac352f56022a4c1ba3df6ec9e4"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f199b50db114ca2a56ea7a40c42457be948fed48","unresolved":false,"context_lines":[{"line_number":728,"context_line":""},{"line_number":729,"context_line":"        mode \u003d deploy_utils.rescue_or_deploy_mode(node)"},{"line_number":730,"context_line":""},{"line_number":731,"context_line":"        iso_ref \u003d self._prepare_deploy_iso(task, ramdisk_params, mode)"},{"line_number":732,"context_line":""},{"line_number":733,"context_line":"        self._eject_vmedia(task, sushy.VIRTUAL_MEDIA_CD)"},{"line_number":734,"context_line":"        self._insert_vmedia(task, iso_ref, sushy.VIRTUAL_MEDIA_CD)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_847b30f1","line":731,"range":{"start_line":731,"start_character":8,"end_line":731,"end_character":70},"in_reply_to":"3fa7e38b_7c4d843a","updated":"2020-01-06 22:16:52.000000000","message":"Not really redundant in that we\u0027ll likely end up dropping all floppy support at some point soon...","commit_id":"7264cefe49436dac352f56022a4c1ba3df6ec9e4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a194b6e5f4d3a776987209b93baaae99d7a4ce0e","unresolved":false,"context_lines":[{"line_number":823,"context_line":""},{"line_number":824,"context_line":"        config_via_floppy \u003d d_info.get(\u0027config_via_floppy\u0027)"},{"line_number":825,"context_line":""},{"line_number":826,"context_line":"        if config_via_floppy:"},{"line_number":827,"context_line":"            self._prepare_and_insert_floppy(task, params\u003dparams)"},{"line_number":828,"context_line":""},{"line_number":829,"context_line":"        iso_ref \u003d self._prepare_boot_iso(task, **params)"},{"line_number":830,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_bc477c1e","line":827,"range":{"start_line":826,"start_character":8,"end_line":827,"end_character":64},"updated":"2020-01-03 05:49:10.000000000","message":"We just pass the \u0027root_uuid_or_disk_id\u0027 as part of params. How it would get consumed if passed from the floppy? This will not cause any failure as this data is getting passed to cdrom as well at L829.","commit_id":"7264cefe49436dac352f56022a4c1ba3df6ec9e4"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"028bfa6e64b247550fb23810b4aef7e7a812f1a6","unresolved":false,"context_lines":[{"line_number":823,"context_line":""},{"line_number":824,"context_line":"        config_via_floppy \u003d d_info.get(\u0027config_via_floppy\u0027)"},{"line_number":825,"context_line":""},{"line_number":826,"context_line":"        if config_via_floppy:"},{"line_number":827,"context_line":"            self._prepare_and_insert_floppy(task, params\u003dparams)"},{"line_number":828,"context_line":""},{"line_number":829,"context_line":"        iso_ref \u003d self._prepare_boot_iso(task, **params)"},{"line_number":830,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_5159b826","line":827,"range":{"start_line":826,"start_character":8,"end_line":827,"end_character":64},"in_reply_to":"3fa7e38b_56452e9a","updated":"2020-01-20 14:29:17.000000000","message":"I have these thoughts:\n\n1) In the context of virtual media, can we consider floppy \u003d\u003d USB flash drive \u003d\u003d SD-card. I can add corresponding knobs to control the exact destination.\n2) Should we, optionally, dump config-drive to floppy/flash for ramdisk/instance to make use of.\n3) Let\u0027s not pass IPA params via floppy/usb for now. They are being served via kernel cmdline what implies flashing them into boot ISO. However we could change that going forward because of (4)\n4) Conceptually, floppy/usb/SD can be tiny so that the operator could reuse the same (larger) boot image for many nodes. Node-specific config could then be served via smaller virtual media devices.\n\nItem (2) is dependent on the outcome of the L3 spec discussion.\n\nDoes it make sense?","commit_id":"7264cefe49436dac352f56022a4c1ba3df6ec9e4"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b1aa625202e2b8705281baa2c2a2279a7a78bcf6","unresolved":false,"context_lines":[{"line_number":823,"context_line":""},{"line_number":824,"context_line":"        config_via_floppy \u003d d_info.get(\u0027config_via_floppy\u0027)"},{"line_number":825,"context_line":""},{"line_number":826,"context_line":"        if config_via_floppy:"},{"line_number":827,"context_line":"            self._prepare_and_insert_floppy(task, params\u003dparams)"},{"line_number":828,"context_line":""},{"line_number":829,"context_line":"        iso_ref \u003d self._prepare_boot_iso(task, **params)"},{"line_number":830,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_56452e9a","line":827,"range":{"start_line":826,"start_character":8,"end_line":827,"end_character":64},"in_reply_to":"3fa7e38b_6d0254bc","updated":"2020-01-20 14:10:57.000000000","message":"So... preparing for instance does NOT mean that IPA should ever be expected to operate or need to do something on the deployed host.\n\nI guess I\u0027m becoming more and more alarmed why we\u0027re even trying to facilitate some sort of floppy attachment action to a deployed instance if we\u0027re not offering the configuration drive, but even then...\n\nhttps://github.com/torvalds/linux/commit/47d6a7607443ea43dbc4d0f371bf773540a8f8f4","commit_id":"7264cefe49436dac352f56022a4c1ba3df6ec9e4"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"e08a217366f9f4cfcbcfc8aa21d4a9e4dd31e03b","unresolved":false,"context_lines":[{"line_number":823,"context_line":""},{"line_number":824,"context_line":"        config_via_floppy \u003d d_info.get(\u0027config_via_floppy\u0027)"},{"line_number":825,"context_line":""},{"line_number":826,"context_line":"        if config_via_floppy:"},{"line_number":827,"context_line":"            self._prepare_and_insert_floppy(task, params\u003dparams)"},{"line_number":828,"context_line":""},{"line_number":829,"context_line":"        iso_ref \u003d self._prepare_boot_iso(task, **params)"},{"line_number":830,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_6d0254bc","line":827,"range":{"start_line":826,"start_character":8,"end_line":827,"end_character":64},"in_reply_to":"3fa7e38b_bc477c1e","updated":"2020-01-10 19:07:30.000000000","message":"Yeah, these params won\u0027t be consumed by IPA out-of-the-box...\n\nMay be we should better dump config-drive (if given) onto floppy instead? And do it only for instances so that cloud-init would probably pick it up from there...?\n\nThis latter idea repeats the L3 spec ideas where I propose passing network configuration for ramdisk/instance in config-drive via boot ISO.\n\nWDYT?","commit_id":"7264cefe49436dac352f56022a4c1ba3df6ec9e4"}]}