)]}'
{"ironic/conf/ipmi.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a6ecea9a27c619d1bb955a4d5d413fc03addc33d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                      \u0027sent to a server. There is a risk with some hardware \u0027"},{"line_number":36,"context_line":"                      \u0027that setting this too low may cause the BMC to crash. \u0027"},{"line_number":37,"context_line":"                      \u0027Recommended setting is 5 seconds.\u0027)),"},{"line_number":38,"context_line":"    cfg.BoolOpt(\u0027kill_on_timeout\u0027,"},{"line_number":39,"context_line":"                default\u003dTrue,"},{"line_number":40,"context_line":"                help\u003d_(\u0027Kill `ipmitool` process invoked by ironic to read \u0027"},{"line_number":41,"context_line":"                       \u0027node power state if `ipmitool` process does not exit \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_361b871c","line":38,"updated":"2020-01-07 13:43:59.000000000","message":"I agree with Ruby\u0027s reasoning.","commit_id":"2fe5c65c073e80b4b5b4d3f2682721d7c239c033"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"dcae1519ecd0a994a98f84a69ec6b8462345a37a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                      \u0027sent to a server. There is a risk with some hardware \u0027"},{"line_number":36,"context_line":"                      \u0027that setting this too low may cause the BMC to crash. \u0027"},{"line_number":37,"context_line":"                      \u0027Recommended setting is 5 seconds.\u0027)),"},{"line_number":38,"context_line":"    cfg.BoolOpt(\u0027kill_on_timeout\u0027,"},{"line_number":39,"context_line":"                default\u003dTrue,"},{"line_number":40,"context_line":"                help\u003d_(\u0027Kill `ipmitool` process invoked by ironic to read \u0027"},{"line_number":41,"context_line":"                       \u0027node power state if `ipmitool` process does not exit \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_6e605c36","line":38,"updated":"2019-11-20 00:05:15.000000000","message":"This is changing behavior although for a bug fix which is logical to do... so we can either make it default, or default it at False. Going to tag Dmitry for his thoughts.","commit_id":"2fe5c65c073e80b4b5b4d3f2682721d7c239c033"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"bc40e5f0f3ffd6fa561031cbd31bd051345a7d05","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                      \u0027sent to a server. There is a risk with some hardware \u0027"},{"line_number":36,"context_line":"                      \u0027that setting this too low may cause the BMC to crash. \u0027"},{"line_number":37,"context_line":"                      \u0027Recommended setting is 5 seconds.\u0027)),"},{"line_number":38,"context_line":"    cfg.BoolOpt(\u0027kill_on_timeout\u0027,"},{"line_number":39,"context_line":"                default\u003dTrue,"},{"line_number":40,"context_line":"                help\u003d_(\u0027Kill `ipmitool` process invoked by ironic to read \u0027"},{"line_number":41,"context_line":"                       \u0027node power state if `ipmitool` process does not exit \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_61e346d8","line":38,"in_reply_to":"3fa7e38b_361b871c","updated":"2020-01-28 07:22:02.000000000","message":"It appears like we voted for leaving it defaulted as-is.","commit_id":"2fe5c65c073e80b4b5b4d3f2682721d7c239c033"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"77967372d77868a105892391ed8dc264c8f04fd2","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                      \u0027sent to a server. There is a risk with some hardware \u0027"},{"line_number":36,"context_line":"                      \u0027that setting this too low may cause the BMC to crash. \u0027"},{"line_number":37,"context_line":"                      \u0027Recommended setting is 5 seconds.\u0027)),"},{"line_number":38,"context_line":"    cfg.BoolOpt(\u0027kill_on_timeout\u0027,"},{"line_number":39,"context_line":"                default\u003dTrue,"},{"line_number":40,"context_line":"                help\u003d_(\u0027Kill `ipmitool` process invoked by ironic to read \u0027"},{"line_number":41,"context_line":"                       \u0027node power state if `ipmitool` process does not exit \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_b960d536","line":38,"in_reply_to":"3fa7e38b_6e605c36","updated":"2019-11-20 14:25:50.000000000","message":"interesting conundrum, I\u0027m for having this enabled by default, all considered\nit\u0027s a big change in behavior, but it fixes a nasty issue, especially for large deployments","commit_id":"2fe5c65c073e80b4b5b4d3f2682721d7c239c033"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"645ca512531d1ec11e7faff25a3f795eed775a9a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                      \u0027sent to a server. There is a risk with some hardware \u0027"},{"line_number":36,"context_line":"                      \u0027that setting this too low may cause the BMC to crash. \u0027"},{"line_number":37,"context_line":"                      \u0027Recommended setting is 5 seconds.\u0027)),"},{"line_number":38,"context_line":"    cfg.BoolOpt(\u0027kill_on_timeout\u0027,"},{"line_number":39,"context_line":"                default\u003dTrue,"},{"line_number":40,"context_line":"                help\u003d_(\u0027Kill `ipmitool` process invoked by ironic to read \u0027"},{"line_number":41,"context_line":"                       \u0027node power state if `ipmitool` process does not exit \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_04be60ae","line":38,"in_reply_to":"3fa7e38b_b960d536","updated":"2020-01-06 22:03:32.000000000","message":"I think it\u0027ll be too confusing if this defaults to False (in rocky, stein, and perhaps pike, queens), yet in master (train), it defaults to True.\n\nIt fixes a bug. Bonus that we implemented it so that there is a choice :)","commit_id":"2fe5c65c073e80b4b5b4d3f2682721d7c239c033"}],"ironic/drivers/modules/ipmitool.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a6ecea9a27c619d1bb955a4d5d413fc03addc33d","unresolved":false,"context_lines":[{"line_number":393,"context_line":"                {\u0027node\u0027: driver_info[\u0027uuid\u0027], \u0027cmd\u0027: popen_obj.cmd})"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"    popen_obj.terminate()"},{"line_number":396,"context_line":"    time.sleep(0.5)"},{"line_number":397,"context_line":"    if popen_obj.poll():"},{"line_number":398,"context_line":"        popen_obj.kill()"},{"line_number":399,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_d6131301","line":396,"updated":"2020-01-07 13:43:59.000000000","message":":(","commit_id":"2fe5c65c073e80b4b5b4d3f2682721d7c239c033"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a6ecea9a27c619d1bb955a4d5d413fc03addc33d","unresolved":false,"context_lines":[{"line_number":397,"context_line":"    if popen_obj.poll():"},{"line_number":398,"context_line":"        popen_obj.kill()"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    time.sleep(1)"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    if popen_obj.poll():"},{"line_number":403,"context_line":"        LOG.warning(\u0027Could not kill IPMI process \"%(cmd)s\" for node %(node)s.\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_f6108ff6","line":400,"updated":"2020-01-07 13:43:59.000000000","message":":(((","commit_id":"2fe5c65c073e80b4b5b4d3f2682721d7c239c033"}],"releasenotes/notes/force-out-hung-ipmitool-process-519c7567bcbaa882.yaml":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"77967372d77868a105892391ed8dc264c8f04fd2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Kill ``ipmitool`` process invoked by ironic to read node\u0027s power state if"},{"line_number":5,"context_line":"    ``ipmitool`` process does not exit after configured timeout expires. It"},{"line_number":6,"context_line":"    appears pretty common for ``ipmitool`` to run for five minutes (with"},{"line_number":7,"context_line":"    current ironic defauls) once it hits a non-responsive bare metal node."},{"line_number":8,"context_line":"    This could slow down the management of other nodes due periodic tasks"},{"line_number":9,"context_line":"    slots exhaustion. The new behaviour could is enabled by default, but"},{"line_number":10,"context_line":"    could be disabled via the ``[ipmi]kill_on_timeout`` ironic configuration"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_9934f94a","line":7,"range":{"start_line":7,"start_character":19,"end_line":7,"end_character":26},"updated":"2019-11-20 14:25:50.000000000","message":"nit: default","commit_id":"2fe5c65c073e80b4b5b4d3f2682721d7c239c033"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"77967372d77868a105892391ed8dc264c8f04fd2","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    ``ipmitool`` process does not exit after configured timeout expires. It"},{"line_number":6,"context_line":"    appears pretty common for ``ipmitool`` to run for five minutes (with"},{"line_number":7,"context_line":"    current ironic defauls) once it hits a non-responsive bare metal node."},{"line_number":8,"context_line":"    This could slow down the management of other nodes due periodic tasks"},{"line_number":9,"context_line":"    slots exhaustion. The new behaviour could is enabled by default, but"},{"line_number":10,"context_line":"    could be disabled via the ``[ipmi]kill_on_timeout`` ironic configuration"},{"line_number":11,"context_line":"    option."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_593a0134","line":8,"range":{"start_line":8,"start_character":55,"end_line":8,"end_character":58},"updated":"2019-11-20 14:25:50.000000000","message":"nit: due to","commit_id":"2fe5c65c073e80b4b5b4d3f2682721d7c239c033"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"77967372d77868a105892391ed8dc264c8f04fd2","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    appears pretty common for ``ipmitool`` to run for five minutes (with"},{"line_number":7,"context_line":"    current ironic defauls) once it hits a non-responsive bare metal node."},{"line_number":8,"context_line":"    This could slow down the management of other nodes due periodic tasks"},{"line_number":9,"context_line":"    slots exhaustion. The new behaviour could is enabled by default, but"},{"line_number":10,"context_line":"    could be disabled via the ``[ipmi]kill_on_timeout`` ironic configuration"},{"line_number":11,"context_line":"    option."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_39f8657a","line":9,"range":{"start_line":9,"start_character":40,"end_line":9,"end_character":46},"updated":"2019-11-20 14:25:50.000000000","message":"nit: remove this \"could\"","commit_id":"2fe5c65c073e80b4b5b4d3f2682721d7c239c033"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"645ca512531d1ec11e7faff25a3f795eed775a9a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    appears pretty common for ``ipmitool`` to run for five minutes (with"},{"line_number":7,"context_line":"    current ironic defauls) once it hits a non-responsive bare metal node."},{"line_number":8,"context_line":"    This could slow down the management of other nodes due periodic tasks"},{"line_number":9,"context_line":"    slots exhaustion. The new behaviour could is enabled by default, but"},{"line_number":10,"context_line":"    could be disabled via the ``[ipmi]kill_on_timeout`` ironic configuration"},{"line_number":11,"context_line":"    option."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_0470a040","line":9,"range":{"start_line":9,"start_character":40,"end_line":9,"end_character":46},"in_reply_to":"3fa7e38b_39f8657a","updated":"2020-01-06 22:03:32.000000000","message":"Darn, we should have gotten it right in the original. Since this is a backport, I don\u0027t think we should be modifying it.","commit_id":"2fe5c65c073e80b4b5b4d3f2682721d7c239c033"}]}