)]}'
{"ironic/drivers/modules/pxe.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"69a74d45e442f34914a631ce272d237741cc3a4b","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        # TODO(TheJulia): Once the pxe/ipxe interfaces split is complete,"},{"line_number":60,"context_line":"        # this can be removed."},{"line_number":61,"context_line":"        if CONF.pxe.ipxe_enabled:"},{"line_number":62,"context_line":"            pxe_utils.create_ipxe_boot_script()"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _validate_common(self, task):"},{"line_number":65,"context_line":"        node \u003d task.node"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_1b738fea","line":62,"updated":"2019-12-02 11:48:25.000000000","message":"should we set self.ipxe_enabled accordingly here?","commit_id":"ce1d5a884ed0081015b6d286a95913940128bfff"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"685260aaa7a4ba2f62686b6e823f4e2201b22e4a","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        # TODO(TheJulia): Once the pxe/ipxe interfaces split is complete,"},{"line_number":60,"context_line":"        # this can be removed."},{"line_number":61,"context_line":"        if CONF.pxe.ipxe_enabled:"},{"line_number":62,"context_line":"            pxe_utils.create_ipxe_boot_script()"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _validate_common(self, task):"},{"line_number":65,"context_line":"        node \u003d task.node"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_96b191e3","line":62,"in_reply_to":"3fa7e38b_1b738fea","updated":"2019-12-02 15:08:13.000000000","message":"we should, i am trying another way in https://review.opendev.org/696810, and if it works i will rebase this patch above of it (which including more changes on removing duplicated codes).\nIf everyone is good on this change as a start point, we can also merge this one first.","commit_id":"ce1d5a884ed0081015b6d286a95913940128bfff"}],"ironic/drivers/modules/pxe_base.py":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"2b54a3746bd62630b2e0154635b5be36e1559a11","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            pxe_utils.clean_up_pxe_env(task, images_info,"},{"line_number":132,"context_line":"                                       ipxe_enabled\u003dself.ipxe_enabled)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    @METRICS.timer(\u0027iPXEBoot.prepare_ramdisk\u0027)"},{"line_number":135,"context_line":"    def prepare_ramdisk(self, task, ramdisk_params):"},{"line_number":136,"context_line":"        \"\"\"Prepares the boot of Ironic ramdisk using PXE."},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_b1377ae4","line":134,"range":{"start_line":134,"start_character":20,"end_line":134,"end_character":28},"updated":"2020-02-12 15:19:45.000000000","message":"Here it should be PXEBaseMixin no?","commit_id":"77ee042679947465160186cf340e4f996a546c0c"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"6712780c142c478d8134ce6715f2c3d1404baf89","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            pxe_utils.clean_up_pxe_env(task, images_info,"},{"line_number":132,"context_line":"                                       ipxe_enabled\u003dself.ipxe_enabled)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    @METRICS.timer(\u0027iPXEBoot.prepare_ramdisk\u0027)"},{"line_number":135,"context_line":"    def prepare_ramdisk(self, task, ramdisk_params):"},{"line_number":136,"context_line":"        \"\"\"Prepares the boot of Ironic ramdisk using PXE."},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_3f4a29ae","line":134,"range":{"start_line":134,"start_character":20,"end_line":134,"end_character":28},"in_reply_to":"3fa7e38b_b1377ae4","updated":"2020-02-18 08:39:33.000000000","message":"Done","commit_id":"77ee042679947465160186cf340e4f996a546c0c"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"95e61c76ec11e2e021146fdfe3890cc4b4c5e073","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            pxe_utils.clean_up_pxe_env(task, images_info,"},{"line_number":132,"context_line":"                                       ipxe_enabled\u003dself.ipxe_enabled)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    @METRICS.timer(\u0027iPXEBoot.prepare_ramdisk\u0027)"},{"line_number":135,"context_line":"    def prepare_ramdisk(self, task, ramdisk_params):"},{"line_number":136,"context_line":"        \"\"\"Prepares the boot of Ironic ramdisk using PXE."},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_d10eac3a","line":134,"range":{"start_line":134,"start_character":20,"end_line":134,"end_character":28},"in_reply_to":"3fa7e38b_b1377ae4","updated":"2020-02-13 03:08:34.000000000","message":"Ugh, will update, thanks!","commit_id":"77ee042679947465160186cf340e4f996a546c0c"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"b3d6c7228924846b6e39c981118d6cab5ac6a48f","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            pxe_utils.clean_up_pxe_env(task, images_info,"},{"line_number":132,"context_line":"                                       ipxe_enabled\u003dself.ipxe_enabled)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    @METRICS.timer(\u0027iPXEBoot.prepare_ramdisk\u0027)"},{"line_number":135,"context_line":"    def prepare_ramdisk(self, task, ramdisk_params):"},{"line_number":136,"context_line":"        \"\"\"Prepares the boot of Ironic ramdisk using PXE."},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_3d0ef1d7","line":134,"range":{"start_line":134,"start_character":20,"end_line":134,"end_character":28},"in_reply_to":"3fa7e38b_d10eac3a","updated":"2020-02-13 09:47:11.000000000","message":"Np o/","commit_id":"77ee042679947465160186cf340e4f996a546c0c"}]}