)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6304511c2da1db5a325fe236e9bc0b34590284a2","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Story: 2007025"},{"line_number":16,"context_line":"Task: 37819"},{"line_number":17,"context_line":"Depends-On: https://review.opendev.org/#/c/692614/"},{"line_number":18,"context_line":"Change-Id: Iaa2a52c2e53534cbf6998ad24f1f1184c0f222d8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"3fa7e38b_0d32240f","line":17,"updated":"2020-02-10 12:03:31.000000000","message":"nit: doesn\u0027t work for IPA","commit_id":"cdf7d0bae98244391a4194b8fcd385f40e159950"}],"ironic/conductor/utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6304511c2da1db5a325fe236e9bc0b34590284a2","unresolved":false,"context_lines":[{"line_number":1010,"context_line":"                                skip_current_step\u003dskip_current_step)"},{"line_number":1011,"context_line":""},{"line_number":1012,"context_line":""},{"line_number":1013,"context_line":"def add_secret_token(node, pregenerate\u003dFalse):"},{"line_number":1014,"context_line":"    \"\"\"Adds a secret token to driver_internal_info for IPA verification.\"\"\""},{"line_number":1015,"context_line":"    characters \u003d string.ascii_letters + string.digits"},{"line_number":1016,"context_line":"    token \u003d \u0027\u0027.join(random.choice(characters) for i in range(128))"}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_cd1f2c6f","line":1013,"updated":"2020-02-10 12:03:31.000000000","message":"nit: pregenerated (it\u0027s a flag, not a request)","commit_id":"cdf7d0bae98244391a4194b8fcd385f40e159950"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3ed8351f8145f3d77a3d2b87b4ec8a6bc88dce93","unresolved":false,"context_lines":[{"line_number":1010,"context_line":"                                skip_current_step\u003dskip_current_step)"},{"line_number":1011,"context_line":""},{"line_number":1012,"context_line":""},{"line_number":1013,"context_line":"def add_secret_token(node, pregenerate\u003dFalse):"},{"line_number":1014,"context_line":"    \"\"\"Adds a secret token to driver_internal_info for IPA verification.\"\"\""},{"line_number":1015,"context_line":"    characters \u003d string.ascii_letters + string.digits"},{"line_number":1016,"context_line":"    token \u003d \u0027\u0027.join(random.choice(characters) for i in range(128))"}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_27361051","line":1013,"in_reply_to":"3fa7e38b_cd1f2c6f","updated":"2020-02-10 21:38:02.000000000","message":"Done","commit_id":"cdf7d0bae98244391a4194b8fcd385f40e159950"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"92dada299bd6fd009a87487ecc7c9b3981ecc5b6","unresolved":false,"context_lines":[{"line_number":1010,"context_line":"                                skip_current_step\u003dskip_current_step)"},{"line_number":1011,"context_line":""},{"line_number":1012,"context_line":""},{"line_number":1013,"context_line":"def add_secret_token(node, pregenerated\u003dFalse):"},{"line_number":1014,"context_line":"    \"\"\"Adds a secret token to driver_internal_info for IPA verification.\"\"\""},{"line_number":1015,"context_line":"    characters \u003d string.ascii_letters + string.digits"},{"line_number":1016,"context_line":"    token \u003d \u0027\u0027.join(random.choice(characters) for i in range(128))"}],"source_content_type":"text/x-python","patch_set":21,"id":"3fa7e38b_fdf9f6c5","line":1013,"updated":"2020-02-18 12:38:34.000000000","message":"nit: a docstring can be useful now","commit_id":"4abbec33232eb34c2ab41c77d7412ddb371730fd"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e4fd2d291c6df61e771c2d7caf48f25eb968ac4d","unresolved":false,"context_lines":[{"line_number":1010,"context_line":"                                skip_current_step\u003dskip_current_step)"},{"line_number":1011,"context_line":""},{"line_number":1012,"context_line":""},{"line_number":1013,"context_line":"def add_secret_token(node, pregenerated\u003dFalse):"},{"line_number":1014,"context_line":"    \"\"\"Adds a secret token to driver_internal_info for IPA verification.\"\"\""},{"line_number":1015,"context_line":"    characters \u003d string.ascii_letters + string.digits"},{"line_number":1016,"context_line":"    token \u003d \u0027\u0027.join(random.choice(characters) for i in range(128))"}],"source_content_type":"text/x-python","patch_set":21,"id":"3fa7e38b_fc700d12","line":1013,"in_reply_to":"3fa7e38b_fdf9f6c5","updated":"2020-02-21 14:01:05.000000000","message":"Done","commit_id":"4abbec33232eb34c2ab41c77d7412ddb371730fd"}],"ironic/drivers/modules/ilo/boot.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6304511c2da1db5a325fe236e9bc0b34590284a2","unresolved":false,"context_lines":[{"line_number":493,"context_line":"        # during boot."},{"line_number":494,"context_line":"        ilo_common.eject_vmedia_devices(task)"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"        # NOTE(TheJulia): Since we\u0027re deploying, cleaning, or rescuing,"},{"line_number":497,"context_line":"        # with virtual media boot, we should generate a token!"},{"line_number":498,"context_line":"        manager_utils.add_secret_token(task.node, pregenerate\u003dTrue)"},{"line_number":499,"context_line":"        ramdisk_params[\u0027agent_token\u0027] \u003d \\"},{"line_number":500,"context_line":"            task.node.driver_internal_info[\u0027agent_secret_token\u0027]"},{"line_number":501,"context_line":"        task.node.save()"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"        deploy_nic_mac \u003d deploy_utils.get_single_nic_with_vif_port_id(task)"},{"line_number":504,"context_line":"        ramdisk_params[\u0027BOOTIF\u0027] \u003d deploy_nic_mac"}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_4d157c4b","line":501,"range":{"start_line":496,"start_character":0,"end_line":501,"end_character":24},"updated":"2020-02-10 12:03:31.000000000","message":"nit: make this snippet a helper function?","commit_id":"cdf7d0bae98244391a4194b8fcd385f40e159950"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3ed8351f8145f3d77a3d2b87b4ec8a6bc88dce93","unresolved":false,"context_lines":[{"line_number":493,"context_line":"        # during boot."},{"line_number":494,"context_line":"        ilo_common.eject_vmedia_devices(task)"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"        # NOTE(TheJulia): Since we\u0027re deploying, cleaning, or rescuing,"},{"line_number":497,"context_line":"        # with virtual media boot, we should generate a token!"},{"line_number":498,"context_line":"        manager_utils.add_secret_token(task.node, pregenerate\u003dTrue)"},{"line_number":499,"context_line":"        ramdisk_params[\u0027agent_token\u0027] \u003d \\"},{"line_number":500,"context_line":"            task.node.driver_internal_info[\u0027agent_secret_token\u0027]"},{"line_number":501,"context_line":"        task.node.save()"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"        deploy_nic_mac \u003d deploy_utils.get_single_nic_with_vif_port_id(task)"},{"line_number":504,"context_line":"        ramdisk_params[\u0027BOOTIF\u0027] \u003d deploy_nic_mac"}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_07f43487","line":501,"range":{"start_line":496,"start_character":0,"end_line":501,"end_character":24},"in_reply_to":"3fa7e38b_4d157c4b","updated":"2020-02-10 21:38:02.000000000","message":"There is a slight difference between two of the drivers due to behavior, so I\u0027m kind of hesitant, at least until ilo/irmc folks have taken a look :\\","commit_id":"cdf7d0bae98244391a4194b8fcd385f40e159950"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"92dada299bd6fd009a87487ecc7c9b3981ecc5b6","unresolved":false,"context_lines":[{"line_number":496,"context_line":"        # NOTE(TheJulia): Since we\u0027re deploying, cleaning, or rescuing,"},{"line_number":497,"context_line":"        # with virtual media boot, we should generate a token!"},{"line_number":498,"context_line":"        manager_utils.add_secret_token(task.node, pregenerated\u003dTrue)"},{"line_number":499,"context_line":"        ramdisk_params[\u0027agent_token\u0027] \u003d \\"},{"line_number":500,"context_line":"            task.node.driver_internal_info[\u0027agent_secret_token\u0027]"},{"line_number":501,"context_line":"        task.node.save()"},{"line_number":502,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"3fa7e38b_1df732d4","line":499,"updated":"2020-02-18 12:38:34.000000000","message":"This will be passed through kernel command line, no? meaning that it must be ipa-agent-token and must be supported by IPA explicitly (it\u0027s not right now).","commit_id":"4abbec33232eb34c2ab41c77d7412ddb371730fd"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e4fd2d291c6df61e771c2d7caf48f25eb968ac4d","unresolved":false,"context_lines":[{"line_number":496,"context_line":"        # NOTE(TheJulia): Since we\u0027re deploying, cleaning, or rescuing,"},{"line_number":497,"context_line":"        # with virtual media boot, we should generate a token!"},{"line_number":498,"context_line":"        manager_utils.add_secret_token(task.node, pregenerated\u003dTrue)"},{"line_number":499,"context_line":"        ramdisk_params[\u0027agent_token\u0027] \u003d \\"},{"line_number":500,"context_line":"            task.node.driver_internal_info[\u0027agent_secret_token\u0027]"},{"line_number":501,"context_line":"        task.node.save()"},{"line_number":502,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"3fa7e38b_3c8a25bd","line":499,"in_reply_to":"3fa7e38b_1df732d4","updated":"2020-02-21 14:01:05.000000000","message":"Great catch, thanks!","commit_id":"4abbec33232eb34c2ab41c77d7412ddb371730fd"}]}