)]}'
{"ironic/drivers/modules/agent.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4a4bff3713e3bcc0f9ddc4bf53df627962f723bd","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"class AgentDeployMixin(agent_base_vendor.AgentDeployMixin):"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    @METRICS.timer(\u0027AgentDeployMixin.has_decomposed_deploy_steps\u0027)"},{"line_number":173,"context_line":"    def has_decomposed_deploy_steps(self):"},{"line_number":174,"context_line":"        \"\"\"Return whether the driver supports decomposed deploy steps."},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_ac726e17","line":172,"updated":"2020-01-14 13:16:39.000000000","message":"nit: no need for metrics","commit_id":"eff0fa079140744f3e31c0029311610ef921d615"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4a4bff3713e3bcc0f9ddc4bf53df627962f723bd","unresolved":false,"context_lines":[{"line_number":170,"context_line":"class AgentDeployMixin(agent_base_vendor.AgentDeployMixin):"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    @METRICS.timer(\u0027AgentDeployMixin.has_decomposed_deploy_steps\u0027)"},{"line_number":173,"context_line":"    def has_decomposed_deploy_steps(self):"},{"line_number":174,"context_line":"        \"\"\"Return whether the driver supports decomposed deploy steps."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        Previously (since Rocky), drivers used a single \u0027deploy\u0027 deploy step on"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_cc77aa07","line":173,"updated":"2020-01-14 13:16:39.000000000","message":"nit: this could be just a class-level variable","commit_id":"eff0fa079140744f3e31c0029311610ef921d615"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4a4bff3713e3bcc0f9ddc4bf53df627962f723bd","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    # FIXME(mgoddard): backwards compatibility."},{"line_number":194,"context_line":"    # TODO(mgoddard): Can we do this as an in-band deploy step, and poll using"},{"line_number":195,"context_line":"    # the normal method?"},{"line_number":196,"context_line":"    @METRICS.timer(\u0027AgentDeployMixin.deploy_is_done\u0027)"},{"line_number":197,"context_line":"    @base.deploy_step(priority\u003d89)"},{"line_number":198,"context_line":"    def deploy_is_done(self, task):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_6c7c76ea","line":195,"updated":"2020-01-14 13:16:39.000000000","message":"I think that\u0027s the final plan, right?","commit_id":"eff0fa079140744f3e31c0029311610ef921d615"}],"ironic/drivers/modules/agent_base.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"260c710eddec404e1c16bc9037e4fa4da2b3268a","unresolved":false,"context_lines":[{"line_number":471,"context_line":"                        \u0027maintenance mode; not taking any action.\u0027,"},{"line_number":472,"context_line":"                        {\u0027node\u0027: node.uuid})"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"    @METRICS.timer(\u0027HeartbeatMixin.heartbeat\u0027)"},{"line_number":475,"context_line":"    def heartbeat(self, task, callback_url, agent_version):"},{"line_number":476,"context_line":"        \"\"\"Process a heartbeat."},{"line_number":477,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"df33271e_40df1a68","line":474,"updated":"2020-04-01 18:40:35.000000000","message":"C901 \u0027HeartbeatMixin.heartbeat\u0027 is too complex (21)","commit_id":"aaaa237244e46bf0f929322467e53c2222673904"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"260c710eddec404e1c16bc9037e4fa4da2b3268a","unresolved":false,"context_lines":[{"line_number":529,"context_line":"            # may cause the agent to boot, but we should not trigger deployment"},{"line_number":530,"context_line":"            # at that point if the driver is polling for completion of a step."},{"line_number":531,"context_line":"            if node.provision_state \u003d\u003d states.DEPLOYWAIT:"},{"line_number":532,"context_line":"                if (not self.has_decomposed_deploy_steps() and"},{"line_number":533,"context_line":"                        self.in_core_deploy_step(task)):"},{"line_number":534,"context_line":"                    # NOTE(mgoddard): support backwards compatibility for"},{"line_number":535,"context_line":"                    # drivers which do not implement continue_deploy and"}],"source_content_type":"text/x-python","patch_set":18,"id":"df33271e_20dad676","line":532,"updated":"2020-04-01 18:40:35.000000000","message":"W504 line break after binary operator","commit_id":"aaaa237244e46bf0f929322467e53c2222673904"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d23f9982b95bdc8af3b56dfdb95bdd675f06d8b5","unresolved":false,"context_lines":[{"line_number":471,"context_line":"                        \u0027maintenance mode; not taking any action.\u0027,"},{"line_number":472,"context_line":"                        {\u0027node\u0027: node.uuid})"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"    @METRICS.timer(\u0027HeartbeatMixin.heartbeat\u0027)"},{"line_number":475,"context_line":"    def heartbeat(self, task, callback_url, agent_version):"},{"line_number":476,"context_line":"        \"\"\"Process a heartbeat."},{"line_number":477,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"df33271e_f6452645","line":474,"updated":"2020-04-03 16:41:48.000000000","message":"pep8: C901 \u0027HeartbeatMixin.heartbeat\u0027 is too complex (21)","commit_id":"5f57b818c4a5ed9244bfa6158e5766ca95aaca0a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d23f9982b95bdc8af3b56dfdb95bdd675f06d8b5","unresolved":false,"context_lines":[{"line_number":529,"context_line":"            # may cause the agent to boot, but we should not trigger deployment"},{"line_number":530,"context_line":"            # at that point if the driver is polling for completion of a step."},{"line_number":531,"context_line":"            if node.provision_state \u003d\u003d states.DEPLOYWAIT:"},{"line_number":532,"context_line":"                if (not self.has_decomposed_deploy_steps() and"},{"line_number":533,"context_line":"                        self.in_core_deploy_step(task)):"},{"line_number":534,"context_line":"                    # NOTE(mgoddard): support backwards compatibility for"},{"line_number":535,"context_line":"                    # drivers which do not implement continue_deploy and"}],"source_content_type":"text/x-python","patch_set":19,"id":"df33271e_5674d29c","line":532,"updated":"2020-04-03 16:41:48.000000000","message":"pep8: W504 line break after binary operator","commit_id":"5f57b818c4a5ed9244bfa6158e5766ca95aaca0a"}],"ironic/drivers/modules/agent_base_vendor.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4a4bff3713e3bcc0f9ddc4bf53df627962f723bd","unresolved":false,"context_lines":[{"line_number":393,"context_line":"            # may cause the agent to boot, but we should not trigger deployment"},{"line_number":394,"context_line":"            # at that point if the driver is polling for completion of a step."},{"line_number":395,"context_line":"            if node.provision_state \u003d\u003d states.DEPLOYWAIT:"},{"line_number":396,"context_line":"                if (not self.has_decomposed_deploy_steps() and"},{"line_number":397,"context_line":"                        self.in_core_deploy_step(task)):"},{"line_number":398,"context_line":"                    # NOTE(mgoddard): support backwards compatibility for"},{"line_number":399,"context_line":"                    # drivers which do not implement continue_deploy and"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_0c1862cb","line":396,"updated":"2020-01-14 13:16:39.000000000","message":"we need a deprecation warning for has_decomposed_deploy_steps \u003d\u003d False","commit_id":"eff0fa079140744f3e31c0029311610ef921d615"}],"ironic/drivers/modules/iscsi_deploy.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4a4bff3713e3bcc0f9ddc4bf53df627962f723bd","unresolved":false,"context_lines":[{"line_number":334,"context_line":"class AgentDeployMixin(agent_base_vendor.AgentDeployMixin):"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"    @METRICS.timer(\u0027AgentDeployMixin.has_decomposed_deploy_steps\u0027)"},{"line_number":337,"context_line":"    def has_decomposed_deploy_steps(self):"},{"line_number":338,"context_line":"        \"\"\"Return whether the driver supports decomposed deploy steps."},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"        Previously (since Rocky), drivers used a single \u0027deploy\u0027 deploy step on"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_ec1aa6c5","line":337,"updated":"2020-01-14 13:16:39.000000000","message":"Not needed, the parent has it","commit_id":"eff0fa079140744f3e31c0029311610ef921d615"}]}