)]}'
{"ironic/drivers/modules/iscsi_deploy.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ad7a1620bbfc032ac32ce6b9096bca4b86f546c0","unresolved":false,"context_lines":[{"line_number":327,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":328,"context_line":"            _(\u0027Failed to validate the root device hints for node \u0027"},{"line_number":329,"context_line":"              \u0027%(node)s. Error: %(error)s\u0027) % {\u0027node\u0027: task.node.uuid,"},{"line_number":330,"context_line":"                                               \u0027error\u0027: e})"},{"line_number":331,"context_line":"    deploy_utils.parse_instance_info(task.node)"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_245420c6","line":330,"updated":"2020-01-16 21:01:13.000000000","message":"hmm. I guess people will have to know where the value comes from.","commit_id":"42dc9787e52670bb1e1baa36f08703dd802804f4"}],"ironic/tests/unit/drivers/modules/test_iscsi_deploy.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ad7a1620bbfc032ac32ce6b9096bca4b86f546c0","unresolved":false,"context_lines":[{"line_number":579,"context_line":"        mock_get_url.return_value \u003d \u0027http://spam.ham/baremetal\u0027"},{"line_number":580,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":581,"context_line":"                                  shared\u003dTrue) as task:"},{"line_number":582,"context_line":"            task.node.instance_info[\u0027root_device\u0027] \u003d {\u0027size\u0027: \u0027not-int\u0027}"},{"line_number":583,"context_line":"            self.assertRaises(exception.InvalidParameterValue,"},{"line_number":584,"context_line":"                              iscsi_deploy.validate, task)"},{"line_number":585,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_c4f74cd1","line":582,"updated":"2020-01-16 21:01:13.000000000","message":"I don\u0027t see an explicit test for deploy_utils.get_root_device_for_deploy(). Maybe just add task.node.properties[\u0027root_device\u0027] \u003d something-valid here?","commit_id":"42dc9787e52670bb1e1baa36f08703dd802804f4"}],"releasenotes/notes/instance-info-root-device-0a5190240fcc8fd8.yaml":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ad7a1620bbfc032ac32ce6b9096bca4b86f546c0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Allows reading the ``root_device`` from ``instance_info``, overriding"},{"line_number":5,"context_line":"    the value in ``properties``. This enables per-instance root device"},{"line_number":6,"context_line":"    settings and requires the Ussuri release of ironic-python-agent."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_440cbcea","line":4,"updated":"2020-01-16 21:01:13.000000000","message":"might want to mention \u0027node\u0027 somewhere, just to make it easier to understand what is going on :)","commit_id":"42dc9787e52670bb1e1baa36f08703dd802804f4"}]}