)]}'
{"ironic/drivers/modules/agent_base_vendor.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3d91a50d257f40eb0ead46e4691a2d6f50270185","unresolved":false,"context_lines":[{"line_number":855,"context_line":"                      \u0027partition %(part)s, EFI system partition %(efi)s\u0027,"},{"line_number":856,"context_line":"                      {\u0027node\u0027: node.uuid, \u0027part\u0027: root_uuid,"},{"line_number":857,"context_line":"                       \u0027efi\u0027: efi_system_part_uuid})"},{"line_number":858,"context_line":"            result \u003d self._client.install_bootloader("},{"line_number":859,"context_line":"                node, root_uuid\u003droot_uuid,"},{"line_number":860,"context_line":"                efi_system_part_uuid\u003defi_system_part_uuid,"},{"line_number":861,"context_line":"                prep_boot_part_uuid\u003dprep_boot_part_uuid)"},{"line_number":862,"context_line":"            if result[\u0027command_status\u0027] \u003d\u003d \u0027FAILED\u0027:"},{"line_number":863,"context_line":"                msg \u003d (_(\"Failed to install a bootloader when \""},{"line_number":864,"context_line":"                         \"deploying node %(node)s. Error: %(error)s\") %"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_b1ed8c25","line":861,"range":{"start_line":858,"start_character":0,"end_line":861,"end_character":56},"updated":"2020-01-20 17:56:14.000000000","message":"So however metalsmith is setting things up with its image and contents, something is going sideways. Specifcially:\n\nhttps://faf3e0ee72596f29a0fc-0fec5ce1527809b443817b617c225254.ssl.cf1.rackcdn.com/702293/3/check/metalsmith-integration-glance-localboot-centos7/a4e6107/controller/logs/screen-ir-cond.txt.gz\n\nJan 14 01:54:45.563119 ubuntu-bionic-rax-iad-0013824590 ironic-conductor[26114]: ERROR ironic.drivers.modu\nles.agent_base_vendor [None req-b2f4ef07-e169-49ac-94ac-d91f083cb6e3 None None] Asynchronous exception: No\nde failed to deploy. Exception: Failed to install a bootloader when deploying node f6f5e4ab-c3a6-4058-95c3\n-772fb12eec97. Error: {\u0027type\u0027: \u0027DeviceNotFound\u0027, \u0027code\u0027: 404, \u0027message\u0027: \u0027Error finding the disk or partit\nion device to deploy the image onto\u0027, \u0027details\u0027: \u0027No partition with UUID None found on device /dev/vda\u0027} f\nor node f6f5e4ab-c3a6-4058-95c3-772fb12eec97: ironic.common.exception.InstanceDeployFailure: Failed to ins\ntall a bootloader when deploying node f6f5e4ab-c3a6-4058-95c3-772fb12eec97. Error: {\u0027type\u0027: \u0027DeviceNotFoun\nd\u0027, \u0027code\u0027: 404, \u0027message\u0027: \u0027Error finding the disk or partition device to deploy the image onto\u0027, \u0027detail\ns\u0027: \u0027No partition with UUID None found on device /dev/vda\u0027}\nJan 14 01:54:45.563119 ubuntu-bionic-rax-iad-0013824590 ironic-conductor[26114]: ERROR ironic.drivers.modu\nles.agent_base_vendor Traceback (most recent call last):\nJan 14 01:54:45.563119 ubuntu-bionic-rax-iad-0013824590 ironic-conductor[26114]: ERROR ironic.drivers.modu\nles.agent_base_vendor   File \"/opt/stack/ironic/ironic/drivers/modules/agent_base_vendor.py\", line 389, in\n heartbeat\nJan 14 01:54:45.563119 ubuntu-bionic-rax-iad-0013824590 ironic-conductor[26114]: ERROR ironic.drivers.modu\nles.agent_base_vendor     self.continue_deploy(task)\nJan 14 01:54:45.563119 ubuntu-bionic-rax-iad-0013824590 ironic-conductor[26114]: ERROR ironic.drivers.modu\nles.agent_base_vendor   File \"/usr/local/lib/python3.6/dist-packages/ironic_lib/metrics.py\", line 59, in w\nrapped\nJan 14 01:54:45.563119 ubuntu-bionic-rax-iad-0013824590 ironic-conductor[26114]: ERROR ironic.drivers.modu\nles.agent_base_vendor     result \u003d f(*args, **kwargs)\nJan 14 01:54:45.563119 ubuntu-bionic-rax-iad-0013824590 ironic-conductor[26114]: ERROR ironic.drivers.modu\nles.agent_base_vendor   File \"/opt/stack/ironic/ironic/conductor/task_manager.py\", line 148, in wrapper\nJan 14 01:54:45.563119 ubuntu-bionic-rax-iad-0013824590 ironic-conductor[26114]: ERROR ironic.drivers.modu\nles.agent_base_vendor     return f(*args, **kwargs)\nJan 14 01:54:45.563119 ubuntu-bionic-rax-iad-0013824590 ironic-conductor[26114]: ERROR ironic.drivers.modules.agent_base_vendor   File \"/opt/stack/ironic/ironic/drivers/modules/iscsi_deploy.py\", line 361, in continue_deploy\nJan 14 01:54:45.563119 ubuntu-bionic-rax-iad-0013824590 ironic-conductor[26114]: ERROR ironic.drivers.modules.agent_base_vendor     prep_boot_part_uuid\u003dprep_boot_part_uuid)\nJan 14 01:54:45.563119 ubuntu-bionic-rax-iad-0013824590 ironic-conductor[26114]: ERROR ironic.drivers.modules.agent_base_vendor   File \"/usr/local/lib/python3.6/dist-packages/ironic_lib/metrics.py\", line 59, in wrapped\nJan 14 01:54:45.563119 ubuntu-bionic-rax-iad-0013824590 ironic-conductor[26114]: ERROR ironic.drivers.modules.agent_base_vendor     result \u003d f(*args, **kwargs)\nJan 14 01:54:45.563119 ubuntu-bionic-rax-iad-0013824590 ironic-conductor[26114]: ERROR ironic.drivers.modules.agent_base_vendor   File \"/opt/stack/ironic/ironic/drivers/modules/agent_base_vendor.py\", line 778, in prepare_instance_to_boot\nJan 14 01:54:45.563119 ubuntu-bionic-rax-iad-0013824590 ironic-conductor[26114]: ERROR ironic.drivers.modules.agent_base_vendor     prep_boot_part_uuid\u003dprep_boot_part_uuid)\nJan 14 01:54:45.563119 ubuntu-bionic-rax-iad-0013824590 ironic-conductor[26114]: ERROR ironic.drivers.modules.agent_base_vendor   File \"/usr/local/lib/python3.6/dist-packages/ironic_lib/metrics.py\", line 59, in wrapped\nJan 14 01:54:45.563119 ubuntu-bionic-rax-iad-0013824590 ironic-conductor[26114]: ERROR ironic.drivers.modules.agent_base_vendor     result \u003d f(*args, **kwargs)\nJan 14 01:54:45.563119 ubuntu-bionic-rax-iad-0013824590 ironic-conductor[26114]: ERROR ironic.drivers.modules.agent_base_vendor   File \"/opt/stack/ironic/ironic/drivers/modules/agent_base_vendor.py\", line 867, in configure_local_boot\nJan 14 01:54:45.563119 ubuntu-bionic-rax-iad-0013824590 ironic-conductor[26114]: ERROR ironic.drivers.modules.agent_base_vendor     log_and_raise_deployment_error(task, msg)\nJan 14 01:54:45.563119 ubuntu-bionic-rax-iad-0013824590 ironic-conductor[26114]: ERROR ironic.drivers.modules.agent_base_vendor   File \"/usr/local/lib/python3.6/dist-packages/ironic_lib/metrics.py\", line 59, in wrapped\nJan 14 01:54:45.563119 ubuntu-bionic-rax-iad-0013824590 ironic-conductor[26114]: ERROR ironic.drivers.modules.agent_base_vendor     result \u003d f(*args, **kwargs)\nJan 14 01:54:45.563119 ubuntu-bionic-rax-iad-0013824590 ironic-conductor[26114]: ERROR ironic.drivers.modules.agent_base_vendor   File \"/opt/stack/ironic/ironic/drivers/modules/agent_base_vendor.py\", line 227, in log_and_raise_deployment_error\nJan 14 01:54:45.563119 ubuntu-bionic-rax-iad-0013824590 ironic-conductor[26114]: ERROR ironic.drivers.modules.agent_base_vendor     raise exception.InstanceDeployFailure(msg)\nJan 14 01:54:45.563119 ubuntu-bionic-rax-iad-0013824590 ironic-conductor[26114]: ERROR ironic.drivers.modules.agent_base_vendor ironic.common.exception.InstanceDeployFailure: Failed to install a bootloader when deploying node f6f5e4ab-c3a6-4058-95c3-772fb12eec97. Error: {\u0027type\u0027: \u0027DeviceNotFound\u0027, \u0027code\u0027: 404, \u0027message\u0027: \u0027Error finding the disk or partition device to deploy the image onto\u0027, \u0027details\u0027: \u0027No partition with UUID None found on device /dev/vda\u0027}","commit_id":"780063a3d18080b86bd360898acced808c708f59"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"13396c0db19530d3eb75a6f78b82a5d83a55426f","unresolved":false,"context_lines":[{"line_number":855,"context_line":"                      \u0027partition %(part)s, EFI system partition %(efi)s\u0027,"},{"line_number":856,"context_line":"                      {\u0027node\u0027: node.uuid, \u0027part\u0027: root_uuid,"},{"line_number":857,"context_line":"                       \u0027efi\u0027: efi_system_part_uuid})"},{"line_number":858,"context_line":"            result \u003d self._client.install_bootloader("},{"line_number":859,"context_line":"                node, root_uuid\u003droot_uuid,"},{"line_number":860,"context_line":"                efi_system_part_uuid\u003defi_system_part_uuid,"},{"line_number":861,"context_line":"                prep_boot_part_uuid\u003dprep_boot_part_uuid)"},{"line_number":862,"context_line":"            if result[\u0027command_status\u0027] \u003d\u003d \u0027FAILED\u0027:"},{"line_number":863,"context_line":"                msg \u003d (_(\"Failed to install a bootloader when \""},{"line_number":864,"context_line":"                         \"deploying node %(node)s. Error: %(error)s\") %"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_38d098f4","line":861,"range":{"start_line":858,"start_character":0,"end_line":861,"end_character":56},"in_reply_to":"3fa7e38b_1d4a6eac","updated":"2020-01-20 22:43:26.000000000","message":"That kind of feels like maybe something we should do in IPA... Maybe?\n\nIf we don,t and do or (whole_disk_image and uefi_boot_mode), then I guess that could work as well because then the boot mode logic would apply. I guess either works actually.","commit_id":"780063a3d18080b86bd360898acced808c708f59"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"e752d8b6b9b2390174d30151cf88f470cdd927fc","unresolved":false,"context_lines":[{"line_number":855,"context_line":"                      \u0027partition %(part)s, EFI system partition %(efi)s\u0027,"},{"line_number":856,"context_line":"                      {\u0027node\u0027: node.uuid, \u0027part\u0027: root_uuid,"},{"line_number":857,"context_line":"                       \u0027efi\u0027: efi_system_part_uuid})"},{"line_number":858,"context_line":"            result \u003d self._client.install_bootloader("},{"line_number":859,"context_line":"                node, root_uuid\u003droot_uuid,"},{"line_number":860,"context_line":"                efi_system_part_uuid\u003defi_system_part_uuid,"},{"line_number":861,"context_line":"                prep_boot_part_uuid\u003dprep_boot_part_uuid)"},{"line_number":862,"context_line":"            if result[\u0027command_status\u0027] \u003d\u003d \u0027FAILED\u0027:"},{"line_number":863,"context_line":"                msg \u003d (_(\"Failed to install a bootloader when \""},{"line_number":864,"context_line":"                         \"deploying node %(node)s. Error: %(error)s\") %"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_93564d5e","line":861,"range":{"start_line":858,"start_character":0,"end_line":861,"end_character":56},"in_reply_to":"3fa7e38b_38d098f4","updated":"2020-01-21 01:07:41.000000000","message":"I added the check here, it seems like it should in the logic that calls install_bootloader.","commit_id":"780063a3d18080b86bd360898acced808c708f59"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"5cf76db78e8f032a521d3f224c7e467df6e4dc4e","unresolved":false,"context_lines":[{"line_number":855,"context_line":"                      \u0027partition %(part)s, EFI system partition %(efi)s\u0027,"},{"line_number":856,"context_line":"                      {\u0027node\u0027: node.uuid, \u0027part\u0027: root_uuid,"},{"line_number":857,"context_line":"                       \u0027efi\u0027: efi_system_part_uuid})"},{"line_number":858,"context_line":"            result \u003d self._client.install_bootloader("},{"line_number":859,"context_line":"                node, root_uuid\u003droot_uuid,"},{"line_number":860,"context_line":"                efi_system_part_uuid\u003defi_system_part_uuid,"},{"line_number":861,"context_line":"                prep_boot_part_uuid\u003dprep_boot_part_uuid)"},{"line_number":862,"context_line":"            if result[\u0027command_status\u0027] \u003d\u003d \u0027FAILED\u0027:"},{"line_number":863,"context_line":"                msg \u003d (_(\"Failed to install a bootloader when \""},{"line_number":864,"context_line":"                         \"deploying node %(node)s. Error: %(error)s\") %"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_1d4a6eac","line":861,"range":{"start_line":858,"start_character":0,"end_line":861,"end_character":56},"in_reply_to":"3fa7e38b_b1ed8c25","updated":"2020-01-20 21:38:04.000000000","message":"So in this case BIOS mode is being used, so _install_grub() is called in IPA here - https://github.com/openstack/ironic-python-agent/blob/master/ironic_python_agent/extensions/image.\u003e (1 comment)\npy#L533, and it looks like root UUID is not defined so we get:\n2020-01-20 15:31:48.873 521 ERROR root   File \"/usr/local/lib/python3.6/site-packages/ironic_python_agent/extensions/image.py\", line 122, in _get_partition\n2020-01-20 15:31:48.873 521 ERROR root ironic_python_agent.errors.DeviceNotFound: Error finding the disk or partition device to deploy the image onto: No partition with UUID None found on device /dev/vda\n\nMay need to modify this change to check for uefi boot mode as that\u0027s the only time we\u0027ll find the bootloaders on the disk.","commit_id":"780063a3d18080b86bd360898acced808c708f59"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e23e4dc98f5d2c229ac9abc952dc56a88ec510d0","unresolved":false,"context_lines":[{"line_number":875,"context_line":"                    LOG.info(\u0027Could not install bootloader for whole disk \u0027"},{"line_number":876,"context_line":"                             \u0027image for node %(node)s, Error: %(error)s\"\u0027,"},{"line_number":877,"context_line":"                             {\u0027node\u0027: node.uuid,"},{"line_number":878,"context_line":"                              \u0027error\u0027: result[\u0027command_error\u0027]})"},{"line_number":879,"context_line":"                    return"},{"line_number":880,"context_line":""},{"line_number":881,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_d423fa55","line":878,"updated":"2020-01-27 14:58:24.000000000","message":"Seems reasonable, thanks!","commit_id":"d614d86eef0db7fd9784f4d81a3369841c5a9eb3"}]}