)]}'
{"ironic/tests/db/utils.py":[{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"b42a5bdbb2aecbbd9b96bb2f38e429a5d65f2afe","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        dict(json.loads(pxe_info), **json.loads(ssh_info)))"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"pxe_ipmi_info \u003d json.dumps("},{"line_number":55,"context_line":"        dict(json.loads(pxe_info), **json.loads(ipmi_info)))"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"properties \u003d {"},{"line_number":58,"context_line":"            \"cpu_arch\": \"x86_64\","}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F98m0%3D","side":"PARENT","line":55,"updated":"2014-01-31 19:28:38.000000000","message":"These ones were unused","commit_id":"a2b444d915631ec12791fa79ec85f93349fac4cc"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"c29b8f1f6c18bd64d2be9cf321f3e0fc7a27e2f8","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def get_impi_info():"},{"line_number":50,"context_line":"    return copy.deepcopy(_ipmi_info)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def get_ssh_info():"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F910c%3D","line":50,"updated":"2014-02-03 12:56:45.000000000","message":"I think directly copy not needed here if you place dict into function:\n\ndef get_impi_info():\n    _ipmi_info \u003d { ...\n    return _ipmi_info\n\n \u003e\u003e\u003e def a():\n ...     b \u003d {\u0027foo\u0027: \u0027bar\u0027}\n ...     return b\n ... \n \u003e\u003e\u003e c\u003da()\n \u003e\u003e\u003e d\u003da()\n \u003e\u003e\u003e id(c)\n 139976825245776\n \u003e\u003e\u003e id(d)\n 139976860370992\n \u003e\u003e\u003e","commit_id":"87162d980ccd93cd8b728b86cabb3e0a4729a465"},{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"a653fc17276ef2e87ea2b4f4699fa92cd1dcfc80","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def get_impi_info():"},{"line_number":50,"context_line":"    return copy.deepcopy(_ipmi_info)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def get_ssh_info():"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9whw%3D","line":50,"in_reply_to":"AAAAUH%2F910c%3D","updated":"2014-02-04 09:40:09.000000000","message":"Thant\u0027s true. Thanks","commit_id":"87162d980ccd93cd8b728b86cabb3e0a4729a465"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"c29b8f1f6c18bd64d2be9cf321f3e0fc7a27e2f8","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def get_ssh_info():"},{"line_number":54,"context_line":"    return copy.deepcopy(_ssh_info)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def get_pxe_info():"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F91zc%3D","line":54,"updated":"2014-02-03 12:56:45.000000000","message":"ditto","commit_id":"87162d980ccd93cd8b728b86cabb3e0a4729a465"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"c29b8f1f6c18bd64d2be9cf321f3e0fc7a27e2f8","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def get_pxe_info():"},{"line_number":58,"context_line":"    return copy.deepcopy(_pxe_info)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"properties \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F91zY%3D","line":58,"updated":"2014-02-03 12:56:45.000000000","message":"ditto","commit_id":"87162d980ccd93cd8b728b86cabb3e0a4729a465"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e23d4acd95b5c5196700959b6695e743a6d6811c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from ironic.common import states"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def get_impi_info():"},{"line_number":23,"context_line":"    ipmi_info \u003d {"},{"line_number":24,"context_line":"        \"ipmi_address\": \"1.2.3.4\","},{"line_number":25,"context_line":"        \"ipmi_username\": \"admin\","}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2FyOw%3D","line":22,"updated":"2014-02-10 20:45:05.000000000","message":"Name suggestion: get_test_ipmi_info()\n\nFor the resources we have functions like these called get_test_nodes(), get_test_port(), etc...\n\nSame for the other get_*() functions","commit_id":"22206fd446127e30a1d42c91d030b3129d289481"},{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"e7144892ae68904bfff675695b4bbf2df03d4145","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from ironic.common import states"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def get_impi_info():"},{"line_number":23,"context_line":"    ipmi_info \u003d {"},{"line_number":24,"context_line":"        \"ipmi_address\": \"1.2.3.4\","},{"line_number":25,"context_line":"        \"ipmi_username\": \"admin\","}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2FxBc%3D","line":22,"in_reply_to":"AAAAUX%2F%2FyOw%3D","updated":"2014-02-10 22:55:47.000000000","message":"+1","commit_id":"22206fd446127e30a1d42c91d030b3129d289481"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e23d4acd95b5c5196700959b6695e743a6d6811c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        \"ipmi_username\": \"admin\","},{"line_number":26,"context_line":"        \"ipmi_password\": \"fake\","},{"line_number":27,"context_line":"    }"},{"line_number":28,"context_line":"    return ipmi_info"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def get_ssh_info():"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2FyQQ%3D","line":28,"updated":"2014-02-10 20:45:05.000000000","message":"nit: Just return direct?\n\ndef get_impi_info():\n    return {...}\n\nSame for the other get_*() functions","commit_id":"22206fd446127e30a1d42c91d030b3129d289481"},{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"e7144892ae68904bfff675695b4bbf2df03d4145","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        \"ipmi_username\": \"admin\","},{"line_number":26,"context_line":"        \"ipmi_password\": \"fake\","},{"line_number":27,"context_line":"    }"},{"line_number":28,"context_line":"    return ipmi_info"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def get_ssh_info():"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2FxBU%3D","line":28,"in_reply_to":"AAAAUX%2F%2FyQQ%3D","updated":"2014-02-10 22:55:47.000000000","message":"+1","commit_id":"22206fd446127e30a1d42c91d030b3129d289481"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e23d4acd95b5c5196700959b6695e743a6d6811c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    \"memory\": \"4096\","},{"line_number":59,"context_line":"}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"fake_info \u003d {\"foo\": \"bar\"}"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"def get_test_node(**kw):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2FyME%3D","line":61,"updated":"2014-02-10 20:45:05.000000000","message":"Seems that \"properties\" and \"fake_info\" is only used by the get_test_node() function, I think we should add it to the get_test_node() function scope. Having those being created at import time might be dangerous (can be modified by one function and others holding a reference to it would also be changed)","commit_id":"22206fd446127e30a1d42c91d030b3129d289481"},{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"e7144892ae68904bfff675695b4bbf2df03d4145","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    \"memory\": \"4096\","},{"line_number":59,"context_line":"}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"fake_info \u003d {\"foo\": \"bar\"}"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"def get_test_node(**kw):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2FxA8%3D","line":61,"in_reply_to":"AAAAUX%2F%2FyME%3D","updated":"2014-02-10 22:55:47.000000000","message":"++1 :-P will move inline","commit_id":"22206fd446127e30a1d42c91d030b3129d289481"}]}