)]}'
{"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"afcc496521c34d576a129af6a61e29a96ae1878a","unresolved":false,"context_lines":[{"line_number":298,"context_line":"class IndicatorState(base.APIBase):"},{"line_number":299,"context_line":"    \"\"\"API representation of indicator state.\"\"\""},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    state \u003d ctypes.wsattr(str)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def __init__(self, **kwargs):"},{"line_number":304,"context_line":"        self.state \u003d kwargs.get(\u0027state\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_cd5f550c","line":301,"updated":"2020-04-17 08:33:52.000000000","message":"nit: these changes should be in the parent patch","commit_id":"7e9a56808c18b07773cd25f811b7f14540ad888c"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f75d26699ea51831ddf2d10e7eb9afac43a97852","unresolved":false,"context_lines":[{"line_number":298,"context_line":"class IndicatorState(base.APIBase):"},{"line_number":299,"context_line":"    \"\"\"API representation of indicator state.\"\"\""},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    state \u003d ctypes.wsattr(str)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def __init__(self, **kwargs):"},{"line_number":304,"context_line":"        self.state \u003d kwargs.get(\u0027state\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_a0cd9232","line":301,"in_reply_to":"3f4c43b2_cd5f550c","updated":"2020-04-20 00:35:44.000000000","message":"Done","commit_id":"7e9a56808c18b07773cd25f811b7f14540ad888c"}],"ironic/api/expose.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"afcc496521c34d576a129af6a61e29a96ae1878a","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                    orig_code \u003d getattr(orig_exception, \u0027code\u0027, None)"},{"line_number":100,"context_line":"                    data \u003d format_exception("},{"line_number":101,"context_line":"                        exception_info,"},{"line_number":102,"context_line":"                        pecan.conf.get(\u0027wsme\u0027, {}).get(\u0027debug\u0027, False)"},{"line_number":103,"context_line":"                    )"},{"line_number":104,"context_line":"                finally:"},{"line_number":105,"context_line":"                    del exception_info"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_2d9cf9be","line":102,"updated":"2020-04-17 08:33:52.000000000","message":"I think we have a configuration option for this","commit_id":"7e9a56808c18b07773cd25f811b7f14540ad888c"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f75d26699ea51831ddf2d10e7eb9afac43a97852","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                    orig_code \u003d getattr(orig_exception, \u0027code\u0027, None)"},{"line_number":100,"context_line":"                    data \u003d format_exception("},{"line_number":101,"context_line":"                        exception_info,"},{"line_number":102,"context_line":"                        pecan.conf.get(\u0027wsme\u0027, {}).get(\u0027debug\u0027, False)"},{"line_number":103,"context_line":"                    )"},{"line_number":104,"context_line":"                finally:"},{"line_number":105,"context_line":"                    del exception_info"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_00cf2629","line":102,"in_reply_to":"3f4c43b2_2d9cf9be","updated":"2020-04-20 00:35:44.000000000","message":"ah, debug_tracebacks_in_api","commit_id":"7e9a56808c18b07773cd25f811b7f14540ad888c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"afcc496521c34d576a129af6a61e29a96ae1878a","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    \"\"\"Extract informations that can be sent to the client.\"\"\""},{"line_number":171,"context_line":"    error \u003d excinfo[1]"},{"line_number":172,"context_line":"    code \u003d getattr(error, \u0027code\u0027, None)"},{"line_number":173,"context_line":"    if code and code in http_client.responses and (400 \u003c\u003d code \u003c\u003d 500):"},{"line_number":174,"context_line":"        faultstring \u003d (error.faultstring if hasattr(error, \u0027faultstring\u0027)"},{"line_number":175,"context_line":"                       else str(error))"},{"line_number":176,"context_line":"        faultcode \u003d getattr(error, \u0027faultcode\u0027, \u0027Client\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_0d9f7db4","line":173,"updated":"2020-04-17 08:33:52.000000000","message":"500 must be excluded","commit_id":"7e9a56808c18b07773cd25f811b7f14540ad888c"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f75d26699ea51831ddf2d10e7eb9afac43a97852","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    \"\"\"Extract informations that can be sent to the client.\"\"\""},{"line_number":171,"context_line":"    error \u003d excinfo[1]"},{"line_number":172,"context_line":"    code \u003d getattr(error, \u0027code\u0027, None)"},{"line_number":173,"context_line":"    if code and code in http_client.responses and (400 \u003c\u003d code \u003c\u003d 500):"},{"line_number":174,"context_line":"        faultstring \u003d (error.faultstring if hasattr(error, \u0027faultstring\u0027)"},{"line_number":175,"context_line":"                       else str(error))"},{"line_number":176,"context_line":"        faultcode \u003d getattr(error, \u0027faultcode\u0027, \u0027Client\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4c43b2_e0d31ad4","line":173,"in_reply_to":"3f4c43b2_0d9f7db4","updated":"2020-04-20 00:35:44.000000000","message":"Done","commit_id":"7e9a56808c18b07773cd25f811b7f14540ad888c"},{"author":{"_account_id":27336,"name":"XiaojueGuan","email":"xiaojueguan@gmail.com","username":"XiaojueGuan"},"change_message_id":"f5eafac1456515931ad07512b371096e787ba691","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        if \u0027faultcode\u0027 in namespace:"},{"line_number":44,"context_line":"            return encode_error(None, namespace)"},{"line_number":45,"context_line":"        result \u003d encode_result("},{"line_number":46,"context_line":"            namespace[\u0027result\u0027],"},{"line_number":47,"context_line":"            namespace[\u0027datatype\u0027]"},{"line_number":48,"context_line":"        )"},{"line_number":49,"context_line":"        return result"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_f4feb8ac","line":47,"range":{"start_line":46,"start_character":0,"end_line":47,"end_character":33},"updated":"2020-05-09 09:13:58.000000000","message":"result and datatype will always exists?","commit_id":"a83dfd5b983d5276a53a40713b2186bb8d78f7ec"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"92fcc0c6f22119a5d8b445d064593ac7832a5e74","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        if \u0027faultcode\u0027 in namespace:"},{"line_number":44,"context_line":"            return encode_error(None, namespace)"},{"line_number":45,"context_line":"        result \u003d encode_result("},{"line_number":46,"context_line":"            namespace[\u0027result\u0027],"},{"line_number":47,"context_line":"            namespace[\u0027datatype\u0027]"},{"line_number":48,"context_line":"        )"},{"line_number":49,"context_line":"        return result"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_f0d99df4","line":47,"range":{"start_line":46,"start_character":0,"end_line":47,"end_character":33},"in_reply_to":"ff570b3c_f4feb8ac","updated":"2020-05-10 20:54:54.000000000","message":"According to the original implementation, yes https://opendev.org/x/wsme/src/branch/master/wsmeext/pecan.py#L25","commit_id":"a83dfd5b983d5276a53a40713b2186bb8d78f7ec"}]}