)]}'
{"id":"openstack%2Fironic~705995","triplet_id":"openstack%2Fironic~master~I5f7003efd5108264e54d6e45aabf680bb86a04ea","project":"openstack/ironic","branch":"master","topic":"fix-cd-too-large-ansible","hashtags":[],"change_id":"I5f7003efd5108264e54d6e45aabf680bb86a04ea","subject":"Handle saving too big messages in last_error field","status":"ABANDONED","created":"2020-02-05 15:58:42.000000000","updated":"2020-02-05 16:40:34.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7f33da31db02a8f4f26b43044d17f3b2c1ffb0b7","_number":705995,"virtual_id_number":705995,"owner":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":10288,"name":"Aleksey","email":"alexz.kh.ua@gmail.com","username":"alexz"},{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":10288,"name":"Aleksey","email":"alexz.kh.ua@gmail.com","username":"alexz"},"all":[{"value":1,"date":"2020-02-05 16:26:01.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10288,"name":"Aleksey","email":"alexz.kh.ua@gmail.com","username":"alexz"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"all":[{"_account_id":10288,"name":"Aleksey","email":"alexz.kh.ua@gmail.com","username":"alexz"},{"value":-1,"date":"2020-02-05 16:38:18.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":10288,"name":"Aleksey","email":"alexz.kh.ua@gmail.com","username":"alexz"},{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10288,"name":"Aleksey","email":"alexz.kh.ua@gmail.com","username":"alexz"},{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-02-05 16:26:01.000000000","updated_by":{"_account_id":10288,"name":"Aleksey","email":"alexz.kh.ua@gmail.com","username":"alexz"},"reviewer":{"_account_id":10288,"name":"Aleksey","email":"alexz.kh.ua@gmail.com","username":"alexz"},"state":"REVIEWER"}],"messages":[{"id":"617d4854a77743bac6a6eeeb6dba41667cfbc798","author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"date":"2020-02-05 15:58:42.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7bc4e32dfd14eb6f3ab5e34e6c2bf28460568023","author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"date":"2020-02-05 16:00:45.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"acef93a9ef787bfe13bdfd0126a2cd1aa37a4f3b","author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"date":"2020-02-05 16:01:51.000000000","message":"Patch Set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"350dc271745c92201f6d203ce2a673894f17e5d7","author":{"_account_id":10288,"name":"Aleksey","email":"alexz.kh.ua@gmail.com","username":"alexz"},"date":"2020-02-05 16:26:01.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"b45c3a7e29a9357844d553b20347981f89747aa3","author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"date":"2020-02-05 16:35:15.000000000","message":"Patch Set 3:\n\nI think I\u0027ll fix this same problem for rescue and cleaning. Or is it worth handling it generically, in node.save() method maybe?","accounts_in_message":[],"_revision_number":3},{"id":"b1486a313f5719cb89a60e222a675ae7e6eea614","author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"date":"2020-02-05 16:38:15.000000000","message":"Patch Set 3:\n\nHeh, I see it is fixed in master already https://review.opendev.org/650307, hitting that in stein release","accounts_in_message":[],"_revision_number":3},{"id":"9a0d9a8a9e906b72d15ae0d0369805ddbe3ee204","author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"date":"2020-02-05 16:38:18.000000000","message":"Patch Set 3: Workflow-1","accounts_in_message":[],"_revision_number":3},{"id":"67709e579efa2e6f585678a9cccde558d2833d94","author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"date":"2020-02-05 16:40:34.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"b40716929fd03d5f66cf10e63a1a75c527caaaca","revisions":{"2ad7387746df851accbc9ef53c9521d373bd24ee":{"kind":"REWORK","_number":1,"created":"2020-02-05 15:58:42.000000000","uploader":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"ref":"refs/changes/95/705995/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic","ref":"refs/changes/95/705995/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic refs/changes/95/705995/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic refs/changes/95/705995/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic refs/changes/95/705995/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic refs/changes/95/705995/1"}}},"commit":{"parents":[{"commit":"990c17e3569ed7ffc0f29c178f4cab224e2df085","subject":"Merge \"Support node retirement\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic/commit/990c17e3569ed7ffc0f29c178f4cab224e2df085"}]}],"author":{"name":"Vladyslav Drok","email":"vdrok@mirantis.com","date":"2020-02-03 16:07:01.000000000","tz":60},"committer":{"name":"Vladyslav Drok","email":"vdrok@mirantis.com","date":"2020-02-05 15:58:25.000000000","tz":60},"subject":"Handle saving too big messages in last_error field","message":"Handle saving too big messages in last_error field\n\nIf the deployment using ansible deploy interface fails, the error\nreturned from ansible might be quite substantial. In some cases it\ncan be more than 64KiB, which is the limit of the last_error field\nin the nodes table (for most database backends). As the deployment\nerror is saved into database as-is, there is a possibility of\nfailure to save this info in the database. This change fixes this\nissue by saving \"see the logs\" message into the last_error field.\n\nStory: 2007266\nTask: 38659\n\nChange-Id: I5f7003efd5108264e54d6e45aabf680bb86a04ea\n(cherry picked from commit e18cb0fc124d9a89fa8d5e62d5a5bbe7222e9905)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic/commit/2ad7387746df851accbc9ef53c9521d373bd24ee"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic/commit/2ad7387746df851accbc9ef53c9521d373bd24ee"}]},"branch":"refs/heads/master"},"02df38b91aa911e147098deb5081e376828b20ad":{"kind":"REWORK","_number":2,"created":"2020-02-05 16:00:45.000000000","uploader":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"ref":"refs/changes/95/705995/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic","ref":"refs/changes/95/705995/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic refs/changes/95/705995/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic refs/changes/95/705995/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic refs/changes/95/705995/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic refs/changes/95/705995/2"}}},"commit":{"parents":[{"commit":"990c17e3569ed7ffc0f29c178f4cab224e2df085","subject":"Merge \"Support node retirement\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic/commit/990c17e3569ed7ffc0f29c178f4cab224e2df085"}]}],"author":{"name":"Vladyslav Drok","email":"vdrok@mirantis.com","date":"2020-02-03 16:07:01.000000000","tz":60},"committer":{"name":"Vladyslav Drok","email":"vdrok@mirantis.com","date":"2020-02-05 16:00:33.000000000","tz":60},"subject":"Handle saving too big messages in last_error field","message":"Handle saving too big messages in last_error field\n\nIf the deployment using ansible deploy interface fails, the error\nreturned from ansible might be quite substantial. In some cases it\ncan be more than 64KiB, which is the limit of the last_error field\nin the nodes table (for most database backends). As the deployment\nerror is saved into database as-is, there is a possibility of\nfailure to save this info in the database. This change fixes this\nissue by saving \"see the logs\" message into the last_error field.\n\nStory: 2007266\nTask: 38659\n\nChange-Id: I5f7003efd5108264e54d6e45aabf680bb86a04ea\n(cherry picked from commit e18cb0fc124d9a89fa8d5e62d5a5bbe7222e9905)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic/commit/02df38b91aa911e147098deb5081e376828b20ad"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic/commit/02df38b91aa911e147098deb5081e376828b20ad"}]},"branch":"refs/heads/master"},"b40716929fd03d5f66cf10e63a1a75c527caaaca":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2020-02-05 16:01:51.000000000","uploader":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"ref":"refs/changes/95/705995/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic","ref":"refs/changes/95/705995/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic refs/changes/95/705995/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic refs/changes/95/705995/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic refs/changes/95/705995/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic refs/changes/95/705995/3"}}},"commit":{"parents":[{"commit":"990c17e3569ed7ffc0f29c178f4cab224e2df085","subject":"Merge \"Support node retirement\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic/commit/990c17e3569ed7ffc0f29c178f4cab224e2df085"}]}],"author":{"name":"Vladyslav Drok","email":"vdrok@mirantis.com","date":"2020-02-03 16:07:01.000000000","tz":60},"committer":{"name":"Vladyslav Drok","email":"vdrok@mirantis.com","date":"2020-02-05 16:01:46.000000000","tz":0},"subject":"Handle saving too big messages in last_error field","message":"Handle saving too big messages in last_error field\n\nIf the deployment using ansible deploy interface fails, the error\nreturned from ansible might be quite substantial. In some cases it\ncan be more than 64KiB, which is the limit of the last_error field\nin the nodes table (for most database backends). As the deployment\nerror is saved into database as-is, there is a possibility of\nfailure to save this info in the database. This change fixes this\nissue by saving \"see the logs\" message into the last_error field.\n\nStory: 2007266\nTask: 38659\n\nChange-Id: I5f7003efd5108264e54d6e45aabf680bb86a04ea\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic/commit/b40716929fd03d5f66cf10e63a1a75c527caaaca"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic/commit/b40716929fd03d5f66cf10e63a1a75c527caaaca"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
