)]}'
{"ironic/conf/console.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c13f1bd7c7d9f846da1e7345d932b25a4b18cff6","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                     \u0027ironic conductor. Used only by Socat console.\u0027)),"},{"line_number":56,"context_line":"    cfg.StrOpt(\u0027port_range\u0027,"},{"line_number":57,"context_line":"               regex\u003dr\u0027^\\d+:\\d+$\u0027,"},{"line_number":58,"context_line":"               sample_default\u003d\u002710000:20000\u0027,"},{"line_number":59,"context_line":"               help\u003d_(\u0027A range of ports available to be used for the console \u0027"},{"line_number":60,"context_line":"                      \u0027proxy service running on the host of ironic \u0027"},{"line_number":61,"context_line":"                      \u0027conductor, in the form of \u003cstart\u003e:\u003cstop\u003e. This option \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_0c464923","line":58,"updated":"2020-02-15 03:37:10.000000000","message":"I wonder if we could somehow do a range validation...","commit_id":"b3721ce4ff04bd3fbe89e98e9a494db5cf29edc9"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"ebfc4e3f9c3f988c3cfbb993e5594ce182d47b3d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                     \u0027ironic conductor. Used only by Socat console.\u0027)),"},{"line_number":56,"context_line":"    cfg.StrOpt(\u0027port_range\u0027,"},{"line_number":57,"context_line":"               regex\u003dr\u0027^\\d+:\\d+$\u0027,"},{"line_number":58,"context_line":"               sample_default\u003d\u002710000:20000\u0027,"},{"line_number":59,"context_line":"               help\u003d_(\u0027A range of ports available to be used for the console \u0027"},{"line_number":60,"context_line":"                      \u0027proxy service running on the host of ironic \u0027"},{"line_number":61,"context_line":"                      \u0027conductor, in the form of \u003cstart\u003e:\u003cstop\u003e. This option \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_c72c8a95","line":58,"in_reply_to":"3fa7e38b_0c464923","updated":"2020-02-15 08:44:53.000000000","message":"we can\u0027t check start \u003c stop at the oslo.config level, but we can validate during conductor start if needed. This can be included if there is an update.","commit_id":"b3721ce4ff04bd3fbe89e98e9a494db5cf29edc9"}],"ironic/drivers/modules/ipmitool.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fc75abcc44c76521ee559c733fb2cd11ea8a1c8a","unresolved":false,"context_lines":[{"line_number":845,"context_line":"    dii \u003d node.driver_internal_info or {}"},{"line_number":846,"context_line":"    allocated_port \u003d dii.get(\u0027allocated_ipmi_terminal_port\u0027)"},{"line_number":847,"context_line":"    if allocated_port:"},{"line_number":848,"context_line":"        dii.pop(\u0027allocated_ipmi_terminal_port\u0027)"},{"line_number":849,"context_line":"        node.driver_internal_info \u003d dii"},{"line_number":850,"context_line":"        node.save()"},{"line_number":851,"context_line":"        console_utils.release_port(allocated_port)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_4b05e767","line":848,"updated":"2020-02-18 12:09:52.000000000","message":"nit: could use dii.pop(..., None) and avoid double get/pop","commit_id":"b3721ce4ff04bd3fbe89e98e9a494db5cf29edc9"}]}