)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"5a0a32131d1e56ce2889e4400613021dc062a25d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rachit7194 \u003ckapadiarachit007@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-02-11 10:04:00 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DRAC: Upgraded RAID create_config clean step"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This modifies create_configuration cleaning step"},{"line_number":10,"context_line":"by converting physical drives from jbod to raid"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_bf32ebf1","line":7,"updated":"2020-02-12 09:30:06.000000000","message":"I would change this to mention it\u0027s a bug fix","commit_id":"06192ec4bd9dd982a39b4fe97c008b28393f768d"},{"author":{"_account_id":29405,"name":"Rachit Kapadia","email":"kapadiarachit007@gmail.com","username":"rachit7194"},"change_message_id":"8191e8e6702b3b5ccf182415718ccbf6f79823c4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rachit7194 \u003ckapadiarachit007@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-02-11 10:04:00 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DRAC: Upgraded RAID create_config clean step"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This modifies create_configuration cleaning step"},{"line_number":10,"context_line":"by converting physical drives from jbod to raid"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_c7e7b944","line":7,"in_reply_to":"3fa7e38b_bf32ebf1","updated":"2020-02-14 06:28:37.000000000","message":"Done","commit_id":"06192ec4bd9dd982a39b4fe97c008b28393f768d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e9a87cf682fe05a7077f689178227fc156d0201f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"by converting physical drives from jbod to raid"},{"line_number":11,"context_line":"and let task manager filter out the configuration"},{"line_number":12,"context_line":"job and then after it creates virtual disks."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I7879e0534018f9a2ad12155fd886b069604bf3d3"},{"line_number":15,"context_line":"Story: 2007285"},{"line_number":16,"context_line":"Task: 38738"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_ac35b5a8","line":13,"updated":"2020-02-15 03:30:46.000000000","message":"If you could touch on the changes made to the tests, it would help. I\u0027m worried about reviewing the test change and not understanding the change.","commit_id":"cd1c120003e339b900eda4c3e0e5621c8dd1940c"}],"ironic/drivers/modules/drac/raid.py":[{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"01ec18e8c27e6100844128576e01662d07ec6ff2","unresolved":false,"context_lines":[{"line_number":928,"context_line":""},{"line_number":929,"context_line":""},{"line_number":930,"context_line":"def _create_virtual_disks(task, node):"},{"line_number":931,"context_line":"    LOG.debug(\"Waiting for configuration job to complete \""},{"line_number":932,"context_line":"              \"for node %(node_uuid)s. \", {\"node_uuid\": node.uuid})"},{"line_number":933,"context_line":"    drac_job.wait_for_job_completion(node)"},{"line_number":934,"context_line":""},{"line_number":935,"context_line":"    logical_disks_to_create \u003d node.driver_internal_info["},{"line_number":936,"context_line":"        \u0027logical_disks_to_create\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_9c4a39ac","line":933,"range":{"start_line":931,"start_character":0,"end_line":933,"end_character":42},"updated":"2020-02-18 23:46:07.000000000","message":"I don\u0027t think these lines are needed.  There are 2 paths that we can take to get here:\n1. RAID controller does not support JBOD mode.  In this case, no jobs will have been created yet, so there\u0027s no need to wait.\n2. RAID controller does support JBOD mode.  In this case, we\u0027re being called from _check_node_raid_jobs() and the job that we would be waiting for has finished already.","commit_id":"cd1c120003e339b900eda4c3e0e5621c8dd1940c"},{"author":{"_account_id":29405,"name":"Rachit Kapadia","email":"kapadiarachit007@gmail.com","username":"rachit7194"},"change_message_id":"034182d29d09ddfa452f20377af4687a6d97f8df","unresolved":false,"context_lines":[{"line_number":928,"context_line":""},{"line_number":929,"context_line":""},{"line_number":930,"context_line":"def _create_virtual_disks(task, node):"},{"line_number":931,"context_line":"    LOG.debug(\"Waiting for configuration job to complete \""},{"line_number":932,"context_line":"              \"for node %(node_uuid)s. \", {\"node_uuid\": node.uuid})"},{"line_number":933,"context_line":"    drac_job.wait_for_job_completion(node)"},{"line_number":934,"context_line":""},{"line_number":935,"context_line":"    logical_disks_to_create \u003d node.driver_internal_info["},{"line_number":936,"context_line":"        \u0027logical_disks_to_create\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_2f8bad6a","line":933,"range":{"start_line":931,"start_character":0,"end_line":933,"end_character":42},"in_reply_to":"3fa7e38b_9c4a39ac","updated":"2020-02-20 13:43:03.000000000","message":"Yes you are right. Done.","commit_id":"cd1c120003e339b900eda4c3e0e5621c8dd1940c"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"01ec18e8c27e6100844128576e01662d07ec6ff2","unresolved":false,"context_lines":[{"line_number":1083,"context_line":"                \"logical disks to RAID mode for node %(node_uuid)s \","},{"line_number":1084,"context_line":"                {\"node_uuid\": node.uuid})"},{"line_number":1085,"context_line":"            raid_mode \u003d drac_constants.RaidStatus.raid"},{"line_number":1086,"context_line":"            conversion_results \u003d _change_physical_disk_mode("},{"line_number":1087,"context_line":"                node, raid_mode,"},{"line_number":1088,"context_line":"                controllers_to_physical_disk_ids,"},{"line_number":1089,"context_line":"                substep\u003d\"create_virtual_disks\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_9c979938","line":1086,"updated":"2020-02-18 23:46:07.000000000","message":"Could you rename conversion_results to something like commit_results?  In all the other places, conversion_results is a dictionary that maps controller ids to results for that controller.  In this case, the return value is None, CLEANWAIT, or DEPLOYWAIT.","commit_id":"cd1c120003e339b900eda4c3e0e5621c8dd1940c"},{"author":{"_account_id":29405,"name":"Rachit Kapadia","email":"kapadiarachit007@gmail.com","username":"rachit7194"},"change_message_id":"034182d29d09ddfa452f20377af4687a6d97f8df","unresolved":false,"context_lines":[{"line_number":1083,"context_line":"                \"logical disks to RAID mode for node %(node_uuid)s \","},{"line_number":1084,"context_line":"                {\"node_uuid\": node.uuid})"},{"line_number":1085,"context_line":"            raid_mode \u003d drac_constants.RaidStatus.raid"},{"line_number":1086,"context_line":"            conversion_results \u003d _change_physical_disk_mode("},{"line_number":1087,"context_line":"                node, raid_mode,"},{"line_number":1088,"context_line":"                controllers_to_physical_disk_ids,"},{"line_number":1089,"context_line":"                substep\u003d\"create_virtual_disks\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_0fd59148","line":1086,"in_reply_to":"3fa7e38b_9c979938","updated":"2020-02-20 13:43:03.000000000","message":"Done","commit_id":"cd1c120003e339b900eda4c3e0e5621c8dd1940c"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"01ec18e8c27e6100844128576e01662d07ec6ff2","unresolved":false,"context_lines":[{"line_number":1088,"context_line":"                controllers_to_physical_disk_ids,"},{"line_number":1089,"context_line":"                substep\u003d\"create_virtual_disks\")"},{"line_number":1090,"context_line":""},{"line_number":1091,"context_line":"        # adding logical_disks to driver_internal_info to create virtual disks"},{"line_number":1092,"context_line":"        driver_internal_info \u003d node.driver_internal_info"},{"line_number":1093,"context_line":"        driver_internal_info["},{"line_number":1094,"context_line":"            \"logical_disks_to_create\"] \u003d logical_disks_to_create"},{"line_number":1095,"context_line":"        node.driver_internal_info \u003d driver_internal_info"},{"line_number":1096,"context_line":"        node.save()"},{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"        if conversion_results:"},{"line_number":1099,"context_line":"            return conversion_results"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_fcd48df2","line":1096,"range":{"start_line":1091,"start_character":0,"end_line":1096,"end_character":19},"updated":"2020-02-18 23:46:07.000000000","message":"I think this block of code should be moved before to line 1078, before _change_physical_disk_mode is called to prevent a very unlikely race condition from occurring.","commit_id":"cd1c120003e339b900eda4c3e0e5621c8dd1940c"},{"author":{"_account_id":29405,"name":"Rachit Kapadia","email":"kapadiarachit007@gmail.com","username":"rachit7194"},"change_message_id":"034182d29d09ddfa452f20377af4687a6d97f8df","unresolved":false,"context_lines":[{"line_number":1088,"context_line":"                controllers_to_physical_disk_ids,"},{"line_number":1089,"context_line":"                substep\u003d\"create_virtual_disks\")"},{"line_number":1090,"context_line":""},{"line_number":1091,"context_line":"        # adding logical_disks to driver_internal_info to create virtual disks"},{"line_number":1092,"context_line":"        driver_internal_info \u003d node.driver_internal_info"},{"line_number":1093,"context_line":"        driver_internal_info["},{"line_number":1094,"context_line":"            \"logical_disks_to_create\"] \u003d logical_disks_to_create"},{"line_number":1095,"context_line":"        node.driver_internal_info \u003d driver_internal_info"},{"line_number":1096,"context_line":"        node.save()"},{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"        if conversion_results:"},{"line_number":1099,"context_line":"            return conversion_results"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_cf89b970","line":1096,"range":{"start_line":1091,"start_character":0,"end_line":1096,"end_character":19},"in_reply_to":"3fa7e38b_fcd48df2","updated":"2020-02-20 13:43:03.000000000","message":"done.","commit_id":"cd1c120003e339b900eda4c3e0e5621c8dd1940c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e9a87cf682fe05a7077f689178227fc156d0201f","unresolved":false,"context_lines":[{"line_number":1258,"context_line":"    def _convert_drives(self, task, node):"},{"line_number":1259,"context_line":"        jbod \u003d drac_constants.RaidStatus.jbod"},{"line_number":1260,"context_line":"        drives_results \u003d _change_physical_disk_mode("},{"line_number":1261,"context_line":"            node, mode\u003djbod)"},{"line_number":1262,"context_line":"        if drives_results is None:"},{"line_number":1263,"context_line":"            LOG.debug(\"Controller does not support drives \""},{"line_number":1264,"context_line":"                      \"conversion on %(node_uuid)s\","}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_ecb16d2d","line":1261,"updated":"2020-02-15 03:30:46.000000000","message":"no substep invocation required here?","commit_id":"cd1c120003e339b900eda4c3e0e5621c8dd1940c"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"01ec18e8c27e6100844128576e01662d07ec6ff2","unresolved":false,"context_lines":[{"line_number":1258,"context_line":"    def _convert_drives(self, task, node):"},{"line_number":1259,"context_line":"        jbod \u003d drac_constants.RaidStatus.jbod"},{"line_number":1260,"context_line":"        drives_results \u003d _change_physical_disk_mode("},{"line_number":1261,"context_line":"            node, mode\u003djbod)"},{"line_number":1262,"context_line":"        if drives_results is None:"},{"line_number":1263,"context_line":"            LOG.debug(\"Controller does not support drives \""},{"line_number":1264,"context_line":"                      \"conversion on %(node_uuid)s\","}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_1cbba974","line":1261,"in_reply_to":"3fa7e38b_ecb16d2d","updated":"2020-02-18 23:46:07.000000000","message":"Hey Julia, this method is only called when the delete_configuration cleaning step is executing, and it is the last substep in the chain.  As a result, the default substep of \"completed\" is used, which indicates it\u0027s the last substep.","commit_id":"cd1c120003e339b900eda4c3e0e5621c8dd1940c"},{"author":{"_account_id":29405,"name":"Rachit Kapadia","email":"kapadiarachit007@gmail.com","username":"rachit7194"},"change_message_id":"034182d29d09ddfa452f20377af4687a6d97f8df","unresolved":false,"context_lines":[{"line_number":1258,"context_line":"    def _convert_drives(self, task, node):"},{"line_number":1259,"context_line":"        jbod \u003d drac_constants.RaidStatus.jbod"},{"line_number":1260,"context_line":"        drives_results \u003d _change_physical_disk_mode("},{"line_number":1261,"context_line":"            node, mode\u003djbod)"},{"line_number":1262,"context_line":"        if drives_results is None:"},{"line_number":1263,"context_line":"            LOG.debug(\"Controller does not support drives \""},{"line_number":1264,"context_line":"                      \"conversion on %(node_uuid)s\","}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_3e3560f5","line":1261,"in_reply_to":"3fa7e38b_ecb16d2d","updated":"2020-02-20 13:43:03.000000000","message":"It was not needed here actually because it is a last operation(substep) as a part of the the cleaning(delete_configuration) step and so it will take by-default substep which is ``completed`` at line https://review.opendev.org/#/c/707169/3/ironic/drivers/modules/drac/raid.py@842 . It will resume the cleaning step and put the node to `cleaning` state from `clean wait`.","commit_id":"cd1c120003e339b900eda4c3e0e5621c8dd1940c"}],"releasenotes/notes/fix-create-configuration-0e000392d9d7f23b.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"2bb1601750e100c0578831d64e776565149cbaa2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    would still be executing."},{"line_number":11,"context_line":"    This patch fixes this issue by only allowing the cleaning step to"},{"line_number":12,"context_line":"    finish after the job to create the virtual disk completes."},{"line_number":13,"context_line":"    See bug `https://storyboard.openstack.org/#!/story/2007285`"},{"line_number":14,"context_line":"    for more details."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_c745154c","line":13,"updated":"2020-02-20 20:25:27.000000000","message":"`text \u003curl\u003e`_","commit_id":"b0d7c950f8be601a4060193bc7d54fea5af3ad0b"}],"releasenotes/notes/upgraded-create-configuration-0e000392d9d7f23b.yaml":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"5a0a32131d1e56ce2889e4400613021dc062a25d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"fixes:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    Fixes a bug in the ``idrac`` hardware type where node goes to cleaning"},{"line_number":4,"context_line":"    state even when there is unfinished configuration job for"},{"line_number":5,"context_line":"    create_virtual_disks of create_configuration clean step. The approach is"},{"line_number":6,"context_line":"    first finished configuration job completely and let task manager filter"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_5c2665ce","line":3,"range":{"start_line":3,"start_character":53,"end_line":3,"end_character":62},"updated":"2020-02-12 09:30:06.000000000","message":"\u0027nodes go\u0027 or \u0027a node goes\u0027","commit_id":"06192ec4bd9dd982a39b4fe97c008b28393f768d"},{"author":{"_account_id":29405,"name":"Rachit Kapadia","email":"kapadiarachit007@gmail.com","username":"rachit7194"},"change_message_id":"8191e8e6702b3b5ccf182415718ccbf6f79823c4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"fixes:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    Fixes a bug in the ``idrac`` hardware type where node goes to cleaning"},{"line_number":4,"context_line":"    state even when there is unfinished configuration job for"},{"line_number":5,"context_line":"    create_virtual_disks of create_configuration clean step. The approach is"},{"line_number":6,"context_line":"    first finished configuration job completely and let task manager filter"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_87ed4124","line":3,"range":{"start_line":3,"start_character":53,"end_line":3,"end_character":62},"in_reply_to":"3fa7e38b_5c2665ce","updated":"2020-02-14 06:28:37.000000000","message":"Done","commit_id":"06192ec4bd9dd982a39b4fe97c008b28393f768d"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"5a0a32131d1e56ce2889e4400613021dc062a25d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    Fixes a bug in the ``idrac`` hardware type where node goes to cleaning"},{"line_number":4,"context_line":"    state even when there is unfinished configuration job for"},{"line_number":5,"context_line":"    create_virtual_disks of create_configuration clean step. The approach is"},{"line_number":6,"context_line":"    first finished configuration job completely and let task manager filter"},{"line_number":7,"context_line":"    out the configuration job from the node properties."},{"line_number":8,"context_line":"    See bug `https://storyboard.openstack.org/#!/story/2007285` for more"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_3c192986","line":5,"range":{"start_line":5,"start_character":25,"end_line":5,"end_character":27},"updated":"2020-02-12 09:30:06.000000000","message":"during the","commit_id":"06192ec4bd9dd982a39b4fe97c008b28393f768d"},{"author":{"_account_id":29405,"name":"Rachit Kapadia","email":"kapadiarachit007@gmail.com","username":"rachit7194"},"change_message_id":"8191e8e6702b3b5ccf182415718ccbf6f79823c4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    Fixes a bug in the ``idrac`` hardware type where node goes to cleaning"},{"line_number":4,"context_line":"    state even when there is unfinished configuration job for"},{"line_number":5,"context_line":"    create_virtual_disks of create_configuration clean step. The approach is"},{"line_number":6,"context_line":"    first finished configuration job completely and let task manager filter"},{"line_number":7,"context_line":"    out the configuration job from the node properties."},{"line_number":8,"context_line":"    See bug `https://storyboard.openstack.org/#!/story/2007285` for more"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_47d3c963","line":5,"range":{"start_line":5,"start_character":25,"end_line":5,"end_character":27},"in_reply_to":"3fa7e38b_3c192986","updated":"2020-02-14 06:28:37.000000000","message":"Done","commit_id":"06192ec4bd9dd982a39b4fe97c008b28393f768d"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"5a0a32131d1e56ce2889e4400613021dc062a25d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    Fixes a bug in the ``idrac`` hardware type where node goes to cleaning"},{"line_number":4,"context_line":"    state even when there is unfinished configuration job for"},{"line_number":5,"context_line":"    create_virtual_disks of create_configuration clean step. The approach is"},{"line_number":6,"context_line":"    first finished configuration job completely and let task manager filter"},{"line_number":7,"context_line":"    out the configuration job from the node properties."},{"line_number":8,"context_line":"    See bug `https://storyboard.openstack.org/#!/story/2007285` for more"},{"line_number":9,"context_line":"    details"},{"line_number":10,"context_line":"other:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_7cfa4112","line":7,"range":{"start_line":5,"start_character":61,"end_line":7,"end_character":55},"updated":"2020-02-12 09:30:06.000000000","message":"this part is a bit confusing, do you mind rewording it ?","commit_id":"06192ec4bd9dd982a39b4fe97c008b28393f768d"},{"author":{"_account_id":29405,"name":"Rachit Kapadia","email":"kapadiarachit007@gmail.com","username":"rachit7194"},"change_message_id":"8191e8e6702b3b5ccf182415718ccbf6f79823c4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    Fixes a bug in the ``idrac`` hardware type where node goes to cleaning"},{"line_number":4,"context_line":"    state even when there is unfinished configuration job for"},{"line_number":5,"context_line":"    create_virtual_disks of create_configuration clean step. The approach is"},{"line_number":6,"context_line":"    first finished configuration job completely and let task manager filter"},{"line_number":7,"context_line":"    out the configuration job from the node properties."},{"line_number":8,"context_line":"    See bug `https://storyboard.openstack.org/#!/story/2007285` for more"},{"line_number":9,"context_line":"    details"},{"line_number":10,"context_line":"other:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_07d9517f","line":7,"range":{"start_line":5,"start_character":61,"end_line":7,"end_character":55},"in_reply_to":"3fa7e38b_7cfa4112","updated":"2020-02-14 06:28:37.000000000","message":"Done.","commit_id":"06192ec4bd9dd982a39b4fe97c008b28393f768d"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"5a0a32131d1e56ce2889e4400613021dc062a25d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    out the configuration job from the node properties."},{"line_number":8,"context_line":"    See bug `https://storyboard.openstack.org/#!/story/2007285` for more"},{"line_number":9,"context_line":"    details"},{"line_number":10,"context_line":"other:"},{"line_number":11,"context_line":"  - |"},{"line_number":12,"context_line":"    Add other notes here, or remove this section.  All of the list items in"},{"line_number":13,"context_line":"    this section are combined when the release notes are rendered, so the text"},{"line_number":14,"context_line":"    needs to be worded so that it does not depend on any information only"},{"line_number":15,"context_line":"    available in another section, such as the prelude. This may mean repeating"},{"line_number":16,"context_line":"    some details."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_dc32550e","line":16,"range":{"start_line":10,"start_character":0,"end_line":16,"end_character":17},"updated":"2020-02-12 09:30:06.000000000","message":"remove this","commit_id":"06192ec4bd9dd982a39b4fe97c008b28393f768d"},{"author":{"_account_id":29405,"name":"Rachit Kapadia","email":"kapadiarachit007@gmail.com","username":"rachit7194"},"change_message_id":"8191e8e6702b3b5ccf182415718ccbf6f79823c4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    out the configuration job from the node properties."},{"line_number":8,"context_line":"    See bug `https://storyboard.openstack.org/#!/story/2007285` for more"},{"line_number":9,"context_line":"    details"},{"line_number":10,"context_line":"other:"},{"line_number":11,"context_line":"  - |"},{"line_number":12,"context_line":"    Add other notes here, or remove this section.  All of the list items in"},{"line_number":13,"context_line":"    this section are combined when the release notes are rendered, so the text"},{"line_number":14,"context_line":"    needs to be worded so that it does not depend on any information only"},{"line_number":15,"context_line":"    available in another section, such as the prelude. This may mean repeating"},{"line_number":16,"context_line":"    some details."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_a7cdddba","line":16,"range":{"start_line":10,"start_character":0,"end_line":16,"end_character":17},"in_reply_to":"3fa7e38b_dc32550e","updated":"2020-02-14 06:28:37.000000000","message":"Apologies.Done.!","commit_id":"06192ec4bd9dd982a39b4fe97c008b28393f768d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e9a87cf682fe05a7077f689178227fc156d0201f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"fixes:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    Fixes a bug in the ``idrac`` hardware type where node go to"},{"line_number":4,"context_line":"    cleaning state even when there is unfinished configuration"},{"line_number":5,"context_line":"    job for create_virtual_disks during create_configuration"},{"line_number":6,"context_line":"    clean step. The approach is to finish configuration job"},{"line_number":7,"context_line":"    for drives conversion and when Periodic task manager completes"},{"line_number":8,"context_line":"    the asynchronous configuration job and removes metadata from the"},{"line_number":9,"context_line":"    node properties by changing the node state to `cleaning`,"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_0cd8897d","line":6,"range":{"start_line":3,"start_character":4,"end_line":6,"end_character":16},"updated":"2020-02-15 03:30:46.000000000","message":"It may be helpful to reword this because I think your wanting to express that the issue is that the task could proceed to the next step prematurely while already in cleaning.","commit_id":"cd1c120003e339b900eda4c3e0e5621c8dd1940c"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"01ec18e8c27e6100844128576e01662d07ec6ff2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"fixes:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    Fixes a bug in the ``idrac`` hardware type where node go to"},{"line_number":4,"context_line":"    cleaning state even when there is unfinished configuration"},{"line_number":5,"context_line":"    job for create_virtual_disks during create_configuration"},{"line_number":6,"context_line":"    clean step. The approach is to finish configuration job"},{"line_number":7,"context_line":"    for drives conversion and when Periodic task manager completes"},{"line_number":8,"context_line":"    the asynchronous configuration job and removes metadata from the"},{"line_number":9,"context_line":"    node properties by changing the node state to `cleaning`,"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_f757c6cb","line":6,"range":{"start_line":3,"start_character":4,"end_line":6,"end_character":16},"in_reply_to":"3fa7e38b_0cd8897d","updated":"2020-02-18 23:46:07.000000000","message":"Hey Rachit, how about something like this:\n\nFixes a bug in the ``idrac`` hardware type where when creating one or more virtual disks on a RAID controller that supports passthru mode (PERC H730P), the cleaning step would finish before the job to create the virtual disks actually completed.  This could result in the client attempting to perform another action against the iDRAC that creates a configuration job, and that action would fail since the job to create the virtual disk would still be executing.","commit_id":"cd1c120003e339b900eda4c3e0e5621c8dd1940c"},{"author":{"_account_id":29405,"name":"Rachit Kapadia","email":"kapadiarachit007@gmail.com","username":"rachit7194"},"change_message_id":"034182d29d09ddfa452f20377af4687a6d97f8df","unresolved":false,"context_lines":[{"line_number":1,"context_line":"fixes:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    Fixes a bug in the ``idrac`` hardware type where node go to"},{"line_number":4,"context_line":"    cleaning state even when there is unfinished configuration"},{"line_number":5,"context_line":"    job for create_virtual_disks during create_configuration"},{"line_number":6,"context_line":"    clean step. The approach is to finish configuration job"},{"line_number":7,"context_line":"    for drives conversion and when Periodic task manager completes"},{"line_number":8,"context_line":"    the asynchronous configuration job and removes metadata from the"},{"line_number":9,"context_line":"    node properties by changing the node state to `cleaning`,"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_4fc4e994","line":6,"range":{"start_line":3,"start_character":4,"end_line":6,"end_character":16},"in_reply_to":"3fa7e38b_f757c6cb","updated":"2020-02-20 13:43:03.000000000","message":"Looks easy. Thanks.","commit_id":"cd1c120003e339b900eda4c3e0e5621c8dd1940c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e9a87cf682fe05a7077f689178227fc156d0201f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    Fixes a bug in the ``idrac`` hardware type where node go to"},{"line_number":4,"context_line":"    cleaning state even when there is unfinished configuration"},{"line_number":5,"context_line":"    job for create_virtual_disks during create_configuration"},{"line_number":6,"context_line":"    clean step. The approach is to finish configuration job"},{"line_number":7,"context_line":"    for drives conversion and when Periodic task manager completes"},{"line_number":8,"context_line":"    the asynchronous configuration job and removes metadata from the"},{"line_number":9,"context_line":"    node properties by changing the node state to `cleaning`,"},{"line_number":10,"context_line":"    and then invoke `create_virtual_disks` method."},{"line_number":11,"context_line":"    See bug `https://storyboard.openstack.org/#!/story/2007285`"},{"line_number":12,"context_line":"    for more details."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_6cc6dd9d","line":10,"range":{"start_line":6,"start_character":15,"end_line":10,"end_character":50},"updated":"2020-02-15 03:30:46.000000000","message":"The intended reader needs to understand the effect upon them, all of the details as to how the issue is solved.  In other words, I think it would help if the explanation of what we now do is shorter and less developer oriented.","commit_id":"cd1c120003e339b900eda4c3e0e5621c8dd1940c"},{"author":{"_account_id":29405,"name":"Rachit Kapadia","email":"kapadiarachit007@gmail.com","username":"rachit7194"},"change_message_id":"034182d29d09ddfa452f20377af4687a6d97f8df","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    Fixes a bug in the ``idrac`` hardware type where node go to"},{"line_number":4,"context_line":"    cleaning state even when there is unfinished configuration"},{"line_number":5,"context_line":"    job for create_virtual_disks during create_configuration"},{"line_number":6,"context_line":"    clean step. The approach is to finish configuration job"},{"line_number":7,"context_line":"    for drives conversion and when Periodic task manager completes"},{"line_number":8,"context_line":"    the asynchronous configuration job and removes metadata from the"},{"line_number":9,"context_line":"    node properties by changing the node state to `cleaning`,"},{"line_number":10,"context_line":"    and then invoke `create_virtual_disks` method."},{"line_number":11,"context_line":"    See bug `https://storyboard.openstack.org/#!/story/2007285`"},{"line_number":12,"context_line":"    for more details."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_0fbef100","line":10,"range":{"start_line":6,"start_character":15,"end_line":10,"end_character":50},"in_reply_to":"3fa7e38b_57625aa9","updated":"2020-02-20 13:43:03.000000000","message":"Yes added. Thanks","commit_id":"cd1c120003e339b900eda4c3e0e5621c8dd1940c"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"01ec18e8c27e6100844128576e01662d07ec6ff2","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    Fixes a bug in the ``idrac`` hardware type where node go to"},{"line_number":4,"context_line":"    cleaning state even when there is unfinished configuration"},{"line_number":5,"context_line":"    job for create_virtual_disks during create_configuration"},{"line_number":6,"context_line":"    clean step. The approach is to finish configuration job"},{"line_number":7,"context_line":"    for drives conversion and when Periodic task manager completes"},{"line_number":8,"context_line":"    the asynchronous configuration job and removes metadata from the"},{"line_number":9,"context_line":"    node properties by changing the node state to `cleaning`,"},{"line_number":10,"context_line":"    and then invoke `create_virtual_disks` method."},{"line_number":11,"context_line":"    See bug `https://storyboard.openstack.org/#!/story/2007285`"},{"line_number":12,"context_line":"    for more details."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_57625aa9","line":10,"range":{"start_line":6,"start_character":15,"end_line":10,"end_character":50},"in_reply_to":"3fa7e38b_6cc6dd9d","updated":"2020-02-18 23:46:07.000000000","message":"Hey Rachit, how about something like this:\n\nThis patch fixes this issue by only allowing the cleaning step to finish after the job to create the virtual disk completes.","commit_id":"cd1c120003e339b900eda4c3e0e5621c8dd1940c"}]}