)]}'
{"ironic/drivers/modules/redfish/utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"325b237a7d7090fbaeda8455756449eb5a33511d","unresolved":false,"context_lines":[{"line_number":257,"context_line":"        except sushy.exceptions.ResourceNotFoundError as e:"},{"line_number":258,"context_line":"            LOG.error(\u0027The Redfish System \"%(system)s\" was not found for \u0027"},{"line_number":259,"context_line":"                      \u0027node %(node)s. Error %(error)s\u0027,"},{"line_number":260,"context_line":"                      {\u0027system\u0027: system_id or \u0027\u003cdiscover\u003e\u0027,"},{"line_number":261,"context_line":"                       \u0027node\u0027: node.uuid, \u0027error\u0027: e})"},{"line_number":262,"context_line":"            raise exception.RedfishError(error\u003de)"},{"line_number":263,"context_line":"        # TODO(lucasagomes): We should look at other types of"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_3950655f","line":260,"updated":"2020-02-11 17:17:34.000000000","message":"maybe s/discover/default/ ?","commit_id":"3908968ea30ae936882f9b63c78327b728862088"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"facf07c34a44ab89bc7b28f0327a49e70d026c23","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                  \u0027The value should be a path (string) to the resource \u0027"},{"line_number":127,"context_line":"                  \u0027that the driver will interact with. For example: \u0027"},{"line_number":128,"context_line":"                  \u0027/redfish/v1/Systems/1\u0027) %"},{"line_number":129,"context_line":"                {\u0027value\u0027: driver_info[\u0027redfish_system_id\u0027], \u0027node\u0027: node.uuid})"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    # Check if verify_ca is a Boolean or a file/directory in the file-system"},{"line_number":132,"context_line":"    verify_ca \u003d driver_info.get(\u0027redfish_verify_ca\u0027, True)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_e5053469","line":129,"updated":"2020-02-12 12:13:02.000000000","message":"nit: use the redfish_system_id variable here","commit_id":"92ab74f1d7c9db453e3bce721092bf236be82c6e"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"cc4e00eb15793436f31ef8dff7ba97489f02a6bf","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                  \u0027The value should be a path (string) to the resource \u0027"},{"line_number":127,"context_line":"                  \u0027that the driver will interact with. For example: \u0027"},{"line_number":128,"context_line":"                  \u0027/redfish/v1/Systems/1\u0027) %"},{"line_number":129,"context_line":"                {\u0027value\u0027: driver_info[\u0027redfish_system_id\u0027], \u0027node\u0027: node.uuid})"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    # Check if verify_ca is a Boolean or a file/directory in the file-system"},{"line_number":132,"context_line":"    verify_ca \u003d driver_info.get(\u0027redfish_verify_ca\u0027, True)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_2b80fd48","line":129,"in_reply_to":"3fa7e38b_e5053469","updated":"2020-02-12 13:56:28.000000000","message":"Done","commit_id":"92ab74f1d7c9db453e3bce721092bf236be82c6e"}],"releasenotes/notes/optional-redfish-system-id-3f6e8b0ac989cb9b.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"facf07c34a44ab89bc7b28f0327a49e70d026c23","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``redfish_system_id`` property of redfish hardware type made optional."},{"line_number":5,"context_line":"    If not specified in ``driver_info``, and target BMC manages a single"},{"line_number":6,"context_line":"    ComputerSystem, ironic will automatically grab and manage that system."},{"line_number":7,"context_line":"    Otherwise, ironic will fail requiring explicit ``redfish_system_id``"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_853b2034","line":4,"updated":"2020-02-12 12:13:02.000000000","message":"nit: \"has been made\"","commit_id":"92ab74f1d7c9db453e3bce721092bf236be82c6e"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"cc4e00eb15793436f31ef8dff7ba97489f02a6bf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``redfish_system_id`` property of redfish hardware type made optional."},{"line_number":5,"context_line":"    If not specified in ``driver_info``, and target BMC manages a single"},{"line_number":6,"context_line":"    ComputerSystem, ironic will automatically grab and manage that system."},{"line_number":7,"context_line":"    Otherwise, ironic will fail requiring explicit ``redfish_system_id``"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_cb8e0979","line":4,"in_reply_to":"3fa7e38b_853b2034","updated":"2020-02-12 13:56:28.000000000","message":"Done","commit_id":"92ab74f1d7c9db453e3bce721092bf236be82c6e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"facf07c34a44ab89bc7b28f0327a49e70d026c23","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``redfish_system_id`` property of redfish hardware type made optional."},{"line_number":5,"context_line":"    If not specified in ``driver_info``, and target BMC manages a single"},{"line_number":6,"context_line":"    ComputerSystem, ironic will automatically grab and manage that system."},{"line_number":7,"context_line":"    Otherwise, ironic will fail requiring explicit ``redfish_system_id``"},{"line_number":8,"context_line":"    specification in ``driver_info``."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_25102cab","line":5,"updated":"2020-02-12 12:13:02.000000000","message":"nit: \"the target BMC\"","commit_id":"92ab74f1d7c9db453e3bce721092bf236be82c6e"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"cc4e00eb15793436f31ef8dff7ba97489f02a6bf","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``redfish_system_id`` property of redfish hardware type made optional."},{"line_number":5,"context_line":"    If not specified in ``driver_info``, and target BMC manages a single"},{"line_number":6,"context_line":"    ComputerSystem, ironic will automatically grab and manage that system."},{"line_number":7,"context_line":"    Otherwise, ironic will fail requiring explicit ``redfish_system_id``"},{"line_number":8,"context_line":"    specification in ``driver_info``."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_4be8d913","line":5,"in_reply_to":"3fa7e38b_25102cab","updated":"2020-02-12 13:56:28.000000000","message":"Done","commit_id":"92ab74f1d7c9db453e3bce721092bf236be82c6e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"facf07c34a44ab89bc7b28f0327a49e70d026c23","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``redfish_system_id`` property of redfish hardware type made optional."},{"line_number":5,"context_line":"    If not specified in ``driver_info``, and target BMC manages a single"},{"line_number":6,"context_line":"    ComputerSystem, ironic will automatically grab and manage that system."},{"line_number":7,"context_line":"    Otherwise, ironic will fail requiring explicit ``redfish_system_id``"},{"line_number":8,"context_line":"    specification in ``driver_info``."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_4513e8b7","line":6,"updated":"2020-02-12 12:13:02.000000000","message":"s/automatically grab and use/assume/ ?","commit_id":"92ab74f1d7c9db453e3bce721092bf236be82c6e"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"cc4e00eb15793436f31ef8dff7ba97489f02a6bf","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``redfish_system_id`` property of redfish hardware type made optional."},{"line_number":5,"context_line":"    If not specified in ``driver_info``, and target BMC manages a single"},{"line_number":6,"context_line":"    ComputerSystem, ironic will automatically grab and manage that system."},{"line_number":7,"context_line":"    Otherwise, ironic will fail requiring explicit ``redfish_system_id``"},{"line_number":8,"context_line":"    specification in ``driver_info``."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_cbd36962","line":6,"in_reply_to":"3fa7e38b_4513e8b7","updated":"2020-02-12 13:56:28.000000000","message":"Done","commit_id":"92ab74f1d7c9db453e3bce721092bf236be82c6e"}]}