)]}'
{"ironic/tests/api/test_chassis.py":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"704e4ad2aa7f698d2d720bc58f84ddccdb74dbb1","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        response \u003d self.patch_json(\u0027/chassis/%s\u0027 % cdict[\u0027uuid\u0027],"},{"line_number":270,"context_line":"                                   [{\u0027path\u0027: \u0027/uuid\u0027, \u0027op\u0027: \u0027remove\u0027}],"},{"line_number":271,"context_line":"                                   expect_errors\u003dTrue)"},{"line_number":272,"context_line":"        self.assertEqual(response.status_int, 400)"},{"line_number":273,"context_line":"        self.assertEqual(response.content_type, \u0027application/json\u0027)"},{"line_number":274,"context_line":"        self.assertTrue(response.json[\u0027error_message\u0027])"},{"line_number":275,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F9kMM%3D","line":272,"updated":"2014-02-06 00:58:44.000000000","message":"Lucas, I remember the first parameter is expected value, and 2nd one is the actual value, so suggest:\n\n    self.assertEqual(400, response.status_int)\n\nThis comments can be apply all new assertEqual lines.","commit_id":"969dac648d4540e2a0bc6f757172ff54f102fe5d"}],"ironic/tests/api/test_nodes.py":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"a9eafb0442d544f9c936669fd736775d82c490af","unresolved":false,"context_lines":[{"line_number":447,"context_line":"        ndict \u003d dbutils.get_test_node(id\u003d99, uuid\u003dutils.generate_uuid(),"},{"line_number":448,"context_line":"                                      target_power_state\u003dstates.POWER_OFF)"},{"line_number":449,"context_line":"        node \u003d self.dbapi.create_node(ndict)"},{"line_number":450,"context_line":"        self.assertRaises(webtest.app.AppError, self.patch_json,"},{"line_number":451,"context_line":"                          \u0027/nodes/%s\u0027 % node[\u0027uuid\u0027],"},{"line_number":452,"context_line":"                          [{\u0027path\u0027: \u0027/extra/foo\u0027, \u0027value\u0027: \u0027bar\u0027,"},{"line_number":453,"context_line":"                            \u0027op\u0027: \u0027add\u0027}])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9ruU%3D","line":450,"updated":"2014-02-05 01:12:48.000000000","message":"why does this assertRaises(...) then issue the same call with expect_errors\u003dTrue?","commit_id":"cfeb7b0b347bd67a75f3a556680b8e8b6f2eec9d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1b618fe9c297ac49c15d40e7249a7abb203942b8","unresolved":false,"context_lines":[{"line_number":447,"context_line":"        ndict \u003d dbutils.get_test_node(id\u003d99, uuid\u003dutils.generate_uuid(),"},{"line_number":448,"context_line":"                                      target_power_state\u003dstates.POWER_OFF)"},{"line_number":449,"context_line":"        node \u003d self.dbapi.create_node(ndict)"},{"line_number":450,"context_line":"        self.assertRaises(webtest.app.AppError, self.patch_json,"},{"line_number":451,"context_line":"                          \u0027/nodes/%s\u0027 % node[\u0027uuid\u0027],"},{"line_number":452,"context_line":"                          [{\u0027path\u0027: \u0027/extra/foo\u0027, \u0027value\u0027: \u0027bar\u0027,"},{"line_number":453,"context_line":"                            \u0027op\u0027: \u0027add\u0027}])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9puA%3D","line":450,"in_reply_to":"AAAAUH%2F9ruU%3D","updated":"2014-02-05 10:36:55.000000000","message":"+1 indeed it\u0027s redundant, thanks for pointing that out!","commit_id":"cfeb7b0b347bd67a75f3a556680b8e8b6f2eec9d"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"a9eafb0442d544f9c936669fd736775d82c490af","unresolved":false,"context_lines":[{"line_number":713,"context_line":""},{"line_number":714,"context_line":"        self.dbapi.update_node(self.node[\u0027uuid\u0027],"},{"line_number":715,"context_line":"                               {\u0027target_power_state\u0027: \u0027fake\u0027})"},{"line_number":716,"context_line":"        self.assertRaises(webtest.app.AppError, self.put_json,"},{"line_number":717,"context_line":"                          \u0027/nodes/%s/states/power\u0027 % self.node[\u0027uuid\u0027],"},{"line_number":718,"context_line":"                          {\u0027target\u0027: states.POWER_ON})"},{"line_number":719,"context_line":"        response \u003d self.put_json(\u0027/nodes/%s/states/power\u0027 % self.node[\u0027uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9rvI%3D","line":716,"updated":"2014-02-05 01:12:48.000000000","message":"why does this assertRaises(...) then issue the same call with expect_errors\u003dTrue?","commit_id":"cfeb7b0b347bd67a75f3a556680b8e8b6f2eec9d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1b618fe9c297ac49c15d40e7249a7abb203942b8","unresolved":false,"context_lines":[{"line_number":713,"context_line":""},{"line_number":714,"context_line":"        self.dbapi.update_node(self.node[\u0027uuid\u0027],"},{"line_number":715,"context_line":"                               {\u0027target_power_state\u0027: \u0027fake\u0027})"},{"line_number":716,"context_line":"        self.assertRaises(webtest.app.AppError, self.put_json,"},{"line_number":717,"context_line":"                          \u0027/nodes/%s/states/power\u0027 % self.node[\u0027uuid\u0027],"},{"line_number":718,"context_line":"                          {\u0027target\u0027: states.POWER_ON})"},{"line_number":719,"context_line":"        response \u003d self.put_json(\u0027/nodes/%s/states/power\u0027 % self.node[\u0027uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9pt4%3D","line":716,"in_reply_to":"AAAAUH%2F9rvI%3D","updated":"2014-02-05 10:36:55.000000000","message":"+1 indeed it\u0027s redundant, thanks for pointing that out!","commit_id":"cfeb7b0b347bd67a75f3a556680b8e8b6f2eec9d"}]}