)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"23a60dda3c50d2fd161bdd4817e1c6c9cb40455c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rachit7194 \u003ckapadiarachit007@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-03-02 14:14:08 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DRAC: Fix to calculate volume size to create VD"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch fixes a issue by validating volume properties"},{"line_number":10,"context_line":"again only if drives are converted  back to JBOD from RAID"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1fa4df85_532fbef5","line":7,"updated":"2020-03-13 20:10:47.000000000","message":"Can you change the above to:\n\nDRAC: Fix a failure to create virtual disk bug","commit_id":"a7319c36339eee6e47254dc15f7b42be11076fd6"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"23a60dda3c50d2fd161bdd4817e1c6c9cb40455c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch fixes a issue by validating volume properties"},{"line_number":10,"context_line":"again only if drives are converted  back to JBOD from RAID"},{"line_number":11,"context_line":"mode."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I720ab15e811f498aa15b88bfe8bb35fc49df292b"},{"line_number":14,"context_line":"Story: 2007359"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1fa4df85_5366de53","line":11,"updated":"2020-03-13 20:10:47.000000000","message":"Can you change the above to:\n\nCertain RAID controllers (PERC H730P) require physical disks to be switched from non-RAID (JBOD) mode to RAID mode to be included in a virtual disk.  When this conversion happens, the available free space on the physical disk is reduced due to some space being allocated to RAID mode housekeeping.  If the user requests a virtual disk (a RAID 1 for example) with a size close to the max size of the physical disks when they are in JBOD mode, then creation of the virtual disk following conversion of the physical disks from JBOD to RAID mode will fail since there is not enough space due to the space used by RAID mode housekeeping.\n\nThis patch works around this issue by recalculating the RAID volume size after physical disk conversion has completed and the free space on the converted drives is known.  Note that this may result in a virtual disk that is slightly smaller than the requested size, but still the max size that the drives can support.","commit_id":"a7319c36339eee6e47254dc15f7b42be11076fd6"}],"ironic/drivers/modules/drac/raid.py":[{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"23a60dda3c50d2fd161bdd4817e1c6c9cb40455c","unresolved":false,"context_lines":[{"line_number":859,"context_line":"            free_space_mb,"},{"line_number":860,"context_line":"            spans_count\u003dspans_count)"},{"line_number":861,"context_line":""},{"line_number":862,"context_line":"        if new_max_vol_size_mb !\u003d logical_disk[\u0027size_mb\u0027]:"},{"line_number":863,"context_line":"            logical_disk[\u0027size_mb\u0027] \u003d new_max_vol_size_mb"},{"line_number":864,"context_line":"            LOG.info(\"Logical size does not match so calculating volume \""},{"line_number":865,"context_line":"                     \"properties for current logical_disk\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_d35bae51","line":862,"updated":"2020-03-13 20:10:47.000000000","message":"What if the user requested a 1 gig RAID 1 on physical disks that are 100 gig in size?  It looks like this code would change the requested size to 100 gig.\nI think instead, that the above line should be:\n\nif logical_disk[\u0027size_mb\u0027] \u003e new_max_vol_size_mb:\n\nThis way, if the size requested is more than the total available size, then we\u0027ll use the total available size instead.","commit_id":"a7319c36339eee6e47254dc15f7b42be11076fd6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a1788212cd859e0e90af8672761efced0753a110","unresolved":false,"context_lines":[{"line_number":870,"context_line":"    if new_processed_volumes:"},{"line_number":871,"context_line":"        return new_processed_volumes"},{"line_number":872,"context_line":""},{"line_number":873,"context_line":"    return logical_disks"},{"line_number":874,"context_line":""},{"line_number":875,"context_line":""},{"line_number":876,"context_line":"def _commit_to_controllers(node, controllers, substep\u003d\"completed\"):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_ab53c46a","line":873,"updated":"2020-03-19 20:03:38.000000000","message":"Given this method is taking input, and providing output that is parsed with conditionals, I strongly believe at least a happy path unit test is added.","commit_id":"6e9b39fb76d0b5dbe6b5b2a00aecace91289ac30"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a1788212cd859e0e90af8672761efced0753a110","unresolved":false,"context_lines":[{"line_number":968,"context_line":"    # Check valid properties attached to voiume after drives conversion"},{"line_number":969,"context_line":"    drives_conversion_results \u003d node.driver_internal_info["},{"line_number":970,"context_line":"        \u0027commit_results\u0027]"},{"line_number":971,"context_line":"    if drives_conversion_results:"},{"line_number":972,"context_line":"        logical_disks_to_create \u003d _validate_volume_size("},{"line_number":973,"context_line":"            node, logical_disks_to_create)"},{"line_number":974,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_cb58808b","line":971,"updated":"2020-03-19 20:03:38.000000000","message":"Please add/update unit test around this conditional that has been added.","commit_id":"6e9b39fb76d0b5dbe6b5b2a00aecace91289ac30"}],"ironic/tests/unit/drivers/modules/drac/test_raid.py":[{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"88498311ad84485bb50a2585f52e301ccc41c087","unresolved":false,"context_lines":[{"line_number":759,"context_line":"        processed_logical_disks \u003d drac_raid._validate_volume_size("},{"line_number":760,"context_line":"            self.node, self.node.target_raid_config[\u0027logical_disks\u0027])"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"        self.assertNotEqual(self.logical_disk, processed_logical_disks[0])"},{"line_number":763,"context_line":""},{"line_number":764,"context_line":"    @mock.patch.object(drac_common, \u0027get_drac_client\u0027, spec_set\u003dTrue,"},{"line_number":765,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_fa4a047e","line":762,"updated":"2020-03-24 14:18:29.000000000","message":"Instead of just checking that the virtual disks are not equal, could we check that the size of the processed_logical_disk is 571776?  At least that\u0027s what I think it will end up being.","commit_id":"788dade97fdba26ba9f339e0de2264effa13fb52"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"6f2c00a768a625b567cb10eb5d6f137d349008f1","unresolved":false,"context_lines":[{"line_number":759,"context_line":"        processed_logical_disks \u003d drac_raid._validate_volume_size("},{"line_number":760,"context_line":"            self.node, self.node.target_raid_config[\u0027logical_disks\u0027])"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"        self.assertNotEqual(self.logical_disk, processed_logical_disks[0])"},{"line_number":763,"context_line":""},{"line_number":764,"context_line":"    @mock.patch.object(drac_common, \u0027get_drac_client\u0027, spec_set\u003dTrue,"},{"line_number":765,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_ceb5bd33","line":762,"in_reply_to":"df33271e_35f63f91","updated":"2020-03-24 17:14:35.000000000","message":"Ah - it\u0027s creating a RAID10 not a RAID1.  Yes, let\u0027s change it if you don\u0027t mind.","commit_id":"788dade97fdba26ba9f339e0de2264effa13fb52"},{"author":{"_account_id":29405,"name":"Rachit Kapadia","email":"kapadiarachit007@gmail.com","username":"rachit7194"},"change_message_id":"f39d8c22e9aebfef69da1d94a88747583f78b504","unresolved":false,"context_lines":[{"line_number":759,"context_line":"        processed_logical_disks \u003d drac_raid._validate_volume_size("},{"line_number":760,"context_line":"            self.node, self.node.target_raid_config[\u0027logical_disks\u0027])"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"        self.assertNotEqual(self.logical_disk, processed_logical_disks[0])"},{"line_number":763,"context_line":""},{"line_number":764,"context_line":"    @mock.patch.object(drac_common, \u0027get_drac_client\u0027, spec_set\u003dTrue,"},{"line_number":765,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_312beeeb","line":762,"in_reply_to":"df33271e_ceb5bd33","updated":"2020-03-24 18:04:57.000000000","message":"Done. Thanks","commit_id":"788dade97fdba26ba9f339e0de2264effa13fb52"},{"author":{"_account_id":29405,"name":"Rachit Kapadia","email":"kapadiarachit007@gmail.com","username":"rachit7194"},"change_message_id":"4bbeb34b914d2c91491adc04bd6341c8a0249f31","unresolved":false,"context_lines":[{"line_number":759,"context_line":"        processed_logical_disks \u003d drac_raid._validate_volume_size("},{"line_number":760,"context_line":"            self.node, self.node.target_raid_config[\u0027logical_disks\u0027])"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"        self.assertNotEqual(self.logical_disk, processed_logical_disks[0])"},{"line_number":763,"context_line":""},{"line_number":764,"context_line":"    @mock.patch.object(drac_common, \u0027get_drac_client\u0027, spec_set\u003dTrue,"},{"line_number":765,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_35f63f91","line":762,"in_reply_to":"df33271e_fa4a047e","updated":"2020-03-24 14:54:03.000000000","message":"Hi Chris,\nI think its a good idea to compare size but 571776(which is a physical disk size) will not be the size which is calculated by _max_volume_size_mb [1]\n\n [1]: https://github.com/openstack/ironic/blob/5f34c0e903a28949712c8a3ca87d34b7d9ced505/ironic/drivers/modules/drac/raid.py#L694\n\naccording to this method size calculated by this method will be different. It will be 2287104\n\nInfo: As per code, When user give size \u0027MAX\u0027 then it will calculate size using above method. Pasted a link for ref.\n\nShould i change?","commit_id":"788dade97fdba26ba9f339e0de2264effa13fb52"}],"releasenotes/notes/fix-drives-conversion-before-raid-creation-ea1f7eb425f79f2f.yaml":[{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"23a60dda3c50d2fd161bdd4817e1c6c9cb40455c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    logical disks which is used for creating virtual disks."},{"line_number":8,"context_line":"    This patch fixes a issue by validating volume properties"},{"line_number":9,"context_line":"    again only if drives are converted  back to JBOD from RAID"},{"line_number":10,"context_line":"    mode."},{"line_number":11,"context_line":"    See bug"},{"line_number":12,"context_line":"    `bug 2007359 \u003chttps://storyboard.openstack.org/#!/story/2007359\u003e`_"},{"line_number":13,"context_line":"    for more details"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1fa4df85_732d1aa7","line":10,"updated":"2020-03-13 20:10:47.000000000","message":"Can you update the above text to be closer to what I requested in the patch comment?","commit_id":"a7319c36339eee6e47254dc15f7b42be11076fd6"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"ac3dd64acbedc00db83b3d3be9185235f7b78142","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    Certain RAID controllers (PERC H730P) require physical disks"},{"line_number":4,"context_line":"    to be switched from non-RAID (JBOD) mode to RAID mode to be"},{"line_number":5,"context_line":"    included in a virtual disk.  When this conversion happens,"},{"line_number":6,"context_line":"    the available free space on the physical disk is reduced due"},{"line_number":7,"context_line":"    to some space being allocated to RAID mode housekeeping."},{"line_number":8,"context_line":"    If the user requests a virtual disk (a RAID 1 for example)"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df33271e_9cb801e6","line":5,"range":{"start_line":5,"start_character":31,"end_line":5,"end_character":32},"updated":"2020-04-07 08:18:37.000000000","message":"nit: blank space","commit_id":"84e8b11a6d1ec04da188f5b34a1396cd92d88d5a"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"ac3dd64acbedc00db83b3d3be9185235f7b78142","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    space used by RAID mode housekeeping."},{"line_number":14,"context_line":"    This patch works around this issue by recalculating the RAID"},{"line_number":15,"context_line":"    volume size after physical disk conversion has completed and"},{"line_number":16,"context_line":"    the free space on the converted drives is known.  Note that"},{"line_number":17,"context_line":"    this may result in a virtual disk that is slightly smaller"},{"line_number":18,"context_line":"    than the requested size, but still the max size that the"},{"line_number":19,"context_line":"    drives can support."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df33271e_fcce6d81","line":16,"range":{"start_line":16,"start_character":52,"end_line":16,"end_character":53},"updated":"2020-04-07 08:18:37.000000000","message":"nit: ditto","commit_id":"84e8b11a6d1ec04da188f5b34a1396cd92d88d5a"}]}