)]}'
{"ironic/drivers/modules/agent.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5b99d177aa1f5ecda44bb8d9cafedabc71f9e6ec","unresolved":false,"context_lines":[{"line_number":439,"context_line":"                # We are missing a piece of information,"},{"line_number":440,"context_line":"                # so we still need to raise an error."},{"line_number":441,"context_line":"                _raise_missing_checksum_exception(node)"},{"line_number":442,"context_line":"            elif not image_checksum:"},{"line_number":443,"context_line":"                # We are lacking the original image_checksum,"},{"line_number":444,"context_line":"                # so we raise the error."},{"line_number":445,"context_line":"                _raise_missing_checksum_exception(node)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_1cfc573c","line":442,"updated":"2020-03-07 16:13:31.000000000","message":"This seems to make image_checksum unconditionally required, no? Did you mean\n\n elif not os_hash_value and not image_checksum:\n\n?","commit_id":"d0c55e65e514b555b33dbaf41fa1f2c2850038c3"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"5bc681da889c1d09a90815f0bc8900df9b542699","unresolved":false,"context_lines":[{"line_number":439,"context_line":"                # We are missing a piece of information,"},{"line_number":440,"context_line":"                # so we still need to raise an error."},{"line_number":441,"context_line":"                _raise_missing_checksum_exception(node)"},{"line_number":442,"context_line":"            elif not image_checksum:"},{"line_number":443,"context_line":"                # We are lacking the original image_checksum,"},{"line_number":444,"context_line":"                # so we raise the error."},{"line_number":445,"context_line":"                _raise_missing_checksum_exception(node)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_99ce1461","line":442,"in_reply_to":"1fa4df85_1cfc573c","updated":"2020-03-09 01:33:47.000000000","message":"yeah, we need to handle three cases here.","commit_id":"d0c55e65e514b555b33dbaf41fa1f2c2850038c3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c874de6fb6d591d991d9017aee800babdfab3538","unresolved":false,"context_lines":[{"line_number":439,"context_line":"                # We are missing a piece of information,"},{"line_number":440,"context_line":"                # so we still need to raise an error."},{"line_number":441,"context_line":"                _raise_missing_checksum_exception(node)"},{"line_number":442,"context_line":"            elif not image_checksum:"},{"line_number":443,"context_line":"                # We are lacking the original image_checksum,"},{"line_number":444,"context_line":"                # so we raise the error."},{"line_number":445,"context_line":"                _raise_missing_checksum_exception(node)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_5fa07790","line":442,"in_reply_to":"1fa4df85_99ce1461","updated":"2020-03-09 14:38:37.000000000","message":"Yeah, that was the elusive one I was trying to think of but was failing to do so over the ?weekend?.","commit_id":"d0c55e65e514b555b33dbaf41fa1f2c2850038c3"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"8cc64ca960c6f315a58a768af032e02bc8ef271f","unresolved":false,"context_lines":[{"line_number":443,"context_line":"                # We are lacking the original image_checksum,"},{"line_number":444,"context_line":"                # so we raise the error."},{"line_number":445,"context_line":"                _raise_missing_checksum_exception(node)"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        validate_http_provisioning_configuration(node)"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        check_image_size(task, image_source)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_9e9d88bd","line":446,"updated":"2020-03-10 01:20:59.000000000","message":"This is a bit tricky and even a clear head in the morning can be confused..\n\nSo, this code will not find this out:\nos_hash_value \u003d False\nos_hash_algo \u003d True\nimage_checksum \u003d True\n\nI\u0027d suggest we use if-elif-elif here, not so fancy looked but robust :)","commit_id":"f00ef8c40d5e33e5c09b67c41fe1a15813c51a49"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8045188bc1a07b1b2501b12248f86ff294c4bca8","unresolved":false,"context_lines":[{"line_number":443,"context_line":"                # We are lacking the original image_checksum,"},{"line_number":444,"context_line":"                # so we raise the error."},{"line_number":445,"context_line":"                _raise_missing_checksum_exception(node)"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        validate_http_provisioning_configuration(node)"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        check_image_size(task, image_source)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_6274939d","line":446,"in_reply_to":"1fa4df85_9e9d88bd","updated":"2020-03-11 15:40:24.000000000","message":"Good point, I didn\u0027t think that as a likely case because I was thinking only from the os_hash* usage path.","commit_id":"f00ef8c40d5e33e5c09b67c41fe1a15813c51a49"}],"releasenotes/notes/image_checksum_optional-381acf9e441d2a58.yaml":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"44c7c58a40e9dc86c2cef302549c372938a0eea3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds the cability for the ``instance_info\\image_checksum`` value"},{"line_number":5,"context_line":"    to be optional in stand-alone deployments if the"},{"line_number":6,"context_line":"    ``instance_info\\image_os_hash_algo`` and"},{"line_number":7,"context_line":"    ``instance_info\\image_os_hash_value`` fields are populated."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1fa4df85_1fe5d238","line":4,"range":{"start_line":4,"start_character":13,"end_line":4,"end_character":21},"updated":"2020-03-13 11:03:15.000000000","message":"nit: capability","commit_id":"fbf92e61267cc10868c1147f7397755fd6f7a0b9"}]}