)]}'
{"ironic/drivers/modules/ipmitool.py":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"c1d01ad6a7ccd67fd3b83310cb598b2cd22a2c6c","unresolved":false,"context_lines":[{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"        indicators \u003d {"},{"line_number":1218,"context_line":"            components.CHASSIS: {"},{"line_number":1219,"context_line":"                \u0027system\u0027: {"},{"line_number":1220,"context_line":"                    \u0027readonly\u0027: False,"},{"line_number":1221,"context_line":"                    \u0027states\u0027: [\u0027ON\u0027, \u0027OFF\u0027, \u0027BLINKING\u0027],"},{"line_number":1222,"context_line":"                }"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_451aef16","line":1219,"updated":"2020-03-09 11:38:27.000000000","message":"Is it possible that a chassis hosts more than one system? I am questioning the`system` key here, may be mix some system ID in there?","commit_id":"c51f7c1d58b340f71b05b29673f9eed0e44a433c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0f2c6b832f92e84f4d02838354947703c47ce4b4","unresolved":false,"context_lines":[{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"        indicators \u003d {"},{"line_number":1218,"context_line":"            components.CHASSIS: {"},{"line_number":1219,"context_line":"                \u0027system\u0027: {"},{"line_number":1220,"context_line":"                    \u0027readonly\u0027: False,"},{"line_number":1221,"context_line":"                    \u0027states\u0027: [\u0027ON\u0027, \u0027OFF\u0027, \u0027BLINKING\u0027],"},{"line_number":1222,"context_line":"                }"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_4b10b44e","line":1219,"in_reply_to":"1fa4df85_451aef16","updated":"2020-03-09 23:34:24.000000000","message":"Well, I don\u0027t have a good grasp on the structure of the data. It is purely a chassis identification indicator and the chassis and a system in ipmi are the same thing.","commit_id":"c51f7c1d58b340f71b05b29673f9eed0e44a433c"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"1f3be0773b02128868c7b00fe43330b1c1b11c95","unresolved":false,"context_lines":[{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"        indicators \u003d {"},{"line_number":1218,"context_line":"            components.CHASSIS: {"},{"line_number":1219,"context_line":"                \u0027system\u0027: {"},{"line_number":1220,"context_line":"                    \u0027readonly\u0027: False,"},{"line_number":1221,"context_line":"                    \u0027states\u0027: [\u0027ON\u0027, \u0027OFF\u0027, \u0027BLINKING\u0027],"},{"line_number":1222,"context_line":"                }"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_44694389","line":1219,"in_reply_to":"1fa4df85_4b10b44e","updated":"2020-03-13 10:07:59.000000000","message":"If with IPMI chassis\u003c-\u003esystem is always a 1-to-1 mapping, than we are good here.","commit_id":"c51f7c1d58b340f71b05b29673f9eed0e44a433c"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"c1d01ad6a7ccd67fd3b83310cb598b2cd22a2c6c","unresolved":false,"context_lines":[{"line_number":1218,"context_line":"            components.CHASSIS: {"},{"line_number":1219,"context_line":"                \u0027system\u0027: {"},{"line_number":1220,"context_line":"                    \u0027readonly\u0027: False,"},{"line_number":1221,"context_line":"                    \u0027states\u0027: [\u0027ON\u0027, \u0027OFF\u0027, \u0027BLINKING\u0027],"},{"line_number":1222,"context_line":"                }"},{"line_number":1223,"context_line":"            }"},{"line_number":1224,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_05a4f7b8","line":1221,"updated":"2020-03-09 11:38:27.000000000","message":"I think we should have `indicator_states.*` constants here.","commit_id":"c51f7c1d58b340f71b05b29673f9eed0e44a433c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0f2c6b832f92e84f4d02838354947703c47ce4b4","unresolved":false,"context_lines":[{"line_number":1218,"context_line":"            components.CHASSIS: {"},{"line_number":1219,"context_line":"                \u0027system\u0027: {"},{"line_number":1220,"context_line":"                    \u0027readonly\u0027: False,"},{"line_number":1221,"context_line":"                    \u0027states\u0027: [\u0027ON\u0027, \u0027OFF\u0027, \u0027BLINKING\u0027],"},{"line_number":1222,"context_line":"                }"},{"line_number":1223,"context_line":"            }"},{"line_number":1224,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_0b163c4a","line":1221,"in_reply_to":"1fa4df85_05a4f7b8","updated":"2020-03-09 23:34:24.000000000","message":"You may want to go update the redfish indicator code then :)","commit_id":"c51f7c1d58b340f71b05b29673f9eed0e44a433c"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"1f3be0773b02128868c7b00fe43330b1c1b11c95","unresolved":false,"context_lines":[{"line_number":1218,"context_line":"            components.CHASSIS: {"},{"line_number":1219,"context_line":"                \u0027system\u0027: {"},{"line_number":1220,"context_line":"                    \u0027readonly\u0027: False,"},{"line_number":1221,"context_line":"                    \u0027states\u0027: [\u0027ON\u0027, \u0027OFF\u0027, \u0027BLINKING\u0027],"},{"line_number":1222,"context_line":"                }"},{"line_number":1223,"context_line":"            }"},{"line_number":1224,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_841dfb10","line":1221,"in_reply_to":"1fa4df85_0b163c4a","updated":"2020-03-13 10:07:59.000000000","message":"I think it\u0027s done [1] with constants in redfish code:\n\n1. https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/redfish/management.py#L456","commit_id":"c51f7c1d58b340f71b05b29673f9eed0e44a433c"}]}