)]}'
{"ironic/conf/ipmi.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"f4c6518073a8e956b7a1dec7a40274d5f6e16d52","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                    help\u003d_(\u0027Additional errors ipmitool may encounter, \u0027"},{"line_number":55,"context_line":"                           \u0027specific to the environment it is run in.\u0027)),"},{"line_number":56,"context_line":"    cfg.BoolOpt(\u0027debug\u0027,"},{"line_number":57,"context_line":"                default\u003dFalse,"},{"line_number":58,"context_line":"                help\u003d_(\u0027Enables all ipmi commands to be executed with a \u0027"},{"line_number":59,"context_line":"                       \u0027additional debugging output. This is a separate \u0027"},{"line_number":60,"context_line":"                       \u0027option as ipmitool can log a substantial amount \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_f0982d1c","line":57,"range":{"start_line":57,"start_character":24,"end_line":57,"end_character":29},"updated":"2020-03-13 03:21:42.000000000","message":"How about default to the global debug option, so no one will be surprised? But it seems the ipmitool verbose output is not so useful except extremely special cases, so I think it\u0027s also fine to turn it off by default.","commit_id":"fde4f39dafcbe606c1b2e2b03a06b50d616a86d5"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4871bd93e544f34ce4069655bee89a29d94853ee","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                    help\u003d_(\u0027Additional errors ipmitool may encounter, \u0027"},{"line_number":55,"context_line":"                           \u0027specific to the environment it is run in.\u0027)),"},{"line_number":56,"context_line":"    cfg.BoolOpt(\u0027debug\u0027,"},{"line_number":57,"context_line":"                default\u003dFalse,"},{"line_number":58,"context_line":"                help\u003d_(\u0027Enables all ipmi commands to be executed with a \u0027"},{"line_number":59,"context_line":"                       \u0027additional debugging output. This is a separate \u0027"},{"line_number":60,"context_line":"                       \u0027option as ipmitool can log a substantial amount \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_d5e71b46","line":57,"range":{"start_line":57,"start_character":24,"end_line":57,"end_character":29},"in_reply_to":"1fa4df85_355f8f0f","updated":"2020-03-13 13:11:42.000000000","message":"as far as I understand the point raise by Kaifeng, I\u0027m much more for soppressing the logging, way too much and not very useful in most cases","commit_id":"fde4f39dafcbe606c1b2e2b03a06b50d616a86d5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4ab95340a4426242efc5e5482df9c01873d80be4","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                    help\u003d_(\u0027Additional errors ipmitool may encounter, \u0027"},{"line_number":55,"context_line":"                           \u0027specific to the environment it is run in.\u0027)),"},{"line_number":56,"context_line":"    cfg.BoolOpt(\u0027debug\u0027,"},{"line_number":57,"context_line":"                default\u003dFalse,"},{"line_number":58,"context_line":"                help\u003d_(\u0027Enables all ipmi commands to be executed with a \u0027"},{"line_number":59,"context_line":"                       \u0027additional debugging output. This is a separate \u0027"},{"line_number":60,"context_line":"                       \u0027option as ipmitool can log a substantial amount \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_355f8f0f","line":57,"range":{"start_line":57,"start_character":24,"end_line":57,"end_character":29},"in_reply_to":"1fa4df85_f0982d1c","updated":"2020-03-13 13:07:11.000000000","message":"I\u0027d prefer it to be false, to be honest. RH has gotten a number of recent reports from operators that are confused because newer versions of ipmitool raises more of what they perceive as errors. I guess I\u0027d prefer to suppress the excess logging and have that be opt-in as opposed to operators continue to complain and then be told how to opt out in future versions of ironic.\n\nDoes anyone else have thoughts on this?","commit_id":"fde4f39dafcbe606c1b2e2b03a06b50d616a86d5"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"8b70b4337d175b83bc27db25dc9c096857da343d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                           \u0027specific to the environment it is run in.\u0027)),"},{"line_number":56,"context_line":"    cfg.BoolOpt(\u0027debug\u0027,"},{"line_number":57,"context_line":"                default\u003dFalse,"},{"line_number":58,"context_line":"                help\u003d_(\u0027Enables all ipmi commands to be executed with a \u0027"},{"line_number":59,"context_line":"                       \u0027additional debugging output. This is a separate \u0027"},{"line_number":60,"context_line":"                       \u0027option as ipmitool can log a substantial amount \u0027"},{"line_number":61,"context_line":"                       \u0027of misleading text when in this mode.\u0027)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_ad882a22","line":58,"range":{"start_line":58,"start_character":70,"end_line":58,"end_character":71},"updated":"2020-03-12 14:28:19.000000000","message":"nit: an","commit_id":"fde4f39dafcbe606c1b2e2b03a06b50d616a86d5"}],"ironic/drivers/modules/ipmitool.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"f4c6518073a8e956b7a1dec7a40274d5f6e16d52","unresolved":false,"context_lines":[{"line_number":446,"context_line":"        args.append(\u0027-f\u0027)"},{"line_number":447,"context_line":"        args.append(pw_file)"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"    if CONF.ipmi.debug:"},{"line_number":450,"context_line":"        args.append(\u0027-v\u0027)"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"    # ensure all arguments are strings"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_f0c10de6","line":449,"updated":"2020-03-13 03:21:42.000000000","message":"Maybe also turn it off when the global debug is false?","commit_id":"fde4f39dafcbe606c1b2e2b03a06b50d616a86d5"}]}