)]}'
{"ironic/common/states.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"12e0bf6b6e838e59786a35ef8226a1f1201cf6ca","unresolved":false,"context_lines":[{"line_number":53,"context_line":"INIT \u003d \u0027initializing\u0027"},{"line_number":54,"context_line":"ACTIVE \u003d \u0027active\u0027"},{"line_number":55,"context_line":"BUILDING \u003d \u0027building\u0027"},{"line_number":56,"context_line":"WAITDEPLOYING \u003d \u0027waiting to start deployment\u0027"},{"line_number":57,"context_line":"DEPLOYING \u003d \u0027deploying\u0027"},{"line_number":58,"context_line":"DEPLOYFAIL \u003d \u0027deploy failed\u0027"},{"line_number":59,"context_line":"DEPLOYDONE \u003d \u0027deploy complete\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9em8%3D","line":56,"updated":"2014-02-06 16:38:54.000000000","message":"And  provision_state \u003d Column(String(15) in DB, your string len \u003e 15","commit_id":"5eebbef30e933c11644127a7a8fbd11816839c90"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"27dd1a111b84a751076d0ca3ec07e6aa0f66a8db","unresolved":false,"context_lines":[{"line_number":53,"context_line":"INIT \u003d \u0027initializing\u0027"},{"line_number":54,"context_line":"ACTIVE \u003d \u0027active\u0027"},{"line_number":55,"context_line":"BUILDING \u003d \u0027building\u0027"},{"line_number":56,"context_line":"WAITDEPLOYING \u003d \u0027waiting to start deployment\u0027"},{"line_number":57,"context_line":"DEPLOYING \u003d \u0027deploying\u0027"},{"line_number":58,"context_line":"DEPLOYFAIL \u003d \u0027deploy failed\u0027"},{"line_number":59,"context_line":"DEPLOYDONE \u003d \u0027deploy complete\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9h7U%3D","line":56,"updated":"2014-02-06 16:09:33.000000000","message":"This message is slightly misleading when exposed to users. Technically the deploy already started; Ironic is waiting for a call-back to continue the deploy process.\n\nI\u0027d also like the constant\u0027s name to be consistent with the other DEPLOY* states. Maybe DEPLOYWAIT?","commit_id":"5eebbef30e933c11644127a7a8fbd11816839c90"}],"ironic/conductor/manager.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"08a9cade742f3884f9a512613a2cd1101e74bcbe","unresolved":false,"context_lines":[{"line_number":282,"context_line":"                    node[\u0027last_error\u0027] \u003d _(\"Failed to deploy. Error: %s\") % e"},{"line_number":283,"context_line":"                    node[\u0027provision_state\u0027] \u003d states.DEPLOYFAIL"},{"line_number":284,"context_line":"                    node[\u0027target_provision_state\u0027] \u003d states.NOSTATE"},{"line_number":285,"context_line":"            else:"},{"line_number":286,"context_line":"                # NOTE(deva): Some drivers may return states.DEPLOYING"},{"line_number":287,"context_line":"                #             eg. if they are waiting for a callback"},{"line_number":288,"context_line":"                if new_state \u003d\u003d states.DEPLOYDONE:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9iII%3D","line":285,"updated":"2014-02-06 08:50:32.000000000","message":"Please edit this comment also.","commit_id":"5eebbef30e933c11644127a7a8fbd11816839c90"}],"ironic/drivers/modules/pxe.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"08a9cade742f3884f9a512613a2cd1101e74bcbe","unresolved":false,"context_lines":[{"line_number":655,"context_line":"            LOG.error(_(\u0027Node %s is not waiting to be deployed.\u0027) %"},{"line_number":656,"context_line":"                      node.uuid)"},{"line_number":657,"context_line":"            return"},{"line_number":658,"context_line":"        node.provision_state \u003d states.DEPLOYING"},{"line_number":659,"context_line":"        # remove cached keystone token immediately"},{"line_number":660,"context_line":"        _destroy_token_file(node)"},{"line_number":661,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9iI8%3D","line":658,"updated":"2014-02-06 08:50:32.000000000","message":"node.save(task.context) should also be here, and IMO this should be after line 669.","commit_id":"5eebbef30e933c11644127a7a8fbd11816839c90"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"b6374e32d8294c37ff0992e46656f44e8db42b72","unresolved":false,"context_lines":[{"line_number":655,"context_line":"            LOG.error(_(\u0027Node %s is not waiting to be deployed.\u0027) %"},{"line_number":656,"context_line":"                      node.uuid)"},{"line_number":657,"context_line":"            return"},{"line_number":658,"context_line":"        node.provision_state \u003d states.DEPLOYING"},{"line_number":659,"context_line":"        # remove cached keystone token immediately"},{"line_number":660,"context_line":"        _destroy_token_file(node)"},{"line_number":661,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9hVE%3D","line":658,"in_reply_to":"AAAAUH%2F9iI8%3D","updated":"2014-02-06 10:41:56.000000000","message":"Fix: only node.save(task.context) here.","commit_id":"5eebbef30e933c11644127a7a8fbd11816839c90"}]}