)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"e5031eea88088ccaf7137063dd553e95a4739323","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gerrit Code Review \u003creview@openstack.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-02-06 22:56:18 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make the parameter order of assertEqual consistent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As part of review 71425 it was identified that the"},{"line_number":10,"context_line":"parameter order to assertEqual in test_{port,chassis,node}.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAUH%2F9Y8k%3D","line":7,"updated":"2014-02-07 08:57:04.000000000","message":"I think the point is not \u0027consistent\u0027, we just should pass the correct parameter position(the first one is the \u0027expected\u0027 value, 2nd one is the \u0027actual\u0027 value) to make it easier to read the error when it fails, else we are confusing with the ut log which is expected and which is actual value.","commit_id":"70b124cb346b7a3949125e61e59cdfc015105499"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"a62cc044cb0e844ce7c7cde08d2e9d4cb9ecf4a1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gerrit Code Review \u003creview@openstack.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-02-06 22:56:18 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make the parameter order of assertEqual consistent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As part of review 71425 it was identified that the"},{"line_number":10,"context_line":"parameter order to assertEqual in test_{port,chassis,node}.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAUX%2F%2F%2FnY%3D","line":7,"in_reply_to":"AAAAUH%2F9Y8k%3D","updated":"2014-02-07 21:28:45.000000000","message":"Done","commit_id":"70b124cb346b7a3949125e61e59cdfc015105499"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d11452a705e56fb174003a99cc82fbdd764a4993","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make the parameter order of assertEqual consistent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As part of review 71425 it was identified that the"},{"line_number":10,"context_line":"parameter order to assertEqual in test_{port,chassis,node}.py"},{"line_number":11,"context_line":"was often not following what is considered standard practice"},{"line_number":12,"context_line":"and inconsistently applied.  This patch updates all instances to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAUH%2F9XcU%3D","line":9,"updated":"2014-02-07 12:27:38.000000000","message":"instad of using the patch identifier in gerrit (71425), we should be the commit SHA \n(a2c3e9d7)","commit_id":"70b124cb346b7a3949125e61e59cdfc015105499"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"a62cc044cb0e844ce7c7cde08d2e9d4cb9ecf4a1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make the parameter order of assertEqual consistent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As part of review 71425 it was identified that the"},{"line_number":10,"context_line":"parameter order to assertEqual in test_{port,chassis,node}.py"},{"line_number":11,"context_line":"was often not following what is considered standard practice"},{"line_number":12,"context_line":"and inconsistently applied.  This patch updates all instances to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAUX%2F%2F%2FnE%3D","line":9,"in_reply_to":"AAAAUH%2F9XcU%3D","updated":"2014-02-07 21:28:45.000000000","message":"Thanks Lucas!","commit_id":"70b124cb346b7a3949125e61e59cdfc015105499"}],"ironic/tests/api/test_chassis.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"c33f00e1661a219236af32ea4a4e7a1d56ccc90e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import datetime"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from oslo.config import cfg"},{"line_number":22,"context_line":"import webtest.app"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from ironic.common import utils"},{"line_number":25,"context_line":"from ironic.openstack.common import timeutils"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9hLY%3D","line":22,"updated":"2014-02-06 11:00:12.000000000","message":"I see https://review.openstack.org/#/c/70766/ removes this. Why it should needed again?","commit_id":"482699de7133f8c44d42186b7ded697a06343eed"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"316f280b623f1a4329eea77c0d6aa4113209ff6c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import datetime"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from oslo.config import cfg"},{"line_number":22,"context_line":"import webtest.app"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from ironic.common import utils"},{"line_number":25,"context_line":"from ironic.openstack.common import timeutils"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9hCo%3D","line":22,"in_reply_to":"AAAAUH%2F9hLY%3D","updated":"2014-02-06 11:22:55.000000000","message":"I think we need rebase to latest file version and do the patch for this file.","commit_id":"482699de7133f8c44d42186b7ded697a06343eed"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"316f280b623f1a4329eea77c0d6aa4113209ff6c","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            chassis \u003d self.dbapi.create_chassis(ndict)"},{"line_number":65,"context_line":"            ch_list.append(chassis[\u0027uuid\u0027])"},{"line_number":66,"context_line":"        data \u003d self.get_json(\u0027/chassis\u0027)"},{"line_number":67,"context_line":"        self.assertEqual(len(ch_list), len(data[\u0027chassis\u0027]))"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        uuids \u003d [n[\u0027uuid\u0027] for n in data[\u0027chassis\u0027]]"},{"line_number":70,"context_line":"        self.assertEqual(ch_list.sort(), uuids.sort())"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9hCI%3D","line":67,"updated":"2014-02-06 11:22:55.000000000","message":"I think len(data[\u0027chassis\u0027]) is the value we expected, so, missed this line change?","commit_id":"482699de7133f8c44d42186b7ded697a06343eed"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"316f280b623f1a4329eea77c0d6aa4113209ff6c","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        self.assertEqual(len(ch_list), len(data[\u0027chassis\u0027]))"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        uuids \u003d [n[\u0027uuid\u0027] for n in data[\u0027chassis\u0027]]"},{"line_number":70,"context_line":"        self.assertEqual(ch_list.sort(), uuids.sort())"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_links(self):"},{"line_number":73,"context_line":"        uuid \u003d utils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9hBM%3D","line":70,"updated":"2014-02-06 11:22:55.000000000","message":"ditto","commit_id":"482699de7133f8c44d42186b7ded697a06343eed"}]}