)]}'
{"ironic/api/controllers/v1/types.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"20b2cd0407d051d42e1ff0fa723e7dd8873f4056","unresolved":false,"context_lines":[{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        # If network_type is \u0027unmanaged\u0027, this is a network with no switch"},{"line_number":323,"context_line":"        # management. i.e local_link_connection details are not required."},{"line_number":324,"context_line":"        if \u0027network_type\u0027 in keys:"},{"line_number":325,"context_line":"            if (value[\u0027network_type\u0027] not in"},{"line_number":326,"context_line":"                    LocalLinkConnectionType.valid_network_types):"},{"line_number":327,"context_line":"                msg \u003d _("}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_01f1016c","line":324,"updated":"2020-03-27 09:53:42.000000000","message":"you need to reject the request with NotAcceptable if the requested API version is less than 1.64","commit_id":"d36fc348d2171d230cb5f4e34b5ee51874b42664"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"86ee70d634b9ad1bc8e1940352803a30f788dd9e","unresolved":false,"context_lines":[{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        # If network_type is \u0027unmanaged\u0027, this is a network with no switch"},{"line_number":323,"context_line":"        # management. i.e local_link_connection details are not required."},{"line_number":324,"context_line":"        if \u0027network_type\u0027 in keys:"},{"line_number":325,"context_line":"            if (value[\u0027network_type\u0027] not in"},{"line_number":326,"context_line":"                    LocalLinkConnectionType.valid_network_types):"},{"line_number":327,"context_line":"                msg \u003d _("}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_9d1d6968","line":324,"in_reply_to":"df33271e_01f1016c","updated":"2020-03-27 19:33:46.000000000","message":"Done","commit_id":"d36fc348d2171d230cb5f4e34b5ee51874b42664"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"20b2cd0407d051d42e1ff0fa723e7dd8873f4056","unresolved":false,"context_lines":[{"line_number":325,"context_line":"            if (value[\u0027network_type\u0027] not in"},{"line_number":326,"context_line":"                    LocalLinkConnectionType.valid_network_types):"},{"line_number":327,"context_line":"                msg \u003d _("},{"line_number":328,"context_line":"                    \u0027Insvalid network_type %(type)s, valid network_types are \u0027"},{"line_number":329,"context_line":"                    \u0027%(valid_network_types)s.\u0027) % {"},{"line_number":330,"context_line":"                    \u0027type\u0027: value[\u0027network_type\u0027],"},{"line_number":331,"context_line":"                    \u0027valid_network_types\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_c150b960","line":328,"updated":"2020-03-27 09:53:42.000000000","message":"nit: Invalid","commit_id":"d36fc348d2171d230cb5f4e34b5ee51874b42664"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"86ee70d634b9ad1bc8e1940352803a30f788dd9e","unresolved":false,"context_lines":[{"line_number":325,"context_line":"            if (value[\u0027network_type\u0027] not in"},{"line_number":326,"context_line":"                    LocalLinkConnectionType.valid_network_types):"},{"line_number":327,"context_line":"                msg \u003d _("},{"line_number":328,"context_line":"                    \u0027Insvalid network_type %(type)s, valid network_types are \u0027"},{"line_number":329,"context_line":"                    \u0027%(valid_network_types)s.\u0027) % {"},{"line_number":330,"context_line":"                    \u0027type\u0027: value[\u0027network_type\u0027],"},{"line_number":331,"context_line":"                    \u0027valid_network_types\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_83dd1172","line":328,"in_reply_to":"df33271e_c150b960","updated":"2020-03-27 19:33:46.000000000","message":"Done","commit_id":"d36fc348d2171d230cb5f4e34b5ee51874b42664"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"20b2cd0407d051d42e1ff0fa723e7dd8873f4056","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                raise exception.Invalid(msg)"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"            if (value[\u0027network_type\u0027] \u003d\u003d \u0027unmanaged\u0027 and"},{"line_number":336,"context_line":"                    not keys - {\u0027network_type\u0027}):"},{"line_number":337,"context_line":"                # Only valid network_type \u0027unmanaged\u0027 is set, no for further"},{"line_number":338,"context_line":"                # validation required."},{"line_number":339,"context_line":"                return value"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_e1ca1d18","line":336,"updated":"2020-03-27 09:53:42.000000000","message":"nit:\n\n not (keys - {\u0027network_type\u0027})\n\n(to be clear about the intention)","commit_id":"d36fc348d2171d230cb5f4e34b5ee51874b42664"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"86ee70d634b9ad1bc8e1940352803a30f788dd9e","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                raise exception.Invalid(msg)"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"            if (value[\u0027network_type\u0027] \u003d\u003d \u0027unmanaged\u0027 and"},{"line_number":336,"context_line":"                    not keys - {\u0027network_type\u0027}):"},{"line_number":337,"context_line":"                # Only valid network_type \u0027unmanaged\u0027 is set, no for further"},{"line_number":338,"context_line":"                # validation required."},{"line_number":339,"context_line":"                return value"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_63d8cd7e","line":336,"in_reply_to":"df33271e_e1ca1d18","updated":"2020-03-27 19:33:46.000000000","message":"Done","commit_id":"d36fc348d2171d230cb5f4e34b5ee51874b42664"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:gate","change_message_id":"4f64f3c0cb0588460c4cc1d068a4ba8173a7419a","unresolved":false,"context_lines":[{"line_number":332,"context_line":"                        LocalLinkConnectionType.valid_network_types}"},{"line_number":333,"context_line":"                raise exception.Invalid(msg)"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"            if (value[\u0027network_type\u0027] \u003d\u003d \u0027unmanaged\u0027 and"},{"line_number":336,"context_line":"                    not (keys - {\u0027network_type\u0027})):"},{"line_number":337,"context_line":"                # Only valid network_type \u0027unmanaged\u0027 is set, no for further"},{"line_number":338,"context_line":"                # validation required."}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_88d5bb1e","line":335,"updated":"2020-04-02 09:25:53.000000000","message":"pep8: W504 line break after binary operator","commit_id":"9be9088707486e8690b9bc8cd65a74540867ccf8"}],"ironic/api/controllers/v1/utils.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:gate","change_message_id":"4f64f3c0cb0588460c4cc1d068a4ba8173a7419a","unresolved":false,"context_lines":[{"line_number":1375,"context_line":""},{"line_number":1376,"context_line":"def allow_local_link_connection_network_type():"},{"line_number":1377,"context_line":"    \"\"\"Check if network_type is allowed in ports link_local_connection\"\"\""},{"line_number":1378,"context_line":"    return (api.request.version.minor \u003e\u003d"},{"line_number":1379,"context_line":"            versions.MINOR_64_LOCAL_LINK_CONNECTION_NETWORK_TYPE)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_28158fe5","line":1378,"updated":"2020-04-02 09:25:53.000000000","message":"pep8: W504 line break after binary operator","commit_id":"9be9088707486e8690b9bc8cd65a74540867ccf8"}],"ironic/api/controllers/v1/versions.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"20b2cd0407d051d42e1ff0fa723e7dd8873f4056","unresolved":false,"context_lines":[{"line_number":167,"context_line":"MINOR_61_NODE_RETIRED \u003d 61"},{"line_number":168,"context_line":"MINOR_62_AGENT_TOKEN \u003d 62"},{"line_number":169,"context_line":"MINOR_63_INDICATORS \u003d 63"},{"line_number":170,"context_line":"MINOR_64_PORT_LOCAL_LINK_CONNECTION_NETWORK_TYPE \u003d 64"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"# When adding another version, update:"},{"line_number":173,"context_line":"# - MINOR_MAX_VERSION"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_21d525ba","line":170,"range":{"start_line":170,"start_character":9,"end_line":170,"end_character":14},"updated":"2020-03-27 09:53:42.000000000","message":"nit: s/PORT_// (just to shorten it)","commit_id":"d36fc348d2171d230cb5f4e34b5ee51874b42664"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"86ee70d634b9ad1bc8e1940352803a30f788dd9e","unresolved":false,"context_lines":[{"line_number":167,"context_line":"MINOR_61_NODE_RETIRED \u003d 61"},{"line_number":168,"context_line":"MINOR_62_AGENT_TOKEN \u003d 62"},{"line_number":169,"context_line":"MINOR_63_INDICATORS \u003d 63"},{"line_number":170,"context_line":"MINOR_64_PORT_LOCAL_LINK_CONNECTION_NETWORK_TYPE \u003d 64"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"# When adding another version, update:"},{"line_number":173,"context_line":"# - MINOR_MAX_VERSION"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_03bf4161","line":170,"range":{"start_line":170,"start_character":9,"end_line":170,"end_character":14},"in_reply_to":"df33271e_21d525ba","updated":"2020-03-27 19:33:46.000000000","message":"Done","commit_id":"d36fc348d2171d230cb5f4e34b5ee51874b42664"}],"releasenotes/notes/port-local-link-connection-network-type-71103d919e27fc5d.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cbd27fd6f198eed3897d349b4e4d0bd01664bb27","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    To allow use of the ``neutron`` network interface in combination with"},{"line_number":5,"context_line":"    ``flat`` provider networks where no actual switch management is done. The"},{"line_number":6,"context_line":"    `local_link_connection` field on ports is extended to support the"},{"line_number":7,"context_line":"    ``network_type`` field."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df33271e_968d4333","line":4,"updated":"2020-03-28 16:03:01.000000000","message":"The release note took em a couple passes to grok what it was saying. Which I suspect means we\u0027ll re-write when preparing final release notes for the cycle.","commit_id":"9be9088707486e8690b9bc8cd65a74540867ccf8"}]}