)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6691210c15b49e3b5ee102269430c33d7de7b9a1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2014-02-10 11:17:27 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move _set_boot_device to VendorPassthru class"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I174f0a058bfe6276b7a42291661f3fd00de9a7ca"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAUX%2F%2F1Z8%3D","line":8,"updated":"2014-02-10 14:19:58.000000000","message":"nit: Would be nice to add a briefly info here about why it\u0027s being moved","commit_id":"d558e97d2f337e60f705dab0067987c2e89d8b17"}],"ironic/drivers/modules/ipmitool.py":[{"author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"change_message_id":"93a6cd8046d0526cae554d808f3bb19df78d9549","unresolved":false,"context_lines":[{"line_number":338,"context_line":"                    \"Invalid boot device %s specified.\") % device)"},{"line_number":339,"context_line":"        else:"},{"line_number":340,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":341,"context_line":"                \"Unsupported method (%s) passed to PXE driver.\")"},{"line_number":342,"context_line":"                % method)"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2F2s4%3D","line":341,"updated":"2014-02-10 11:56:15.000000000","message":"This is not PXE. It\u0027s ipmitool. TBD","commit_id":"d558e97d2f337e60f705dab0067987c2e89d8b17"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6691210c15b49e3b5ee102269430c33d7de7b9a1","unresolved":false,"context_lines":[{"line_number":349,"context_line":"            return self._set_boot_device("},{"line_number":350,"context_line":"                        task, node,"},{"line_number":351,"context_line":"                        kwargs.get(\u0027device\u0027),"},{"line_number":352,"context_line":"                        kwargs.get(\u0027persistent\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2F1es%3D","line":352,"updated":"2014-02-10 14:19:58.000000000","message":"nit: kwargs.get(\u0027persistent\u0027, False)\n\nThe \"persistent\" parameter on the _set_boot_device() method accept a boolen value (afaiui), so if persistent is not present on kwargs that line is going to pass None to the _set_boot_device() method, which is going to do the work but is wrong/misleading (e.g when debugging that method)","commit_id":"d558e97d2f337e60f705dab0067987c2e89d8b17"}]}
