)]}'
{"ironic/dhcp/neutron.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"0a4a666421922e02ee6a3811ef902e1b75757543","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        if ip_address:"},{"line_number":189,"context_line":"            try:"},{"line_number":190,"context_line":"                if ipaddress.ip_address(ip_address).version \u003d\u003d 4:"},{"line_number":191,"context_line":"                    return ip_address"},{"line_number":192,"context_line":"                else:"},{"line_number":193,"context_line":"                    LOG.error(\"Neutron returned invalid IPv4 \""}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_849e1c67","line":190,"updated":"2020-07-18 03:25:53.000000000","message":"So we haven\u0027t supported v6 address here, but we have an ipv6 job set up, hmm..","commit_id":"b1dd9147d2def7fd86d1624ee4404fe6988ec315"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"652a5237892a218266593e31419b662b6e476c88","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        if ip_address:"},{"line_number":189,"context_line":"            try:"},{"line_number":190,"context_line":"                if ipaddress.ip_address(ip_address).version \u003d\u003d 4:"},{"line_number":191,"context_line":"                    return ip_address"},{"line_number":192,"context_line":"                else:"},{"line_number":193,"context_line":"                    LOG.error(\"Neutron returned invalid IPv4 \""}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_87c9fb26","line":190,"in_reply_to":"bf51134e_71f10596","updated":"2020-07-19 13:05:38.000000000","message":"Since the master grub will redirect all requests to the mac address based file link, I think we can safely remove the IP address based config links. tbh I have never seen a bootloader requesting the exact IP based file name we have created, but that\u0027s just my experience.","commit_id":"b1dd9147d2def7fd86d1624ee4404fe6988ec315"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"e3e093e460da32ecbc1b63666abbfcb7cd0d8918","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        if ip_address:"},{"line_number":189,"context_line":"            try:"},{"line_number":190,"context_line":"                if ipaddress.ip_address(ip_address).version \u003d\u003d 4:"},{"line_number":191,"context_line":"                    return ip_address"},{"line_number":192,"context_line":"                else:"},{"line_number":193,"context_line":"                    LOG.error(\"Neutron returned invalid IPv4 \""}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_c48134fe","line":190,"in_reply_to":"bf51134e_849e1c67","updated":"2020-07-18 03:30:19.000000000","message":"I wonder if we should just check it\u0027s a validate IPv4 or IPv6 address here.","commit_id":"b1dd9147d2def7fd86d1624ee4404fe6988ec315"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"21380055d2f9d286ae7c438bd7a171a080a955bf","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        if ip_address:"},{"line_number":189,"context_line":"            try:"},{"line_number":190,"context_line":"                if ipaddress.ip_address(ip_address).version \u003d\u003d 4:"},{"line_number":191,"context_line":"                    return ip_address"},{"line_number":192,"context_line":"                else:"},{"line_number":193,"context_line":"                    LOG.error(\"Neutron returned invalid IPv4 \""}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_71f10596","line":190,"in_reply_to":"bf51134e_c48134fe","updated":"2020-07-18 19:39:50.000000000","message":"It occurs to me, we might not really even be using this method anymore...\n\nI think it was for the EFI boot using IP address stuff we changed like 2 years ago.","commit_id":"b1dd9147d2def7fd86d1624ee4404fe6988ec315"}]}