)]}'
{"ironic/drivers/modules/agent_base.py":[{"author":{"_account_id":31616,"name":"Eric Barrera","email":"Eric_Barrera@Dell.com","username":"erbarr"},"change_message_id":"feb3ea3341f3c8fdc902b49ab498937f714a0c64","unresolved":false,"context_lines":[{"line_number":1087,"context_line":"        if (software_raid or (root_uuid and not whole_disk_image)"},{"line_number":1088,"context_line":"                or (whole_disk_image"},{"line_number":1089,"context_line":"                    and boot_mode_utils.get_boot_mode(node) \u003d\u003d \u0027uefi\u0027)):"},{"line_number":1090,"context_line":"            LOG.debug(\u0027Installing the bootloader for node %(node)s on \u0027"},{"line_number":1091,"context_line":"                      \u0027partition %(part)s, EFI system partition %(efi)s\u0027,"},{"line_number":1092,"context_line":"                      {\u0027node\u0027: node.uuid, \u0027part\u0027: root_uuid,"},{"line_number":1093,"context_line":"                       \u0027efi\u0027: efi_system_part_uuid})"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_a40d2392","line":1090,"range":{"start_line":1090,"start_character":22,"end_line":1090,"end_character":57},"updated":"2020-04-21 00:16:53.000000000","message":"seeing this message in the log of failures. Didn\u0027t see this message when jobs were passing last week.","commit_id":"883e9d605079b899b4b234695b4d263e9e5b5b51"},{"author":{"_account_id":31616,"name":"Eric Barrera","email":"Eric_Barrera@Dell.com","username":"erbarr"},"change_message_id":"feb3ea3341f3c8fdc902b49ab498937f714a0c64","unresolved":false,"context_lines":[{"line_number":1100,"context_line":"            )"},{"line_number":1101,"context_line":"            if result[\u0027command_status\u0027] \u003d\u003d \u0027FAILED\u0027:"},{"line_number":1102,"context_line":"                if not whole_disk_image:"},{"line_number":1103,"context_line":"                    msg \u003d (_(\"Failed to install a bootloader when \""},{"line_number":1104,"context_line":"                             \"deploying node %(node)s. Error: %(error)s\") %"},{"line_number":1105,"context_line":"                           {\u0027node\u0027: node.uuid,"},{"line_number":1106,"context_line":"                            \u0027error\u0027: result[\u0027command_error\u0027]})"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_041e97b9","line":1103,"range":{"start_line":1103,"start_character":30,"end_line":1103,"end_character":60},"updated":"2020-04-21 00:16:53.000000000","message":"Seeing this message in the log. If the whole_disk_image_url setting means whole_disk_image should be true then this shouldn\u0027t be happening.","commit_id":"883e9d605079b899b4b234695b4d263e9e5b5b51"},{"author":{"_account_id":31616,"name":"Eric Barrera","email":"Eric_Barrera@Dell.com","username":"erbarr"},"change_message_id":"feb3ea3341f3c8fdc902b49ab498937f714a0c64","unresolved":false,"context_lines":[{"line_number":1108,"context_line":"                else:"},{"line_number":1109,"context_line":"                    # Its possible the install will fail if the IPA image"},{"line_number":1110,"context_line":"                    # has not been updated, log this and continue"},{"line_number":1111,"context_line":"                    LOG.info(\u0027Could not install bootloader for whole disk \u0027"},{"line_number":1112,"context_line":"                             \u0027image for node %(node)s, Error: %(error)s\"\u0027,"},{"line_number":1113,"context_line":"                             {\u0027node\u0027: node.uuid,"},{"line_number":1114,"context_line":"                              \u0027error\u0027: result[\u0027command_error\u0027]})"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_447d3fe6","line":1111,"range":{"start_line":1111,"start_character":30,"end_line":1111,"end_character":73},"updated":"2020-04-21 00:16:53.000000000","message":"message not found in the logs","commit_id":"883e9d605079b899b4b234695b4d263e9e5b5b51"}],"ironic/drivers/modules/agent_client.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e97d67b8e3062d24a1a8977f37bc659b86f647b0","unresolved":false,"context_lines":[{"line_number":300,"context_line":"                                 params\u003dparams,"},{"line_number":301,"context_line":"                                 wait\u003dTrue,"},{"line_number":302,"context_line":"                                 command_timeout_factor\u003d2)"},{"line_number":303,"context_line":"        except exception.AgentAPIError:"},{"line_number":304,"context_line":"            # NOTE(arne_wiebalck): If for software RAID and \u0027uefi\u0027 as the boot"},{"line_number":305,"context_line":"            # mode, we find that the IPA does not yet support the additional"},{"line_number":306,"context_line":"            # \u0027target_boot_mode\u0027 parameter, we need to fail. For \u0027bios\u0027 boot"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_a89f96b2","line":303,"updated":"2020-04-22 10:07:06.000000000","message":"I think I understand the problem. We don\u0027t raise an error on command failures from the agent, we return a status. This will never be hit.","commit_id":"883e9d605079b899b4b234695b4d263e9e5b5b51"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"1fb9f8d2b6b807c50dfff3ae53d65a5ec916188c","unresolved":false,"context_lines":[{"line_number":300,"context_line":"                                 params\u003dparams,"},{"line_number":301,"context_line":"                                 wait\u003dTrue,"},{"line_number":302,"context_line":"                                 command_timeout_factor\u003d2)"},{"line_number":303,"context_line":"        except exception.AgentAPIError:"},{"line_number":304,"context_line":"            # NOTE(arne_wiebalck): If for software RAID and \u0027uefi\u0027 as the boot"},{"line_number":305,"context_line":"            # mode, we find that the IPA does not yet support the additional"},{"line_number":306,"context_line":"            # \u0027target_boot_mode\u0027 parameter, we need to fail. For \u0027bios\u0027 boot"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_c83662b5","line":303,"in_reply_to":"1f493fa4_a89f96b2","updated":"2020-04-22 10:11:37.000000000","message":"So, we should check the return code rather than catching exceptions?","commit_id":"883e9d605079b899b4b234695b4d263e9e5b5b51"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"04e5bf4b3fe7aefdb9dd7833d7323061ac2b02f2","unresolved":false,"context_lines":[{"line_number":300,"context_line":"                                 params\u003dparams,"},{"line_number":301,"context_line":"                                 wait\u003dTrue,"},{"line_number":302,"context_line":"                                 command_timeout_factor\u003d2)"},{"line_number":303,"context_line":"        except exception.AgentAPIError:"},{"line_number":304,"context_line":"            # NOTE(arne_wiebalck): If for software RAID and \u0027uefi\u0027 as the boot"},{"line_number":305,"context_line":"            # mode, we find that the IPA does not yet support the additional"},{"line_number":306,"context_line":"            # \u0027target_boot_mode\u0027 parameter, we need to fail. For \u0027bios\u0027 boot"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_48d092f8","line":303,"in_reply_to":"1f493fa4_c83662b5","updated":"2020-04-22 10:28:58.000000000","message":"It seems so. I\u0027m testing a similar issue in my code: https://review.opendev.org/721804","commit_id":"883e9d605079b899b4b234695b4d263e9e5b5b51"},{"author":{"_account_id":31616,"name":"Eric Barrera","email":"Eric_Barrera@Dell.com","username":"erbarr"},"change_message_id":"feb3ea3341f3c8fdc902b49ab498937f714a0c64","unresolved":false,"context_lines":[{"line_number":307,"context_line":"            # mode on the other hand we can retry without the parameter,"},{"line_number":308,"context_line":"            # since \u0027bios\u0027 is the default value the IPA will use."},{"line_number":309,"context_line":"            if target_boot_mode \u003d\u003d \u0027uefi\u0027 and software_raid:"},{"line_number":310,"context_line":"                LOG.error(\u0027Unable to pass UEFI boot mode to an out of date \u0027"},{"line_number":311,"context_line":"                          \u0027agent ramdisk. Please contact the administrator \u0027"},{"line_number":312,"context_line":"                          \u0027to update the ramdisk to contain an \u0027"},{"line_number":313,"context_line":"                          \u0027ironic-python-agent version of at least 6.0.0.\u0027)"},{"line_number":314,"context_line":"                raise"},{"line_number":315,"context_line":"            else:"},{"line_number":316,"context_line":"                params \u003d {\u0027root_uuid\u0027: root_uuid,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_8460e734","line":313,"range":{"start_line":310,"start_character":27,"end_line":313,"end_character":73},"updated":"2020-04-21 00:16:53.000000000","message":"message not found in the logs so the except block is not executing","commit_id":"883e9d605079b899b4b234695b4d263e9e5b5b51"},{"author":{"_account_id":31616,"name":"Eric Barrera","email":"Eric_Barrera@Dell.com","username":"erbarr"},"change_message_id":"02fadc7133eb3ab030cd129c844e58889d04a3cc","unresolved":false,"context_lines":[{"line_number":307,"context_line":"            # mode on the other hand we can retry without the parameter,"},{"line_number":308,"context_line":"            # since \u0027bios\u0027 is the default value the IPA will use."},{"line_number":309,"context_line":"            if target_boot_mode \u003d\u003d \u0027uefi\u0027 and software_raid:"},{"line_number":310,"context_line":"                LOG.error(\u0027Unable to pass UEFI boot mode to an out of date \u0027"},{"line_number":311,"context_line":"                          \u0027agent ramdisk. Please contact the administrator \u0027"},{"line_number":312,"context_line":"                          \u0027to update the ramdisk to contain an \u0027"},{"line_number":313,"context_line":"                          \u0027ironic-python-agent version of at least 6.0.0.\u0027)"},{"line_number":314,"context_line":"                raise"},{"line_number":315,"context_line":"            else:"},{"line_number":316,"context_line":"                params \u003d {\u0027root_uuid\u0027: root_uuid,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_80039d0d","line":313,"range":{"start_line":310,"start_character":27,"end_line":313,"end_character":73},"in_reply_to":"1f493fa4_53a5ffb4","updated":"2020-04-21 20:12:32.000000000","message":"made the change and didn\u0027t see that message in the log. Used LOG.error though to match other messages.","commit_id":"883e9d605079b899b4b234695b4d263e9e5b5b51"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"0e7d5bad05d32330f0fc510fbfbb9258cdf826bc","unresolved":false,"context_lines":[{"line_number":307,"context_line":"            # mode on the other hand we can retry without the parameter,"},{"line_number":308,"context_line":"            # since \u0027bios\u0027 is the default value the IPA will use."},{"line_number":309,"context_line":"            if target_boot_mode \u003d\u003d \u0027uefi\u0027 and software_raid:"},{"line_number":310,"context_line":"                LOG.error(\u0027Unable to pass UEFI boot mode to an out of date \u0027"},{"line_number":311,"context_line":"                          \u0027agent ramdisk. Please contact the administrator \u0027"},{"line_number":312,"context_line":"                          \u0027to update the ramdisk to contain an \u0027"},{"line_number":313,"context_line":"                          \u0027ironic-python-agent version of at least 6.0.0.\u0027)"},{"line_number":314,"context_line":"                raise"},{"line_number":315,"context_line":"            else:"},{"line_number":316,"context_line":"                params \u003d {\u0027root_uuid\u0027: root_uuid,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_53a5ffb4","line":313,"range":{"start_line":310,"start_character":27,"end_line":313,"end_character":73},"in_reply_to":"1f493fa4_8460e734","updated":"2020-04-21 07:03:18.000000000","message":"Thanks, Eric. Could you please replace l303 with sth like:\n\n--\u003e\nexcept Exception as e:\n    LOG.exception(\u0027install_bootloader raised %(t)s: %(e)s\u0027,\n                  {\u0027t\u0027: e.__class__.__name__, \u0027e\u0027: e})\n\u003c--\n\nThis is to see whether we get an exception at all and which type it is.\n\nMake sure you restart the conductor before retrying.","commit_id":"883e9d605079b899b4b234695b4d263e9e5b5b51"}]}